Skip to contentSkip to conversation

ALSA: hda/conexant: Fix EAPD pin array overflow

PATCH Applied [email protected] 2 participants 4 messages Jul 29 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ALSA: hda/conexant: Fix EAPD pin array overflow

From: wangdicheng <[email protected]>

The bounds check in cx_auto_parse_eapd() happens after the write, so when a codec has more than 4 EAPD pins the 5th one gets written to eapds[4] which is past the end of the array and clobbers the adjacent dynamic_eapd field.

Swap the check and the write.

---
 sound/hda/codecs/conexant.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/hda/codecs/conexant.c +1 -1
index 40da2832ba66..e7a2a073d22c 100644
@@ -100,9 +100,9 @@ static void cx_auto_parse_eapd(struct hda_codec *codec)
 			continue;
 		if (!(snd_hda_query_pin_caps(codec, nid) & AC_PINCAP_EAPD))
 			continue;
-		spec->eapds[spec->num_eapds++] = nid;
 		if (spec->num_eapds >= ARRAY_SIZE(spec->eapds))
 			break;
+		spec->eapds[spec->num_eapds++] = nid;
 	}
 
 	/* NOTE: below is a wild guess; if we have more than two EAPDs,
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 ALSA: hda/conexant: Add NULL check for dc_mode_path

From: wangdicheng <[email protected]>

snd_hda_add_new_path() returns NULL when no path exists between the given NIDs, but olpc_xo_update_mic_pins() passes dc_mode_path straight to snd_hda_activate_path() which dereferences it without checking. Add the missing NULL guards, same as the local path variable already has in the same function.

---
 sound/hda/codecs/conexant.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
sound/hda/codecs/conexant.c +4 -2
index e7a2a073d22c..880fbbe5b643 100644
@@ -451,7 +451,8 @@ static void olpc_xo_update_mic_pins(struct hda_codec *codec)
 	if (!spec->dc_enable) {
 		/* disable DC bias path and pin for port F */
 		update_mic_pin(codec, 0x1e, 0);
-		snd_hda_activate_path(codec, spec->dc_mode_path, false, false);
+		if (spec->dc_mode_path)
+			snd_hda_activate_path(codec, spec->dc_mode_path, false, false);
 
 		/* update port B (ext mic) and C (int mic) */
 		/* OLPC defers mic widget control until when capture is
@@ -487,7 +488,8 @@ static void olpc_xo_update_mic_pins(struct hda_codec *codec)
 		update_mic_pin(codec, 0x1b, 0);
 		/* enable DC bias path and pin */
 		update_mic_pin(codec, 0x1e, spec->recording ? PIN_IN : 0);
-		snd_hda_activate_path(codec, spec->dc_mode_path, true, false);
+		if (spec->dc_mode_path)
+			snd_hda_activate_path(codec, spec->dc_mode_path, true, false);
 	}
 }
 
Signature · 1 line
2.25.1
Applied
#2 lore raw

Re: [PATCH 2/2] ALSA: hda/conexant: Add NULL check for dc_mode_path

Quoted 10 lines · On Wed, 29 Jul 2026 09:09:35 +0200, [email protected] wrote:

From: wangdicheng <[email protected]>

snd_hda_add_new_path() returns NULL when no path exists between the given NIDs, but olpc_xo_update_mic_pins() passes dc_mode_path straight to snd_hda_activate_path() which dereferences it without checking. Add the missing NULL guards, same as the local path variable already has in the same function.

Applied to for-next branch now. Thanks.

Takashi

#3 lore raw
In reply to [email protected]
Quoted 7 lines · On Wed, 29 Jul 2026 09:09:34 +0200, [email protected] wrote:

From: wangdicheng <[email protected]>

The bounds check in cx_auto_parse_eapd() happens after the write, so when a codec has more than 4 EAPD pins the 5th one gets written to eapds[4] which is past the end of the array and clobbers the adjacent dynamic_eapd field.

No, it checks right after the increment, then aborts the loop. So any overwrite won't happen.

Takashi

Quoted 24 lines
---
 sound/hda/codecs/conexant.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/hda/codecs/conexant.c +1 -1
index 40da2832ba66..e7a2a073d22c 100644
@@ -100,9 +100,9 @@ static void cx_auto_parse_eapd(struct hda_codec *codec)
 			continue;
 		if (!(snd_hda_query_pin_caps(codec, nid) & AC_PINCAP_EAPD))
 			continue;
-		spec->eapds[spec->num_eapds++] = nid;
 		if (spec->num_eapds >= ARRAY_SIZE(spec->eapds))
 			break;
+		spec->eapds[spec->num_eapds++] = nid;
 	}
 
 	/* NOTE: below is a wild guess; if we have more than two EAPDs,
Signature · 1 line
2.25.1