nvmet: fix return status of RMI log page on allocation failure
Subsystems (2)
PATCH 1/4 nvmet: fix return status of RMI log page on allocation failure
nvmet_execute_get_log_page_rmi() leaves 'status' holding NVME_SC_SUCCESS (set by the successful nvmet_req_find_ns() call) when the kzalloc() for the log buffer fails. It then jumps to the out label and completes the request with a success status, so the host is told the command succeeded while no data was transferred.
Initialize 'status' to NVME_SC_INTERNAL, matching the smart log handler, so an allocation failure is reported as an internal error.
--- drivers/nvme/target/admin-cmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/nvme/target/admin-cmd.c +3 -1
@@ -309,8 +309,10 @@ static void nvmet_execute_get_log_page_rmi(struct nvmet_req *req) } log =kzalloc_obj (*log); -if (!log) +if (!log) { + status =NVME_SC_INTERNAL ; goto out; + } log->endgid = req->cmd->get_log_page.lsi; disk = req->ns->bdev->bd_disk;
Signature · 1 line
2.43.7
Quoted 11 lines · Guixin Liu
nvmet_execute_get_log_page_rmi()leaves 'status' holdingNVME_SC_SUCCESS(set by the successfulnvmet_req_find_ns()call) when thekzalloc()for the log buffer fails. It then jumps to the out label and completes the request with a success status, so the host is told the command succeeded while no data was transferred.Initialize 'status' to
NVME_SC_INTERNAL, matching the smart log handler, so an allocation failure is reported as an internal error.Fixes 5fd075cdaf36 ("nvmet: implement rotational media information log")Signed-off-by Guixin Liu <[email protected]>
Looks good:
Keith Busch
maintainerThanks, series applied to nvme-7.3.
For future refernce, please use something sane like 'git send-email' to submit a patch series. This one is split across different threads.