Skip to contentSkip to conversation

xfs/507: use mount -t xfs

PATCH In review Christoph Hellwig 2 participants 3 messages Jul 29

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs/507: use mount -t xfs

Sometimes mount wants to try every other file system but XFS when mounting the loop image, making this test fail. Force mounting as XFS to make it reliably pass.

---
 tests/xfs/507 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xfs/507 +1 -1
index e1450f4f8f94..a9eb8646680b 100755
@@ -86,7 +86,7 @@ loop_dev=$(_create_loop_device $loop_file)
 
 _mkfs_dev -d cowextsize=$MAXEXTLEN -l size=256m $loop_dev >> $seqres.full
 mkdir $loop_mount
-_mount $loop_dev $loop_mount
+_mount -t xfs $loop_dev $loop_mount
 
 echo "Create crazy huge file"
 huge_file="$loop_mount/a"
Signature · 1 line
2.53.0
#1 lore raw
Quoted 3 lines · Christoph Hellwig

Sometimes mount wants to try every other file system but XFS when mounting the loop image, making this test fail. Force mounting as XFS to make it reliably pass.

Weird. Do you know why it does that? Did the kernel really skip xfs or were the sb verifiers simply running in quiet mode?

--D

Quoted 22 lines
---
 tests/xfs/507 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xfs/507 +1 -1
index e1450f4f8f94..a9eb8646680b 100755
@@ -86,7 +86,7 @@ loop_dev=$(_create_loop_device $loop_file)
 
 _mkfs_dev -d cowextsize=$MAXEXTLEN -l size=256m $loop_dev >> $seqres.full
 mkdir $loop_mount
-_mount $loop_dev $loop_mount
+_mount -t xfs $loop_dev $loop_mount
 
 echo "Create crazy huge file"
 huge_file="$loop_mount/a"
Signature · 1 line
2.53.0
#2 lore raw
Quoted 7 lines · Darrick J. Wong
Quoted 3 lines · Christoph Hellwig

Sometimes mount wants to try every other file system but XFS when mounting the loop image, making this test fail. Force mounting as XFS to make it reliably pass.

Weird. Do you know why it does that? Did the kernel really skip xfs or were the sb verifiers simply running in quiet mode?

Not really. I also happens in weird patches, I can reproduce it a few times in a row, but just when I get ready to investigate the problem, it goes away.