Skip to contentSkip to conversation

remove legacy Packet Framework API

PATCH Superseded Stephen Hemminger 2 participants 50 messages Jul 24 – Sep 4 Arm/Amlogic Meson SoC support Page 2 of 2

lore
Share & tools
lore
#17 lore raw

PATCH v3 1/6 app/test: remove packet framework tests

In reply to Stephen Hemminger

The legacy packet framework libraries (port, table, pipeline) are being removed, so remove the unit tests exercising them.

---
 MAINTAINERS                    |    1 -
 app/test/meson.build           |    6 -
 app/test/test_table.c          |  209 -------
 app/test/test_table.h          |  184 ------
 app/test/test_table_acl.c      |  728 ----------------------
 app/test/test_table_acl.h      |    6 -
 app/test/test_table_combined.c |  846 -------------------------
 app/test/test_table_combined.h |   27 -
 app/test/test_table_pipeline.c |  575 -----------------
 app/test/test_table_pipeline.h |    6 -
 app/test/test_table_ports.c    |  195 ------
 app/test/test_table_ports.h    |   13 -
 app/test/test_table_tables.c   | 1058 --------------------------------
 app/test/test_table_tables.h   |   22 -
 14 files changed, 3876 deletions(-)
 delete mode 100644 app/test/test_table.c
 delete mode 100644 app/test/test_table.h
 delete mode 100644 app/test/test_table_acl.c
 delete mode 100644 app/test/test_table_acl.h
 delete mode 100644 app/test/test_table_combined.c
 delete mode 100644 app/test/test_table_combined.h
 delete mode 100644 app/test/test_table_pipeline.c
 delete mode 100644 app/test/test_table_pipeline.h
 delete mode 100644 app/test/test_table_ports.c
 delete mode 100644 app/test/test_table_ports.h
 delete mode 100644 app/test/test_table_tables.c
 delete mode 100644 app/test/test_table_tables.h
MAINTAINERS +0 -1
index e99a65d197..77a41b3fcf 100644
@@ -1739,7 +1739,6 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: app/test/test_table*
 F: app/test-pipeline/
 F: doc/guides/sample_app_ug/test_pipeline.rst
 F: examples/ip_pipeline/
app/test/meson.build +0 -6
index 51abeeb732..4fcd755940 100644
@@ -195,12 +195,6 @@ source_file_deps = {
     'test_stack.c': ['stack'],
     'test_stack_perf.c': ['stack'],
     'test_string_fns.c': [],
-    'test_table.c': ['table', 'pipeline', 'port'],
-    'test_table_acl.c': ['net', 'table', 'pipeline', 'port'],
-    'test_table_combined.c': ['table', 'pipeline', 'port'],
-    'test_table_pipeline.c': ['pipeline', 'table', 'port'],
-    'test_table_ports.c': ['table', 'pipeline', 'port'],
-    'test_table_tables.c': ['table', 'pipeline', 'port'],
     'test_tailq.c': [],
     'test_telemetry_data.c': ['telemetry'],
     'test_telemetry_json.c': ['telemetry'],
app/test/test_table.c deleted +0 -209

209 lines not on this page · raw message

app/test/test_table.h deleted +0 -184

184 lines not on this page · raw message

app/test/test_table_acl.c deleted +0 -728

728 lines not on this page · raw message

app/test/test_table_acl.h deleted +0 -6
deleted file mode 100644
index a6ae7d2838..0000000000
@@ -1,6 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_acl(void);
app/test/test_table_combined.c deleted +0 -846

846 lines not on this page · raw message

app/test/test_table_combined.h deleted +0 -27
deleted file mode 100644
index fb94dbb94d..0000000000
@@ -1,27 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2016 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_stub_combined(void);
-int test_table_lpm_combined(void);
-int test_table_lpm_ipv6_combined(void);
-#ifdef RTE_LIB_ACL
-int test_table_acl(void);
-#endif
-int test_table_hash8unoptimized(void);
-int test_table_hash8lru(void);
-int test_table_hash8ext(void);
-int test_table_hash16unoptimized(void);
-int test_table_hash16lru(void);
-int test_table_hash16ext(void);
-int test_table_hash32unoptimized(void);
-int test_table_hash32lru(void);
-int test_table_hash32ext(void);
-int test_table_hash_cuckoo_combined(void);
-
-/* Extern variables */
-typedef int (*combined_table_test)(void);
-
-extern combined_table_test table_tests_combined[];
-extern unsigned n_table_tests_combined;
app/test/test_table_pipeline.c deleted +0 -575

575 lines not on this page · raw message

app/test/test_table_pipeline.h deleted +0 -6
deleted file mode 100644
index d66d09d6f1..0000000000
@@ -1,6 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_pipeline(void);
app/test/test_table_ports.c deleted +0 -195

195 lines not on this page · raw message

app/test/test_table_ports.h deleted +0 -13
deleted file mode 100644
index dfa6119319..0000000000
@@ -1,13 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_port_ring_reader(void);
-int test_port_ring_writer(void);
-
-/* Extern variables */
-typedef int (*port_test)(void);
-
-extern port_test port_tests[];
-extern unsigned n_port_tests;
app/test/test_table_tables.c deleted +0 -1058

192 lines not on this page · raw message

app/test/test_table_tables.h deleted +0 -22
deleted file mode 100644
index 530633a013..0000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#18 lore raw

PATCH v3 2/6 app/test-pipeline: remove application

In reply to Stephen Hemminger

The test-pipeline application is built on the legacy pipeline library API (rte_pipeline_*), which was announced for removal in the 24.11 release. Remove it before removing the library.

---
 MAINTAINERS                                   |   2 -
 app/meson.build                               |   1 -
 app/test-pipeline/config.c                    | 230 ---------
 app/test-pipeline/init.c                      | 273 ----------
 app/test-pipeline/main.c                      | 188 -------
 app/test-pipeline/main.h                      | 132 -----
 app/test-pipeline/meson.build                 |  21 -
 app/test-pipeline/pipeline_acl.c              | 251 ----------
 app/test-pipeline/pipeline_hash.c             | 471 ------------------
 app/test-pipeline/pipeline_lpm.c              | 175 -------
 app/test-pipeline/pipeline_lpm_ipv6.c         | 168 -------
 app/test-pipeline/pipeline_stub.c             | 137 -----
 app/test-pipeline/runtime.c                   | 160 ------
 doc/guides/rel_notes/release_26_11.rst        |   3 +
 .../sample_app_ug/img/test_pipeline_app.png   | Bin 67410 -> 0 bytes
 doc/guides/sample_app_ug/index.rst            |   1 -
 doc/guides/sample_app_ug/test_pipeline.rst    | 237 ---------
 17 files changed, 3 insertions(+), 2447 deletions(-)
 delete mode 100644 app/test-pipeline/config.c
 delete mode 100644 app/test-pipeline/init.c
 delete mode 100644 app/test-pipeline/main.c
 delete mode 100644 app/test-pipeline/main.h
 delete mode 100644 app/test-pipeline/meson.build
 delete mode 100644 app/test-pipeline/pipeline_acl.c
 delete mode 100644 app/test-pipeline/pipeline_hash.c
 delete mode 100644 app/test-pipeline/pipeline_lpm.c
 delete mode 100644 app/test-pipeline/pipeline_lpm_ipv6.c
 delete mode 100644 app/test-pipeline/pipeline_stub.c
 delete mode 100644 app/test-pipeline/runtime.c
 delete mode 100644 doc/guides/sample_app_ug/img/test_pipeline_app.png
 delete mode 100644 doc/guides/sample_app_ug/test_pipeline.rst
MAINTAINERS +0 -2
index 77a41b3fcf..4c06f85706 100644
@@ -1739,8 +1739,6 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: app/test-pipeline/
-F: doc/guides/sample_app_ug/test_pipeline.rst
 F: examples/ip_pipeline/
 F: examples/pipeline/
 F: doc/guides/sample_app_ug/ip_pipeline.rst
app/meson.build +0 -1
index 1798db3ae4..4515688471 100644
@@ -28,7 +28,6 @@ apps = [
         'test-flow-perf',
         'test-gpudev',
         'test-mldev',
-        'test-pipeline',
         'test-pmd',
         'test-regex',
         'test-sad',
app/test-pipeline/config.c deleted +0 -230

230 lines not on this page · raw message

app/test-pipeline/init.c deleted +0 -273

273 lines not on this page · raw message

app/test-pipeline/main.c deleted +0 -188

188 lines not on this page · raw message

app/test-pipeline/main.h deleted +0 -132

132 lines not on this page · raw message

app/test-pipeline/meson.build deleted +0 -21
deleted file mode 100644
index 3add6b637b..0000000000
@@ -1,21 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2019 Intel Corporation
-
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-sources = files(
-        'config.c',
-        'init.c',
-        'main.c',
-        'pipeline_acl.c',
-        'pipeline_hash.c',
-        'pipeline_lpm.c',
-        'pipeline_lpm_ipv6.c',
-        'pipeline_stub.c',
-        'runtime.c',
-)
-deps += ['pipeline', 'pci']
app/test-pipeline/pipeline_acl.c deleted +0 -251

251 lines not on this page · raw message

app/test-pipeline/pipeline_hash.c deleted +0 -471

471 lines not on this page · raw message

app/test-pipeline/pipeline_lpm.c deleted +0 -175

175 lines not on this page · raw message

app/test-pipeline/pipeline_lpm_ipv6.c deleted +0 -168

168 lines not on this page · raw message

app/test-pipeline/pipeline_stub.c deleted +0 -137

137 lines not on this page · raw message

app/test-pipeline/runtime.c deleted +0 -160

160 lines not on this page · raw message

doc/guides/rel_notes/release_26_11.rst +3 -0
index c8cc86295d..6ad0cf6eec 100644
@@ -77,6 +77,9 @@ Removed Items
     ``rte_rib6_is_equal``
   * table: ``RTE_LPM_IPV6_ADDR_SIZE``
 
+* Removed the ``dpdk-test-pipeline`` application, which was based on
+  the legacy pipeline library API.
+
 
 API Changes
 -----------
doc/guides/sample_app_ug/img/test_pipeline_app.png deleted binary +0 -0
deleted file mode 100644
index d322a9e46e5e714126988a76456c9eae41635879..0000000000000000000000000000000000000000
GIT binary patch
doc/guides/sample_app_ug/index.rst +0 -1
index f12623bb66..c8b50b801c 100644
@@ -45,7 +45,6 @@ Sample Applications User Guides
     vhost_crypto
     vdpa
     ip_pipeline
-    test_pipeline
     pipeline
     eventdev_pipeline
     dist_app
doc/guides/sample_app_ug/test_pipeline.rst deleted +0 -237

237 lines not on this page · raw message

Signature · 1 line
2.53.0
#19 lore raw

PATCH v3 3/6 examples/ip_pipeline: remove example

In reply to Stephen Hemminger

The ip_pipeline example is built on the legacy pipeline library API (rte_pipeline_*) and the associated port and table action APIs, which were announced for removal in the 24.11 release. The pipeline example covers the SWX pipeline API.

---
 MAINTAINERS                                   |    2 -
 doc/guides/nics/softnic.rst                   |    3 +-
 doc/guides/rel_notes/release_26_11.rst        |    4 +
 doc/guides/sample_app_ug/index.rst            |    1 -
 doc/guides/sample_app_ug/ip_pipeline.rst      |  531 --
 examples/ip_pipeline/Makefile                 |   60 -
 examples/ip_pipeline/action.c                 |  391 -
 examples/ip_pipeline/action.h                 |   78 -
 examples/ip_pipeline/cli.c                    | 6791 -----------------
 examples/ip_pipeline/cli.h                    |   18 -
 examples/ip_pipeline/common.h                 |   12 -
 examples/ip_pipeline/conn.c                   |  330 -
 examples/ip_pipeline/conn.h                   |   47 -
 examples/ip_pipeline/cryptodev.c              |  160 -
 examples/ip_pipeline/cryptodev.h              |   46 -
 examples/ip_pipeline/examples/firewall.cli    |   59 -
 examples/ip_pipeline/examples/flow.cli        |   60 -
 examples/ip_pipeline/examples/flow_crypto.cli |   57 -
 examples/ip_pipeline/examples/l2fwd.cli       |   51 -
 examples/ip_pipeline/examples/route.cli       |   60 -
 examples/ip_pipeline/examples/route_ecmp.cli  |   57 -
 examples/ip_pipeline/examples/rss.cli         |  112 -
 examples/ip_pipeline/examples/tap.cli         |   66 -
 examples/ip_pipeline/link.c                   |  270 -
 examples/ip_pipeline/link.h                   |   66 -
 examples/ip_pipeline/main.c                   |  260 -
 examples/ip_pipeline/mempool.c                |   82 -
 examples/ip_pipeline/mempool.h                |   40 -
 examples/ip_pipeline/meson.build              |   30 -
 examples/ip_pipeline/parser.c                 |  506 --
 examples/ip_pipeline/parser.h                 |   56 -
 examples/ip_pipeline/pipeline.c               | 1078 ---
 examples/ip_pipeline/pipeline.h               |  425 --
 examples/ip_pipeline/swq.c                    |   76 -
 examples/ip_pipeline/swq.h                    |   37 -
 examples/ip_pipeline/tap.c                    |  102 -
 examples/ip_pipeline/tap.h                    |   29 -
 examples/ip_pipeline/thread.c                 | 3137 --------
 examples/ip_pipeline/thread.h                 |   24 -
 examples/ip_pipeline/tmgr.c                   |  248 -
 examples/ip_pipeline/tmgr.h                   |   74 -
 examples/meson.build                          |    1 -
 42 files changed, 5 insertions(+), 15532 deletions(-)
 delete mode 100644 doc/guides/sample_app_ug/ip_pipeline.rst
 delete mode 100644 examples/ip_pipeline/Makefile
 delete mode 100644 examples/ip_pipeline/action.c
 delete mode 100644 examples/ip_pipeline/action.h
 delete mode 100644 examples/ip_pipeline/cli.c
 delete mode 100644 examples/ip_pipeline/cli.h
 delete mode 100644 examples/ip_pipeline/common.h
 delete mode 100644 examples/ip_pipeline/conn.c
 delete mode 100644 examples/ip_pipeline/conn.h
 delete mode 100644 examples/ip_pipeline/cryptodev.c
 delete mode 100644 examples/ip_pipeline/cryptodev.h
 delete mode 100644 examples/ip_pipeline/examples/firewall.cli
 delete mode 100644 examples/ip_pipeline/examples/flow.cli
 delete mode 100644 examples/ip_pipeline/examples/flow_crypto.cli
 delete mode 100644 examples/ip_pipeline/examples/l2fwd.cli
 delete mode 100644 examples/ip_pipeline/examples/route.cli
 delete mode 100644 examples/ip_pipeline/examples/route_ecmp.cli
 delete mode 100644 examples/ip_pipeline/examples/rss.cli
 delete mode 100644 examples/ip_pipeline/examples/tap.cli
 delete mode 100644 examples/ip_pipeline/link.c
 delete mode 100644 examples/ip_pipeline/link.h
 delete mode 100644 examples/ip_pipeline/main.c
 delete mode 100644 examples/ip_pipeline/mempool.c
 delete mode 100644 examples/ip_pipeline/mempool.h
 delete mode 100644 examples/ip_pipeline/meson.build
 delete mode 100644 examples/ip_pipeline/parser.c
 delete mode 100644 examples/ip_pipeline/parser.h
 delete mode 100644 examples/ip_pipeline/pipeline.c
 delete mode 100644 examples/ip_pipeline/pipeline.h
 delete mode 100644 examples/ip_pipeline/swq.c
 delete mode 100644 examples/ip_pipeline/swq.h
 delete mode 100644 examples/ip_pipeline/tap.c
 delete mode 100644 examples/ip_pipeline/tap.h
 delete mode 100644 examples/ip_pipeline/thread.c
 delete mode 100644 examples/ip_pipeline/thread.h
 delete mode 100644 examples/ip_pipeline/tmgr.c
 delete mode 100644 examples/ip_pipeline/tmgr.h
MAINTAINERS +0 -2
index 4c06f85706..ae84e7f289 100644
@@ -1739,9 +1739,7 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: examples/ip_pipeline/
 F: examples/pipeline/
-F: doc/guides/sample_app_ug/ip_pipeline.rst
 
 
 Algorithms
doc/guides/nics/softnic.rst +1 -2
index 603fdb49c4..87f3e5adc0 100644
@@ -10,8 +10,7 @@ is DIY and reconfigurable through ``firmware`` (DPDK Packet Framework script).
 The Soft NIC leverages the DPDK Packet Framework libraries (librte_port,
 librte_table and librte_pipeline) to make it modular, flexible and extensible
 with new functionality.
-Please refer to :doc:`/prog_guide/packet_framework` and
-:doc:`/sample_app_ug/ip_pipeline` for more details.
+Please refer to :doc:`/prog_guide/packet_framework` for more details.
 
 The Soft NIC is configured through the standard DPDK ethdev API (ethdev, flow,
 QoS, security). The internal framework is not externally visible.
doc/guides/rel_notes/release_26_11.rst +4 -0
index 6ad0cf6eec..fc84ba367e 100644
@@ -80,6 +80,10 @@ Removed Items
 * Removed the ``dpdk-test-pipeline`` application, which was based on
   the legacy pipeline library API.
 
+* Removed the ``ip_pipeline`` example application, which was based on
+  the legacy pipeline library API.
+  The ``pipeline`` example application covers the SWX pipeline API.
+
 
 API Changes
 -----------
doc/guides/sample_app_ug/index.rst +0 -1
index c8b50b801c..28c4c9a5b2 100644
@@ -44,7 +44,6 @@ Sample Applications User Guides
     vhost_blk
     vhost_crypto
     vdpa
-    ip_pipeline
     pipeline
     eventdev_pipeline
     dist_app
doc/guides/sample_app_ug/ip_pipeline.rst deleted +0 -531

531 lines not on this page · raw message

examples/ip_pipeline/Makefile deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/action.c deleted +0 -391

391 lines not on this page · raw message

examples/ip_pipeline/action.h deleted +0 -78

78 lines not on this page · raw message

examples/ip_pipeline/cli.c deleted +0 -6791

1,905 lines not on this page · raw message

examples/ip_pipeline/cli.h deleted +0 -18
deleted file mode 100644
index 992e4c3a4a..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/common.h deleted +0 -12
deleted file mode 100644
index 0886dfbe95..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/conn.c deleted +0 -330

330 lines not on this page · raw message

examples/ip_pipeline/conn.h deleted +0 -47

47 lines not on this page · raw message

examples/ip_pipeline/cryptodev.c deleted +0 -160

160 lines not on this page · raw message

examples/ip_pipeline/cryptodev.h deleted +0 -46

46 lines not on this page · raw message

examples/ip_pipeline/examples/firewall.cli deleted +0 -59

59 lines not on this page · raw message

examples/ip_pipeline/examples/flow.cli deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/examples/flow_crypto.cli deleted +0 -57

57 lines not on this page · raw message

examples/ip_pipeline/examples/l2fwd.cli deleted +0 -51

51 lines not on this page · raw message

examples/ip_pipeline/examples/route.cli deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/examples/route_ecmp.cli deleted +0 -57

57 lines not on this page · raw message

examples/ip_pipeline/examples/rss.cli deleted +0 -112

112 lines not on this page · raw message

examples/ip_pipeline/examples/tap.cli deleted +0 -66

66 lines not on this page · raw message

examples/ip_pipeline/link.c deleted +0 -270

270 lines not on this page · raw message

examples/ip_pipeline/link.h deleted +0 -66

66 lines not on this page · raw message

examples/ip_pipeline/main.c deleted +0 -260

260 lines not on this page · raw message

examples/ip_pipeline/mempool.c deleted +0 -82

82 lines not on this page · raw message

examples/ip_pipeline/mempool.h deleted +0 -40
deleted file mode 100644
index bd46a11ca0..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/meson.build deleted +0 -30
deleted file mode 100644
index 68049157e4..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/parser.c deleted +0 -506

506 lines not on this page · raw message

examples/ip_pipeline/parser.h deleted +0 -56

56 lines not on this page · raw message

examples/ip_pipeline/pipeline.c deleted +0 -1078

1,078 lines not on this page · raw message

examples/ip_pipeline/pipeline.h deleted +0 -425

425 lines not on this page · raw message

examples/ip_pipeline/swq.c deleted +0 -76

76 lines not on this page · raw message

examples/ip_pipeline/swq.h deleted +0 -37
deleted file mode 100644
index c8440ee3cd..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/tap.c deleted +0 -102

102 lines not on this page · raw message

examples/ip_pipeline/tap.h deleted +0 -29
deleted file mode 100644
index 0dce72fe3c..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/thread.c deleted +0 -3137

3,137 lines not on this page · raw message

examples/ip_pipeline/thread.h deleted +0 -24
deleted file mode 100644
index facdf004eb..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/tmgr.c deleted +0 -248

248 lines not on this page · raw message

examples/ip_pipeline/tmgr.h deleted +0 -74

74 lines not on this page · raw message

examples/meson.build +0 -1
index 25d9c88457..544ec5eadd 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#20 lore raw

PATCH v3 4/6 pipeline: remove legacy API

In reply to Stephen Hemminger

Remove the legacy pipeline API (rte_pipeline_*) together with the port and table action APIs built on top of it, as announced for removal in the 24.11 release. The SWX pipeline API remains.

The sched dependency was only used by the table action API, so drop it.

---
 devtools/cocci/nullfree.cocci              |   12 -
 doc/api/doxy-api-index.md                  |    3 -
 doc/guides/prog_guide/packet_framework.rst |  203 --
 doc/guides/rel_notes/deprecation.rst       |    5 -
 doc/guides/rel_notes/release_26_11.rst     |    4 +
 lib/pipeline/meson.build                   |    8 +-
 lib/pipeline/rte_pipeline.c                | 1640 ---------
 lib/pipeline/rte_pipeline.h                |  840 -----
 lib/pipeline/rte_port_in_action.c          |  539 ---
 lib/pipeline/rte_port_in_action.h          |  311 --
 lib/pipeline/rte_table_action.c            | 3483 --------------------
 lib/pipeline/rte_table_action.h            | 1137 -------
 12 files changed, 5 insertions(+), 8180 deletions(-)
 delete mode 100644 lib/pipeline/rte_pipeline.c
 delete mode 100644 lib/pipeline/rte_pipeline.h
 delete mode 100644 lib/pipeline/rte_port_in_action.c
 delete mode 100644 lib/pipeline/rte_port_in_action.h
 delete mode 100644 lib/pipeline/rte_table_action.c
 delete mode 100644 lib/pipeline/rte_table_action.h
devtools/cocci/nullfree.cocci +0 -12
index e7417b69ff..acf26f45f6 100644
@@ -91,12 +91,6 @@ expression E;
 - if (E != NULL) rte_ring_free(E);
 + rte_ring_free(E);
 |
-- if (E != NULL) rte_port_in_action_free(E);
-+ rte_port_in_action_free(E);
-|
-- if (E != NULL) rte_port_in_action_profile_free(E);
-+ rte_port_in_action_profile_free(E);
-|
 - if (E != NULL) rte_sched_port_free(E);
 + rte_sched_port_free(E);
 |
@@ -118,12 +112,6 @@ expression E;
 - if (E != NULL) rte_swx_table_selector_free(E);
 + rte_swx_table_selector_free(E);
 |
-- if (E != NULL) rte_table_action_free(E);
-+ rte_table_action_free(E);
-|
-- if (E != NULL) rte_table_action_profile_free(E);
-+ rte_table_action_profile_free(E);
-|
 - if (E != NULL) rte_tel_data_free(E);
 + rte_tel_data_free(E);
 |
doc/api/doxy-api-index.md +0 -3
index 9296042119..17c15027b8 100644
@@ -196,9 +196,6 @@ The public API headers are grouped by topics:
     [hash](@ref rte_table_hash.h),
     [array](@ref rte_table_array.h),
     [stub](@ref rte_table_stub.h)
-  * [pipeline](@ref rte_pipeline.h)
-    [port_in_action](@ref rte_port_in_action.h)
-    [table_action](@ref rte_table_action.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/packet_framework.rst +0 -203

209 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 6ad7698c6b..758652a492 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* pipeline: The pipeline library legacy API (functions rte_pipeline_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new pipeline library API (functions rte_swx_pipeline_*)
-  will gradually transition from experimental to stable status.
-
 * table: The table library legacy API (functions rte_table_*)
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new table library API (functions rte_swx_table_*)
doc/guides/rel_notes/release_26_11.rst +4 -0
index fc84ba367e..f7d34aa1ee 100644
@@ -84,6 +84,10 @@ Removed Items
   the legacy pipeline library API.
   The ``pipeline`` example application covers the SWX pipeline API.
 
+* Removed the legacy pipeline library API: ``rte_pipeline_*``,
+  ``rte_port_in_action_*`` and ``rte_table_action_*`` functions.
+  The SWX pipeline API (``rte_swx_pipeline_*``) remains.
+
 
 API Changes
 -----------
lib/pipeline/meson.build +1 -7
index 823c7929a7..997ded6792 100644
@@ -10,21 +10,15 @@ endif
 cflags += no_wvla_cflag
 
 sources = files(
-        'rte_pipeline.c',
-        'rte_port_in_action.c',
-        'rte_table_action.c',
         'rte_swx_ipsec.c',
         'rte_swx_pipeline.c',
         'rte_swx_pipeline_spec.c',
         'rte_swx_ctl.c',
 )
 headers = files(
-        'rte_pipeline.h',
-        'rte_port_in_action.h',
-        'rte_table_action.h',
         'rte_swx_ipsec.h',
         'rte_swx_pipeline.h',
         'rte_swx_extern.h',
         'rte_swx_ctl.h',
 )
-deps += ['port', 'table', 'meter', 'sched', 'cryptodev', 'ipsec']
+deps += ['port', 'table', 'meter', 'cryptodev', 'ipsec']
lib/pipeline/rte_pipeline.c deleted +0 -1640

1,640 lines not on this page · raw message

lib/pipeline/rte_pipeline.h deleted +0 -840

840 lines not on this page · raw message

lib/pipeline/rte_port_in_action.c deleted +0 -539

235 lines not on this page · raw message

lib/pipeline/rte_port_in_action.h deleted +0 -311

311 lines not on this page · raw message

lib/pipeline/rte_table_action.c deleted +0 -3483

3,483 lines not on this page · raw message

lib/pipeline/rte_table_action.h deleted +0 -1137

1,137 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#21 lore raw

PATCH v3 5/6 table: remove legacy API

In reply to Stephen Hemminger

Remove the legacy table library API (rte_table_*) as announced for removal in the 24.11 release. The SWX table API remains.

The lpm and port dependencies were only used by the legacy API, so drop them. The hash and acl dependencies are still needed by the SWX exact match and wildcard match tables.

---
 doc/api/doxy-api-index.md                  |    7 -
 doc/guides/prog_guide/img/figure33.png     |  Bin 65216 -> 0 bytes
 doc/guides/prog_guide/img/figure34.png     |  Bin 11581 -> 0 bytes
 doc/guides/prog_guide/img/figure35.png     |  Bin 75012 -> 0 bytes
 doc/guides/prog_guide/img/figure37.png     |  Bin 6934 -> 0 bytes
 doc/guides/prog_guide/img/figure38.png     |  Bin 7372 -> 0 bytes
 doc/guides/prog_guide/img/figure39.png     |  Bin 55986 -> 0 bytes
 doc/guides/prog_guide/packet_framework.rst |  811 -------------
 doc/guides/rel_notes/deprecation.rst       |    5 -
 doc/guides/rel_notes/release_26_11.rst     |    3 +
 lib/table/meson.build                      |   30 +-
 lib/table/rte_lru.h                        |   85 --
 lib/table/rte_lru_arm64.h                  |   61 -
 lib/table/rte_lru_x86.h                    |   96 --
 lib/table/rte_table.h                      |  263 -----
 lib/table/rte_table_acl.c                  |  795 -------------
 lib/table/rte_table_acl.h                  |   65 --
 lib/table/rte_table_array.c                |  210 ----
 lib/table/rte_table_array.h                |   46 -
 lib/table/rte_table_hash.h                 |  106 --
 lib/table/rte_table_hash_cuckoo.c          |  327 ------
 lib/table/rte_table_hash_cuckoo.h          |   57 -
 lib/table/rte_table_hash_ext.c             | 1011 ----------------
 lib/table/rte_table_hash_func.h            |  263 -----
 lib/table/rte_table_hash_func_arm64.h      |   21 -
 lib/table/rte_table_hash_key16.c           | 1190 -------------------
 lib/table/rte_table_hash_key32.c           | 1223 --------------------
 lib/table/rte_table_hash_key8.c            | 1157 ------------------
 lib/table/rte_table_hash_lru.c             |  959 ---------------
 lib/table/rte_table_lpm.c                  |  369 ------
 lib/table/rte_table_lpm.h                  |   94 --
 lib/table/rte_table_lpm_ipv6.c             |  370 ------
 lib/table/rte_table_lpm_ipv6.h             |   92 --
 lib/table/rte_table_stub.c                 |   95 --
 lib/table/rte_table_stub.h                 |   30 -
 lib/table/table_log.c                      |    7 -
 lib/table/table_log.h                      |   11 -
 37 files changed, 4 insertions(+), 9855 deletions(-)
 delete mode 100644 doc/guides/prog_guide/img/figure33.png
 delete mode 100644 doc/guides/prog_guide/img/figure34.png
 delete mode 100644 doc/guides/prog_guide/img/figure35.png
 delete mode 100644 doc/guides/prog_guide/img/figure37.png
 delete mode 100644 doc/guides/prog_guide/img/figure38.png
 delete mode 100644 doc/guides/prog_guide/img/figure39.png
 delete mode 100644 lib/table/rte_lru.h
 delete mode 100644 lib/table/rte_lru_arm64.h
 delete mode 100644 lib/table/rte_lru_x86.h
 delete mode 100644 lib/table/rte_table.h
 delete mode 100644 lib/table/rte_table_acl.c
 delete mode 100644 lib/table/rte_table_acl.h
 delete mode 100644 lib/table/rte_table_array.c
 delete mode 100644 lib/table/rte_table_array.h
 delete mode 100644 lib/table/rte_table_hash.h
 delete mode 100644 lib/table/rte_table_hash_cuckoo.c
 delete mode 100644 lib/table/rte_table_hash_cuckoo.h
 delete mode 100644 lib/table/rte_table_hash_ext.c
 delete mode 100644 lib/table/rte_table_hash_func.h
 delete mode 100644 lib/table/rte_table_hash_func_arm64.h
 delete mode 100644 lib/table/rte_table_hash_key16.c
 delete mode 100644 lib/table/rte_table_hash_key32.c
 delete mode 100644 lib/table/rte_table_hash_key8.c
 delete mode 100644 lib/table/rte_table_hash_lru.c
 delete mode 100644 lib/table/rte_table_lpm.c
 delete mode 100644 lib/table/rte_table_lpm.h
 delete mode 100644 lib/table/rte_table_lpm_ipv6.c
 delete mode 100644 lib/table/rte_table_lpm_ipv6.h
 delete mode 100644 lib/table/rte_table_stub.c
 delete mode 100644 lib/table/rte_table_stub.h
 delete mode 100644 lib/table/table_log.c
 delete mode 100644 lib/table/table_log.h
doc/api/doxy-api-index.md +0 -7
index 17c15027b8..760b770d6f 100644
@@ -189,13 +189,6 @@ The public API headers are grouped by topics:
     [reass](@ref rte_port_ras.h),
     [sched](@ref rte_port_sched.h),
     [src/sink](@ref rte_port_source_sink.h)
-  * [table](@ref rte_table.h):
-    [lpm IPv4](@ref rte_table_lpm.h),
-    [lpm IPv6](@ref rte_table_lpm_ipv6.h),
-    [ACL](@ref rte_table_acl.h),
-    [hash](@ref rte_table_hash.h),
-    [array](@ref rte_table_array.h),
-    [stub](@ref rte_table_stub.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/img/figure33.png deleted binary +0 -0
deleted file mode 100644
index f0670eb0053da643e1ee932ee3f30fdd0aa973e6..0000000000000000000000000000000000000000
GIT binary patch
doc/guides/prog_guide/img/figure34.png deleted binary +0 -0
deleted file mode 100644
index caa2517a4013acbfc7c405866abfa180dbcacb63..0000000000000000000000000000000000000000
GIT binary patch
doc/guides/prog_guide/img/figure35.png deleted binary +0 -0
deleted file mode 100644
index 42053f006745dbe7e02869817995e2b38dc56932..0000000000000000000000000000000000000000
GIT binary patch
doc/guides/prog_guide/img/figure37.png deleted binary +0 -0
deleted file mode 100644
index 20be4aaa6de8040339e0db4200a5e800816f14b7..0000000000000000000000000000000000000000
GIT binary patch
doc/guides/prog_guide/img/figure38.png deleted binary +0 -0
deleted file mode 100644
index 261c561f98a98d572c9247b7187b33f7e03002ce..0000000000000000000000000000000000000000
GIT binary patch
doc/guides/prog_guide/img/figure39.png deleted binary +0 -0
deleted file mode 100644
index d2db6a499a0f764b9e661b905b0f136ea871b457..0000000000000000000000000000000000000000
GIT binary patch
doc/guides/prog_guide/packet_framework.rst +0 -811

817 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 758652a492..9dcf86098f 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* table: The table library legacy API (functions rte_table_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new table library API (functions rte_swx_table_*)
-  will gradually transition from experimental to stable status.
-
 * port: The port library legacy API (functions rte_port_*)
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new port library API (functions rte_swx_port_*)
doc/guides/rel_notes/release_26_11.rst +3 -0
index f7d34aa1ee..50b0d3ac06 100644
@@ -88,6 +88,9 @@ Removed Items
   ``rte_port_in_action_*`` and ``rte_table_action_*`` functions.
   The SWX pipeline API (``rte_swx_pipeline_*``) remains.
 
+* Removed the legacy table library API (``rte_table_*`` functions).
+  The SWX table API (``rte_swx_table_*``) remains.
+
 
 API Changes
 -----------
lib/table/meson.build +1 -29
index e27957fe89..620c20e594 100644
@@ -9,42 +9,14 @@ sources = files(
         'rte_swx_table_learner.c',
         'rte_swx_table_selector.c',
         'rte_swx_table_wm.c',
-        'rte_table_acl.c',
-        'rte_table_array.c',
-        'rte_table_hash_cuckoo.c',
-        'rte_table_hash_ext.c',
-        'rte_table_hash_key8.c',
-        'rte_table_hash_key16.c',
-        'rte_table_hash_key32.c',
-        'rte_table_hash_lru.c',
-        'rte_table_lpm.c',
-        'rte_table_lpm_ipv6.c',
-        'rte_table_stub.c',
-        'table_log.c',
 )
 
 headers = files(
-        'rte_lru.h',
         'rte_swx_hash_func.h',
         'rte_swx_table.h',
         'rte_swx_table_em.h',
         'rte_swx_table_learner.h',
         'rte_swx_table_selector.h',
         'rte_swx_table_wm.h',
-        'rte_table.h',
-        'rte_table_acl.h',
-        'rte_table_array.h',
-        'rte_table_hash.h',
-        'rte_table_hash_cuckoo.h',
-        'rte_table_hash_func.h',
-        'rte_table_lpm.h',
-        'rte_table_lpm_ipv6.h',
-        'rte_table_stub.h',
-)
-deps += ['mbuf', 'port', 'lpm', 'hash', 'acl']
-
-indirect_headers += files(
-        'rte_lru_arm64.h',
-        'rte_lru_x86.h',
-        'rte_table_hash_func_arm64.h',
 )
+deps += ['mbuf', 'hash', 'acl']
lib/table/rte_lru.h deleted +0 -85

85 lines not on this page · raw message

lib/table/rte_lru_arm64.h deleted +0 -61

61 lines not on this page · raw message

lib/table/rte_lru_x86.h deleted +0 -96

96 lines not on this page · raw message

lib/table/rte_table.h deleted +0 -263

263 lines not on this page · raw message

lib/table/rte_table_acl.c deleted +0 -795

795 lines not on this page · raw message

lib/table/rte_table_acl.h deleted +0 -65

65 lines not on this page · raw message

lib/table/rte_table_array.c deleted +0 -210

210 lines not on this page · raw message

lib/table/rte_table_array.h deleted +0 -46

46 lines not on this page · raw message

lib/table/rte_table_hash.h deleted +0 -106

106 lines not on this page · raw message

lib/table/rte_table_hash_cuckoo.c deleted +0 -327

327 lines not on this page · raw message

lib/table/rte_table_hash_cuckoo.h deleted +0 -57

53 lines not on this page · raw message

lib/table/rte_table_hash_ext.c deleted +0 -1011

1,011 lines not on this page · raw message

lib/table/rte_table_hash_func.h deleted +0 -263

263 lines not on this page · raw message

lib/table/rte_table_hash_func_arm64.h deleted +0 -21
deleted file mode 100644
index eb04c1ff54..0000000000

Lines of this file are not shown. View the raw message.

lib/table/rte_table_hash_key16.c deleted +0 -1190

1,190 lines not on this page · raw message

lib/table/rte_table_hash_key32.c deleted +0 -1223

1,223 lines not on this page · raw message

lib/table/rte_table_hash_key8.c deleted +0 -1157

1,157 lines not on this page · raw message

lib/table/rte_table_hash_lru.c deleted +0 -959

959 lines not on this page · raw message

lib/table/rte_table_lpm.c deleted +0 -369

369 lines not on this page · raw message

lib/table/rte_table_lpm.h deleted +0 -94

94 lines not on this page · raw message

lib/table/rte_table_lpm_ipv6.c deleted +0 -370

370 lines not on this page · raw message

lib/table/rte_table_lpm_ipv6.h deleted +0 -92

92 lines not on this page · raw message

lib/table/rte_table_stub.c deleted +0 -95

95 lines not on this page · raw message

lib/table/rte_table_stub.h deleted +0 -30
deleted file mode 100644
index f7e589df16..0000000000

Lines of this file are not shown. View the raw message.

lib/table/table_log.c deleted +0 -7
deleted file mode 100644
index b329edd2e6..0000000000

Lines of this file are not shown. View the raw message.

lib/table/table_log.h deleted +0 -11
deleted file mode 100644
index b24b8614c2..0000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#22 lore raw

PATCH v3 6/6 port: remove legacy API

In reply to Stephen Hemminger

Remove the legacy port library API (rte_port_*) as announced for removal in the 24.11 release. The SWX port API remains.

The sched, ip_frag, cryptodev and eventdev dependencies were only used by the legacy port types, so drop them. The pcap dependency is kept for the SWX source/sink port.

---
 doc/api/doxy-api-index.md                  |   7 -
 doc/guides/prog_guide/img/figure32.png     | Bin 11603 -> 0 bytes
 doc/guides/prog_guide/packet_framework.rst | 132 +---
 doc/guides/rel_notes/deprecation.rst       |   5 -
 doc/guides/rel_notes/release_26_11.rst     |   3 +
 lib/port/meson.build                       |  22 +-
 lib/port/port_log.c                        |   7 -
 lib/port/port_log.h                        |  11 -
 lib/port/rte_port.h                        | 223 ------
 lib/port/rte_port_ethdev.c                 | 530 --------------
 lib/port/rte_port_ethdev.h                 |  75 --
 lib/port/rte_port_eventdev.c               | 590 ---------------
 lib/port/rte_port_eventdev.h               |  94 ---
 lib/port/rte_port_fd.c                     | 524 --------------
 lib/port/rte_port_fd.h                     |  74 --
 lib/port/rte_port_frag.c                   | 280 --------
 lib/port/rte_port_frag.h                   |  70 --
 lib/port/rte_port_ras.c                    | 336 ---------
 lib/port/rte_port_ras.h                    |  58 --
 lib/port/rte_port_ring.c                   | 796 ---------------------
 lib/port/rte_port_ring.h                   |  91 ---
 lib/port/rte_port_sched.c                  | 298 --------
 lib/port/rte_port_sched.h                  |  52 --
 lib/port/rte_port_source_sink.c            | 616 ----------------
 lib/port/rte_port_source_sink.h            |  57 --
 lib/port/rte_port_sym_crypto.c             | 558 ---------------
 lib/port/rte_port_sym_crypto.h             |  92 ---
 27 files changed, 10 insertions(+), 5591 deletions(-)
 delete mode 100644 doc/guides/prog_guide/img/figure32.png
 delete mode 100644 lib/port/port_log.c
 delete mode 100644 lib/port/port_log.h
 delete mode 100644 lib/port/rte_port.h
 delete mode 100644 lib/port/rte_port_ethdev.c
 delete mode 100644 lib/port/rte_port_ethdev.h
 delete mode 100644 lib/port/rte_port_eventdev.c
 delete mode 100644 lib/port/rte_port_eventdev.h
 delete mode 100644 lib/port/rte_port_fd.c
 delete mode 100644 lib/port/rte_port_fd.h
 delete mode 100644 lib/port/rte_port_frag.c
 delete mode 100644 lib/port/rte_port_frag.h
 delete mode 100644 lib/port/rte_port_ras.c
 delete mode 100644 lib/port/rte_port_ras.h
 delete mode 100644 lib/port/rte_port_ring.c
 delete mode 100644 lib/port/rte_port_ring.h
 delete mode 100644 lib/port/rte_port_sched.c
 delete mode 100644 lib/port/rte_port_sched.h
 delete mode 100644 lib/port/rte_port_source_sink.c
 delete mode 100644 lib/port/rte_port_source_sink.h
 delete mode 100644 lib/port/rte_port_sym_crypto.c
 delete mode 100644 lib/port/rte_port_sym_crypto.h
doc/api/doxy-api-index.md +0 -7
index 760b770d6f..16827a602b 100644
@@ -182,13 +182,6 @@ The public API headers are grouped by topics:
   [bitmap](@ref rte_bitmap.h)
 
 - **packet framework**:
-  * [port](@ref rte_port.h):
-    [ethdev](@ref rte_port_ethdev.h),
-    [ring](@ref rte_port_ring.h),
-    [frag](@ref rte_port_frag.h),
-    [reass](@ref rte_port_ras.h),
-    [sched](@ref rte_port_sched.h),
-    [src/sink](@ref rte_port_source_sink.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/img/figure32.png deleted binary +0 -0
deleted file mode 100644
index 5215113fd9d533ff56526e21e1832bc7a6cabd04..0000000000000000000000000000000000000000
GIT binary patch
doc/guides/prog_guide/packet_framework.rst +6 -126

138 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 9dcf86098f..75b56b0e10 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* port: The port library legacy API (functions rte_port_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new port library API (functions rte_swx_port_*)
-  will gradually transition from experimental to stable status.
-
 * bus/vmbus: Starting DPDK 25.11, all the vmbus API defined in
   ``drivers/bus/vmbus/rte_bus_vmbus.h`` will become internal to DPDK.
   Those API functions are used internally by DPDK core and netvsc PMD.
doc/guides/rel_notes/release_26_11.rst +3 -0
index 50b0d3ac06..31b075b3cc 100644
@@ -91,6 +91,9 @@ Removed Items
 * Removed the legacy table library API (``rte_table_*`` functions).
   The SWX table API (``rte_swx_table_*``) remains.
 
+* Removed the legacy port library API (``rte_port_*`` functions).
+  The SWX port API (``rte_swx_port_*``) remains.
+
 
 API Changes
 -----------
lib/port/meson.build +1 -21
index b597772872..ef88b917a3 100644
@@ -8,39 +8,19 @@ if is_windows
 endif
 
 sources = files(
-        'port_log.c',
-        'rte_port_ethdev.c',
-        'rte_port_fd.c',
-        'rte_port_frag.c',
-        'rte_port_ras.c',
-        'rte_port_ring.c',
-        'rte_port_sched.c',
-        'rte_port_source_sink.c',
-        'rte_port_sym_crypto.c',
-        'rte_port_eventdev.c',
         'rte_swx_port_ethdev.c',
         'rte_swx_port_fd.c',
         'rte_swx_port_ring.c',
         'rte_swx_port_source_sink.c',
 )
 headers = files(
-        'rte_port_ethdev.h',
-        'rte_port_fd.h',
-        'rte_port_frag.h',
-        'rte_port_ras.h',
-        'rte_port.h',
-        'rte_port_ring.h',
-        'rte_port_sched.h',
-        'rte_port_source_sink.h',
-        'rte_port_sym_crypto.h',
-        'rte_port_eventdev.h',
         'rte_swx_port.h',
         'rte_swx_port_ethdev.h',
         'rte_swx_port_fd.h',
         'rte_swx_port_ring.h',
         'rte_swx_port_source_sink.h',
 )
-deps += ['ethdev', 'sched', 'ip_frag', 'cryptodev', 'eventdev']
+deps += ['ethdev']
 
 if dpdk_conf.has('RTE_HAS_LIBPCAP')
     dpdk_conf.set('RTE_PORT_PCAP', 1)
lib/port/port_log.c deleted +0 -7
deleted file mode 100644
index e7a10d80ef..0000000000
@@ -1,7 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2024 Stephen Hemminger <[email protected]>
- */
-
-#include <rte_log.h>
-
-RTE_LOG_REGISTER_DEFAULT(port_logtype, INFO);
lib/port/port_log.h deleted +0 -11
deleted file mode 100644
index 28d75ee48b..0000000000
@@ -1,11 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2023 Red Hat, Inc.
- */
-
-#include <rte_log.h>
-
-extern int port_logtype;
-#define RTE_LOGTYPE_PORT port_logtype
-
-#define PORT_LOG(level, ...) \
-	RTE_LOG_LINE(level, PORT, "" __VA_ARGS__)
lib/port/rte_port.h deleted +0 -223

223 lines not on this page · raw message

lib/port/rte_port_ethdev.c deleted +0 -530

530 lines not on this page · raw message

lib/port/rte_port_ethdev.h deleted +0 -75

75 lines not on this page · raw message

lib/port/rte_port_eventdev.c deleted +0 -590

590 lines not on this page · raw message

lib/port/rte_port_eventdev.h deleted +0 -94

94 lines not on this page · raw message

lib/port/rte_port_fd.c deleted +0 -524

524 lines not on this page · raw message

lib/port/rte_port_fd.h deleted +0 -74

74 lines not on this page · raw message

lib/port/rte_port_frag.c deleted +0 -280

280 lines not on this page · raw message

lib/port/rte_port_frag.h deleted +0 -70

70 lines not on this page · raw message

lib/port/rte_port_ras.c deleted +0 -336

311 lines not on this page · raw message

lib/port/rte_port_ras.h deleted +0 -58

58 lines not on this page · raw message

lib/port/rte_port_ring.c deleted +0 -796

796 lines not on this page · raw message

lib/port/rte_port_ring.h deleted +0 -91

91 lines not on this page · raw message

lib/port/rte_port_sched.c deleted +0 -298

298 lines not on this page · raw message

lib/port/rte_port_sched.h deleted +0 -52

52 lines not on this page · raw message

lib/port/rte_port_source_sink.c deleted +0 -616

616 lines not on this page · raw message

lib/port/rte_port_source_sink.h deleted +0 -57

57 lines not on this page · raw message

lib/port/rte_port_sym_crypto.c deleted +0 -558

558 lines not on this page · raw message

lib/port/rte_port_sym_crypto.h deleted +0 -92

92 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#23 lore raw

Re: [PATCH v3 0/6] remove legacy packet framework

In reply to Stephen Hemminger
Quoted 6 lines · Stephen Hemminger

Remove the legacy packet framework examples and libraries. This was announced in 24.11 but never completed.

v3 - also cleanup cocci scripts

Quoted 7 lines

Stephen Hemminger (6):
app/test: remove packet framework tests
app/test-pipeline: remove application
examples/ip_pipeline: remove example
pipeline: remove legacy API
table: remove legacy API
port: remove legacy API

Not sure why, but downloading the mbox from patchwork gives broken patches. Maybe the binary part gets mangled...

At least, downloading from inbox.dpdk.org works.

Signature · 1 line
David Marchand
#24 lore raw

v4 cover remove deprecated packet framework

In reply to Stephen Hemminger

The packet framework was marked as deprecated in 24.11.
This patch series completes the removal of the libraries, documentation, and tests.

Stephen Hemminger (7):
app/test: remove packet framework tests
app/test-pipeline: remove application
examples/ip_pipeline: remove example
pipeline: remove legacy API
table: remove legacy API
port: remove legacy API
doc: remove packet framework images

 MAINTAINERS                                   |    5 -
 app/meson.build                               |    1 -
 app/test-pipeline/config.c                    |  230 -
 app/test-pipeline/init.c                      |  273 -
 app/test-pipeline/main.c                      |  188 -
 app/test-pipeline/main.h                      |  132 -
 app/test-pipeline/meson.build                 |   21 -
 app/test-pipeline/pipeline_acl.c              |  251 -
 app/test-pipeline/pipeline_hash.c             |  471 --
 app/test-pipeline/pipeline_lpm.c              |  175 -
 app/test-pipeline/pipeline_lpm_ipv6.c         |  168 -
 app/test-pipeline/pipeline_stub.c             |  137 -
 app/test-pipeline/runtime.c                   |  160 -
 app/test/meson.build                          |    6 -
 app/test/test_table.c                         |  209 -
 app/test/test_table.h                         |  184 -
 app/test/test_table_acl.c                     |  728 --
 app/test/test_table_acl.h                     |    6 -
 app/test/test_table_combined.c                |  846 --
 app/test/test_table_combined.h                |   27 -
 app/test/test_table_pipeline.c                |  575 --
 app/test/test_table_pipeline.h                |    6 -
 app/test/test_table_ports.c                   |  195 -
 app/test/test_table_ports.h                   |   13 -
 app/test/test_table_tables.c                  | 1058 ---
 app/test/test_table_tables.h                  |   22 -
 doc/api/doxy-api-index.md                     |   17 -
 doc/guides/nics/softnic.rst                   |    3 +-
 doc/guides/prog_guide/img/figure32.png        |  Bin 11603 -> 0 bytes
 doc/guides/prog_guide/img/figure33.png        |  Bin 65216 -> 0 bytes
 doc/guides/prog_guide/img/figure34.png        |  Bin 11581 -> 0 bytes
 doc/guides/prog_guide/img/figure35.png        |  Bin 75012 -> 0 bytes
 doc/guides/prog_guide/img/figure37.png        |  Bin 6934 -> 0 bytes
 doc/guides/prog_guide/img/figure38.png        |  Bin 7372 -> 0 bytes
 doc/guides/prog_guide/img/figure39.png        |  Bin 55986 -> 0 bytes
 doc/guides/prog_guide/packet_framework.rst    | 1146 +--
 doc/guides/rel_notes/deprecation.rst          |   15 -
 doc/guides/rel_notes/release_26_11.rst        |   17 +
 .../sample_app_ug/img/test_pipeline_app.png   |  Bin 67410 -> 0 bytes
 doc/guides/sample_app_ug/index.rst            |    2 -
 doc/guides/sample_app_ug/ip_pipeline.rst      |  531 --
 doc/guides/sample_app_ug/test_pipeline.rst    |  237 -
 examples/ip_pipeline/Makefile                 |   60 -
 examples/ip_pipeline/action.c                 |  391 -
 examples/ip_pipeline/action.h                 |   78 -
 examples/ip_pipeline/cli.c                    | 6791 -----------------
 examples/ip_pipeline/cli.h                    |   18 -
 examples/ip_pipeline/common.h                 |   12 -
 examples/ip_pipeline/conn.c                   |  330 -
 examples/ip_pipeline/conn.h                   |   47 -
 examples/ip_pipeline/cryptodev.c              |  160 -
 examples/ip_pipeline/cryptodev.h              |   46 -
 examples/ip_pipeline/examples/firewall.cli    |   59 -
 examples/ip_pipeline/examples/flow.cli        |   60 -
 examples/ip_pipeline/examples/flow_crypto.cli |   57 -
 examples/ip_pipeline/examples/l2fwd.cli       |   51 -
 examples/ip_pipeline/examples/route.cli       |   60 -
 examples/ip_pipeline/examples/route_ecmp.cli  |   57 -
 examples/ip_pipeline/examples/rss.cli         |  112 -
 examples/ip_pipeline/examples/tap.cli         |   66 -
 examples/ip_pipeline/link.c                   |  270 -
 examples/ip_pipeline/link.h                   |   66 -
 examples/ip_pipeline/main.c                   |  260 -
 examples/ip_pipeline/mempool.c                |   82 -
 examples/ip_pipeline/mempool.h                |   40 -
 examples/ip_pipeline/meson.build              |   30 -
 examples/ip_pipeline/parser.c                 |  506 --
 examples/ip_pipeline/parser.h                 |   56 -
 examples/ip_pipeline/pipeline.c               | 1078 ---
 examples/ip_pipeline/pipeline.h               |  425 --
 examples/ip_pipeline/swq.c                    |   76 -
 examples/ip_pipeline/swq.h                    |   37 -
 examples/ip_pipeline/tap.c                    |  102 -
 examples/ip_pipeline/tap.h                    |   29 -
 examples/ip_pipeline/thread.c                 | 3137 --------
 examples/ip_pipeline/thread.h                 |   24 -
 examples/ip_pipeline/tmgr.c                   |  248 -
 examples/ip_pipeline/tmgr.h                   |   74 -
 examples/meson.build                          |    1 -
 lib/pipeline/meson.build                      |    8 +-
 lib/pipeline/rte_pipeline.c                   | 1640 ----
 lib/pipeline/rte_pipeline.h                   |  840 --
 lib/pipeline/rte_port_in_action.c             |  539 --
 lib/pipeline/rte_port_in_action.h             |  311 -
 lib/pipeline/rte_table_action.c               | 3483 ---------
 lib/pipeline/rte_table_action.h               | 1137 ---
 lib/port/meson.build                          |   22 +-
 lib/port/port_log.c                           |    7 -
 lib/port/port_log.h                           |   11 -
 lib/port/rte_port.h                           |  223 -
 lib/port/rte_port_ethdev.c                    |  530 --
 lib/port/rte_port_ethdev.h                    |   75 -
 lib/port/rte_port_eventdev.c                  |  590 --
 lib/port/rte_port_eventdev.h                  |   94 -
 lib/port/rte_port_fd.c                        |  524 --
 lib/port/rte_port_fd.h                        |   74 -
 lib/port/rte_port_frag.c                      |  280 -
 lib/port/rte_port_frag.h                      |   70 -
 lib/port/rte_port_ras.c                       |  336 -
 lib/port/rte_port_ras.h                       |   58 -
 lib/port/rte_port_ring.c                      |  796 --
 lib/port/rte_port_ring.h                      |   91 -
 lib/port/rte_port_sched.c                     |  298 -
 lib/port/rte_port_sched.h                     |   52 -
 lib/port/rte_port_source_sink.c               |  616 --
 lib/port/rte_port_source_sink.h               |   57 -
 lib/port/rte_port_sym_crypto.c                |  558 --
 lib/port/rte_port_sym_crypto.h                |   92 -
 lib/table/meson.build                         |   30 +-
 lib/table/rte_lru.h                           |   85 -
 lib/table/rte_lru_arm64.h                     |   61 -
 lib/table/rte_lru_x86.h                       |   96 -
 lib/table/rte_table.h                         |  263 -
 lib/table/rte_table_acl.c                     |  795 --
 lib/table/rte_table_acl.h                     |   65 -
 lib/table/rte_table_array.c                   |  210 -
 lib/table/rte_table_array.h                   |   46 -
 lib/table/rte_table_hash.h                    |  106 -
 lib/table/rte_table_hash_cuckoo.c             |  327 -
 lib/table/rte_table_hash_cuckoo.h             |   57 -
 lib/table/rte_table_hash_ext.c                | 1011 ---
 lib/table/rte_table_hash_func.h               |  263 -
 lib/table/rte_table_hash_func_arm64.h         |   21 -
 lib/table/rte_table_hash_key16.c              | 1190 ---
 lib/table/rte_table_hash_key32.c              | 1223 ---
 lib/table/rte_table_hash_key8.c               | 1157 ---
 lib/table/rte_table_hash_lru.c                |  959 ---
 lib/table/rte_table_lpm.c                     |  369 -
 lib/table/rte_table_lpm.h                     |   94 -
 lib/table/rte_table_lpm_ipv6.c                |  370 -
 lib/table/rte_table_stub.c                    |   95 -
 lib/table/rte_table_stub.h                    |   30 -
 lib/table/table_log.c                         |    7 -
 lib/table/table_log.h                         |   11 -
 134 files changed, 27 insertions(+), 45377 deletions(-)
 delete mode 100644 app/test-pipeline/config.c
 delete mode 100644 app/test-pipeline/init.c
 delete mode 100644 app/test-pipeline/main.c
 delete mode 100644 app/test-pipeline/main.h
 delete mode 100644 app/test-pipeline/meson.build
 delete mode 100644 app/test-pipeline/pipeline_acl.c
 delete mode 100644 app/test-pipeline/pipeline_hash.c
 delete mode 100644 app/test-pipeline/pipeline_lpm.c
 delete mode 100644 app/test-pipeline/pipeline_lpm_ipv6.c
 delete mode 100644 app/test-pipeline/pipeline_stub.c
 delete mode 100644 app/test-pipeline/runtime.c
 delete mode 100644 app/test/test_table.c
 delete mode 100644 app/test/test_table.h
 delete mode 100644 app/test/test_table_acl.c
 delete mode 100644 app/test/test_table_acl.h
 delete mode 100644 app/test/test_table_combined.c
 delete mode 100644 app/test/test_table_combined.h
 delete mode 100644 app/test/test_table_pipeline.c
 delete mode 100644 app/test/test_table_pipeline.h
 delete mode 100644 app/test/test_table_ports.c
 delete mode 100644 app/test/test_table_ports.h
 delete mode 100644 app/test/test_table_tables.c
 delete mode 100644 app/test/test_table_tables.h
 delete mode 100644 doc/guides/prog_guide/img/figure32.png
 delete mode 100644 doc/guides/prog_guide/img/figure33.png
 delete mode 100644 doc/guides/prog_guide/img/figure34.png
 delete mode 100644 doc/guides/prog_guide/img/figure35.png
 delete mode 100644 doc/guides/prog_guide/img/figure37.png
 delete mode 100644 doc/guides/prog_guide/img/figure38.png
 delete mode 100644 doc/guides/prog_guide/img/figure39.png
 delete mode 100644 doc/guides/sample_app_ug/img/test_pipeline_app.png
 delete mode 100644 doc/guides/sample_app_ug/ip_pipeline.rst
 delete mode 100644 doc/guides/sample_app_ug/test_pipeline.rst
 delete mode 100644 examples/ip_pipeline/Makefile
 delete mode 100644 examples/ip_pipeline/action.c
 delete mode 100644 examples/ip_pipeline/action.h
 delete mode 100644 examples/ip_pipeline/cli.c
 delete mode 100644 examples/ip_pipeline/cli.h
 delete mode 100644 examples/ip_pipeline/common.h
 delete mode 100644 examples/ip_pipeline/conn.c
 delete mode 100644 examples/ip_pipeline/conn.h
 delete mode 100644 examples/ip_pipeline/cryptodev.c
 delete mode 100644 examples/ip_pipeline/cryptodev.h
 delete mode 100644 examples/ip_pipeline/examples/firewall.cli
 delete mode 100644 examples/ip_pipeline/examples/flow.cli
 delete mode 100644 examples/ip_pipeline/examples/flow_crypto.cli
 delete mode 100644 examples/ip_pipeline/examples/l2fwd.cli
 delete mode 100644 examples/ip_pipeline/examples/route.cli
 delete mode 100644 examples/ip_pipeline/examples/route_ecmp.cli
 delete mode 100644 examples/ip_pipeline/examples/rss.cli
 delete mode 100644 examples/ip_pipeline/examples/tap.cli
 delete mode 100644 examples/ip_pipeline/link.c
 delete mode 100644 examples/ip_pipeline/link.h
 delete mode 100644 examples/ip_pipeline/main.c
 delete mode 100644 examples/ip_pipeline/mempool.c
 delete mode 100644 examples/ip_pipeline/mempool.h
 delete mode 100644 examples/ip_pipeline/meson.build
 delete mode 100644 examples/ip_pipeline/parser.c
 delete mode 100644 examples/ip_pipeline/parser.h
 delete mode 100644 examples/ip_pipeline/pipeline.c
 delete mode 100644 examples/ip_pipeline/pipeline.h
 delete mode 100644 examples/ip_pipeline/swq.c
 delete mode 100644 examples/ip_pipeline/swq.h
 delete mode 100644 examples/ip_pipeline/tap.c
 delete mode 100644 examples/ip_pipeline/tap.h
 delete mode 100644 examples/ip_pipeline/thread.c
 delete mode 100644 examples/ip_pipeline/thread.h
 delete mode 100644 examples/ip_pipeline/tmgr.c
 delete mode 100644 examples/ip_pipeline/tmgr.h
 delete mode 100644 lib/pipeline/rte_pipeline.c
 delete mode 100644 lib/pipeline/rte_pipeline.h
 delete mode 100644 lib/pipeline/rte_port_in_action.c
 delete mode 100644 lib/pipeline/rte_port_in_action.h
 delete mode 100644 lib/pipeline/rte_table_action.c
 delete mode 100644 lib/pipeline/rte_table_action.h
 delete mode 100644 lib/port/port_log.c
 delete mode 100644 lib/port/port_log.h
 delete mode 100644 lib/port/rte_port.h
 delete mode 100644 lib/port/rte_port_ethdev.c
 delete mode 100644 lib/port/rte_port_ethdev.h
 delete mode 100644 lib/port/rte_port_eventdev.c
 delete mode 100644 lib/port/rte_port_eventdev.h
 delete mode 100644 lib/port/rte_port_fd.c
 delete mode 100644 lib/port/rte_port_fd.h
 delete mode 100644 lib/port/rte_port_frag.c
 delete mode 100644 lib/port/rte_port_frag.h
 delete mode 100644 lib/port/rte_port_ras.c
 delete mode 100644 lib/port/rte_port_ras.h
 delete mode 100644 lib/port/rte_port_ring.c
 delete mode 100644 lib/port/rte_port_ring.h
 delete mode 100644 lib/port/rte_port_sched.c
 delete mode 100644 lib/port/rte_port_sched.h
 delete mode 100644 lib/port/rte_port_source_sink.c
 delete mode 100644 lib/port/rte_port_source_sink.h
 delete mode 100644 lib/port/rte_port_sym_crypto.c
 delete mode 100644 lib/port/rte_port_sym_crypto.h
 delete mode 100644 lib/table/rte_lru.h
 delete mode 100644 lib/table/rte_lru_arm64.h
 delete mode 100644 lib/table/rte_lru_x86.h
 delete mode 100644 lib/table/rte_table.h
 delete mode 100644 lib/table/rte_table_acl.c
 delete mode 100644 lib/table/rte_table_acl.h
 delete mode 100644 lib/table/rte_table_array.c
 delete mode 100644 lib/table/rte_table_array.h
 delete mode 100644 lib/table/rte_table_hash.h
 delete mode 100644 lib/table/rte_table_hash_cuckoo.c
 delete mode 100644 lib/table/rte_table_hash_cuckoo.h
 delete mode 100644 lib/table/rte_table_hash_ext.c
 delete mode 100644 lib/table/rte_table_hash_func.h
 delete mode 100644 lib/table/rte_table_hash_func_arm64.h
 delete mode 100644 lib/table/rte_table_hash_key16.c
 delete mode 100644 lib/table/rte_table_hash_key32.c
 delete mode 100644 lib/table/rte_table_hash_key8.c
 delete mode 100644 lib/table/rte_table_hash_lru.c
 delete mode 100644 lib/table/rte_table_lpm.c
 delete mode 100644 lib/table/rte_table_lpm.h
 delete mode 100644 lib/table/rte_table_lpm_ipv6.c
 delete mode 100644 lib/table/rte_table_stub.c
 delete mode 100644 lib/table/rte_table_stub.h
 delete mode 100644 lib/table/table_log.c
 delete mode 100644 lib/table/table_log.h

--
2.53.0

#25 lore raw

Re: [PATCH v4 0/7] remove deprecated packet framework

Quoted 5 lines · Stephen Hemminger

The packet framework was marked as deprecated in 24.11.
This patch series completes the removal of the libraries, documentation, and tests.

Quoted 8 lines

Stephen Hemminger (7):
app/test: remove packet framework tests
app/test-pipeline: remove application
examples/ip_pipeline: remove example
pipeline: remove legacy API
table: remove legacy API
port: remove legacy API
doc: remove packet framework images

So it seems we have a bug in patchwork wrt binary content in patches.

Please send the series without the last patch, so that the CI can do a pass.

Signature · 1 line
David Marchand
#26 lore raw

PATCH v4 1/7 app/test: remove packet framework tests

In reply to Stephen Hemminger

The legacy packet framework libraries (port, table, pipeline) are being removed, so remove the unit tests exercising them.

---
 MAINTAINERS                    |    1 -
 app/test/meson.build           |    6 -
 app/test/test_table.c          |  209 -------
 app/test/test_table.h          |  184 ------
 app/test/test_table_acl.c      |  728 ----------------------
 app/test/test_table_acl.h      |    6 -
 app/test/test_table_combined.c |  846 -------------------------
 app/test/test_table_combined.h |   27 -
 app/test/test_table_pipeline.c |  575 -----------------
 app/test/test_table_pipeline.h |    6 -
 app/test/test_table_ports.c    |  195 ------
 app/test/test_table_ports.h    |   13 -
 app/test/test_table_tables.c   | 1058 --------------------------------
 app/test/test_table_tables.h   |   22 -
 14 files changed, 3876 deletions(-)
 delete mode 100644 app/test/test_table.c
 delete mode 100644 app/test/test_table.h
 delete mode 100644 app/test/test_table_acl.c
 delete mode 100644 app/test/test_table_acl.h
 delete mode 100644 app/test/test_table_combined.c
 delete mode 100644 app/test/test_table_combined.h
 delete mode 100644 app/test/test_table_pipeline.c
 delete mode 100644 app/test/test_table_pipeline.h
 delete mode 100644 app/test/test_table_ports.c
 delete mode 100644 app/test/test_table_ports.h
 delete mode 100644 app/test/test_table_tables.c
 delete mode 100644 app/test/test_table_tables.h
MAINTAINERS +0 -1
index e99a65d1974d38b62aa88f0662796226e57cd033..77a41b3fcf4110042ef69b7ee53351dd3cadb208 100644
@@ -1739,7 +1739,6 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: app/test/test_table*
 F: app/test-pipeline/
 F: doc/guides/sample_app_ug/test_pipeline.rst
 F: examples/ip_pipeline/
app/test/meson.build +0 -6
index 51abeeb7324483f07df4ff71dbc9e8a283740bc8..4fcd75594091abbf4fd09328023a3118e59b524d 100644
@@ -195,12 +195,6 @@ source_file_deps = {
     'test_stack.c': ['stack'],
     'test_stack_perf.c': ['stack'],
     'test_string_fns.c': [],
-    'test_table.c': ['table', 'pipeline', 'port'],
-    'test_table_acl.c': ['net', 'table', 'pipeline', 'port'],
-    'test_table_combined.c': ['table', 'pipeline', 'port'],
-    'test_table_pipeline.c': ['pipeline', 'table', 'port'],
-    'test_table_ports.c': ['table', 'pipeline', 'port'],
-    'test_table_tables.c': ['table', 'pipeline', 'port'],
     'test_tailq.c': [],
     'test_telemetry_data.c': ['telemetry'],
     'test_telemetry_json.c': ['telemetry'],
app/test/test_table.c deleted +0 -209

209 lines not on this page · raw message

app/test/test_table.h deleted +0 -184

184 lines not on this page · raw message

app/test/test_table_acl.c deleted +0 -728

728 lines not on this page · raw message

app/test/test_table_acl.h deleted +0 -6
deleted file mode 100644
index a6ae7d28385137fedfbfabe199ad0ac412ca698e..0000000000000000000000000000000000000000
@@ -1,6 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_acl(void);
app/test/test_table_combined.c deleted +0 -846

846 lines not on this page · raw message

app/test/test_table_combined.h deleted +0 -27
deleted file mode 100644
index fb94dbb94d08c48ba4bc94e6e657c0eb4fe6b8ce..0000000000000000000000000000000000000000
@@ -1,27 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2016 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_stub_combined(void);
-int test_table_lpm_combined(void);
-int test_table_lpm_ipv6_combined(void);
-#ifdef RTE_LIB_ACL
-int test_table_acl(void);
-#endif
-int test_table_hash8unoptimized(void);
-int test_table_hash8lru(void);
-int test_table_hash8ext(void);
-int test_table_hash16unoptimized(void);
-int test_table_hash16lru(void);
-int test_table_hash16ext(void);
-int test_table_hash32unoptimized(void);
-int test_table_hash32lru(void);
-int test_table_hash32ext(void);
-int test_table_hash_cuckoo_combined(void);
-
-/* Extern variables */
-typedef int (*combined_table_test)(void);
-
-extern combined_table_test table_tests_combined[];
-extern unsigned n_table_tests_combined;
app/test/test_table_pipeline.c deleted +0 -575

575 lines not on this page · raw message

app/test/test_table_pipeline.h deleted +0 -6
deleted file mode 100644
index d66d09d6f1e61f2d7ec179017932407d4620ed04..0000000000000000000000000000000000000000
@@ -1,6 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_pipeline(void);
app/test/test_table_ports.c deleted +0 -195

195 lines not on this page · raw message

app/test/test_table_ports.h deleted +0 -13
deleted file mode 100644
index dfa61193197e741a8ac565a81c2e64e0f0c179a4..0000000000000000000000000000000000000000
@@ -1,13 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_port_ring_reader(void);
-int test_port_ring_writer(void);
-
-/* Extern variables */
-typedef int (*port_test)(void);
-
-extern port_test port_tests[];
-extern unsigned n_port_tests;
app/test/test_table_tables.c deleted +0 -1058

192 lines not on this page · raw message

app/test/test_table_tables.h deleted +0 -22
deleted file mode 100644
index 530633a0136d26c76c59dac8941a862c46068837..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#27 lore raw

PATCH v4 2/7 app/test-pipeline: remove application

In reply to Stephen Hemminger

The test-pipeline application is built on the legacy pipeline library API (rte_pipeline_*), which was announced for removal in the 24.11 release. Remove it before removing the library.

---
 MAINTAINERS                                |   2 -
 app/meson.build                            |   1 -
 app/test-pipeline/config.c                 | 230 ----------
 app/test-pipeline/init.c                   | 273 ------------
 app/test-pipeline/main.c                   | 188 --------
 app/test-pipeline/main.h                   | 132 ------
 app/test-pipeline/meson.build              |  21 -
 app/test-pipeline/pipeline_acl.c           | 251 -----------
 app/test-pipeline/pipeline_hash.c          | 471 ---------------------
 app/test-pipeline/pipeline_lpm.c           | 175 --------
 app/test-pipeline/pipeline_lpm_ipv6.c      | 168 --------
 app/test-pipeline/pipeline_stub.c          | 137 ------
 app/test-pipeline/runtime.c                | 160 -------
 doc/guides/rel_notes/release_26_11.rst     |   3 +
 doc/guides/sample_app_ug/index.rst         |   1 -
 doc/guides/sample_app_ug/test_pipeline.rst | 237 -----------
 16 files changed, 3 insertions(+), 2447 deletions(-)
 delete mode 100644 app/test-pipeline/config.c
 delete mode 100644 app/test-pipeline/init.c
 delete mode 100644 app/test-pipeline/main.c
 delete mode 100644 app/test-pipeline/main.h
 delete mode 100644 app/test-pipeline/meson.build
 delete mode 100644 app/test-pipeline/pipeline_acl.c
 delete mode 100644 app/test-pipeline/pipeline_hash.c
 delete mode 100644 app/test-pipeline/pipeline_lpm.c
 delete mode 100644 app/test-pipeline/pipeline_lpm_ipv6.c
 delete mode 100644 app/test-pipeline/pipeline_stub.c
 delete mode 100644 app/test-pipeline/runtime.c
 delete mode 100644 doc/guides/sample_app_ug/test_pipeline.rst
MAINTAINERS +0 -2
index 77a41b3fcf4110042ef69b7ee53351dd3cadb208..4c06f85706ca9204cab6a655a58b6b7b1457160d 100644
@@ -1739,8 +1739,6 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: app/test-pipeline/
-F: doc/guides/sample_app_ug/test_pipeline.rst
 F: examples/ip_pipeline/
 F: examples/pipeline/
 F: doc/guides/sample_app_ug/ip_pipeline.rst
app/meson.build +0 -1
index 1798db3ae43f685d776533329546e4609d9eb565..4515688471328d2ab315f626c4865c4ba372eaad 100644
@@ -28,7 +28,6 @@ apps = [
         'test-flow-perf',
         'test-gpudev',
         'test-mldev',
-        'test-pipeline',
         'test-pmd',
         'test-regex',
         'test-sad',
app/test-pipeline/config.c deleted +0 -230

230 lines not on this page · raw message

app/test-pipeline/init.c deleted +0 -273

273 lines not on this page · raw message

app/test-pipeline/main.c deleted +0 -188

188 lines not on this page · raw message

app/test-pipeline/main.h deleted +0 -132

132 lines not on this page · raw message

app/test-pipeline/meson.build deleted +0 -21
deleted file mode 100644
index 3add6b637bdb5ec81013140a2011b95b22b7eaaf..0000000000000000000000000000000000000000
@@ -1,21 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2019 Intel Corporation
-
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-sources = files(
-        'config.c',
-        'init.c',
-        'main.c',
-        'pipeline_acl.c',
-        'pipeline_hash.c',
-        'pipeline_lpm.c',
-        'pipeline_lpm_ipv6.c',
-        'pipeline_stub.c',
-        'runtime.c',
-)
-deps += ['pipeline', 'pci']
app/test-pipeline/pipeline_acl.c deleted +0 -251

251 lines not on this page · raw message

app/test-pipeline/pipeline_hash.c deleted +0 -471

471 lines not on this page · raw message

app/test-pipeline/pipeline_lpm.c deleted +0 -175

175 lines not on this page · raw message

app/test-pipeline/pipeline_lpm_ipv6.c deleted +0 -168

168 lines not on this page · raw message

app/test-pipeline/pipeline_stub.c deleted +0 -137

137 lines not on this page · raw message

app/test-pipeline/runtime.c deleted +0 -160

160 lines not on this page · raw message

doc/guides/rel_notes/release_26_11.rst +3 -0
index c8cc86295da2d08b56e1464ca4a3122bbb599068..6ad0cf6eeca19f32429e60c2637b06274d43754a 100644
@@ -77,6 +77,9 @@ Removed Items
     ``rte_rib6_is_equal``
   * table: ``RTE_LPM_IPV6_ADDR_SIZE``
 
+* Removed the ``dpdk-test-pipeline`` application, which was based on
+  the legacy pipeline library API.
+
 
 API Changes
 -----------
doc/guides/sample_app_ug/index.rst +0 -1
index f12623bb669b75c39117f65dad781fe00e4534e9..c8b50b801c5ca317c8107b182a4633a4918fb199 100644
@@ -45,7 +45,6 @@ Sample Applications User Guides
     vhost_crypto
     vdpa
     ip_pipeline
-    test_pipeline
     pipeline
     eventdev_pipeline
     dist_app
doc/guides/sample_app_ug/test_pipeline.rst deleted +0 -237

237 lines not on this page · raw message

Signature · 1 line
2.53.0
#28 lore raw

PATCH v4 3/7 examples/ip_pipeline: remove example

In reply to Stephen Hemminger

The ip_pipeline example is built on the legacy pipeline library API (rte_pipeline_*) and the associated port and table action APIs, which were announced for removal in the 24.11 release. The pipeline example covers the SWX pipeline API.

---
 MAINTAINERS                                   |    2 -
 doc/guides/nics/softnic.rst                   |    3 +-
 doc/guides/rel_notes/release_26_11.rst        |    4 +
 doc/guides/sample_app_ug/index.rst            |    1 -
 doc/guides/sample_app_ug/ip_pipeline.rst      |  531 --
 examples/ip_pipeline/Makefile                 |   60 -
 examples/ip_pipeline/action.c                 |  391 -
 examples/ip_pipeline/action.h                 |   78 -
 examples/ip_pipeline/cli.c                    | 6791 -----------------
 examples/ip_pipeline/cli.h                    |   18 -
 examples/ip_pipeline/common.h                 |   12 -
 examples/ip_pipeline/conn.c                   |  330 -
 examples/ip_pipeline/conn.h                   |   47 -
 examples/ip_pipeline/cryptodev.c              |  160 -
 examples/ip_pipeline/cryptodev.h              |   46 -
 examples/ip_pipeline/examples/firewall.cli    |   59 -
 examples/ip_pipeline/examples/flow.cli        |   60 -
 examples/ip_pipeline/examples/flow_crypto.cli |   57 -
 examples/ip_pipeline/examples/l2fwd.cli       |   51 -
 examples/ip_pipeline/examples/route.cli       |   60 -
 examples/ip_pipeline/examples/route_ecmp.cli  |   57 -
 examples/ip_pipeline/examples/rss.cli         |  112 -
 examples/ip_pipeline/examples/tap.cli         |   66 -
 examples/ip_pipeline/link.c                   |  270 -
 examples/ip_pipeline/link.h                   |   66 -
 examples/ip_pipeline/main.c                   |  260 -
 examples/ip_pipeline/mempool.c                |   82 -
 examples/ip_pipeline/mempool.h                |   40 -
 examples/ip_pipeline/meson.build              |   30 -
 examples/ip_pipeline/parser.c                 |  506 --
 examples/ip_pipeline/parser.h                 |   56 -
 examples/ip_pipeline/pipeline.c               | 1078 ---
 examples/ip_pipeline/pipeline.h               |  425 --
 examples/ip_pipeline/swq.c                    |   76 -
 examples/ip_pipeline/swq.h                    |   37 -
 examples/ip_pipeline/tap.c                    |  102 -
 examples/ip_pipeline/tap.h                    |   29 -
 examples/ip_pipeline/thread.c                 | 3137 --------
 examples/ip_pipeline/thread.h                 |   24 -
 examples/ip_pipeline/tmgr.c                   |  248 -
 examples/ip_pipeline/tmgr.h                   |   74 -
 examples/meson.build                          |    1 -
 42 files changed, 5 insertions(+), 15532 deletions(-)
 delete mode 100644 doc/guides/sample_app_ug/ip_pipeline.rst
 delete mode 100644 examples/ip_pipeline/Makefile
 delete mode 100644 examples/ip_pipeline/action.c
 delete mode 100644 examples/ip_pipeline/action.h
 delete mode 100644 examples/ip_pipeline/cli.c
 delete mode 100644 examples/ip_pipeline/cli.h
 delete mode 100644 examples/ip_pipeline/common.h
 delete mode 100644 examples/ip_pipeline/conn.c
 delete mode 100644 examples/ip_pipeline/conn.h
 delete mode 100644 examples/ip_pipeline/cryptodev.c
 delete mode 100644 examples/ip_pipeline/cryptodev.h
 delete mode 100644 examples/ip_pipeline/examples/firewall.cli
 delete mode 100644 examples/ip_pipeline/examples/flow.cli
 delete mode 100644 examples/ip_pipeline/examples/flow_crypto.cli
 delete mode 100644 examples/ip_pipeline/examples/l2fwd.cli
 delete mode 100644 examples/ip_pipeline/examples/route.cli
 delete mode 100644 examples/ip_pipeline/examples/route_ecmp.cli
 delete mode 100644 examples/ip_pipeline/examples/rss.cli
 delete mode 100644 examples/ip_pipeline/examples/tap.cli
 delete mode 100644 examples/ip_pipeline/link.c
 delete mode 100644 examples/ip_pipeline/link.h
 delete mode 100644 examples/ip_pipeline/main.c
 delete mode 100644 examples/ip_pipeline/mempool.c
 delete mode 100644 examples/ip_pipeline/mempool.h
 delete mode 100644 examples/ip_pipeline/meson.build
 delete mode 100644 examples/ip_pipeline/parser.c
 delete mode 100644 examples/ip_pipeline/parser.h
 delete mode 100644 examples/ip_pipeline/pipeline.c
 delete mode 100644 examples/ip_pipeline/pipeline.h
 delete mode 100644 examples/ip_pipeline/swq.c
 delete mode 100644 examples/ip_pipeline/swq.h
 delete mode 100644 examples/ip_pipeline/tap.c
 delete mode 100644 examples/ip_pipeline/tap.h
 delete mode 100644 examples/ip_pipeline/thread.c
 delete mode 100644 examples/ip_pipeline/thread.h
 delete mode 100644 examples/ip_pipeline/tmgr.c
 delete mode 100644 examples/ip_pipeline/tmgr.h
MAINTAINERS +0 -2
index 4c06f85706ca9204cab6a655a58b6b7b1457160d..ae84e7f289468ac7a6f3f727732377260781ceb4 100644
@@ -1739,9 +1739,7 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: examples/ip_pipeline/
 F: examples/pipeline/
-F: doc/guides/sample_app_ug/ip_pipeline.rst
 
 
 Algorithms
doc/guides/nics/softnic.rst +1 -2
index 603fdb49c461dba89d2d445c8a521485a367ff95..87f3e5adc0e237a31e0048ca75f0eaa5438ae4ce 100644
@@ -10,8 +10,7 @@ is DIY and reconfigurable through ``firmware`` (DPDK Packet Framework script).
 The Soft NIC leverages the DPDK Packet Framework libraries (librte_port,
 librte_table and librte_pipeline) to make it modular, flexible and extensible
 with new functionality.
-Please refer to :doc:`/prog_guide/packet_framework` and
-:doc:`/sample_app_ug/ip_pipeline` for more details.
+Please refer to :doc:`/prog_guide/packet_framework` for more details.
 
 The Soft NIC is configured through the standard DPDK ethdev API (ethdev, flow,
 QoS, security). The internal framework is not externally visible.
doc/guides/rel_notes/release_26_11.rst +4 -0
index 6ad0cf6eeca19f32429e60c2637b06274d43754a..fc84ba367ea730c393caf11883a09024b6c07688 100644
@@ -80,6 +80,10 @@ Removed Items
 * Removed the ``dpdk-test-pipeline`` application, which was based on
   the legacy pipeline library API.
 
+* Removed the ``ip_pipeline`` example application, which was based on
+  the legacy pipeline library API.
+  The ``pipeline`` example application covers the SWX pipeline API.
+
 
 API Changes
 -----------
doc/guides/sample_app_ug/index.rst +0 -1
index c8b50b801c5ca317c8107b182a4633a4918fb199..28c4c9a5b2636037304d3b63ca19861e0bfd6d21 100644
@@ -44,7 +44,6 @@ Sample Applications User Guides
     vhost_blk
     vhost_crypto
     vdpa
-    ip_pipeline
     pipeline
     eventdev_pipeline
     dist_app
doc/guides/sample_app_ug/ip_pipeline.rst deleted +0 -531

531 lines not on this page · raw message

examples/ip_pipeline/Makefile deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/action.c deleted +0 -391

391 lines not on this page · raw message

examples/ip_pipeline/action.h deleted +0 -78

78 lines not on this page · raw message

examples/ip_pipeline/cli.c deleted +0 -6791

1,905 lines not on this page · raw message

examples/ip_pipeline/cli.h deleted +0 -18
deleted file mode 100644
index 992e4c3a4a4a2a667ec03a7997430421b82be273..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/common.h deleted +0 -12
deleted file mode 100644
index 0886dfbe95976257569593012cbf4d9d61eed957..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/conn.c deleted +0 -330

330 lines not on this page · raw message

examples/ip_pipeline/conn.h deleted +0 -47

47 lines not on this page · raw message

examples/ip_pipeline/cryptodev.c deleted +0 -160

160 lines not on this page · raw message

examples/ip_pipeline/cryptodev.h deleted +0 -46

46 lines not on this page · raw message

examples/ip_pipeline/examples/firewall.cli deleted +0 -59

59 lines not on this page · raw message

examples/ip_pipeline/examples/flow.cli deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/examples/flow_crypto.cli deleted +0 -57

57 lines not on this page · raw message

examples/ip_pipeline/examples/l2fwd.cli deleted +0 -51

51 lines not on this page · raw message

examples/ip_pipeline/examples/route.cli deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/examples/route_ecmp.cli deleted +0 -57

57 lines not on this page · raw message

examples/ip_pipeline/examples/rss.cli deleted +0 -112

112 lines not on this page · raw message

examples/ip_pipeline/examples/tap.cli deleted +0 -66

66 lines not on this page · raw message

examples/ip_pipeline/link.c deleted +0 -270

270 lines not on this page · raw message

examples/ip_pipeline/link.h deleted +0 -66

66 lines not on this page · raw message

examples/ip_pipeline/main.c deleted +0 -260

260 lines not on this page · raw message

examples/ip_pipeline/mempool.c deleted +0 -82

82 lines not on this page · raw message

examples/ip_pipeline/mempool.h deleted +0 -40
deleted file mode 100644
index bd46a11ca09f35bca1a52996af92a3c7b9026d0b..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/meson.build deleted +0 -30
deleted file mode 100644
index 68049157e42978a2192fcf86769f5bdfc36465fc..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/parser.c deleted +0 -506

506 lines not on this page · raw message

examples/ip_pipeline/parser.h deleted +0 -56

56 lines not on this page · raw message

examples/ip_pipeline/pipeline.c deleted +0 -1078

1,078 lines not on this page · raw message

examples/ip_pipeline/pipeline.h deleted +0 -425

425 lines not on this page · raw message

examples/ip_pipeline/swq.c deleted +0 -76

76 lines not on this page · raw message

examples/ip_pipeline/swq.h deleted +0 -37
deleted file mode 100644
index c8440ee3cd89590cb157f29f3586a69220765cbf..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/tap.c deleted +0 -102

102 lines not on this page · raw message

examples/ip_pipeline/tap.h deleted +0 -29
deleted file mode 100644
index 0dce72fe3c989ac5443c8037fe2bb929b27a5bb7..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/thread.c deleted +0 -3137

3,137 lines not on this page · raw message

examples/ip_pipeline/thread.h deleted +0 -24
deleted file mode 100644
index facdf004eb6e1dba9dfa388620e8807b235d7dd5..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/tmgr.c deleted +0 -248

248 lines not on this page · raw message

examples/ip_pipeline/tmgr.h deleted +0 -74

74 lines not on this page · raw message

examples/meson.build +0 -1
index 25d9c88457f51f6e806b8dcb20564b3b5ab299b5..544ec5eadd82c3799b3fb884b07a73faa840651f 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#29 lore raw

PATCH v4 4/7 pipeline: remove legacy API

In reply to Stephen Hemminger

Remove the legacy pipeline API (rte_pipeline_*) together with the port and table action APIs built on top of it, as announced for removal in the 24.11 release. The SWX pipeline API remains.

The sched dependency was only used by the table action API, so drop it.

---
 doc/api/doxy-api-index.md                  |    3 -
 doc/guides/prog_guide/packet_framework.rst |  203 --
 doc/guides/rel_notes/deprecation.rst       |    5 -
 doc/guides/rel_notes/release_26_11.rst     |    4 +
 lib/pipeline/meson.build                   |    8 +-
 lib/pipeline/rte_pipeline.c                | 1640 ---------
 lib/pipeline/rte_pipeline.h                |  840 -----
 lib/pipeline/rte_port_in_action.c          |  539 ---
 lib/pipeline/rte_port_in_action.h          |  311 --
 lib/pipeline/rte_table_action.c            | 3483 --------------------
 lib/pipeline/rte_table_action.h            | 1137 -------
 11 files changed, 5 insertions(+), 8168 deletions(-)
 delete mode 100644 lib/pipeline/rte_pipeline.c
 delete mode 100644 lib/pipeline/rte_pipeline.h
 delete mode 100644 lib/pipeline/rte_port_in_action.c
 delete mode 100644 lib/pipeline/rte_port_in_action.h
 delete mode 100644 lib/pipeline/rte_table_action.c
 delete mode 100644 lib/pipeline/rte_table_action.h
doc/api/doxy-api-index.md +0 -3
index 92960421194604a9bc69da1eb6af7fc727cdb310..17c15027b8bd3aae13b992b4bfd038ef8b2bb5cd 100644
@@ -196,9 +196,6 @@ The public API headers are grouped by topics:
     [hash](@ref rte_table_hash.h),
     [array](@ref rte_table_array.h),
     [stub](@ref rte_table_stub.h)
-  * [pipeline](@ref rte_pipeline.h)
-    [port_in_action](@ref rte_port_in_action.h)
-    [table_action](@ref rte_table_action.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/packet_framework.rst +0 -203

209 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 6ad7698c6b8c4f950c9642798bbad36acc814ef9..758652a492e600b267feba131ddcf943106c8c8b 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* pipeline: The pipeline library legacy API (functions rte_pipeline_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new pipeline library API (functions rte_swx_pipeline_*)
-  will gradually transition from experimental to stable status.
-
 * table: The table library legacy API (functions rte_table_*)
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new table library API (functions rte_swx_table_*)
doc/guides/rel_notes/release_26_11.rst +4 -0
index fc84ba367ea730c393caf11883a09024b6c07688..f7d34aa1ee7fd363f456ecf27effdbfb65efbad5 100644
@@ -84,6 +84,10 @@ Removed Items
   the legacy pipeline library API.
   The ``pipeline`` example application covers the SWX pipeline API.
 
+* Removed the legacy pipeline library API: ``rte_pipeline_*``,
+  ``rte_port_in_action_*`` and ``rte_table_action_*`` functions.
+  The SWX pipeline API (``rte_swx_pipeline_*``) remains.
+
 
 API Changes
 -----------
lib/pipeline/meson.build +1 -7
index 823c7929a7f4734b7e23554b2929290c60faf6c0..997ded67925433316aa447f6004b944a2247f2fc 100644
@@ -10,21 +10,15 @@ endif
 cflags += no_wvla_cflag
 
 sources = files(
-        'rte_pipeline.c',
-        'rte_port_in_action.c',
-        'rte_table_action.c',
         'rte_swx_ipsec.c',
         'rte_swx_pipeline.c',
         'rte_swx_pipeline_spec.c',
         'rte_swx_ctl.c',
 )
 headers = files(
-        'rte_pipeline.h',
-        'rte_port_in_action.h',
-        'rte_table_action.h',
         'rte_swx_ipsec.h',
         'rte_swx_pipeline.h',
         'rte_swx_extern.h',
         'rte_swx_ctl.h',
 )
-deps += ['port', 'table', 'meter', 'sched', 'cryptodev', 'ipsec']
+deps += ['port', 'table', 'meter', 'cryptodev', 'ipsec']
lib/pipeline/rte_pipeline.c deleted +0 -1640

1,640 lines not on this page · raw message

lib/pipeline/rte_pipeline.h deleted +0 -840

840 lines not on this page · raw message

lib/pipeline/rte_port_in_action.c deleted +0 -539

259 lines not on this page · raw message

lib/pipeline/rte_port_in_action.h deleted +0 -311

311 lines not on this page · raw message

lib/pipeline/rte_table_action.c deleted +0 -3483

3,483 lines not on this page · raw message

lib/pipeline/rte_table_action.h deleted +0 -1137

1,137 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#30 lore raw

PATCH v4 5/7 table: remove legacy API

In reply to Stephen Hemminger

Remove the legacy table library API (rte_table_*) as announced for removal in the 24.11 release. The SWX table API remains.

The lpm and port dependencies were only used by the legacy API, so drop them. The hash and acl dependencies are still needed by the SWX exact match and wildcard match tables.

---
 doc/api/doxy-api-index.md                  |    7 -
 doc/guides/prog_guide/packet_framework.rst |  811 -------------
 doc/guides/rel_notes/deprecation.rst       |    5 -
 doc/guides/rel_notes/release_26_11.rst     |    3 +
 lib/table/meson.build                      |   30 +-
 lib/table/rte_lru.h                        |   85 --
 lib/table/rte_lru_arm64.h                  |   61 -
 lib/table/rte_lru_x86.h                    |   96 --
 lib/table/rte_table.h                      |  263 -----
 lib/table/rte_table_acl.c                  |  795 -------------
 lib/table/rte_table_acl.h                  |   65 --
 lib/table/rte_table_array.c                |  210 ----
 lib/table/rte_table_array.h                |   46 -
 lib/table/rte_table_hash.h                 |  106 --
 lib/table/rte_table_hash_cuckoo.c          |  327 ------
 lib/table/rte_table_hash_cuckoo.h          |   57 -
 lib/table/rte_table_hash_ext.c             | 1011 ----------------
 lib/table/rte_table_hash_func.h            |  263 -----
 lib/table/rte_table_hash_func_arm64.h      |   21 -
 lib/table/rte_table_hash_key16.c           | 1190 -------------------
 lib/table/rte_table_hash_key32.c           | 1223 --------------------
 lib/table/rte_table_hash_key8.c            | 1157 ------------------
 lib/table/rte_table_hash_lru.c             |  959 ---------------
 lib/table/rte_table_lpm.c                  |  369 ------
 lib/table/rte_table_lpm.h                  |   94 --
 lib/table/rte_table_lpm_ipv6.c             |  370 ------
 lib/table/rte_table_stub.c                 |   95 --
 lib/table/rte_table_stub.h                 |   30 -
 lib/table/table_log.c                      |    7 -
 lib/table/table_log.h                      |   11 -
 30 files changed, 4 insertions(+), 9763 deletions(-)
 delete mode 100644 lib/table/rte_lru.h
 delete mode 100644 lib/table/rte_lru_arm64.h
 delete mode 100644 lib/table/rte_lru_x86.h
 delete mode 100644 lib/table/rte_table.h
 delete mode 100644 lib/table/rte_table_acl.c
 delete mode 100644 lib/table/rte_table_acl.h
 delete mode 100644 lib/table/rte_table_array.c
 delete mode 100644 lib/table/rte_table_array.h
 delete mode 100644 lib/table/rte_table_hash.h
 delete mode 100644 lib/table/rte_table_hash_cuckoo.c
 delete mode 100644 lib/table/rte_table_hash_cuckoo.h
 delete mode 100644 lib/table/rte_table_hash_ext.c
 delete mode 100644 lib/table/rte_table_hash_func.h
 delete mode 100644 lib/table/rte_table_hash_func_arm64.h
 delete mode 100644 lib/table/rte_table_hash_key16.c
 delete mode 100644 lib/table/rte_table_hash_key32.c
 delete mode 100644 lib/table/rte_table_hash_key8.c
 delete mode 100644 lib/table/rte_table_hash_lru.c
 delete mode 100644 lib/table/rte_table_lpm.c
 delete mode 100644 lib/table/rte_table_lpm.h
 delete mode 100644 lib/table/rte_table_lpm_ipv6.c
 delete mode 100644 lib/table/rte_table_stub.c
 delete mode 100644 lib/table/rte_table_stub.h
 delete mode 100644 lib/table/table_log.c
 delete mode 100644 lib/table/table_log.h
doc/api/doxy-api-index.md +0 -7
index 17c15027b8bd3aae13b992b4bfd038ef8b2bb5cd..760b770d6f8ac636e56541b4db609768e6558e11 100644
@@ -189,13 +189,6 @@ The public API headers are grouped by topics:
     [reass](@ref rte_port_ras.h),
     [sched](@ref rte_port_sched.h),
     [src/sink](@ref rte_port_source_sink.h)
-  * [table](@ref rte_table.h):
-    [lpm IPv4](@ref rte_table_lpm.h),
-    [lpm IPv6](@ref rte_table_lpm_ipv6.h),
-    [ACL](@ref rte_table_acl.h),
-    [hash](@ref rte_table_hash.h),
-    [array](@ref rte_table_array.h),
-    [stub](@ref rte_table_stub.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/packet_framework.rst +0 -811

817 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 758652a492e600b267feba131ddcf943106c8c8b..9dcf86098f0d391a44ee1887ba823a1dd04ac295 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* table: The table library legacy API (functions rte_table_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new table library API (functions rte_swx_table_*)
-  will gradually transition from experimental to stable status.
-
 * port: The port library legacy API (functions rte_port_*)
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new port library API (functions rte_swx_port_*)
doc/guides/rel_notes/release_26_11.rst +3 -0
index f7d34aa1ee7fd363f456ecf27effdbfb65efbad5..50b0d3ac06e35b8fd5b86baafd85723d7539cb5d 100644
@@ -88,6 +88,9 @@ Removed Items
   ``rte_port_in_action_*`` and ``rte_table_action_*`` functions.
   The SWX pipeline API (``rte_swx_pipeline_*``) remains.
 
+* Removed the legacy table library API (``rte_table_*`` functions).
+  The SWX table API (``rte_swx_table_*``) remains.
+
 
 API Changes
 -----------
lib/table/meson.build +1 -29
index e27957fe8995a2ffb3aca4d2b514f0be6b8d6968..620c20e594bba4aea99a1f0115a874334ea701cc 100644
@@ -9,42 +9,14 @@ sources = files(
         'rte_swx_table_learner.c',
         'rte_swx_table_selector.c',
         'rte_swx_table_wm.c',
-        'rte_table_acl.c',
-        'rte_table_array.c',
-        'rte_table_hash_cuckoo.c',
-        'rte_table_hash_ext.c',
-        'rte_table_hash_key8.c',
-        'rte_table_hash_key16.c',
-        'rte_table_hash_key32.c',
-        'rte_table_hash_lru.c',
-        'rte_table_lpm.c',
-        'rte_table_lpm_ipv6.c',
-        'rte_table_stub.c',
-        'table_log.c',
 )
 
 headers = files(
-        'rte_lru.h',
         'rte_swx_hash_func.h',
         'rte_swx_table.h',
         'rte_swx_table_em.h',
         'rte_swx_table_learner.h',
         'rte_swx_table_selector.h',
         'rte_swx_table_wm.h',
-        'rte_table.h',
-        'rte_table_acl.h',
-        'rte_table_array.h',
-        'rte_table_hash.h',
-        'rte_table_hash_cuckoo.h',
-        'rte_table_hash_func.h',
-        'rte_table_lpm.h',
-        'rte_table_lpm_ipv6.h',
-        'rte_table_stub.h',
-)
-deps += ['mbuf', 'port', 'lpm', 'hash', 'acl']
-
-indirect_headers += files(
-        'rte_lru_arm64.h',
-        'rte_lru_x86.h',
-        'rte_table_hash_func_arm64.h',
 )
+deps += ['mbuf', 'hash', 'acl']
lib/table/rte_lru.h deleted +0 -85

85 lines not on this page · raw message

lib/table/rte_lru_arm64.h deleted +0 -61

61 lines not on this page · raw message

lib/table/rte_lru_x86.h deleted +0 -96

96 lines not on this page · raw message

lib/table/rte_table.h deleted +0 -263

263 lines not on this page · raw message

lib/table/rte_table_acl.c deleted +0 -795

795 lines not on this page · raw message

lib/table/rte_table_acl.h deleted +0 -65

65 lines not on this page · raw message

lib/table/rte_table_array.c deleted +0 -210

210 lines not on this page · raw message

lib/table/rte_table_array.h deleted +0 -46

46 lines not on this page · raw message

lib/table/rte_table_hash.h deleted +0 -106

106 lines not on this page · raw message

lib/table/rte_table_hash_cuckoo.c deleted +0 -327

327 lines not on this page · raw message

lib/table/rte_table_hash_cuckoo.h deleted +0 -57

53 lines not on this page · raw message

lib/table/rte_table_hash_ext.c deleted +0 -1011

1,011 lines not on this page · raw message

lib/table/rte_table_hash_func.h deleted +0 -263

263 lines not on this page · raw message

lib/table/rte_table_hash_func_arm64.h deleted +0 -21
deleted file mode 100644
index eb04c1ff54f7e930ef8b6e9028a51d5a4ecce6f6..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

lib/table/rte_table_hash_key16.c deleted +0 -1190

1,190 lines not on this page · raw message

lib/table/rte_table_hash_key32.c deleted +0 -1223

1,223 lines not on this page · raw message

lib/table/rte_table_hash_key8.c deleted +0 -1157

1,157 lines not on this page · raw message

lib/table/rte_table_hash_lru.c deleted +0 -959

959 lines not on this page · raw message

lib/table/rte_table_lpm.c deleted +0 -369

369 lines not on this page · raw message

lib/table/rte_table_lpm.h deleted +0 -94

94 lines not on this page · raw message

lib/table/rte_table_lpm_ipv6.c deleted +0 -370

370 lines not on this page · raw message

lib/table/rte_table_stub.c deleted +0 -95

95 lines not on this page · raw message

lib/table/rte_table_stub.h deleted +0 -30
deleted file mode 100644
index f7e589df16f77f0aca839232b32747b4856936f6..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

lib/table/table_log.c deleted +0 -7
deleted file mode 100644
index b329edd2e69f8035d25c05582aeeb97d210a2f9c..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

lib/table/table_log.h deleted +0 -11
deleted file mode 100644
index b24b8614c227be014cd8f3139da712570957ff7d..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#31 lore raw

PATCH v4 6/7 port: remove legacy API

In reply to Stephen Hemminger

Remove the legacy port library API (rte_port_*) as announced for removal in the 24.11 release. The SWX port API remains.

The sched, ip_frag, cryptodev and eventdev dependencies were only used by the legacy port types, so drop them. The pcap dependency is kept for the SWX source/sink port.

---
 doc/api/doxy-api-index.md                  |   7 -
 doc/guides/prog_guide/packet_framework.rst | 132 +---
 doc/guides/rel_notes/deprecation.rst       |   5 -
 doc/guides/rel_notes/release_26_11.rst     |   3 +
 lib/port/meson.build                       |  22 +-
 lib/port/port_log.c                        |   7 -
 lib/port/port_log.h                        |  11 -
 lib/port/rte_port.h                        | 223 ------
 lib/port/rte_port_ethdev.c                 | 530 --------------
 lib/port/rte_port_ethdev.h                 |  75 --
 lib/port/rte_port_eventdev.c               | 590 ---------------
 lib/port/rte_port_eventdev.h               |  94 ---
 lib/port/rte_port_fd.c                     | 524 --------------
 lib/port/rte_port_fd.h                     |  74 --
 lib/port/rte_port_frag.c                   | 280 --------
 lib/port/rte_port_frag.h                   |  70 --
 lib/port/rte_port_ras.c                    | 336 ---------
 lib/port/rte_port_ras.h                    |  58 --
 lib/port/rte_port_ring.c                   | 796 ---------------------
 lib/port/rte_port_ring.h                   |  91 ---
 lib/port/rte_port_sched.c                  | 298 --------
 lib/port/rte_port_sched.h                  |  52 --
 lib/port/rte_port_source_sink.c            | 616 ----------------
 lib/port/rte_port_source_sink.h            |  57 --
 lib/port/rte_port_sym_crypto.c             | 558 ---------------
 lib/port/rte_port_sym_crypto.h             |  92 ---
 26 files changed, 10 insertions(+), 5591 deletions(-)
 delete mode 100644 lib/port/port_log.c
 delete mode 100644 lib/port/port_log.h
 delete mode 100644 lib/port/rte_port.h
 delete mode 100644 lib/port/rte_port_ethdev.c
 delete mode 100644 lib/port/rte_port_ethdev.h
 delete mode 100644 lib/port/rte_port_eventdev.c
 delete mode 100644 lib/port/rte_port_eventdev.h
 delete mode 100644 lib/port/rte_port_fd.c
 delete mode 100644 lib/port/rte_port_fd.h
 delete mode 100644 lib/port/rte_port_frag.c
 delete mode 100644 lib/port/rte_port_frag.h
 delete mode 100644 lib/port/rte_port_ras.c
 delete mode 100644 lib/port/rte_port_ras.h
 delete mode 100644 lib/port/rte_port_ring.c
 delete mode 100644 lib/port/rte_port_ring.h
 delete mode 100644 lib/port/rte_port_sched.c
 delete mode 100644 lib/port/rte_port_sched.h
 delete mode 100644 lib/port/rte_port_source_sink.c
 delete mode 100644 lib/port/rte_port_source_sink.h
 delete mode 100644 lib/port/rte_port_sym_crypto.c
 delete mode 100644 lib/port/rte_port_sym_crypto.h
doc/api/doxy-api-index.md +0 -7
index 760b770d6f8ac636e56541b4db609768e6558e11..16827a602b501491948e583c08bc49c55de44bf1 100644
@@ -182,13 +182,6 @@ The public API headers are grouped by topics:
   [bitmap](@ref rte_bitmap.h)
 
 - **packet framework**:
-  * [port](@ref rte_port.h):
-    [ethdev](@ref rte_port_ethdev.h),
-    [ring](@ref rte_port_ring.h),
-    [frag](@ref rte_port_frag.h),
-    [reass](@ref rte_port_ras.h),
-    [sched](@ref rte_port_sched.h),
-    [src/sink](@ref rte_port_source_sink.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/packet_framework.rst +6 -126

138 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 9dcf86098f0d391a44ee1887ba823a1dd04ac295..75b56b0e104d95a0d6a4c049bbcec561272104ea 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* port: The port library legacy API (functions rte_port_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new port library API (functions rte_swx_port_*)
-  will gradually transition from experimental to stable status.
-
 * bus/vmbus: Starting DPDK 25.11, all the vmbus API defined in
   ``drivers/bus/vmbus/rte_bus_vmbus.h`` will become internal to DPDK.
   Those API functions are used internally by DPDK core and netvsc PMD.
doc/guides/rel_notes/release_26_11.rst +3 -0
index 50b0d3ac06e35b8fd5b86baafd85723d7539cb5d..31b075b3ccf203b45706b6cb39d5a38f4c20a05b 100644
@@ -91,6 +91,9 @@ Removed Items
 * Removed the legacy table library API (``rte_table_*`` functions).
   The SWX table API (``rte_swx_table_*``) remains.
 
+* Removed the legacy port library API (``rte_port_*`` functions).
+  The SWX port API (``rte_swx_port_*``) remains.
+
 
 API Changes
 -----------
lib/port/meson.build +1 -21
index b5977728723a9ef9e21a23ae3a1eca7342b93dc5..ef88b917a3293fbdc51ea22ef862a8e9f432cae8 100644
@@ -8,39 +8,19 @@ if is_windows
 endif
 
 sources = files(
-        'port_log.c',
-        'rte_port_ethdev.c',
-        'rte_port_fd.c',
-        'rte_port_frag.c',
-        'rte_port_ras.c',
-        'rte_port_ring.c',
-        'rte_port_sched.c',
-        'rte_port_source_sink.c',
-        'rte_port_sym_crypto.c',
-        'rte_port_eventdev.c',
         'rte_swx_port_ethdev.c',
         'rte_swx_port_fd.c',
         'rte_swx_port_ring.c',
         'rte_swx_port_source_sink.c',
 )
 headers = files(
-        'rte_port_ethdev.h',
-        'rte_port_fd.h',
-        'rte_port_frag.h',
-        'rte_port_ras.h',
-        'rte_port.h',
-        'rte_port_ring.h',
-        'rte_port_sched.h',
-        'rte_port_source_sink.h',
-        'rte_port_sym_crypto.h',
-        'rte_port_eventdev.h',
         'rte_swx_port.h',
         'rte_swx_port_ethdev.h',
         'rte_swx_port_fd.h',
         'rte_swx_port_ring.h',
         'rte_swx_port_source_sink.h',
 )
-deps += ['ethdev', 'sched', 'ip_frag', 'cryptodev', 'eventdev']
+deps += ['ethdev']
 
 if dpdk_conf.has('RTE_HAS_LIBPCAP')
     dpdk_conf.set('RTE_PORT_PCAP', 1)
lib/port/port_log.c deleted +0 -7
deleted file mode 100644
index e7a10d80ef8ca58aec03e4764517cc5d8b8dfe79..0000000000000000000000000000000000000000
@@ -1,7 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2024 Stephen Hemminger <[email protected]>
- */
-
-#include <rte_log.h>
-
-RTE_LOG_REGISTER_DEFAULT(port_logtype, INFO);
lib/port/port_log.h deleted +0 -11
deleted file mode 100644
index 28d75ee48b3be232751ac60f8eefc3d4d03850bb..0000000000000000000000000000000000000000
@@ -1,11 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2023 Red Hat, Inc.
- */
-
-#include <rte_log.h>
-
-extern int port_logtype;
-#define RTE_LOGTYPE_PORT port_logtype
-
-#define PORT_LOG(level, ...) \
-	RTE_LOG_LINE(level, PORT, "" __VA_ARGS__)
lib/port/rte_port.h deleted +0 -223

223 lines not on this page · raw message

lib/port/rte_port_ethdev.c deleted +0 -530

530 lines not on this page · raw message

lib/port/rte_port_ethdev.h deleted +0 -75

75 lines not on this page · raw message

lib/port/rte_port_eventdev.c deleted +0 -590

590 lines not on this page · raw message

lib/port/rte_port_eventdev.h deleted +0 -94

94 lines not on this page · raw message

lib/port/rte_port_fd.c deleted +0 -524

524 lines not on this page · raw message

lib/port/rte_port_fd.h deleted +0 -74

74 lines not on this page · raw message

lib/port/rte_port_frag.c deleted +0 -280

280 lines not on this page · raw message

lib/port/rte_port_frag.h deleted +0 -70

70 lines not on this page · raw message

lib/port/rte_port_ras.c deleted +0 -336

311 lines not on this page · raw message

lib/port/rte_port_ras.h deleted +0 -58

58 lines not on this page · raw message

lib/port/rte_port_ring.c deleted +0 -796

796 lines not on this page · raw message

lib/port/rte_port_ring.h deleted +0 -91

91 lines not on this page · raw message

lib/port/rte_port_sched.c deleted +0 -298

298 lines not on this page · raw message

lib/port/rte_port_sched.h deleted +0 -52

52 lines not on this page · raw message

lib/port/rte_port_source_sink.c deleted +0 -616

616 lines not on this page · raw message

lib/port/rte_port_source_sink.h deleted +0 -57

57 lines not on this page · raw message

lib/port/rte_port_sym_crypto.c deleted +0 -558

558 lines not on this page · raw message

lib/port/rte_port_sym_crypto.h deleted +0 -92

92 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#32 lore raw

PATCH v4 7/7 doc: remove packet framework images

In reply to Stephen Hemminger

Remove no longer used documentation images.
Split out as standalone patch to workaround patchwork encoding issues.

---
 doc/guides/prog_guide/img/figure32.png          | Bin 11603 -> 0 bytes
 doc/guides/prog_guide/img/figure33.png          | Bin 65216 -> 0 bytes
 doc/guides/prog_guide/img/figure34.png          | Bin 11581 -> 0 bytes
 doc/guides/prog_guide/img/figure35.png          | Bin 75012 -> 0 bytes
 doc/guides/prog_guide/img/figure37.png          | Bin 6934 -> 0 bytes
 doc/guides/prog_guide/img/figure38.png          | Bin 7372 -> 0 bytes
 doc/guides/prog_guide/img/figure39.png          | Bin 55986 -> 0 bytes
 .../sample_app_ug/img/test_pipeline_app.png     | Bin 67410 -> 0 bytes
 8 files changed, 0 insertions(+), 0 deletions(-)
 delete mode 100644 doc/guides/prog_guide/img/figure32.png
 delete mode 100644 doc/guides/prog_guide/img/figure33.png
 delete mode 100644 doc/guides/prog_guide/img/figure34.png
 delete mode 100644 doc/guides/prog_guide/img/figure35.png
 delete mode 100644 doc/guides/prog_guide/img/figure37.png
 delete mode 100644 doc/guides/prog_guide/img/figure38.png
 delete mode 100644 doc/guides/prog_guide/img/figure39.png
 delete mode 100644 doc/guides/sample_app_ug/img/test_pipeline_app.png
doc/guides/prog_guide/img/figure32.png deleted binary +0 -0
deleted file mode 100644
index 5215113fd9d533ff56526e21e1832bc7a6cabd04..0000000000000000000000000000000000000000
Binary files a/doc/guides/prog_guide/img/figure32.png and /dev/null differ
doc/guides/prog_guide/img/figure33.png deleted binary +0 -0
deleted file mode 100644
index f0670eb0053da643e1ee932ee3f30fdd0aa973e6..0000000000000000000000000000000000000000
Binary files a/doc/guides/prog_guide/img/figure33.png and /dev/null differ
doc/guides/prog_guide/img/figure34.png deleted binary +0 -0
deleted file mode 100644
index caa2517a4013acbfc7c405866abfa180dbcacb63..0000000000000000000000000000000000000000
Binary files a/doc/guides/prog_guide/img/figure34.png and /dev/null differ
doc/guides/prog_guide/img/figure35.png deleted binary +0 -0
deleted file mode 100644
index 42053f006745dbe7e02869817995e2b38dc56932..0000000000000000000000000000000000000000
Binary files a/doc/guides/prog_guide/img/figure35.png and /dev/null differ
doc/guides/prog_guide/img/figure37.png deleted binary +0 -0
deleted file mode 100644
index 20be4aaa6de8040339e0db4200a5e800816f14b7..0000000000000000000000000000000000000000
Binary files a/doc/guides/prog_guide/img/figure37.png and /dev/null differ
doc/guides/prog_guide/img/figure38.png deleted binary +0 -0
deleted file mode 100644
index 261c561f98a98d572c9247b7187b33f7e03002ce..0000000000000000000000000000000000000000
Binary files a/doc/guides/prog_guide/img/figure38.png and /dev/null differ
doc/guides/prog_guide/img/figure39.png deleted binary +0 -0
deleted file mode 100644
index d2db6a499a0f764b9e661b905b0f136ea871b457..0000000000000000000000000000000000000000
Binary files a/doc/guides/prog_guide/img/figure39.png and /dev/null differ
doc/guides/sample_app_ug/img/test_pipeline_app.png deleted binary +0 -0
deleted file mode 100644
index d322a9e46e5e714126988a76456c9eae41635879..0000000000000000000000000000000000000000
Binary files a/doc/guides/sample_app_ug/img/test_pipeline_app.png and /dev/null differ
Signature · 1 line
2.53.0
#33 lore raw

v5 cover remove legacy packet framework

In reply to Stephen Hemminger

The legacy Packet Framework APIs were announced for removal in the 24.11 release but the removal never happened:

* pipeline: The pipeline library legacy API (functions rte_pipeline_*)
* table: The table library legacy API (functions rte_table_*)
* port: The port library legacy API (functions rte_port_*)

Do the removal now, in the 26.11 ABI window. The SWX API in the same libraries (rte_swx_*) is unaffected and remains the Packet Framework API. The softnic driver and the pipeline example already use only the SWX API.

The applications built on the legacy API (test-pipeline, ip_pipeline) and the unit tests are removed first, then the legacy half of each library, pipeline before table before port to follow the dependency chain. Library dependencies and the programmer's guide are trimmed accordingly.

Follow-up candidates, kept out of this series: the stale comments in lib/ethdev/ethdev_trace.h still refer to examples/ip_pipeline, and struct rte_pipeline_acl_rule in the removed rte_table_acl.c was only a local name.

Note: there are some figures leftover that will need maintainer to manually remove with 'git rm' since patchwork mangled that.

v5 - resend of v4 without patch that broke patchwork

Stephen Hemminger (6):
app/test: remove packet framework tests
app/test-pipeline: remove application
examples/ip_pipeline: remove example
pipeline: remove legacy API
table: remove legacy API
port: remove legacy API

 MAINTAINERS                                   |    5 -
 app/meson.build                               |    1 -
 app/test-pipeline/config.c                    |  230 -
 app/test-pipeline/init.c                      |  273 -
 app/test-pipeline/main.c                      |  188 -
 app/test-pipeline/main.h                      |  132 -
 app/test-pipeline/meson.build                 |   21 -
 app/test-pipeline/pipeline_acl.c              |  251 -
 app/test-pipeline/pipeline_hash.c             |  471 --
 app/test-pipeline/pipeline_lpm.c              |  175 -
 app/test-pipeline/pipeline_lpm_ipv6.c         |  168 -
 app/test-pipeline/pipeline_stub.c             |  137 -
 app/test-pipeline/runtime.c                   |  160 -
 app/test/meson.build                          |    6 -
 app/test/test_table.c                         |  209 -
 app/test/test_table.h                         |  184 -
 app/test/test_table_acl.c                     |  728 --
 app/test/test_table_acl.h                     |    6 -
 app/test/test_table_combined.c                |  846 --
 app/test/test_table_combined.h                |   27 -
 app/test/test_table_pipeline.c                |  575 --
 app/test/test_table_pipeline.h                |    6 -
 app/test/test_table_ports.c                   |  195 -
 app/test/test_table_ports.h                   |   13 -
 app/test/test_table_tables.c                  | 1058 ---
 app/test/test_table_tables.h                  |   22 -
 doc/api/doxy-api-index.md                     |   17 -
 doc/guides/nics/softnic.rst                   |    3 +-
 doc/guides/prog_guide/packet_framework.rst    | 1146 +--
 doc/guides/rel_notes/deprecation.rst          |   15 -
 doc/guides/rel_notes/release_26_11.rst        |   17 +
 doc/guides/sample_app_ug/index.rst            |    2 -
 doc/guides/sample_app_ug/ip_pipeline.rst      |  531 --
 doc/guides/sample_app_ug/test_pipeline.rst    |  237 -
 examples/ip_pipeline/Makefile                 |   60 -
 examples/ip_pipeline/action.c                 |  391 -
 examples/ip_pipeline/action.h                 |   78 -
 examples/ip_pipeline/cli.c                    | 6791 -----------------
 examples/ip_pipeline/cli.h                    |   18 -
 examples/ip_pipeline/common.h                 |   12 -
 examples/ip_pipeline/conn.c                   |  330 -
 examples/ip_pipeline/conn.h                   |   47 -
 examples/ip_pipeline/cryptodev.c              |  160 -
 examples/ip_pipeline/cryptodev.h              |   46 -
 examples/ip_pipeline/examples/firewall.cli    |   59 -
 examples/ip_pipeline/examples/flow.cli        |   60 -
 examples/ip_pipeline/examples/flow_crypto.cli |   57 -
 examples/ip_pipeline/examples/l2fwd.cli       |   51 -
 examples/ip_pipeline/examples/route.cli       |   60 -
 examples/ip_pipeline/examples/route_ecmp.cli  |   57 -
 examples/ip_pipeline/examples/rss.cli         |  112 -
 examples/ip_pipeline/examples/tap.cli         |   66 -
 examples/ip_pipeline/link.c                   |  270 -
 examples/ip_pipeline/link.h                   |   66 -
 examples/ip_pipeline/main.c                   |  260 -
 examples/ip_pipeline/mempool.c                |   82 -
 examples/ip_pipeline/mempool.h                |   40 -
 examples/ip_pipeline/meson.build              |   30 -
 examples/ip_pipeline/parser.c                 |  506 --
 examples/ip_pipeline/parser.h                 |   56 -
 examples/ip_pipeline/pipeline.c               | 1078 ---
 examples/ip_pipeline/pipeline.h               |  425 --
 examples/ip_pipeline/swq.c                    |   76 -
 examples/ip_pipeline/swq.h                    |   37 -
 examples/ip_pipeline/tap.c                    |  102 -
 examples/ip_pipeline/tap.h                    |   29 -
 examples/ip_pipeline/thread.c                 | 3137 --------
 examples/ip_pipeline/thread.h                 |   24 -
 examples/ip_pipeline/tmgr.c                   |  248 -
 examples/ip_pipeline/tmgr.h                   |   74 -
 examples/meson.build                          |    1 -
 lib/pipeline/meson.build                      |    8 +-
 lib/pipeline/rte_pipeline.c                   | 1640 ----
 lib/pipeline/rte_pipeline.h                   |  840 --
 lib/pipeline/rte_port_in_action.c             |  539 --
 lib/pipeline/rte_port_in_action.h             |  311 -
 lib/pipeline/rte_table_action.c               | 3483 ---------
 lib/pipeline/rte_table_action.h               | 1137 ---
 lib/port/meson.build                          |   22 +-
 lib/port/port_log.c                           |    7 -
 lib/port/port_log.h                           |   11 -
 lib/port/rte_port.h                           |  223 -
 lib/port/rte_port_ethdev.c                    |  530 --
 lib/port/rte_port_ethdev.h                    |   75 -
 lib/port/rte_port_eventdev.c                  |  590 --
 lib/port/rte_port_eventdev.h                  |   94 -
 lib/port/rte_port_fd.c                        |  524 --
 lib/port/rte_port_fd.h                        |   74 -
 lib/port/rte_port_frag.c                      |  280 -
 lib/port/rte_port_frag.h                      |   70 -
 lib/port/rte_port_ras.c                       |  336 -
 lib/port/rte_port_ras.h                       |   58 -
 lib/port/rte_port_ring.c                      |  796 --
 lib/port/rte_port_ring.h                      |   91 -
 lib/port/rte_port_sched.c                     |  298 -
 lib/port/rte_port_sched.h                     |   52 -
 lib/port/rte_port_source_sink.c               |  616 --
 lib/port/rte_port_source_sink.h               |   57 -
 lib/port/rte_port_sym_crypto.c                |  558 --
 lib/port/rte_port_sym_crypto.h                |   92 -
 lib/table/meson.build                         |   30 +-
 lib/table/rte_lru.h                           |   85 -
 lib/table/rte_lru_arm64.h                     |   61 -
 lib/table/rte_lru_x86.h                       |   96 -
 lib/table/rte_table.h                         |  263 -
 lib/table/rte_table_acl.c                     |  795 --
 lib/table/rte_table_acl.h                     |   65 -
 lib/table/rte_table_array.c                   |  210 -
 lib/table/rte_table_array.h                   |   46 -
 lib/table/rte_table_hash.h                    |  106 -
 lib/table/rte_table_hash_cuckoo.c             |  327 -
 lib/table/rte_table_hash_cuckoo.h             |   57 -
 lib/table/rte_table_hash_ext.c                | 1011 ---
 lib/table/rte_table_hash_func.h               |  263 -
 lib/table/rte_table_hash_func_arm64.h         |   21 -
 lib/table/rte_table_hash_key16.c              | 1190 ---
 lib/table/rte_table_hash_key32.c              | 1223 ---
 lib/table/rte_table_hash_key8.c               | 1157 ---
 lib/table/rte_table_hash_lru.c                |  959 ---
 lib/table/rte_table_lpm.c                     |  369 -
 lib/table/rte_table_lpm.h                     |   94 -
 lib/table/rte_table_lpm_ipv6.c                |  370 -
 lib/table/rte_table_stub.c                    |   95 -
 lib/table/rte_table_stub.h                    |   30 -
 lib/table/table_log.c                         |    7 -
 lib/table/table_log.h                         |   11 -
 126 files changed, 27 insertions(+), 45377 deletions(-)
 delete mode 100644 app/test-pipeline/config.c
 delete mode 100644 app/test-pipeline/init.c
 delete mode 100644 app/test-pipeline/main.c
 delete mode 100644 app/test-pipeline/main.h
 delete mode 100644 app/test-pipeline/meson.build
 delete mode 100644 app/test-pipeline/pipeline_acl.c
 delete mode 100644 app/test-pipeline/pipeline_hash.c
 delete mode 100644 app/test-pipeline/pipeline_lpm.c
 delete mode 100644 app/test-pipeline/pipeline_lpm_ipv6.c
 delete mode 100644 app/test-pipeline/pipeline_stub.c
 delete mode 100644 app/test-pipeline/runtime.c
 delete mode 100644 app/test/test_table.c
 delete mode 100644 app/test/test_table.h
 delete mode 100644 app/test/test_table_acl.c
 delete mode 100644 app/test/test_table_acl.h
 delete mode 100644 app/test/test_table_combined.c
 delete mode 100644 app/test/test_table_combined.h
 delete mode 100644 app/test/test_table_pipeline.c
 delete mode 100644 app/test/test_table_pipeline.h
 delete mode 100644 app/test/test_table_ports.c
 delete mode 100644 app/test/test_table_ports.h
 delete mode 100644 app/test/test_table_tables.c
 delete mode 100644 app/test/test_table_tables.h
 delete mode 100644 doc/guides/sample_app_ug/ip_pipeline.rst
 delete mode 100644 doc/guides/sample_app_ug/test_pipeline.rst
 delete mode 100644 examples/ip_pipeline/Makefile
 delete mode 100644 examples/ip_pipeline/action.c
 delete mode 100644 examples/ip_pipeline/action.h
 delete mode 100644 examples/ip_pipeline/cli.c
 delete mode 100644 examples/ip_pipeline/cli.h
 delete mode 100644 examples/ip_pipeline/common.h
 delete mode 100644 examples/ip_pipeline/conn.c
 delete mode 100644 examples/ip_pipeline/conn.h
 delete mode 100644 examples/ip_pipeline/cryptodev.c
 delete mode 100644 examples/ip_pipeline/cryptodev.h
 delete mode 100644 examples/ip_pipeline/examples/firewall.cli
 delete mode 100644 examples/ip_pipeline/examples/flow.cli
 delete mode 100644 examples/ip_pipeline/examples/flow_crypto.cli
 delete mode 100644 examples/ip_pipeline/examples/l2fwd.cli
 delete mode 100644 examples/ip_pipeline/examples/route.cli
 delete mode 100644 examples/ip_pipeline/examples/route_ecmp.cli
 delete mode 100644 examples/ip_pipeline/examples/rss.cli
 delete mode 100644 examples/ip_pipeline/examples/tap.cli
 delete mode 100644 examples/ip_pipeline/link.c
 delete mode 100644 examples/ip_pipeline/link.h
 delete mode 100644 examples/ip_pipeline/main.c
 delete mode 100644 examples/ip_pipeline/mempool.c
 delete mode 100644 examples/ip_pipeline/mempool.h
 delete mode 100644 examples/ip_pipeline/meson.build
 delete mode 100644 examples/ip_pipeline/parser.c
 delete mode 100644 examples/ip_pipeline/parser.h
 delete mode 100644 examples/ip_pipeline/pipeline.c
 delete mode 100644 examples/ip_pipeline/pipeline.h
 delete mode 100644 examples/ip_pipeline/swq.c
 delete mode 100644 examples/ip_pipeline/swq.h
 delete mode 100644 examples/ip_pipeline/tap.c
 delete mode 100644 examples/ip_pipeline/tap.h
 delete mode 100644 examples/ip_pipeline/thread.c
 delete mode 100644 examples/ip_pipeline/thread.h
 delete mode 100644 examples/ip_pipeline/tmgr.c
 delete mode 100644 examples/ip_pipeline/tmgr.h
 delete mode 100644 lib/pipeline/rte_pipeline.c
 delete mode 100644 lib/pipeline/rte_pipeline.h
 delete mode 100644 lib/pipeline/rte_port_in_action.c
 delete mode 100644 lib/pipeline/rte_port_in_action.h
 delete mode 100644 lib/pipeline/rte_table_action.c
 delete mode 100644 lib/pipeline/rte_table_action.h
 delete mode 100644 lib/port/port_log.c
 delete mode 100644 lib/port/port_log.h
 delete mode 100644 lib/port/rte_port.h
 delete mode 100644 lib/port/rte_port_ethdev.c
 delete mode 100644 lib/port/rte_port_ethdev.h
 delete mode 100644 lib/port/rte_port_eventdev.c
 delete mode 100644 lib/port/rte_port_eventdev.h
 delete mode 100644 lib/port/rte_port_fd.c
 delete mode 100644 lib/port/rte_port_fd.h
 delete mode 100644 lib/port/rte_port_frag.c
 delete mode 100644 lib/port/rte_port_frag.h
 delete mode 100644 lib/port/rte_port_ras.c
 delete mode 100644 lib/port/rte_port_ras.h
 delete mode 100644 lib/port/rte_port_ring.c
 delete mode 100644 lib/port/rte_port_ring.h
 delete mode 100644 lib/port/rte_port_sched.c
 delete mode 100644 lib/port/rte_port_sched.h
 delete mode 100644 lib/port/rte_port_source_sink.c
 delete mode 100644 lib/port/rte_port_source_sink.h
 delete mode 100644 lib/port/rte_port_sym_crypto.c
 delete mode 100644 lib/port/rte_port_sym_crypto.h
 delete mode 100644 lib/table/rte_lru.h
 delete mode 100644 lib/table/rte_lru_arm64.h
 delete mode 100644 lib/table/rte_lru_x86.h
 delete mode 100644 lib/table/rte_table.h
 delete mode 100644 lib/table/rte_table_acl.c
 delete mode 100644 lib/table/rte_table_acl.h
 delete mode 100644 lib/table/rte_table_array.c
 delete mode 100644 lib/table/rte_table_array.h
 delete mode 100644 lib/table/rte_table_hash.h
 delete mode 100644 lib/table/rte_table_hash_cuckoo.c
 delete mode 100644 lib/table/rte_table_hash_cuckoo.h
 delete mode 100644 lib/table/rte_table_hash_ext.c
 delete mode 100644 lib/table/rte_table_hash_func.h
 delete mode 100644 lib/table/rte_table_hash_func_arm64.h
 delete mode 100644 lib/table/rte_table_hash_key16.c
 delete mode 100644 lib/table/rte_table_hash_key32.c
 delete mode 100644 lib/table/rte_table_hash_key8.c
 delete mode 100644 lib/table/rte_table_hash_lru.c
 delete mode 100644 lib/table/rte_table_lpm.c
 delete mode 100644 lib/table/rte_table_lpm.h
 delete mode 100644 lib/table/rte_table_lpm_ipv6.c
 delete mode 100644 lib/table/rte_table_stub.c
 delete mode 100644 lib/table/rte_table_stub.h
 delete mode 100644 lib/table/table_log.c
 delete mode 100644 lib/table/table_log.h
Signature · 1 line
2.53.0
#34 lore raw

PATCH v5 1/6 app/test: remove packet framework tests

The legacy packet framework libraries (port, table, pipeline) are being removed, so remove the unit tests exercising them.

---
 MAINTAINERS                    |    1 -
 app/test/meson.build           |    6 -
 app/test/test_table.c          |  209 -------
 app/test/test_table.h          |  184 ------
 app/test/test_table_acl.c      |  728 ----------------------
 app/test/test_table_acl.h      |    6 -
 app/test/test_table_combined.c |  846 -------------------------
 app/test/test_table_combined.h |   27 -
 app/test/test_table_pipeline.c |  575 -----------------
 app/test/test_table_pipeline.h |    6 -
 app/test/test_table_ports.c    |  195 ------
 app/test/test_table_ports.h    |   13 -
 app/test/test_table_tables.c   | 1058 --------------------------------
 app/test/test_table_tables.h   |   22 -
 14 files changed, 3876 deletions(-)
 delete mode 100644 app/test/test_table.c
 delete mode 100644 app/test/test_table.h
 delete mode 100644 app/test/test_table_acl.c
 delete mode 100644 app/test/test_table_acl.h
 delete mode 100644 app/test/test_table_combined.c
 delete mode 100644 app/test/test_table_combined.h
 delete mode 100644 app/test/test_table_pipeline.c
 delete mode 100644 app/test/test_table_pipeline.h
 delete mode 100644 app/test/test_table_ports.c
 delete mode 100644 app/test/test_table_ports.h
 delete mode 100644 app/test/test_table_tables.c
 delete mode 100644 app/test/test_table_tables.h
MAINTAINERS +0 -1
index e99a65d197..77a41b3fcf 100644
@@ -1739,7 +1739,6 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: app/test/test_table*
 F: app/test-pipeline/
 F: doc/guides/sample_app_ug/test_pipeline.rst
 F: examples/ip_pipeline/
app/test/meson.build +0 -6
index 51abeeb732..4fcd755940 100644
@@ -195,12 +195,6 @@ source_file_deps = {
     'test_stack.c': ['stack'],
     'test_stack_perf.c': ['stack'],
     'test_string_fns.c': [],
-    'test_table.c': ['table', 'pipeline', 'port'],
-    'test_table_acl.c': ['net', 'table', 'pipeline', 'port'],
-    'test_table_combined.c': ['table', 'pipeline', 'port'],
-    'test_table_pipeline.c': ['pipeline', 'table', 'port'],
-    'test_table_ports.c': ['table', 'pipeline', 'port'],
-    'test_table_tables.c': ['table', 'pipeline', 'port'],
     'test_tailq.c': [],
     'test_telemetry_data.c': ['telemetry'],
     'test_telemetry_json.c': ['telemetry'],
app/test/test_table.c deleted +0 -209

209 lines not on this page · raw message

app/test/test_table.h deleted +0 -184

184 lines not on this page · raw message

app/test/test_table_acl.c deleted +0 -728

728 lines not on this page · raw message

app/test/test_table_acl.h deleted +0 -6
deleted file mode 100644
index a6ae7d2838..0000000000
@@ -1,6 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_acl(void);
app/test/test_table_combined.c deleted +0 -846

846 lines not on this page · raw message

app/test/test_table_combined.h deleted +0 -27
deleted file mode 100644
index fb94dbb94d..0000000000
@@ -1,27 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2016 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_stub_combined(void);
-int test_table_lpm_combined(void);
-int test_table_lpm_ipv6_combined(void);
-#ifdef RTE_LIB_ACL
-int test_table_acl(void);
-#endif
-int test_table_hash8unoptimized(void);
-int test_table_hash8lru(void);
-int test_table_hash8ext(void);
-int test_table_hash16unoptimized(void);
-int test_table_hash16lru(void);
-int test_table_hash16ext(void);
-int test_table_hash32unoptimized(void);
-int test_table_hash32lru(void);
-int test_table_hash32ext(void);
-int test_table_hash_cuckoo_combined(void);
-
-/* Extern variables */
-typedef int (*combined_table_test)(void);
-
-extern combined_table_test table_tests_combined[];
-extern unsigned n_table_tests_combined;
app/test/test_table_pipeline.c deleted +0 -575

575 lines not on this page · raw message

app/test/test_table_pipeline.h deleted +0 -6
deleted file mode 100644
index d66d09d6f1..0000000000
@@ -1,6 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_pipeline(void);
app/test/test_table_ports.c deleted +0 -195

195 lines not on this page · raw message

app/test/test_table_ports.h deleted +0 -13
deleted file mode 100644
index dfa6119319..0000000000
@@ -1,13 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_port_ring_reader(void);
-int test_port_ring_writer(void);
-
-/* Extern variables */
-typedef int (*port_test)(void);
-
-extern port_test port_tests[];
-extern unsigned n_port_tests;
app/test/test_table_tables.c deleted +0 -1058

192 lines not on this page · raw message

app/test/test_table_tables.h deleted +0 -22
deleted file mode 100644
index 530633a013..0000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#35 lore raw

PATCH v5 2/6 app/test-pipeline: remove application

In reply to Stephen Hemminger

The test-pipeline application is built on the legacy pipeline library API (rte_pipeline_*), which was announced for removal in the 24.11 release. Remove it before removing the library.

---
 MAINTAINERS                                |   2 -
 app/meson.build                            |   1 -
 app/test-pipeline/config.c                 | 230 ----------
 app/test-pipeline/init.c                   | 273 ------------
 app/test-pipeline/main.c                   | 188 --------
 app/test-pipeline/main.h                   | 132 ------
 app/test-pipeline/meson.build              |  21 -
 app/test-pipeline/pipeline_acl.c           | 251 -----------
 app/test-pipeline/pipeline_hash.c          | 471 ---------------------
 app/test-pipeline/pipeline_lpm.c           | 175 --------
 app/test-pipeline/pipeline_lpm_ipv6.c      | 168 --------
 app/test-pipeline/pipeline_stub.c          | 137 ------
 app/test-pipeline/runtime.c                | 160 -------
 doc/guides/rel_notes/release_26_11.rst     |   3 +
 doc/guides/sample_app_ug/index.rst         |   1 -
 doc/guides/sample_app_ug/test_pipeline.rst | 237 -----------
 16 files changed, 3 insertions(+), 2447 deletions(-)
 delete mode 100644 app/test-pipeline/config.c
 delete mode 100644 app/test-pipeline/init.c
 delete mode 100644 app/test-pipeline/main.c
 delete mode 100644 app/test-pipeline/main.h
 delete mode 100644 app/test-pipeline/meson.build
 delete mode 100644 app/test-pipeline/pipeline_acl.c
 delete mode 100644 app/test-pipeline/pipeline_hash.c
 delete mode 100644 app/test-pipeline/pipeline_lpm.c
 delete mode 100644 app/test-pipeline/pipeline_lpm_ipv6.c
 delete mode 100644 app/test-pipeline/pipeline_stub.c
 delete mode 100644 app/test-pipeline/runtime.c
 delete mode 100644 doc/guides/sample_app_ug/test_pipeline.rst
MAINTAINERS +0 -2
index 77a41b3fcf..4c06f85706 100644
@@ -1739,8 +1739,6 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: app/test-pipeline/
-F: doc/guides/sample_app_ug/test_pipeline.rst
 F: examples/ip_pipeline/
 F: examples/pipeline/
 F: doc/guides/sample_app_ug/ip_pipeline.rst
app/meson.build +0 -1
index 1798db3ae4..4515688471 100644
@@ -28,7 +28,6 @@ apps = [
         'test-flow-perf',
         'test-gpudev',
         'test-mldev',
-        'test-pipeline',
         'test-pmd',
         'test-regex',
         'test-sad',
app/test-pipeline/config.c deleted +0 -230

230 lines not on this page · raw message

app/test-pipeline/init.c deleted +0 -273

273 lines not on this page · raw message

app/test-pipeline/main.c deleted +0 -188

188 lines not on this page · raw message

app/test-pipeline/main.h deleted +0 -132

132 lines not on this page · raw message

app/test-pipeline/meson.build deleted +0 -21
deleted file mode 100644
index 3add6b637b..0000000000
@@ -1,21 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2019 Intel Corporation
-
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-sources = files(
-        'config.c',
-        'init.c',
-        'main.c',
-        'pipeline_acl.c',
-        'pipeline_hash.c',
-        'pipeline_lpm.c',
-        'pipeline_lpm_ipv6.c',
-        'pipeline_stub.c',
-        'runtime.c',
-)
-deps += ['pipeline', 'pci']
app/test-pipeline/pipeline_acl.c deleted +0 -251

251 lines not on this page · raw message

app/test-pipeline/pipeline_hash.c deleted +0 -471

471 lines not on this page · raw message

app/test-pipeline/pipeline_lpm.c deleted +0 -175

175 lines not on this page · raw message

app/test-pipeline/pipeline_lpm_ipv6.c deleted +0 -168

168 lines not on this page · raw message

app/test-pipeline/pipeline_stub.c deleted +0 -137

137 lines not on this page · raw message

app/test-pipeline/runtime.c deleted +0 -160

160 lines not on this page · raw message

doc/guides/rel_notes/release_26_11.rst +3 -0
index c8cc86295d..6ad0cf6eec 100644
@@ -77,6 +77,9 @@ Removed Items
     ``rte_rib6_is_equal``
   * table: ``RTE_LPM_IPV6_ADDR_SIZE``
 
+* Removed the ``dpdk-test-pipeline`` application, which was based on
+  the legacy pipeline library API.
+
 
 API Changes
 -----------
doc/guides/sample_app_ug/index.rst +0 -1
index f12623bb66..c8b50b801c 100644
@@ -45,7 +45,6 @@ Sample Applications User Guides
     vhost_crypto
     vdpa
     ip_pipeline
-    test_pipeline
     pipeline
     eventdev_pipeline
     dist_app
doc/guides/sample_app_ug/test_pipeline.rst deleted +0 -237

237 lines not on this page · raw message

Signature · 1 line
2.53.0
#36 lore raw

PATCH v5 3/6 examples/ip_pipeline: remove example

In reply to Stephen Hemminger

The ip_pipeline example is built on the legacy pipeline library API (rte_pipeline_*) and the associated port and table action APIs, which were announced for removal in the 24.11 release. The pipeline example covers the SWX pipeline API.

---
 MAINTAINERS                                   |    2 -
 doc/guides/nics/softnic.rst                   |    3 +-
 doc/guides/rel_notes/release_26_11.rst        |    4 +
 doc/guides/sample_app_ug/index.rst            |    1 -
 doc/guides/sample_app_ug/ip_pipeline.rst      |  531 --
 examples/ip_pipeline/Makefile                 |   60 -
 examples/ip_pipeline/action.c                 |  391 -
 examples/ip_pipeline/action.h                 |   78 -
 examples/ip_pipeline/cli.c                    | 6791 -----------------
 examples/ip_pipeline/cli.h                    |   18 -
 examples/ip_pipeline/common.h                 |   12 -
 examples/ip_pipeline/conn.c                   |  330 -
 examples/ip_pipeline/conn.h                   |   47 -
 examples/ip_pipeline/cryptodev.c              |  160 -
 examples/ip_pipeline/cryptodev.h              |   46 -
 examples/ip_pipeline/examples/firewall.cli    |   59 -
 examples/ip_pipeline/examples/flow.cli        |   60 -
 examples/ip_pipeline/examples/flow_crypto.cli |   57 -
 examples/ip_pipeline/examples/l2fwd.cli       |   51 -
 examples/ip_pipeline/examples/route.cli       |   60 -
 examples/ip_pipeline/examples/route_ecmp.cli  |   57 -
 examples/ip_pipeline/examples/rss.cli         |  112 -
 examples/ip_pipeline/examples/tap.cli         |   66 -
 examples/ip_pipeline/link.c                   |  270 -
 examples/ip_pipeline/link.h                   |   66 -
 examples/ip_pipeline/main.c                   |  260 -
 examples/ip_pipeline/mempool.c                |   82 -
 examples/ip_pipeline/mempool.h                |   40 -
 examples/ip_pipeline/meson.build              |   30 -
 examples/ip_pipeline/parser.c                 |  506 --
 examples/ip_pipeline/parser.h                 |   56 -
 examples/ip_pipeline/pipeline.c               | 1078 ---
 examples/ip_pipeline/pipeline.h               |  425 --
 examples/ip_pipeline/swq.c                    |   76 -
 examples/ip_pipeline/swq.h                    |   37 -
 examples/ip_pipeline/tap.c                    |  102 -
 examples/ip_pipeline/tap.h                    |   29 -
 examples/ip_pipeline/thread.c                 | 3137 --------
 examples/ip_pipeline/thread.h                 |   24 -
 examples/ip_pipeline/tmgr.c                   |  248 -
 examples/ip_pipeline/tmgr.h                   |   74 -
 examples/meson.build                          |    1 -
 42 files changed, 5 insertions(+), 15532 deletions(-)
 delete mode 100644 doc/guides/sample_app_ug/ip_pipeline.rst
 delete mode 100644 examples/ip_pipeline/Makefile
 delete mode 100644 examples/ip_pipeline/action.c
 delete mode 100644 examples/ip_pipeline/action.h
 delete mode 100644 examples/ip_pipeline/cli.c
 delete mode 100644 examples/ip_pipeline/cli.h
 delete mode 100644 examples/ip_pipeline/common.h
 delete mode 100644 examples/ip_pipeline/conn.c
 delete mode 100644 examples/ip_pipeline/conn.h
 delete mode 100644 examples/ip_pipeline/cryptodev.c
 delete mode 100644 examples/ip_pipeline/cryptodev.h
 delete mode 100644 examples/ip_pipeline/examples/firewall.cli
 delete mode 100644 examples/ip_pipeline/examples/flow.cli
 delete mode 100644 examples/ip_pipeline/examples/flow_crypto.cli
 delete mode 100644 examples/ip_pipeline/examples/l2fwd.cli
 delete mode 100644 examples/ip_pipeline/examples/route.cli
 delete mode 100644 examples/ip_pipeline/examples/route_ecmp.cli
 delete mode 100644 examples/ip_pipeline/examples/rss.cli
 delete mode 100644 examples/ip_pipeline/examples/tap.cli
 delete mode 100644 examples/ip_pipeline/link.c
 delete mode 100644 examples/ip_pipeline/link.h
 delete mode 100644 examples/ip_pipeline/main.c
 delete mode 100644 examples/ip_pipeline/mempool.c
 delete mode 100644 examples/ip_pipeline/mempool.h
 delete mode 100644 examples/ip_pipeline/meson.build
 delete mode 100644 examples/ip_pipeline/parser.c
 delete mode 100644 examples/ip_pipeline/parser.h
 delete mode 100644 examples/ip_pipeline/pipeline.c
 delete mode 100644 examples/ip_pipeline/pipeline.h
 delete mode 100644 examples/ip_pipeline/swq.c
 delete mode 100644 examples/ip_pipeline/swq.h
 delete mode 100644 examples/ip_pipeline/tap.c
 delete mode 100644 examples/ip_pipeline/tap.h
 delete mode 100644 examples/ip_pipeline/thread.c
 delete mode 100644 examples/ip_pipeline/thread.h
 delete mode 100644 examples/ip_pipeline/tmgr.c
 delete mode 100644 examples/ip_pipeline/tmgr.h
MAINTAINERS +0 -2
index 4c06f85706..ae84e7f289 100644
@@ -1739,9 +1739,7 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: examples/ip_pipeline/
 F: examples/pipeline/
-F: doc/guides/sample_app_ug/ip_pipeline.rst
 
 
 Algorithms
doc/guides/nics/softnic.rst +1 -2
index 603fdb49c4..87f3e5adc0 100644
@@ -10,8 +10,7 @@ is DIY and reconfigurable through ``firmware`` (DPDK Packet Framework script).
 The Soft NIC leverages the DPDK Packet Framework libraries (librte_port,
 librte_table and librte_pipeline) to make it modular, flexible and extensible
 with new functionality.
-Please refer to :doc:`/prog_guide/packet_framework` and
-:doc:`/sample_app_ug/ip_pipeline` for more details.
+Please refer to :doc:`/prog_guide/packet_framework` for more details.
 
 The Soft NIC is configured through the standard DPDK ethdev API (ethdev, flow,
 QoS, security). The internal framework is not externally visible.
doc/guides/rel_notes/release_26_11.rst +4 -0
index 6ad0cf6eec..fc84ba367e 100644
@@ -80,6 +80,10 @@ Removed Items
 * Removed the ``dpdk-test-pipeline`` application, which was based on
   the legacy pipeline library API.
 
+* Removed the ``ip_pipeline`` example application, which was based on
+  the legacy pipeline library API.
+  The ``pipeline`` example application covers the SWX pipeline API.
+
 
 API Changes
 -----------
doc/guides/sample_app_ug/index.rst +0 -1
index c8b50b801c..28c4c9a5b2 100644
@@ -44,7 +44,6 @@ Sample Applications User Guides
     vhost_blk
     vhost_crypto
     vdpa
-    ip_pipeline
     pipeline
     eventdev_pipeline
     dist_app
doc/guides/sample_app_ug/ip_pipeline.rst deleted +0 -531

531 lines not on this page · raw message

examples/ip_pipeline/Makefile deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/action.c deleted +0 -391

391 lines not on this page · raw message

examples/ip_pipeline/action.h deleted +0 -78

78 lines not on this page · raw message

examples/ip_pipeline/cli.c deleted +0 -6791

1,905 lines not on this page · raw message

examples/ip_pipeline/cli.h deleted +0 -18
deleted file mode 100644
index 992e4c3a4a..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/common.h deleted +0 -12
deleted file mode 100644
index 0886dfbe95..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/conn.c deleted +0 -330

330 lines not on this page · raw message

examples/ip_pipeline/conn.h deleted +0 -47

47 lines not on this page · raw message

examples/ip_pipeline/cryptodev.c deleted +0 -160

160 lines not on this page · raw message

examples/ip_pipeline/cryptodev.h deleted +0 -46

46 lines not on this page · raw message

examples/ip_pipeline/examples/firewall.cli deleted +0 -59

59 lines not on this page · raw message

examples/ip_pipeline/examples/flow.cli deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/examples/flow_crypto.cli deleted +0 -57

57 lines not on this page · raw message

examples/ip_pipeline/examples/l2fwd.cli deleted +0 -51

51 lines not on this page · raw message

examples/ip_pipeline/examples/route.cli deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/examples/route_ecmp.cli deleted +0 -57

57 lines not on this page · raw message

examples/ip_pipeline/examples/rss.cli deleted +0 -112

112 lines not on this page · raw message

examples/ip_pipeline/examples/tap.cli deleted +0 -66

66 lines not on this page · raw message

examples/ip_pipeline/link.c deleted +0 -270

270 lines not on this page · raw message

examples/ip_pipeline/link.h deleted +0 -66

66 lines not on this page · raw message

examples/ip_pipeline/main.c deleted +0 -260

260 lines not on this page · raw message

examples/ip_pipeline/mempool.c deleted +0 -82

82 lines not on this page · raw message

examples/ip_pipeline/mempool.h deleted +0 -40
deleted file mode 100644
index bd46a11ca0..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/meson.build deleted +0 -30
deleted file mode 100644
index 68049157e4..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/parser.c deleted +0 -506

506 lines not on this page · raw message

examples/ip_pipeline/parser.h deleted +0 -56

56 lines not on this page · raw message

examples/ip_pipeline/pipeline.c deleted +0 -1078

1,078 lines not on this page · raw message

examples/ip_pipeline/pipeline.h deleted +0 -425

425 lines not on this page · raw message

examples/ip_pipeline/swq.c deleted +0 -76

76 lines not on this page · raw message

examples/ip_pipeline/swq.h deleted +0 -37
deleted file mode 100644
index c8440ee3cd..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/tap.c deleted +0 -102

102 lines not on this page · raw message

examples/ip_pipeline/tap.h deleted +0 -29
deleted file mode 100644
index 0dce72fe3c..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/thread.c deleted +0 -3137

3,137 lines not on this page · raw message

examples/ip_pipeline/thread.h deleted +0 -24
deleted file mode 100644
index facdf004eb..0000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/tmgr.c deleted +0 -248

248 lines not on this page · raw message

examples/ip_pipeline/tmgr.h deleted +0 -74

74 lines not on this page · raw message

examples/meson.build +0 -1
index 25d9c88457..544ec5eadd 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#37 lore raw

PATCH v5 4/6 pipeline: remove legacy API

In reply to Stephen Hemminger

Remove the legacy pipeline API (rte_pipeline_*) together with the port and table action APIs built on top of it, as announced for removal in the 24.11 release. The SWX pipeline API remains.

The sched dependency was only used by the table action API, so drop it.

---
 doc/api/doxy-api-index.md                  |    3 -
 doc/guides/prog_guide/packet_framework.rst |  203 --
 doc/guides/rel_notes/deprecation.rst       |    5 -
 doc/guides/rel_notes/release_26_11.rst     |    4 +
 lib/pipeline/meson.build                   |    8 +-
 lib/pipeline/rte_pipeline.c                | 1640 ---------
 lib/pipeline/rte_pipeline.h                |  840 -----
 lib/pipeline/rte_port_in_action.c          |  539 ---
 lib/pipeline/rte_port_in_action.h          |  311 --
 lib/pipeline/rte_table_action.c            | 3483 --------------------
 lib/pipeline/rte_table_action.h            | 1137 -------
 11 files changed, 5 insertions(+), 8168 deletions(-)
 delete mode 100644 lib/pipeline/rte_pipeline.c
 delete mode 100644 lib/pipeline/rte_pipeline.h
 delete mode 100644 lib/pipeline/rte_port_in_action.c
 delete mode 100644 lib/pipeline/rte_port_in_action.h
 delete mode 100644 lib/pipeline/rte_table_action.c
 delete mode 100644 lib/pipeline/rte_table_action.h
doc/api/doxy-api-index.md +0 -3
index 9296042119..17c15027b8 100644
@@ -196,9 +196,6 @@ The public API headers are grouped by topics:
     [hash](@ref rte_table_hash.h),
     [array](@ref rte_table_array.h),
     [stub](@ref rte_table_stub.h)
-  * [pipeline](@ref rte_pipeline.h)
-    [port_in_action](@ref rte_port_in_action.h)
-    [table_action](@ref rte_table_action.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/packet_framework.rst +0 -203

209 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 6ad7698c6b..758652a492 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* pipeline: The pipeline library legacy API (functions rte_pipeline_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new pipeline library API (functions rte_swx_pipeline_*)
-  will gradually transition from experimental to stable status.
-
 * table: The table library legacy API (functions rte_table_*)
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new table library API (functions rte_swx_table_*)
doc/guides/rel_notes/release_26_11.rst +4 -0
index fc84ba367e..f7d34aa1ee 100644
@@ -84,6 +84,10 @@ Removed Items
   the legacy pipeline library API.
   The ``pipeline`` example application covers the SWX pipeline API.
 
+* Removed the legacy pipeline library API: ``rte_pipeline_*``,
+  ``rte_port_in_action_*`` and ``rte_table_action_*`` functions.
+  The SWX pipeline API (``rte_swx_pipeline_*``) remains.
+
 
 API Changes
 -----------
lib/pipeline/meson.build +1 -7
index 823c7929a7..997ded6792 100644
@@ -10,21 +10,15 @@ endif
 cflags += no_wvla_cflag
 
 sources = files(
-        'rte_pipeline.c',
-        'rte_port_in_action.c',
-        'rte_table_action.c',
         'rte_swx_ipsec.c',
         'rte_swx_pipeline.c',
         'rte_swx_pipeline_spec.c',
         'rte_swx_ctl.c',
 )
 headers = files(
-        'rte_pipeline.h',
-        'rte_port_in_action.h',
-        'rte_table_action.h',
         'rte_swx_ipsec.h',
         'rte_swx_pipeline.h',
         'rte_swx_extern.h',
         'rte_swx_ctl.h',
 )
-deps += ['port', 'table', 'meter', 'sched', 'cryptodev', 'ipsec']
+deps += ['port', 'table', 'meter', 'cryptodev', 'ipsec']
lib/pipeline/rte_pipeline.c deleted +0 -1640

1,640 lines not on this page · raw message

lib/pipeline/rte_pipeline.h deleted +0 -840

840 lines not on this page · raw message

lib/pipeline/rte_port_in_action.c deleted +0 -539

259 lines not on this page · raw message

lib/pipeline/rte_port_in_action.h deleted +0 -311

311 lines not on this page · raw message

lib/pipeline/rte_table_action.c deleted +0 -3483

3,483 lines not on this page · raw message

lib/pipeline/rte_table_action.h deleted +0 -1137

1,137 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#38 lore raw

PATCH v5 5/6 table: remove legacy API

In reply to Stephen Hemminger

Remove the legacy table library API (rte_table_*) as announced for removal in the 24.11 release. The SWX table API remains.

The lpm and port dependencies were only used by the legacy API, so drop them. The hash and acl dependencies are still needed by the SWX exact match and wildcard match tables.

---
 doc/api/doxy-api-index.md                  |    7 -
 doc/guides/prog_guide/packet_framework.rst |  811 -------------
 doc/guides/rel_notes/deprecation.rst       |    5 -
 doc/guides/rel_notes/release_26_11.rst     |    3 +
 lib/table/meson.build                      |   30 +-
 lib/table/rte_lru.h                        |   85 --
 lib/table/rte_lru_arm64.h                  |   61 -
 lib/table/rte_lru_x86.h                    |   96 --
 lib/table/rte_table.h                      |  263 -----
 lib/table/rte_table_acl.c                  |  795 -------------
 lib/table/rte_table_acl.h                  |   65 --
 lib/table/rte_table_array.c                |  210 ----
 lib/table/rte_table_array.h                |   46 -
 lib/table/rte_table_hash.h                 |  106 --
 lib/table/rte_table_hash_cuckoo.c          |  327 ------
 lib/table/rte_table_hash_cuckoo.h          |   57 -
 lib/table/rte_table_hash_ext.c             | 1011 ----------------
 lib/table/rte_table_hash_func.h            |  263 -----
 lib/table/rte_table_hash_func_arm64.h      |   21 -
 lib/table/rte_table_hash_key16.c           | 1190 -------------------
 lib/table/rte_table_hash_key32.c           | 1223 --------------------
 lib/table/rte_table_hash_key8.c            | 1157 ------------------
 lib/table/rte_table_hash_lru.c             |  959 ---------------
 lib/table/rte_table_lpm.c                  |  369 ------
 lib/table/rte_table_lpm.h                  |   94 --
 lib/table/rte_table_lpm_ipv6.c             |  370 ------
 lib/table/rte_table_stub.c                 |   95 --
 lib/table/rte_table_stub.h                 |   30 -
 lib/table/table_log.c                      |    7 -
 lib/table/table_log.h                      |   11 -
 30 files changed, 4 insertions(+), 9763 deletions(-)
 delete mode 100644 lib/table/rte_lru.h
 delete mode 100644 lib/table/rte_lru_arm64.h
 delete mode 100644 lib/table/rte_lru_x86.h
 delete mode 100644 lib/table/rte_table.h
 delete mode 100644 lib/table/rte_table_acl.c
 delete mode 100644 lib/table/rte_table_acl.h
 delete mode 100644 lib/table/rte_table_array.c
 delete mode 100644 lib/table/rte_table_array.h
 delete mode 100644 lib/table/rte_table_hash.h
 delete mode 100644 lib/table/rte_table_hash_cuckoo.c
 delete mode 100644 lib/table/rte_table_hash_cuckoo.h
 delete mode 100644 lib/table/rte_table_hash_ext.c
 delete mode 100644 lib/table/rte_table_hash_func.h
 delete mode 100644 lib/table/rte_table_hash_func_arm64.h
 delete mode 100644 lib/table/rte_table_hash_key16.c
 delete mode 100644 lib/table/rte_table_hash_key32.c
 delete mode 100644 lib/table/rte_table_hash_key8.c
 delete mode 100644 lib/table/rte_table_hash_lru.c
 delete mode 100644 lib/table/rte_table_lpm.c
 delete mode 100644 lib/table/rte_table_lpm.h
 delete mode 100644 lib/table/rte_table_lpm_ipv6.c
 delete mode 100644 lib/table/rte_table_stub.c
 delete mode 100644 lib/table/rte_table_stub.h
 delete mode 100644 lib/table/table_log.c
 delete mode 100644 lib/table/table_log.h
doc/api/doxy-api-index.md +0 -7
index 17c15027b8..760b770d6f 100644
@@ -189,13 +189,6 @@ The public API headers are grouped by topics:
     [reass](@ref rte_port_ras.h),
     [sched](@ref rte_port_sched.h),
     [src/sink](@ref rte_port_source_sink.h)
-  * [table](@ref rte_table.h):
-    [lpm IPv4](@ref rte_table_lpm.h),
-    [lpm IPv6](@ref rte_table_lpm_ipv6.h),
-    [ACL](@ref rte_table_acl.h),
-    [hash](@ref rte_table_hash.h),
-    [array](@ref rte_table_array.h),
-    [stub](@ref rte_table_stub.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/packet_framework.rst +0 -811

817 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 758652a492..9dcf86098f 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* table: The table library legacy API (functions rte_table_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new table library API (functions rte_swx_table_*)
-  will gradually transition from experimental to stable status.
-
 * port: The port library legacy API (functions rte_port_*)
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new port library API (functions rte_swx_port_*)
doc/guides/rel_notes/release_26_11.rst +3 -0
index f7d34aa1ee..50b0d3ac06 100644
@@ -88,6 +88,9 @@ Removed Items
   ``rte_port_in_action_*`` and ``rte_table_action_*`` functions.
   The SWX pipeline API (``rte_swx_pipeline_*``) remains.
 
+* Removed the legacy table library API (``rte_table_*`` functions).
+  The SWX table API (``rte_swx_table_*``) remains.
+
 
 API Changes
 -----------
lib/table/meson.build +1 -29
index e27957fe89..620c20e594 100644
@@ -9,42 +9,14 @@ sources = files(
         'rte_swx_table_learner.c',
         'rte_swx_table_selector.c',
         'rte_swx_table_wm.c',
-        'rte_table_acl.c',
-        'rte_table_array.c',
-        'rte_table_hash_cuckoo.c',
-        'rte_table_hash_ext.c',
-        'rte_table_hash_key8.c',
-        'rte_table_hash_key16.c',
-        'rte_table_hash_key32.c',
-        'rte_table_hash_lru.c',
-        'rte_table_lpm.c',
-        'rte_table_lpm_ipv6.c',
-        'rte_table_stub.c',
-        'table_log.c',
 )
 
 headers = files(
-        'rte_lru.h',
         'rte_swx_hash_func.h',
         'rte_swx_table.h',
         'rte_swx_table_em.h',
         'rte_swx_table_learner.h',
         'rte_swx_table_selector.h',
         'rte_swx_table_wm.h',
-        'rte_table.h',
-        'rte_table_acl.h',
-        'rte_table_array.h',
-        'rte_table_hash.h',
-        'rte_table_hash_cuckoo.h',
-        'rte_table_hash_func.h',
-        'rte_table_lpm.h',
-        'rte_table_lpm_ipv6.h',
-        'rte_table_stub.h',
-)
-deps += ['mbuf', 'port', 'lpm', 'hash', 'acl']
-
-indirect_headers += files(
-        'rte_lru_arm64.h',
-        'rte_lru_x86.h',
-        'rte_table_hash_func_arm64.h',
 )
+deps += ['mbuf', 'hash', 'acl']
lib/table/rte_lru.h deleted +0 -85

85 lines not on this page · raw message

lib/table/rte_lru_arm64.h deleted +0 -61

61 lines not on this page · raw message

lib/table/rte_lru_x86.h deleted +0 -96

96 lines not on this page · raw message

lib/table/rte_table.h deleted +0 -263

263 lines not on this page · raw message

lib/table/rte_table_acl.c deleted +0 -795

795 lines not on this page · raw message

lib/table/rte_table_acl.h deleted +0 -65

65 lines not on this page · raw message

lib/table/rte_table_array.c deleted +0 -210

210 lines not on this page · raw message

lib/table/rte_table_array.h deleted +0 -46

46 lines not on this page · raw message

lib/table/rte_table_hash.h deleted +0 -106

106 lines not on this page · raw message

lib/table/rte_table_hash_cuckoo.c deleted +0 -327

327 lines not on this page · raw message

lib/table/rte_table_hash_cuckoo.h deleted +0 -57

53 lines not on this page · raw message

lib/table/rte_table_hash_ext.c deleted +0 -1011

1,011 lines not on this page · raw message

lib/table/rte_table_hash_func.h deleted +0 -263

263 lines not on this page · raw message

lib/table/rte_table_hash_func_arm64.h deleted +0 -21
deleted file mode 100644
index eb04c1ff54..0000000000

Lines of this file are not shown. View the raw message.

lib/table/rte_table_hash_key16.c deleted +0 -1190

1,190 lines not on this page · raw message

lib/table/rte_table_hash_key32.c deleted +0 -1223

1,223 lines not on this page · raw message

lib/table/rte_table_hash_key8.c deleted +0 -1157

1,157 lines not on this page · raw message

lib/table/rte_table_hash_lru.c deleted +0 -959

959 lines not on this page · raw message

lib/table/rte_table_lpm.c deleted +0 -369

369 lines not on this page · raw message

lib/table/rte_table_lpm.h deleted +0 -94

94 lines not on this page · raw message

lib/table/rte_table_lpm_ipv6.c deleted +0 -370

370 lines not on this page · raw message

lib/table/rte_table_stub.c deleted +0 -95

95 lines not on this page · raw message

lib/table/rte_table_stub.h deleted +0 -30
deleted file mode 100644
index f7e589df16..0000000000

Lines of this file are not shown. View the raw message.

lib/table/table_log.c deleted +0 -7
deleted file mode 100644
index b329edd2e6..0000000000

Lines of this file are not shown. View the raw message.

lib/table/table_log.h deleted +0 -11
deleted file mode 100644
index b24b8614c2..0000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#39 lore raw

PATCH v5 6/6 port: remove legacy API

In reply to Stephen Hemminger

Remove the legacy port library API (rte_port_*) as announced for removal in the 24.11 release. The SWX port API remains.

The sched, ip_frag, cryptodev and eventdev dependencies were only used by the legacy port types, so drop them. The pcap dependency is kept for the SWX source/sink port.

---
 doc/api/doxy-api-index.md                  |   7 -
 doc/guides/prog_guide/packet_framework.rst | 132 +---
 doc/guides/rel_notes/deprecation.rst       |   5 -
 doc/guides/rel_notes/release_26_11.rst     |   3 +
 lib/port/meson.build                       |  22 +-
 lib/port/port_log.c                        |   7 -
 lib/port/port_log.h                        |  11 -
 lib/port/rte_port.h                        | 223 ------
 lib/port/rte_port_ethdev.c                 | 530 --------------
 lib/port/rte_port_ethdev.h                 |  75 --
 lib/port/rte_port_eventdev.c               | 590 ---------------
 lib/port/rte_port_eventdev.h               |  94 ---
 lib/port/rte_port_fd.c                     | 524 --------------
 lib/port/rte_port_fd.h                     |  74 --
 lib/port/rte_port_frag.c                   | 280 --------
 lib/port/rte_port_frag.h                   |  70 --
 lib/port/rte_port_ras.c                    | 336 ---------
 lib/port/rte_port_ras.h                    |  58 --
 lib/port/rte_port_ring.c                   | 796 ---------------------
 lib/port/rte_port_ring.h                   |  91 ---
 lib/port/rte_port_sched.c                  | 298 --------
 lib/port/rte_port_sched.h                  |  52 --
 lib/port/rte_port_source_sink.c            | 616 ----------------
 lib/port/rte_port_source_sink.h            |  57 --
 lib/port/rte_port_sym_crypto.c             | 558 ---------------
 lib/port/rte_port_sym_crypto.h             |  92 ---
 26 files changed, 10 insertions(+), 5591 deletions(-)
 delete mode 100644 lib/port/port_log.c
 delete mode 100644 lib/port/port_log.h
 delete mode 100644 lib/port/rte_port.h
 delete mode 100644 lib/port/rte_port_ethdev.c
 delete mode 100644 lib/port/rte_port_ethdev.h
 delete mode 100644 lib/port/rte_port_eventdev.c
 delete mode 100644 lib/port/rte_port_eventdev.h
 delete mode 100644 lib/port/rte_port_fd.c
 delete mode 100644 lib/port/rte_port_fd.h
 delete mode 100644 lib/port/rte_port_frag.c
 delete mode 100644 lib/port/rte_port_frag.h
 delete mode 100644 lib/port/rte_port_ras.c
 delete mode 100644 lib/port/rte_port_ras.h
 delete mode 100644 lib/port/rte_port_ring.c
 delete mode 100644 lib/port/rte_port_ring.h
 delete mode 100644 lib/port/rte_port_sched.c
 delete mode 100644 lib/port/rte_port_sched.h
 delete mode 100644 lib/port/rte_port_source_sink.c
 delete mode 100644 lib/port/rte_port_source_sink.h
 delete mode 100644 lib/port/rte_port_sym_crypto.c
 delete mode 100644 lib/port/rte_port_sym_crypto.h
doc/api/doxy-api-index.md +0 -7
index 760b770d6f..16827a602b 100644
@@ -182,13 +182,6 @@ The public API headers are grouped by topics:
   [bitmap](@ref rte_bitmap.h)
 
 - **packet framework**:
-  * [port](@ref rte_port.h):
-    [ethdev](@ref rte_port_ethdev.h),
-    [ring](@ref rte_port_ring.h),
-    [frag](@ref rte_port_frag.h),
-    [reass](@ref rte_port_ras.h),
-    [sched](@ref rte_port_sched.h),
-    [src/sink](@ref rte_port_source_sink.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/packet_framework.rst +6 -126

138 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 9dcf86098f..75b56b0e10 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* port: The port library legacy API (functions rte_port_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new port library API (functions rte_swx_port_*)
-  will gradually transition from experimental to stable status.
-
 * bus/vmbus: Starting DPDK 25.11, all the vmbus API defined in
   ``drivers/bus/vmbus/rte_bus_vmbus.h`` will become internal to DPDK.
   Those API functions are used internally by DPDK core and netvsc PMD.
doc/guides/rel_notes/release_26_11.rst +3 -0
index 50b0d3ac06..31b075b3cc 100644
@@ -91,6 +91,9 @@ Removed Items
 * Removed the legacy table library API (``rte_table_*`` functions).
   The SWX table API (``rte_swx_table_*``) remains.
 
+* Removed the legacy port library API (``rte_port_*`` functions).
+  The SWX port API (``rte_swx_port_*``) remains.
+
 
 API Changes
 -----------
lib/port/meson.build +1 -21
index b597772872..ef88b917a3 100644
@@ -8,39 +8,19 @@ if is_windows
 endif
 
 sources = files(
-        'port_log.c',
-        'rte_port_ethdev.c',
-        'rte_port_fd.c',
-        'rte_port_frag.c',
-        'rte_port_ras.c',
-        'rte_port_ring.c',
-        'rte_port_sched.c',
-        'rte_port_source_sink.c',
-        'rte_port_sym_crypto.c',
-        'rte_port_eventdev.c',
         'rte_swx_port_ethdev.c',
         'rte_swx_port_fd.c',
         'rte_swx_port_ring.c',
         'rte_swx_port_source_sink.c',
 )
 headers = files(
-        'rte_port_ethdev.h',
-        'rte_port_fd.h',
-        'rte_port_frag.h',
-        'rte_port_ras.h',
-        'rte_port.h',
-        'rte_port_ring.h',
-        'rte_port_sched.h',
-        'rte_port_source_sink.h',
-        'rte_port_sym_crypto.h',
-        'rte_port_eventdev.h',
         'rte_swx_port.h',
         'rte_swx_port_ethdev.h',
         'rte_swx_port_fd.h',
         'rte_swx_port_ring.h',
         'rte_swx_port_source_sink.h',
 )
-deps += ['ethdev', 'sched', 'ip_frag', 'cryptodev', 'eventdev']
+deps += ['ethdev']
 
 if dpdk_conf.has('RTE_HAS_LIBPCAP')
     dpdk_conf.set('RTE_PORT_PCAP', 1)
lib/port/port_log.c deleted +0 -7
deleted file mode 100644
index e7a10d80ef..0000000000
@@ -1,7 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2024 Stephen Hemminger <[email protected]>
- */
-
-#include <rte_log.h>
-
-RTE_LOG_REGISTER_DEFAULT(port_logtype, INFO);
lib/port/port_log.h deleted +0 -11
deleted file mode 100644
index 28d75ee48b..0000000000
@@ -1,11 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2023 Red Hat, Inc.
- */
-
-#include <rte_log.h>
-
-extern int port_logtype;
-#define RTE_LOGTYPE_PORT port_logtype
-
-#define PORT_LOG(level, ...) \
-	RTE_LOG_LINE(level, PORT, "" __VA_ARGS__)
lib/port/rte_port.h deleted +0 -223

223 lines not on this page · raw message

lib/port/rte_port_ethdev.c deleted +0 -530

530 lines not on this page · raw message

lib/port/rte_port_ethdev.h deleted +0 -75

75 lines not on this page · raw message

lib/port/rte_port_eventdev.c deleted +0 -590

590 lines not on this page · raw message

lib/port/rte_port_eventdev.h deleted +0 -94

94 lines not on this page · raw message

lib/port/rte_port_fd.c deleted +0 -524

524 lines not on this page · raw message

lib/port/rte_port_fd.h deleted +0 -74

74 lines not on this page · raw message

lib/port/rte_port_frag.c deleted +0 -280

280 lines not on this page · raw message

lib/port/rte_port_frag.h deleted +0 -70

70 lines not on this page · raw message

lib/port/rte_port_ras.c deleted +0 -336

311 lines not on this page · raw message

lib/port/rte_port_ras.h deleted +0 -58

58 lines not on this page · raw message

lib/port/rte_port_ring.c deleted +0 -796

796 lines not on this page · raw message

lib/port/rte_port_ring.h deleted +0 -91

91 lines not on this page · raw message

lib/port/rte_port_sched.c deleted +0 -298

298 lines not on this page · raw message

lib/port/rte_port_sched.h deleted +0 -52

52 lines not on this page · raw message

lib/port/rte_port_source_sink.c deleted +0 -616

616 lines not on this page · raw message

lib/port/rte_port_source_sink.h deleted +0 -57

57 lines not on this page · raw message

lib/port/rte_port_sym_crypto.c deleted +0 -558

558 lines not on this page · raw message

lib/port/rte_port_sym_crypto.h deleted +0 -92

92 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#40 lore raw

v6 cover remove deprecated packet framework

In reply to Stephen Hemminger

The legacy Packet Framework APIs were announced for removal in the 24.11 release but the removal never happened:

* pipeline: The pipeline library legacy API (functions rte_pipeline_*)
* table: The table library legacy API (functions rte_table_*)
* port: The port library legacy API (functions rte_port_*)

Do the removal now, in the 26.11 ABI window. The SWX API in the same libraries (rte_swx_*) is unaffected and remains the Packet Framework API. The softnic driver and the pipeline example already use only the SWX API.

The applications built on the legacy API (test-pipeline, ip_pipeline) and the unit tests are removed first, then the legacy half of each library, pipeline before table before port to follow the dependency chain. Library dependencies and the programmer's guide are trimmed accordingly.

Follow-up candidates, kept out of this series: the stale comments in lib/ethdev/ethdev_trace.h still refer to examples/ip_pipeline, and struct rte_pipeline_acl_rule in the removed rte_table_acl.c was only a local name.

Note: there are some figures leftover that will need maintainer to manually remove with 'git rm' since patchwork mangled that.

v6 - rebase and cleanup some leftovers

Stephen Hemminger (6):
app/test: remove packet framework tests
app/test-pipeline: remove application
examples/ip_pipeline: remove example
pipeline: remove legacy API
table: remove legacy API
port: remove legacy API

 MAINTAINERS                                   |    5 -
 app/meson.build                               |    1 -
 app/test-pipeline/config.c                    |  230 -
 app/test-pipeline/init.c                      |  273 -
 app/test-pipeline/main.c                      |  188 -
 app/test-pipeline/main.h                      |  132 -
 app/test-pipeline/meson.build                 |   21 -
 app/test-pipeline/pipeline_acl.c              |  251 -
 app/test-pipeline/pipeline_hash.c             |  471 --
 app/test-pipeline/pipeline_lpm.c              |  175 -
 app/test-pipeline/pipeline_lpm_ipv6.c         |  168 -
 app/test-pipeline/pipeline_stub.c             |  137 -
 app/test-pipeline/runtime.c                   |  160 -
 app/test/meson.build                          |    6 -
 app/test/test_table.c                         |  209 -
 app/test/test_table.h                         |  184 -
 app/test/test_table_acl.c                     |  728 --
 app/test/test_table_acl.h                     |    6 -
 app/test/test_table_combined.c                |  846 --
 app/test/test_table_combined.h                |   27 -
 app/test/test_table_pipeline.c                |  575 --
 app/test/test_table_pipeline.h                |    6 -
 app/test/test_table_ports.c                   |  195 -
 app/test/test_table_ports.h                   |   13 -
 app/test/test_table_tables.c                  | 1058 ---
 app/test/test_table_tables.h                  |   22 -
 devtools/cocci/nullfree.cocci                 |   12 -
 doc/api/doxy-api-index.md                     |   17 -
 doc/guides/nics/softnic.rst                   |    3 +-
 doc/guides/prog_guide/packet_framework.rst    | 1146 +--
 doc/guides/rel_notes/deprecation.rst          |   15 -
 doc/guides/rel_notes/release_26_11.rst        |   17 +
 doc/guides/sample_app_ug/index.rst            |    2 -
 doc/guides/sample_app_ug/ip_pipeline.rst      |  531 --
 doc/guides/sample_app_ug/test_pipeline.rst    |  237 -
 examples/ip_pipeline/Makefile                 |   60 -
 examples/ip_pipeline/action.c                 |  391 -
 examples/ip_pipeline/action.h                 |   78 -
 examples/ip_pipeline/cli.c                    | 6791 -----------------
 examples/ip_pipeline/cli.h                    |   18 -
 examples/ip_pipeline/common.h                 |   12 -
 examples/ip_pipeline/conn.c                   |  330 -
 examples/ip_pipeline/conn.h                   |   47 -
 examples/ip_pipeline/cryptodev.c              |  160 -
 examples/ip_pipeline/cryptodev.h              |   46 -
 examples/ip_pipeline/examples/firewall.cli    |   59 -
 examples/ip_pipeline/examples/flow.cli        |   60 -
 examples/ip_pipeline/examples/flow_crypto.cli |   57 -
 examples/ip_pipeline/examples/l2fwd.cli       |   51 -
 examples/ip_pipeline/examples/route.cli       |   60 -
 examples/ip_pipeline/examples/route_ecmp.cli  |   57 -
 examples/ip_pipeline/examples/rss.cli         |  112 -
 examples/ip_pipeline/examples/tap.cli         |   66 -
 examples/ip_pipeline/link.c                   |  270 -
 examples/ip_pipeline/link.h                   |   66 -
 examples/ip_pipeline/main.c                   |  260 -
 examples/ip_pipeline/mempool.c                |   82 -
 examples/ip_pipeline/mempool.h                |   40 -
 examples/ip_pipeline/meson.build              |   30 -
 examples/ip_pipeline/parser.c                 |  506 --
 examples/ip_pipeline/parser.h                 |   56 -
 examples/ip_pipeline/pipeline.c               | 1078 ---
 examples/ip_pipeline/pipeline.h               |  425 --
 examples/ip_pipeline/swq.c                    |   76 -
 examples/ip_pipeline/swq.h                    |   37 -
 examples/ip_pipeline/tap.c                    |  102 -
 examples/ip_pipeline/tap.h                    |   29 -
 examples/ip_pipeline/thread.c                 | 3137 --------
 examples/ip_pipeline/thread.h                 |   24 -
 examples/ip_pipeline/tmgr.c                   |  248 -
 examples/ip_pipeline/tmgr.h                   |   74 -
 examples/meson.build                          |    1 -
 lib/pipeline/meson.build                      |    8 +-
 lib/pipeline/rte_pipeline.c                   | 1640 ----
 lib/pipeline/rte_pipeline.h                   |  840 --
 lib/pipeline/rte_port_in_action.c             |  539 --
 lib/pipeline/rte_port_in_action.h             |  311 -
 lib/pipeline/rte_table_action.c               | 3483 ---------
 lib/pipeline/rte_table_action.h               | 1137 ---
 lib/port/meson.build                          |   22 +-
 lib/port/port_log.c                           |    7 -
 lib/port/port_log.h                           |   11 -
 lib/port/rte_port.h                           |  223 -
 lib/port/rte_port_ethdev.c                    |  530 --
 lib/port/rte_port_ethdev.h                    |   75 -
 lib/port/rte_port_eventdev.c                  |  590 --
 lib/port/rte_port_eventdev.h                  |   94 -
 lib/port/rte_port_fd.c                        |  524 --
 lib/port/rte_port_fd.h                        |   74 -
 lib/port/rte_port_frag.c                      |  280 -
 lib/port/rte_port_frag.h                      |   70 -
 lib/port/rte_port_ras.c                       |  336 -
 lib/port/rte_port_ras.h                       |   58 -
 lib/port/rte_port_ring.c                      |  796 --
 lib/port/rte_port_ring.h                      |   91 -
 lib/port/rte_port_sched.c                     |  298 -
 lib/port/rte_port_sched.h                     |   52 -
 lib/port/rte_port_source_sink.c               |  616 --
 lib/port/rte_port_source_sink.h               |   57 -
 lib/port/rte_port_sym_crypto.c                |  558 --
 lib/port/rte_port_sym_crypto.h                |   92 -
 lib/table/meson.build                         |   30 +-
 lib/table/rte_lru.h                           |   85 -
 lib/table/rte_lru_arm64.h                     |   61 -
 lib/table/rte_lru_x86.h                       |   96 -
 lib/table/rte_table.h                         |  263 -
 lib/table/rte_table_acl.c                     |  795 --
 lib/table/rte_table_acl.h                     |   65 -
 lib/table/rte_table_array.c                   |  210 -
 lib/table/rte_table_array.h                   |   46 -
 lib/table/rte_table_hash.h                    |  106 -
 lib/table/rte_table_hash_cuckoo.c             |  327 -
 lib/table/rte_table_hash_cuckoo.h             |   57 -
 lib/table/rte_table_hash_ext.c                | 1011 ---
 lib/table/rte_table_hash_func.h               |  263 -
 lib/table/rte_table_hash_func_arm64.h         |   21 -
 lib/table/rte_table_hash_key16.c              | 1190 ---
 lib/table/rte_table_hash_key32.c              | 1223 ---
 lib/table/rte_table_hash_key8.c               | 1157 ---
 lib/table/rte_table_hash_lru.c                |  959 ---
 lib/table/rte_table_lpm.c                     |  369 -
 lib/table/rte_table_lpm.h                     |   94 -
 lib/table/rte_table_lpm_ipv6.c                |  370 -
 lib/table/rte_table_lpm_ipv6.h                |   92 -
 lib/table/rte_table_stub.c                    |   95 -
 lib/table/rte_table_stub.h                    |   30 -
 lib/table/table_log.c                         |    7 -
 lib/table/table_log.h                         |   11 -
 128 files changed, 27 insertions(+), 45481 deletions(-)
 delete mode 100644 app/test-pipeline/config.c
 delete mode 100644 app/test-pipeline/init.c
 delete mode 100644 app/test-pipeline/main.c
 delete mode 100644 app/test-pipeline/main.h
 delete mode 100644 app/test-pipeline/meson.build
 delete mode 100644 app/test-pipeline/pipeline_acl.c
 delete mode 100644 app/test-pipeline/pipeline_hash.c
 delete mode 100644 app/test-pipeline/pipeline_lpm.c
 delete mode 100644 app/test-pipeline/pipeline_lpm_ipv6.c
 delete mode 100644 app/test-pipeline/pipeline_stub.c
 delete mode 100644 app/test-pipeline/runtime.c
 delete mode 100644 app/test/test_table.c
 delete mode 100644 app/test/test_table.h
 delete mode 100644 app/test/test_table_acl.c
 delete mode 100644 app/test/test_table_acl.h
 delete mode 100644 app/test/test_table_combined.c
 delete mode 100644 app/test/test_table_combined.h
 delete mode 100644 app/test/test_table_pipeline.c
 delete mode 100644 app/test/test_table_pipeline.h
 delete mode 100644 app/test/test_table_ports.c
 delete mode 100644 app/test/test_table_ports.h
 delete mode 100644 app/test/test_table_tables.c
 delete mode 100644 app/test/test_table_tables.h
 delete mode 100644 doc/guides/sample_app_ug/ip_pipeline.rst
 delete mode 100644 doc/guides/sample_app_ug/test_pipeline.rst
 delete mode 100644 examples/ip_pipeline/Makefile
 delete mode 100644 examples/ip_pipeline/action.c
 delete mode 100644 examples/ip_pipeline/action.h
 delete mode 100644 examples/ip_pipeline/cli.c
 delete mode 100644 examples/ip_pipeline/cli.h
 delete mode 100644 examples/ip_pipeline/common.h
 delete mode 100644 examples/ip_pipeline/conn.c
 delete mode 100644 examples/ip_pipeline/conn.h
 delete mode 100644 examples/ip_pipeline/cryptodev.c
 delete mode 100644 examples/ip_pipeline/cryptodev.h
 delete mode 100644 examples/ip_pipeline/examples/firewall.cli
 delete mode 100644 examples/ip_pipeline/examples/flow.cli
 delete mode 100644 examples/ip_pipeline/examples/flow_crypto.cli
 delete mode 100644 examples/ip_pipeline/examples/l2fwd.cli
 delete mode 100644 examples/ip_pipeline/examples/route.cli
 delete mode 100644 examples/ip_pipeline/examples/route_ecmp.cli
 delete mode 100644 examples/ip_pipeline/examples/rss.cli
 delete mode 100644 examples/ip_pipeline/examples/tap.cli
 delete mode 100644 examples/ip_pipeline/link.c
 delete mode 100644 examples/ip_pipeline/link.h
 delete mode 100644 examples/ip_pipeline/main.c
 delete mode 100644 examples/ip_pipeline/mempool.c
 delete mode 100644 examples/ip_pipeline/mempool.h
 delete mode 100644 examples/ip_pipeline/meson.build
 delete mode 100644 examples/ip_pipeline/parser.c
 delete mode 100644 examples/ip_pipeline/parser.h
 delete mode 100644 examples/ip_pipeline/pipeline.c
 delete mode 100644 examples/ip_pipeline/pipeline.h
 delete mode 100644 examples/ip_pipeline/swq.c
 delete mode 100644 examples/ip_pipeline/swq.h
 delete mode 100644 examples/ip_pipeline/tap.c
 delete mode 100644 examples/ip_pipeline/tap.h
 delete mode 100644 examples/ip_pipeline/thread.c
 delete mode 100644 examples/ip_pipeline/thread.h
 delete mode 100644 examples/ip_pipeline/tmgr.c
 delete mode 100644 examples/ip_pipeline/tmgr.h
 delete mode 100644 lib/pipeline/rte_pipeline.c
 delete mode 100644 lib/pipeline/rte_pipeline.h
 delete mode 100644 lib/pipeline/rte_port_in_action.c
 delete mode 100644 lib/pipeline/rte_port_in_action.h
 delete mode 100644 lib/pipeline/rte_table_action.c
 delete mode 100644 lib/pipeline/rte_table_action.h
 delete mode 100644 lib/port/port_log.c
 delete mode 100644 lib/port/port_log.h
 delete mode 100644 lib/port/rte_port.h
 delete mode 100644 lib/port/rte_port_ethdev.c
 delete mode 100644 lib/port/rte_port_ethdev.h
 delete mode 100644 lib/port/rte_port_eventdev.c
 delete mode 100644 lib/port/rte_port_eventdev.h
 delete mode 100644 lib/port/rte_port_fd.c
 delete mode 100644 lib/port/rte_port_fd.h
 delete mode 100644 lib/port/rte_port_frag.c
 delete mode 100644 lib/port/rte_port_frag.h
 delete mode 100644 lib/port/rte_port_ras.c
 delete mode 100644 lib/port/rte_port_ras.h
 delete mode 100644 lib/port/rte_port_ring.c
 delete mode 100644 lib/port/rte_port_ring.h
 delete mode 100644 lib/port/rte_port_sched.c
 delete mode 100644 lib/port/rte_port_sched.h
 delete mode 100644 lib/port/rte_port_source_sink.c
 delete mode 100644 lib/port/rte_port_source_sink.h
 delete mode 100644 lib/port/rte_port_sym_crypto.c
 delete mode 100644 lib/port/rte_port_sym_crypto.h
 delete mode 100644 lib/table/rte_lru.h
 delete mode 100644 lib/table/rte_lru_arm64.h
 delete mode 100644 lib/table/rte_lru_x86.h
 delete mode 100644 lib/table/rte_table.h
 delete mode 100644 lib/table/rte_table_acl.c
 delete mode 100644 lib/table/rte_table_acl.h
 delete mode 100644 lib/table/rte_table_array.c
 delete mode 100644 lib/table/rte_table_array.h
 delete mode 100644 lib/table/rte_table_hash.h
 delete mode 100644 lib/table/rte_table_hash_cuckoo.c
 delete mode 100644 lib/table/rte_table_hash_cuckoo.h
 delete mode 100644 lib/table/rte_table_hash_ext.c
 delete mode 100644 lib/table/rte_table_hash_func.h
 delete mode 100644 lib/table/rte_table_hash_func_arm64.h
 delete mode 100644 lib/table/rte_table_hash_key16.c
 delete mode 100644 lib/table/rte_table_hash_key32.c
 delete mode 100644 lib/table/rte_table_hash_key8.c
 delete mode 100644 lib/table/rte_table_hash_lru.c
 delete mode 100644 lib/table/rte_table_lpm.c
 delete mode 100644 lib/table/rte_table_lpm.h
 delete mode 100644 lib/table/rte_table_lpm_ipv6.c
 delete mode 100644 lib/table/rte_table_lpm_ipv6.h
 delete mode 100644 lib/table/rte_table_stub.c
 delete mode 100644 lib/table/rte_table_stub.h
 delete mode 100644 lib/table/table_log.c
 delete mode 100644 lib/table/table_log.h

--
2.53.0

#41 lore raw

Re: [PATCH v6 0/6] remove deprecated packet framework

Quoted 272 lines · Stephen Hemminger

The legacy Packet Framework APIs were announced for removal in the 24.11 release but the removal never happened:

* pipeline: The pipeline library legacy API (functions rte_pipeline_*)
* table: The table library legacy API (functions rte_table_*)
* port: The port library legacy API (functions rte_port_*)

Do the removal now, in the 26.11 ABI window. The SWX API in the same libraries (rte_swx_*) is unaffected and remains the Packet Framework API. The softnic driver and the pipeline example already use only the SWX API.

The applications built on the legacy API (test-pipeline, ip_pipeline) and the unit tests are removed first, then the legacy half of each library, pipeline before table before port to follow the dependency chain. Library dependencies and the programmer's guide are trimmed accordingly.

Follow-up candidates, kept out of this series: the stale comments in lib/ethdev/ethdev_trace.h still refer to examples/ip_pipeline, and struct rte_pipeline_acl_rule in the removed rte_table_acl.c was only a local name.

Note: there are some figures leftover that will need maintainer to manually remove with 'git rm' since patchwork mangled that.

v6 - rebase and cleanup some leftovers

Stephen Hemminger (6):
app/test: remove packet framework tests
app/test-pipeline: remove application
examples/ip_pipeline: remove example
pipeline: remove legacy API
table: remove legacy API
port: remove legacy API

 MAINTAINERS                                   |    5 -
 app/meson.build                               |    1 -
 app/test-pipeline/config.c                    |  230 -
 app/test-pipeline/init.c                      |  273 -
 app/test-pipeline/main.c                      |  188 -
 app/test-pipeline/main.h                      |  132 -
 app/test-pipeline/meson.build                 |   21 -
 app/test-pipeline/pipeline_acl.c              |  251 -
 app/test-pipeline/pipeline_hash.c             |  471 --
 app/test-pipeline/pipeline_lpm.c              |  175 -
 app/test-pipeline/pipeline_lpm_ipv6.c         |  168 -
 app/test-pipeline/pipeline_stub.c             |  137 -
 app/test-pipeline/runtime.c                   |  160 -
 app/test/meson.build                          |    6 -
 app/test/test_table.c                         |  209 -
 app/test/test_table.h                         |  184 -
 app/test/test_table_acl.c                     |  728 --
 app/test/test_table_acl.h                     |    6 -
 app/test/test_table_combined.c                |  846 --
 app/test/test_table_combined.h                |   27 -
 app/test/test_table_pipeline.c                |  575 --
 app/test/test_table_pipeline.h                |    6 -
 app/test/test_table_ports.c                   |  195 -
 app/test/test_table_ports.h                   |   13 -
 app/test/test_table_tables.c                  | 1058 ---
 app/test/test_table_tables.h                  |   22 -
 devtools/cocci/nullfree.cocci                 |   12 -
 doc/api/doxy-api-index.md                     |   17 -
 doc/guides/nics/softnic.rst                   |    3 +-
 doc/guides/prog_guide/packet_framework.rst    | 1146 +--
 doc/guides/rel_notes/deprecation.rst          |   15 -
 doc/guides/rel_notes/release_26_11.rst        |   17 +
 doc/guides/sample_app_ug/index.rst            |    2 -
 doc/guides/sample_app_ug/ip_pipeline.rst      |  531 --
 doc/guides/sample_app_ug/test_pipeline.rst    |  237 -
 examples/ip_pipeline/Makefile                 |   60 -
 examples/ip_pipeline/action.c                 |  391 -
 examples/ip_pipeline/action.h                 |   78 -
 examples/ip_pipeline/cli.c                    | 6791 -----------------
 examples/ip_pipeline/cli.h                    |   18 -
 examples/ip_pipeline/common.h                 |   12 -
 examples/ip_pipeline/conn.c                   |  330 -
 examples/ip_pipeline/conn.h                   |   47 -
 examples/ip_pipeline/cryptodev.c              |  160 -
 examples/ip_pipeline/cryptodev.h              |   46 -
 examples/ip_pipeline/examples/firewall.cli    |   59 -
 examples/ip_pipeline/examples/flow.cli        |   60 -
 examples/ip_pipeline/examples/flow_crypto.cli |   57 -
 examples/ip_pipeline/examples/l2fwd.cli       |   51 -
 examples/ip_pipeline/examples/route.cli       |   60 -
 examples/ip_pipeline/examples/route_ecmp.cli  |   57 -
 examples/ip_pipeline/examples/rss.cli         |  112 -
 examples/ip_pipeline/examples/tap.cli         |   66 -
 examples/ip_pipeline/link.c                   |  270 -
 examples/ip_pipeline/link.h                   |   66 -
 examples/ip_pipeline/main.c                   |  260 -
 examples/ip_pipeline/mempool.c                |   82 -
 examples/ip_pipeline/mempool.h                |   40 -
 examples/ip_pipeline/meson.build              |   30 -
 examples/ip_pipeline/parser.c                 |  506 --
 examples/ip_pipeline/parser.h                 |   56 -
 examples/ip_pipeline/pipeline.c               | 1078 ---
 examples/ip_pipeline/pipeline.h               |  425 --
 examples/ip_pipeline/swq.c                    |   76 -
 examples/ip_pipeline/swq.h                    |   37 -
 examples/ip_pipeline/tap.c                    |  102 -
 examples/ip_pipeline/tap.h                    |   29 -
 examples/ip_pipeline/thread.c                 | 3137 --------
 examples/ip_pipeline/thread.h                 |   24 -
 examples/ip_pipeline/tmgr.c                   |  248 -
 examples/ip_pipeline/tmgr.h                   |   74 -
 examples/meson.build                          |    1 -
 lib/pipeline/meson.build                      |    8 +-
 lib/pipeline/rte_pipeline.c                   | 1640 ----
 lib/pipeline/rte_pipeline.h                   |  840 --
 lib/pipeline/rte_port_in_action.c             |  539 --
 lib/pipeline/rte_port_in_action.h             |  311 -
 lib/pipeline/rte_table_action.c               | 3483 ---------
 lib/pipeline/rte_table_action.h               | 1137 ---
 lib/port/meson.build                          |   22 +-
 lib/port/port_log.c                           |    7 -
 lib/port/port_log.h                           |   11 -
 lib/port/rte_port.h                           |  223 -
 lib/port/rte_port_ethdev.c                    |  530 --
 lib/port/rte_port_ethdev.h                    |   75 -
 lib/port/rte_port_eventdev.c                  |  590 --
 lib/port/rte_port_eventdev.h                  |   94 -
 lib/port/rte_port_fd.c                        |  524 --
 lib/port/rte_port_fd.h                        |   74 -
 lib/port/rte_port_frag.c                      |  280 -
 lib/port/rte_port_frag.h                      |   70 -
 lib/port/rte_port_ras.c                       |  336 -
 lib/port/rte_port_ras.h                       |   58 -
 lib/port/rte_port_ring.c                      |  796 --
 lib/port/rte_port_ring.h                      |   91 -
 lib/port/rte_port_sched.c                     |  298 -
 lib/port/rte_port_sched.h                     |   52 -
 lib/port/rte_port_source_sink.c               |  616 --
 lib/port/rte_port_source_sink.h               |   57 -
 lib/port/rte_port_sym_crypto.c                |  558 --
 lib/port/rte_port_sym_crypto.h                |   92 -
 lib/table/meson.build                         |   30 +-
 lib/table/rte_lru.h                           |   85 -
 lib/table/rte_lru_arm64.h                     |   61 -
 lib/table/rte_lru_x86.h                       |   96 -
 lib/table/rte_table.h                         |  263 -
 lib/table/rte_table_acl.c                     |  795 --
 lib/table/rte_table_acl.h                     |   65 -
 lib/table/rte_table_array.c                   |  210 -
 lib/table/rte_table_array.h                   |   46 -
 lib/table/rte_table_hash.h                    |  106 -
 lib/table/rte_table_hash_cuckoo.c             |  327 -
 lib/table/rte_table_hash_cuckoo.h             |   57 -
 lib/table/rte_table_hash_ext.c                | 1011 ---
 lib/table/rte_table_hash_func.h               |  263 -
 lib/table/rte_table_hash_func_arm64.h         |   21 -
 lib/table/rte_table_hash_key16.c              | 1190 ---
 lib/table/rte_table_hash_key32.c              | 1223 ---
 lib/table/rte_table_hash_key8.c               | 1157 ---
 lib/table/rte_table_hash_lru.c                |  959 ---
 lib/table/rte_table_lpm.c                     |  369 -
 lib/table/rte_table_lpm.h                     |   94 -
 lib/table/rte_table_lpm_ipv6.c                |  370 -
 lib/table/rte_table_lpm_ipv6.h                |   92 -
 lib/table/rte_table_stub.c                    |   95 -
 lib/table/rte_table_stub.h                    |   30 -
 lib/table/table_log.c                         |    7 -
 lib/table/table_log.h                         |   11 -
 128 files changed, 27 insertions(+), 45481 deletions(-)
 delete mode 100644 app/test-pipeline/config.c
 delete mode 100644 app/test-pipeline/init.c
 delete mode 100644 app/test-pipeline/main.c
 delete mode 100644 app/test-pipeline/main.h
 delete mode 100644 app/test-pipeline/meson.build
 delete mode 100644 app/test-pipeline/pipeline_acl.c
 delete mode 100644 app/test-pipeline/pipeline_hash.c
 delete mode 100644 app/test-pipeline/pipeline_lpm.c
 delete mode 100644 app/test-pipeline/pipeline_lpm_ipv6.c
 delete mode 100644 app/test-pipeline/pipeline_stub.c
 delete mode 100644 app/test-pipeline/runtime.c
 delete mode 100644 app/test/test_table.c
 delete mode 100644 app/test/test_table.h
 delete mode 100644 app/test/test_table_acl.c
 delete mode 100644 app/test/test_table_acl.h
 delete mode 100644 app/test/test_table_combined.c
 delete mode 100644 app/test/test_table_combined.h
 delete mode 100644 app/test/test_table_pipeline.c
 delete mode 100644 app/test/test_table_pipeline.h
 delete mode 100644 app/test/test_table_ports.c
 delete mode 100644 app/test/test_table_ports.h
 delete mode 100644 app/test/test_table_tables.c
 delete mode 100644 app/test/test_table_tables.h
 delete mode 100644 doc/guides/sample_app_ug/ip_pipeline.rst
 delete mode 100644 doc/guides/sample_app_ug/test_pipeline.rst
 delete mode 100644 examples/ip_pipeline/Makefile
 delete mode 100644 examples/ip_pipeline/action.c
 delete mode 100644 examples/ip_pipeline/action.h
 delete mode 100644 examples/ip_pipeline/cli.c
 delete mode 100644 examples/ip_pipeline/cli.h
 delete mode 100644 examples/ip_pipeline/common.h
 delete mode 100644 examples/ip_pipeline/conn.c
 delete mode 100644 examples/ip_pipeline/conn.h
 delete mode 100644 examples/ip_pipeline/cryptodev.c
 delete mode 100644 examples/ip_pipeline/cryptodev.h
 delete mode 100644 examples/ip_pipeline/examples/firewall.cli
 delete mode 100644 examples/ip_pipeline/examples/flow.cli
 delete mode 100644 examples/ip_pipeline/examples/flow_crypto.cli
 delete mode 100644 examples/ip_pipeline/examples/l2fwd.cli
 delete mode 100644 examples/ip_pipeline/examples/route.cli
 delete mode 100644 examples/ip_pipeline/examples/route_ecmp.cli
 delete mode 100644 examples/ip_pipeline/examples/rss.cli
 delete mode 100644 examples/ip_pipeline/examples/tap.cli
 delete mode 100644 examples/ip_pipeline/link.c
 delete mode 100644 examples/ip_pipeline/link.h
 delete mode 100644 examples/ip_pipeline/main.c
 delete mode 100644 examples/ip_pipeline/mempool.c
 delete mode 100644 examples/ip_pipeline/mempool.h
 delete mode 100644 examples/ip_pipeline/meson.build
 delete mode 100644 examples/ip_pipeline/parser.c
 delete mode 100644 examples/ip_pipeline/parser.h
 delete mode 100644 examples/ip_pipeline/pipeline.c
 delete mode 100644 examples/ip_pipeline/pipeline.h
 delete mode 100644 examples/ip_pipeline/swq.c
 delete mode 100644 examples/ip_pipeline/swq.h
 delete mode 100644 examples/ip_pipeline/tap.c
 delete mode 100644 examples/ip_pipeline/tap.h
 delete mode 100644 examples/ip_pipeline/thread.c
 delete mode 100644 examples/ip_pipeline/thread.h
 delete mode 100644 examples/ip_pipeline/tmgr.c
 delete mode 100644 examples/ip_pipeline/tmgr.h
 delete mode 100644 lib/pipeline/rte_pipeline.c
 delete mode 100644 lib/pipeline/rte_pipeline.h
 delete mode 100644 lib/pipeline/rte_port_in_action.c
 delete mode 100644 lib/pipeline/rte_port_in_action.h
 delete mode 100644 lib/pipeline/rte_table_action.c
 delete mode 100644 lib/pipeline/rte_table_action.h
 delete mode 100644 lib/port/port_log.c
 delete mode 100644 lib/port/port_log.h
 delete mode 100644 lib/port/rte_port.h
 delete mode 100644 lib/port/rte_port_ethdev.c
 delete mode 100644 lib/port/rte_port_ethdev.h
 delete mode 100644 lib/port/rte_port_eventdev.c
 delete mode 100644 lib/port/rte_port_eventdev.h
 delete mode 100644 lib/port/rte_port_fd.c
 delete mode 100644 lib/port/rte_port_fd.h
 delete mode 100644 lib/port/rte_port_frag.c
 delete mode 100644 lib/port/rte_port_frag.h
 delete mode 100644 lib/port/rte_port_ras.c
 delete mode 100644 lib/port/rte_port_ras.h
 delete mode 100644 lib/port/rte_port_ring.c
 delete mode 100644 lib/port/rte_port_ring.h
 delete mode 100644 lib/port/rte_port_sched.c
 delete mode 100644 lib/port/rte_port_sched.h
 delete mode 100644 lib/port/rte_port_source_sink.c
 delete mode 100644 lib/port/rte_port_source_sink.h
 delete mode 100644 lib/port/rte_port_sym_crypto.c
 delete mode 100644 lib/port/rte_port_sym_crypto.h
 delete mode 100644 lib/table/rte_lru.h
 delete mode 100644 lib/table/rte_lru_arm64.h
 delete mode 100644 lib/table/rte_lru_x86.h
 delete mode 100644 lib/table/rte_table.h
 delete mode 100644 lib/table/rte_table_acl.c
 delete mode 100644 lib/table/rte_table_acl.h
 delete mode 100644 lib/table/rte_table_array.c
 delete mode 100644 lib/table/rte_table_array.h
 delete mode 100644 lib/table/rte_table_hash.h
 delete mode 100644 lib/table/rte_table_hash_cuckoo.c
 delete mode 100644 lib/table/rte_table_hash_cuckoo.h
 delete mode 100644 lib/table/rte_table_hash_ext.c
 delete mode 100644 lib/table/rte_table_hash_func.h
 delete mode 100644 lib/table/rte_table_hash_func_arm64.h
 delete mode 100644 lib/table/rte_table_hash_key16.c
 delete mode 100644 lib/table/rte_table_hash_key32.c
 delete mode 100644 lib/table/rte_table_hash_key8.c
 delete mode 100644 lib/table/rte_table_hash_lru.c
Quoted 8 lines
 delete mode 100644 lib/table/rte_table_lpm.c
 delete mode 100644 lib/table/rte_table_lpm.h
 delete mode 100644 lib/table/rte_table_lpm_ipv6.c
 delete mode 100644 lib/table/rte_table_lpm_ipv6.h
 delete mode 100644 lib/table/rte_table_stub.c
 delete mode 100644 lib/table/rte_table_stub.h
 delete mode 100644 lib/table/table_log.c
 delete mode 100644 lib/table/table_log.h

I did not see much activity on this series on the ml, but I see it is applied to next-net already.
I see some images were left behind.
Worth fixing before this gets pulled in main.

doc/guides/prog_guide/img/figure32.png
c561e0deda - port: remove legacy API (11 days ago) <Stephen Hemminger>

doc/guides/prog_guide/img/figure33.png
cd71a03348 - table: remove legacy API (11 days ago) <Stephen Hemminger>

doc/guides/prog_guide/img/figure34.png
cd71a03348 - table: remove legacy API (11 days ago) <Stephen Hemminger>

doc/guides/prog_guide/img/figure35.png
cd71a03348 - table: remove legacy API (11 days ago) <Stephen Hemminger>

doc/guides/prog_guide/img/figure37.png
cd71a03348 - table: remove legacy API (11 days ago) <Stephen Hemminger>

doc/guides/prog_guide/img/figure38.png
cd71a03348 - table: remove legacy API (11 days ago) <Stephen Hemminger>

doc/guides/prog_guide/img/figure39.png
cd71a03348 - table: remove legacy API (11 days ago) <Stephen Hemminger>

doc/guides/sample_app_ug/img/test_pipeline_app.png 5234c2b166 - app/test-pipeline: remove application (11 days ago) <Stephen Hemminger>

Signature · 1 line
David Marchand
#42 lore raw

Re: [PATCH v6 0/6] remove deprecated packet framework

Quoted 4 lines · On Fri, 4 Sep 2026 14:13:02 +0200 David Marchand <[email protected]>…

I did not see much activity on this series on the ml, but I see it is applied to next-net already.
I see some images were left behind.
Worth fixing before this gets pulled in main.

Thanks will cleanup. Put it in next-net as way to get full CI and avoid any later merge issues

#43 lore raw

PATCH v6 1/6 app/test: remove packet framework tests

In reply to Stephen Hemminger

The legacy packet framework libraries (port, table, pipeline) are being removed, so remove the unit tests exercising them.

---
 MAINTAINERS                    |    1 -
 app/test/meson.build           |    6 -
 app/test/test_table.c          |  209 -------
 app/test/test_table.h          |  184 ------
 app/test/test_table_acl.c      |  728 ----------------------
 app/test/test_table_acl.h      |    6 -
 app/test/test_table_combined.c |  846 -------------------------
 app/test/test_table_combined.h |   27 -
 app/test/test_table_pipeline.c |  575 -----------------
 app/test/test_table_pipeline.h |    6 -
 app/test/test_table_ports.c    |  195 ------
 app/test/test_table_ports.h    |   13 -
 app/test/test_table_tables.c   | 1058 --------------------------------
 app/test/test_table_tables.h   |   22 -
 14 files changed, 3876 deletions(-)
 delete mode 100644 app/test/test_table.c
 delete mode 100644 app/test/test_table.h
 delete mode 100644 app/test/test_table_acl.c
 delete mode 100644 app/test/test_table_acl.h
 delete mode 100644 app/test/test_table_combined.c
 delete mode 100644 app/test/test_table_combined.h
 delete mode 100644 app/test/test_table_pipeline.c
 delete mode 100644 app/test/test_table_pipeline.h
 delete mode 100644 app/test/test_table_ports.c
 delete mode 100644 app/test/test_table_ports.h
 delete mode 100644 app/test/test_table_tables.c
 delete mode 100644 app/test/test_table_tables.h
MAINTAINERS +0 -1
index e99a65d1974d38b62aa88f0662796226e57cd033..77a41b3fcf4110042ef69b7ee53351dd3cadb208 100644
@@ -1739,7 +1739,6 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: app/test/test_table*
 F: app/test-pipeline/
 F: doc/guides/sample_app_ug/test_pipeline.rst
 F: examples/ip_pipeline/
app/test/meson.build +0 -6
index 51abeeb7324483f07df4ff71dbc9e8a283740bc8..4fcd75594091abbf4fd09328023a3118e59b524d 100644
@@ -195,12 +195,6 @@ source_file_deps = {
     'test_stack.c': ['stack'],
     'test_stack_perf.c': ['stack'],
     'test_string_fns.c': [],
-    'test_table.c': ['table', 'pipeline', 'port'],
-    'test_table_acl.c': ['net', 'table', 'pipeline', 'port'],
-    'test_table_combined.c': ['table', 'pipeline', 'port'],
-    'test_table_pipeline.c': ['pipeline', 'table', 'port'],
-    'test_table_ports.c': ['table', 'pipeline', 'port'],
-    'test_table_tables.c': ['table', 'pipeline', 'port'],
     'test_tailq.c': [],
     'test_telemetry_data.c': ['telemetry'],
     'test_telemetry_json.c': ['telemetry'],
app/test/test_table.c deleted +0 -209

209 lines not on this page · raw message

app/test/test_table.h deleted +0 -184

184 lines not on this page · raw message

app/test/test_table_acl.c deleted +0 -728

728 lines not on this page · raw message

app/test/test_table_acl.h deleted +0 -6
deleted file mode 100644
index a6ae7d28385137fedfbfabe199ad0ac412ca698e..0000000000000000000000000000000000000000
@@ -1,6 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_acl(void);
app/test/test_table_combined.c deleted +0 -846

846 lines not on this page · raw message

app/test/test_table_combined.h deleted +0 -27
deleted file mode 100644
index fb94dbb94d08c48ba4bc94e6e657c0eb4fe6b8ce..0000000000000000000000000000000000000000
@@ -1,27 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2016 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_stub_combined(void);
-int test_table_lpm_combined(void);
-int test_table_lpm_ipv6_combined(void);
-#ifdef RTE_LIB_ACL
-int test_table_acl(void);
-#endif
-int test_table_hash8unoptimized(void);
-int test_table_hash8lru(void);
-int test_table_hash8ext(void);
-int test_table_hash16unoptimized(void);
-int test_table_hash16lru(void);
-int test_table_hash16ext(void);
-int test_table_hash32unoptimized(void);
-int test_table_hash32lru(void);
-int test_table_hash32ext(void);
-int test_table_hash_cuckoo_combined(void);
-
-/* Extern variables */
-typedef int (*combined_table_test)(void);
-
-extern combined_table_test table_tests_combined[];
-extern unsigned n_table_tests_combined;
app/test/test_table_pipeline.c deleted +0 -575

575 lines not on this page · raw message

app/test/test_table_pipeline.h deleted +0 -6
deleted file mode 100644
index d66d09d6f1e61f2d7ec179017932407d4620ed04..0000000000000000000000000000000000000000
@@ -1,6 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_table_pipeline(void);
app/test/test_table_ports.c deleted +0 -195

195 lines not on this page · raw message

app/test/test_table_ports.h deleted +0 -13
deleted file mode 100644
index dfa61193197e741a8ac565a81c2e64e0f0c179a4..0000000000000000000000000000000000000000
@@ -1,13 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2014 Intel Corporation
- */
-
-/* Test prototypes */
-int test_port_ring_reader(void);
-int test_port_ring_writer(void);
-
-/* Extern variables */
-typedef int (*port_test)(void);
-
-extern port_test port_tests[];
-extern unsigned n_port_tests;
app/test/test_table_tables.c deleted +0 -1058

192 lines not on this page · raw message

app/test/test_table_tables.h deleted +0 -22
deleted file mode 100644
index 530633a0136d26c76c59dac8941a862c46068837..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#44 lore raw

PATCH v6 2/6 app/test-pipeline: remove application

In reply to Stephen Hemminger

The test-pipeline application is built on the legacy pipeline library API (rte_pipeline_*), which was announced for removal in the 24.11 release. Remove it before removing the library.

---
 MAINTAINERS                                |   2 -
 app/meson.build                            |   1 -
 app/test-pipeline/config.c                 | 230 ----------
 app/test-pipeline/init.c                   | 273 ------------
 app/test-pipeline/main.c                   | 188 --------
 app/test-pipeline/main.h                   | 132 ------
 app/test-pipeline/meson.build              |  21 -
 app/test-pipeline/pipeline_acl.c           | 251 -----------
 app/test-pipeline/pipeline_hash.c          | 471 ---------------------
 app/test-pipeline/pipeline_lpm.c           | 175 --------
 app/test-pipeline/pipeline_lpm_ipv6.c      | 168 --------
 app/test-pipeline/pipeline_stub.c          | 137 ------
 app/test-pipeline/runtime.c                | 160 -------
 doc/guides/rel_notes/release_26_11.rst     |   3 +
 doc/guides/sample_app_ug/index.rst         |   1 -
 doc/guides/sample_app_ug/test_pipeline.rst | 237 -----------
 16 files changed, 3 insertions(+), 2447 deletions(-)
 delete mode 100644 app/test-pipeline/config.c
 delete mode 100644 app/test-pipeline/init.c
 delete mode 100644 app/test-pipeline/main.c
 delete mode 100644 app/test-pipeline/main.h
 delete mode 100644 app/test-pipeline/meson.build
 delete mode 100644 app/test-pipeline/pipeline_acl.c
 delete mode 100644 app/test-pipeline/pipeline_hash.c
 delete mode 100644 app/test-pipeline/pipeline_lpm.c
 delete mode 100644 app/test-pipeline/pipeline_lpm_ipv6.c
 delete mode 100644 app/test-pipeline/pipeline_stub.c
 delete mode 100644 app/test-pipeline/runtime.c
 delete mode 100644 doc/guides/sample_app_ug/test_pipeline.rst
MAINTAINERS +0 -2
index 77a41b3fcf4110042ef69b7ee53351dd3cadb208..4c06f85706ca9204cab6a655a58b6b7b1457160d 100644
@@ -1739,8 +1739,6 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: app/test-pipeline/
-F: doc/guides/sample_app_ug/test_pipeline.rst
 F: examples/ip_pipeline/
 F: examples/pipeline/
 F: doc/guides/sample_app_ug/ip_pipeline.rst
app/meson.build +0 -1
index 1798db3ae43f685d776533329546e4609d9eb565..4515688471328d2ab315f626c4865c4ba372eaad 100644
@@ -28,7 +28,6 @@ apps = [
         'test-flow-perf',
         'test-gpudev',
         'test-mldev',
-        'test-pipeline',
         'test-pmd',
         'test-regex',
         'test-sad',
app/test-pipeline/config.c deleted +0 -230

230 lines not on this page · raw message

app/test-pipeline/init.c deleted +0 -273

273 lines not on this page · raw message

app/test-pipeline/main.c deleted +0 -188

188 lines not on this page · raw message

app/test-pipeline/main.h deleted +0 -132

132 lines not on this page · raw message

app/test-pipeline/meson.build deleted +0 -21
deleted file mode 100644
index 3add6b637bdb5ec81013140a2011b95b22b7eaaf..0000000000000000000000000000000000000000
@@ -1,21 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2019 Intel Corporation
-
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-sources = files(
-        'config.c',
-        'init.c',
-        'main.c',
-        'pipeline_acl.c',
-        'pipeline_hash.c',
-        'pipeline_lpm.c',
-        'pipeline_lpm_ipv6.c',
-        'pipeline_stub.c',
-        'runtime.c',
-)
-deps += ['pipeline', 'pci']
app/test-pipeline/pipeline_acl.c deleted +0 -251

251 lines not on this page · raw message

app/test-pipeline/pipeline_hash.c deleted +0 -471

471 lines not on this page · raw message

app/test-pipeline/pipeline_lpm.c deleted +0 -175

175 lines not on this page · raw message

app/test-pipeline/pipeline_lpm_ipv6.c deleted +0 -168

168 lines not on this page · raw message

app/test-pipeline/pipeline_stub.c deleted +0 -137

137 lines not on this page · raw message

app/test-pipeline/runtime.c deleted +0 -160

160 lines not on this page · raw message

doc/guides/rel_notes/release_26_11.rst +3 -0
index c8cc86295da2d08b56e1464ca4a3122bbb599068..6ad0cf6eeca19f32429e60c2637b06274d43754a 100644
@@ -77,6 +77,9 @@ Removed Items
     ``rte_rib6_is_equal``
   * table: ``RTE_LPM_IPV6_ADDR_SIZE``
 
+* Removed the ``dpdk-test-pipeline`` application, which was based on
+  the legacy pipeline library API.
+
 
 API Changes
 -----------
doc/guides/sample_app_ug/index.rst +0 -1
index f12623bb669b75c39117f65dad781fe00e4534e9..c8b50b801c5ca317c8107b182a4633a4918fb199 100644
@@ -45,7 +45,6 @@ Sample Applications User Guides
     vhost_crypto
     vdpa
     ip_pipeline
-    test_pipeline
     pipeline
     eventdev_pipeline
     dist_app
doc/guides/sample_app_ug/test_pipeline.rst deleted +0 -237

237 lines not on this page · raw message

Signature · 1 line
2.53.0
#45 lore raw

PATCH v6 3/6 examples/ip_pipeline: remove example

In reply to Stephen Hemminger

The ip_pipeline example is built on the legacy pipeline library API (rte_pipeline_*) and the associated port and table action APIs, which were announced for removal in the 24.11 release. The pipeline example covers the SWX pipeline API.

---
 MAINTAINERS                                   |    2 -
 doc/guides/nics/softnic.rst                   |    3 +-
 doc/guides/rel_notes/release_26_11.rst        |    4 +
 doc/guides/sample_app_ug/index.rst            |    1 -
 doc/guides/sample_app_ug/ip_pipeline.rst      |  531 --
 examples/ip_pipeline/Makefile                 |   60 -
 examples/ip_pipeline/action.c                 |  391 -
 examples/ip_pipeline/action.h                 |   78 -
 examples/ip_pipeline/cli.c                    | 6791 -----------------
 examples/ip_pipeline/cli.h                    |   18 -
 examples/ip_pipeline/common.h                 |   12 -
 examples/ip_pipeline/conn.c                   |  330 -
 examples/ip_pipeline/conn.h                   |   47 -
 examples/ip_pipeline/cryptodev.c              |  160 -
 examples/ip_pipeline/cryptodev.h              |   46 -
 examples/ip_pipeline/examples/firewall.cli    |   59 -
 examples/ip_pipeline/examples/flow.cli        |   60 -
 examples/ip_pipeline/examples/flow_crypto.cli |   57 -
 examples/ip_pipeline/examples/l2fwd.cli       |   51 -
 examples/ip_pipeline/examples/route.cli       |   60 -
 examples/ip_pipeline/examples/route_ecmp.cli  |   57 -
 examples/ip_pipeline/examples/rss.cli         |  112 -
 examples/ip_pipeline/examples/tap.cli         |   66 -
 examples/ip_pipeline/link.c                   |  270 -
 examples/ip_pipeline/link.h                   |   66 -
 examples/ip_pipeline/main.c                   |  260 -
 examples/ip_pipeline/mempool.c                |   82 -
 examples/ip_pipeline/mempool.h                |   40 -
 examples/ip_pipeline/meson.build              |   30 -
 examples/ip_pipeline/parser.c                 |  506 --
 examples/ip_pipeline/parser.h                 |   56 -
 examples/ip_pipeline/pipeline.c               | 1078 ---
 examples/ip_pipeline/pipeline.h               |  425 --
 examples/ip_pipeline/swq.c                    |   76 -
 examples/ip_pipeline/swq.h                    |   37 -
 examples/ip_pipeline/tap.c                    |  102 -
 examples/ip_pipeline/tap.h                    |   29 -
 examples/ip_pipeline/thread.c                 | 3137 --------
 examples/ip_pipeline/thread.h                 |   24 -
 examples/ip_pipeline/tmgr.c                   |  248 -
 examples/ip_pipeline/tmgr.h                   |   74 -
 examples/meson.build                          |    1 -
 lib/ethdev/ethdev_trace.h                     |    2 -
 43 files changed, 5 insertions(+), 15534 deletions(-)
 delete mode 100644 doc/guides/sample_app_ug/ip_pipeline.rst
 delete mode 100644 examples/ip_pipeline/Makefile
 delete mode 100644 examples/ip_pipeline/action.c
 delete mode 100644 examples/ip_pipeline/action.h
 delete mode 100644 examples/ip_pipeline/cli.c
 delete mode 100644 examples/ip_pipeline/cli.h
 delete mode 100644 examples/ip_pipeline/common.h
 delete mode 100644 examples/ip_pipeline/conn.c
 delete mode 100644 examples/ip_pipeline/conn.h
 delete mode 100644 examples/ip_pipeline/cryptodev.c
 delete mode 100644 examples/ip_pipeline/cryptodev.h
 delete mode 100644 examples/ip_pipeline/examples/firewall.cli
 delete mode 100644 examples/ip_pipeline/examples/flow.cli
 delete mode 100644 examples/ip_pipeline/examples/flow_crypto.cli
 delete mode 100644 examples/ip_pipeline/examples/l2fwd.cli
 delete mode 100644 examples/ip_pipeline/examples/route.cli
 delete mode 100644 examples/ip_pipeline/examples/route_ecmp.cli
 delete mode 100644 examples/ip_pipeline/examples/rss.cli
 delete mode 100644 examples/ip_pipeline/examples/tap.cli
 delete mode 100644 examples/ip_pipeline/link.c
 delete mode 100644 examples/ip_pipeline/link.h
 delete mode 100644 examples/ip_pipeline/main.c
 delete mode 100644 examples/ip_pipeline/mempool.c
 delete mode 100644 examples/ip_pipeline/mempool.h
 delete mode 100644 examples/ip_pipeline/meson.build
 delete mode 100644 examples/ip_pipeline/parser.c
 delete mode 100644 examples/ip_pipeline/parser.h
 delete mode 100644 examples/ip_pipeline/pipeline.c
 delete mode 100644 examples/ip_pipeline/pipeline.h
 delete mode 100644 examples/ip_pipeline/swq.c
 delete mode 100644 examples/ip_pipeline/swq.h
 delete mode 100644 examples/ip_pipeline/tap.c
 delete mode 100644 examples/ip_pipeline/tap.h
 delete mode 100644 examples/ip_pipeline/thread.c
 delete mode 100644 examples/ip_pipeline/thread.h
 delete mode 100644 examples/ip_pipeline/tmgr.c
 delete mode 100644 examples/ip_pipeline/tmgr.h
MAINTAINERS +0 -2
index 4c06f85706ca9204cab6a655a58b6b7b1457160d..ae84e7f289468ac7a6f3f727732377260781ceb4 100644
@@ -1739,9 +1739,7 @@ F: lib/pipeline/
 F: lib/port/
 F: lib/table/
 F: doc/guides/prog_guide/packet_framework.rst
-F: examples/ip_pipeline/
 F: examples/pipeline/
-F: doc/guides/sample_app_ug/ip_pipeline.rst
 
 
 Algorithms
doc/guides/nics/softnic.rst +1 -2
index 603fdb49c461dba89d2d445c8a521485a367ff95..87f3e5adc0e237a31e0048ca75f0eaa5438ae4ce 100644
@@ -10,8 +10,7 @@ is DIY and reconfigurable through ``firmware`` (DPDK Packet Framework script).
 The Soft NIC leverages the DPDK Packet Framework libraries (librte_port,
 librte_table and librte_pipeline) to make it modular, flexible and extensible
 with new functionality.
-Please refer to :doc:`/prog_guide/packet_framework` and
-:doc:`/sample_app_ug/ip_pipeline` for more details.
+Please refer to :doc:`/prog_guide/packet_framework` for more details.
 
 The Soft NIC is configured through the standard DPDK ethdev API (ethdev, flow,
 QoS, security). The internal framework is not externally visible.
doc/guides/rel_notes/release_26_11.rst +4 -0
index 6ad0cf6eeca19f32429e60c2637b06274d43754a..fc84ba367ea730c393caf11883a09024b6c07688 100644
@@ -80,6 +80,10 @@ Removed Items
 * Removed the ``dpdk-test-pipeline`` application, which was based on
   the legacy pipeline library API.
 
+* Removed the ``ip_pipeline`` example application, which was based on
+  the legacy pipeline library API.
+  The ``pipeline`` example application covers the SWX pipeline API.
+
 
 API Changes
 -----------
doc/guides/sample_app_ug/index.rst +0 -1
index c8b50b801c5ca317c8107b182a4633a4918fb199..28c4c9a5b2636037304d3b63ca19861e0bfd6d21 100644
@@ -44,7 +44,6 @@ Sample Applications User Guides
     vhost_blk
     vhost_crypto
     vdpa
-    ip_pipeline
     pipeline
     eventdev_pipeline
     dist_app
doc/guides/sample_app_ug/ip_pipeline.rst deleted +0 -531

531 lines not on this page · raw message

examples/ip_pipeline/Makefile deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/action.c deleted +0 -391

391 lines not on this page · raw message

examples/ip_pipeline/action.h deleted +0 -78

78 lines not on this page · raw message

examples/ip_pipeline/cli.c deleted +0 -6791

1,905 lines not on this page · raw message

examples/ip_pipeline/cli.h deleted +0 -18
deleted file mode 100644
index 992e4c3a4a4a2a667ec03a7997430421b82be273..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/common.h deleted +0 -12
deleted file mode 100644
index 0886dfbe95976257569593012cbf4d9d61eed957..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/conn.c deleted +0 -330

330 lines not on this page · raw message

examples/ip_pipeline/conn.h deleted +0 -47

47 lines not on this page · raw message

examples/ip_pipeline/cryptodev.c deleted +0 -160

160 lines not on this page · raw message

examples/ip_pipeline/cryptodev.h deleted +0 -46

46 lines not on this page · raw message

examples/ip_pipeline/examples/firewall.cli deleted +0 -59

59 lines not on this page · raw message

examples/ip_pipeline/examples/flow.cli deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/examples/flow_crypto.cli deleted +0 -57

57 lines not on this page · raw message

examples/ip_pipeline/examples/l2fwd.cli deleted +0 -51

51 lines not on this page · raw message

examples/ip_pipeline/examples/route.cli deleted +0 -60

60 lines not on this page · raw message

examples/ip_pipeline/examples/route_ecmp.cli deleted +0 -57

57 lines not on this page · raw message

examples/ip_pipeline/examples/rss.cli deleted +0 -112

112 lines not on this page · raw message

examples/ip_pipeline/examples/tap.cli deleted +0 -66

66 lines not on this page · raw message

examples/ip_pipeline/link.c deleted +0 -270

270 lines not on this page · raw message

examples/ip_pipeline/link.h deleted +0 -66

66 lines not on this page · raw message

examples/ip_pipeline/main.c deleted +0 -260

260 lines not on this page · raw message

examples/ip_pipeline/mempool.c deleted +0 -82

82 lines not on this page · raw message

examples/ip_pipeline/mempool.h deleted +0 -40
deleted file mode 100644
index bd46a11ca09f35bca1a52996af92a3c7b9026d0b..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/meson.build deleted +0 -30
deleted file mode 100644
index 68049157e42978a2192fcf86769f5bdfc36465fc..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/parser.c deleted +0 -506

506 lines not on this page · raw message

examples/ip_pipeline/parser.h deleted +0 -56

56 lines not on this page · raw message

examples/ip_pipeline/pipeline.c deleted +0 -1078

1,078 lines not on this page · raw message

examples/ip_pipeline/pipeline.h deleted +0 -425

425 lines not on this page · raw message

examples/ip_pipeline/swq.c deleted +0 -76

76 lines not on this page · raw message

examples/ip_pipeline/swq.h deleted +0 -37
deleted file mode 100644
index c8440ee3cd89590cb157f29f3586a69220765cbf..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/tap.c deleted +0 -102

102 lines not on this page · raw message

examples/ip_pipeline/tap.h deleted +0 -29
deleted file mode 100644
index 0dce72fe3c989ac5443c8037fe2bb929b27a5bb7..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/thread.c deleted +0 -3137

3,137 lines not on this page · raw message

examples/ip_pipeline/thread.h deleted +0 -24
deleted file mode 100644
index facdf004eb6e1dba9dfa388620e8807b235d7dd5..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/tmgr.c deleted +0 -248

248 lines not on this page · raw message

examples/ip_pipeline/tmgr.h deleted +0 -74

74 lines not on this page · raw message

examples/meson.build +0 -1
index 25d9c88457f51f6e806b8dcb20564b3b5ab299b5..544ec5eadd82c3799b3fb884b07a73faa840651f 100644

Lines of this file are not shown. View the raw message.

lib/ethdev/ethdev_trace.h +0 -2
index 6554cc1a2140988653d03a871acc1fa6b2a4b53a..e7b291988000914292e0bc6633174f36d1f0b44c 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#46 lore raw

PATCH v6 4/6 pipeline: remove legacy API

In reply to Stephen Hemminger

Remove the legacy pipeline API (rte_pipeline_*) together with the port and table action APIs built on top of it, as announced for removal in the 24.11 release. The SWX pipeline API remains.

The sched dependency was only used by the table action API, so drop it.

---
 devtools/cocci/nullfree.cocci              |   12 -
 doc/api/doxy-api-index.md                  |    3 -
 doc/guides/prog_guide/packet_framework.rst |  203 --
 doc/guides/rel_notes/deprecation.rst       |    5 -
 doc/guides/rel_notes/release_26_11.rst     |    4 +
 lib/pipeline/meson.build                   |    8 +-
 lib/pipeline/rte_pipeline.c                | 1640 ---------
 lib/pipeline/rte_pipeline.h                |  840 -----
 lib/pipeline/rte_port_in_action.c          |  539 ---
 lib/pipeline/rte_port_in_action.h          |  311 --
 lib/pipeline/rte_table_action.c            | 3483 --------------------
 lib/pipeline/rte_table_action.h            | 1137 -------
 12 files changed, 5 insertions(+), 8180 deletions(-)
 delete mode 100644 lib/pipeline/rte_pipeline.c
 delete mode 100644 lib/pipeline/rte_pipeline.h
 delete mode 100644 lib/pipeline/rte_port_in_action.c
 delete mode 100644 lib/pipeline/rte_port_in_action.h
 delete mode 100644 lib/pipeline/rte_table_action.c
 delete mode 100644 lib/pipeline/rte_table_action.h
devtools/cocci/nullfree.cocci +0 -12
index e7417b69ff99872c340129ac966ae91f64ae7456..acf26f45f654781df5c70e1cdb7e8936f807fed5 100644
@@ -91,12 +91,6 @@ expression E;
 - if (E != NULL) rte_ring_free(E);
 + rte_ring_free(E);
 |
-- if (E != NULL) rte_port_in_action_free(E);
-+ rte_port_in_action_free(E);
-|
-- if (E != NULL) rte_port_in_action_profile_free(E);
-+ rte_port_in_action_profile_free(E);
-|
 - if (E != NULL) rte_sched_port_free(E);
 + rte_sched_port_free(E);
 |
@@ -118,12 +112,6 @@ expression E;
 - if (E != NULL) rte_swx_table_selector_free(E);
 + rte_swx_table_selector_free(E);
 |
-- if (E != NULL) rte_table_action_free(E);
-+ rte_table_action_free(E);
-|
-- if (E != NULL) rte_table_action_profile_free(E);
-+ rte_table_action_profile_free(E);
-|
 - if (E != NULL) rte_tel_data_free(E);
 + rte_tel_data_free(E);
 |
doc/api/doxy-api-index.md +0 -3
index 92960421194604a9bc69da1eb6af7fc727cdb310..17c15027b8bd3aae13b992b4bfd038ef8b2bb5cd 100644
@@ -196,9 +196,6 @@ The public API headers are grouped by topics:
     [hash](@ref rte_table_hash.h),
     [array](@ref rte_table_array.h),
     [stub](@ref rte_table_stub.h)
-  * [pipeline](@ref rte_pipeline.h)
-    [port_in_action](@ref rte_port_in_action.h)
-    [table_action](@ref rte_table_action.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/packet_framework.rst +0 -203

209 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 6ad7698c6b8c4f950c9642798bbad36acc814ef9..758652a492e600b267feba131ddcf943106c8c8b 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* pipeline: The pipeline library legacy API (functions rte_pipeline_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new pipeline library API (functions rte_swx_pipeline_*)
-  will gradually transition from experimental to stable status.
-
 * table: The table library legacy API (functions rte_table_*)
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new table library API (functions rte_swx_table_*)
doc/guides/rel_notes/release_26_11.rst +4 -0
index fc84ba367ea730c393caf11883a09024b6c07688..f7d34aa1ee7fd363f456ecf27effdbfb65efbad5 100644
@@ -84,6 +84,10 @@ Removed Items
   the legacy pipeline library API.
   The ``pipeline`` example application covers the SWX pipeline API.
 
+* Removed the legacy pipeline library API: ``rte_pipeline_*``,
+  ``rte_port_in_action_*`` and ``rte_table_action_*`` functions.
+  The SWX pipeline API (``rte_swx_pipeline_*``) remains.
+
 
 API Changes
 -----------
lib/pipeline/meson.build +1 -7
index 823c7929a7f4734b7e23554b2929290c60faf6c0..997ded67925433316aa447f6004b944a2247f2fc 100644
@@ -10,21 +10,15 @@ endif
 cflags += no_wvla_cflag
 
 sources = files(
-        'rte_pipeline.c',
-        'rte_port_in_action.c',
-        'rte_table_action.c',
         'rte_swx_ipsec.c',
         'rte_swx_pipeline.c',
         'rte_swx_pipeline_spec.c',
         'rte_swx_ctl.c',
 )
 headers = files(
-        'rte_pipeline.h',
-        'rte_port_in_action.h',
-        'rte_table_action.h',
         'rte_swx_ipsec.h',
         'rte_swx_pipeline.h',
         'rte_swx_extern.h',
         'rte_swx_ctl.h',
 )
-deps += ['port', 'table', 'meter', 'sched', 'cryptodev', 'ipsec']
+deps += ['port', 'table', 'meter', 'cryptodev', 'ipsec']
lib/pipeline/rte_pipeline.c deleted +0 -1640

1,640 lines not on this page · raw message

lib/pipeline/rte_pipeline.h deleted +0 -840

840 lines not on this page · raw message

lib/pipeline/rte_port_in_action.c deleted +0 -539

235 lines not on this page · raw message

lib/pipeline/rte_port_in_action.h deleted +0 -311

311 lines not on this page · raw message

lib/pipeline/rte_table_action.c deleted +0 -3483

3,483 lines not on this page · raw message

lib/pipeline/rte_table_action.h deleted +0 -1137

1,137 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#47 lore raw

PATCH v6 5/6 table: remove legacy API

In reply to Stephen Hemminger

Remove the legacy table library API (rte_table_*) as announced for removal in the 24.11 release. The SWX table API remains.

The lpm and port dependencies were only used by the legacy API, so drop them. The hash and acl dependencies are still needed by the SWX exact match and wildcard match tables.

---
 doc/api/doxy-api-index.md                  |    7 -
 doc/guides/prog_guide/packet_framework.rst |  811 -------------
 doc/guides/rel_notes/deprecation.rst       |    5 -
 doc/guides/rel_notes/release_26_11.rst     |    3 +
 lib/table/meson.build                      |   30 +-
 lib/table/rte_lru.h                        |   85 --
 lib/table/rte_lru_arm64.h                  |   61 -
 lib/table/rte_lru_x86.h                    |   96 --
 lib/table/rte_table.h                      |  263 -----
 lib/table/rte_table_acl.c                  |  795 -------------
 lib/table/rte_table_acl.h                  |   65 --
 lib/table/rte_table_array.c                |  210 ----
 lib/table/rte_table_array.h                |   46 -
 lib/table/rte_table_hash.h                 |  106 --
 lib/table/rte_table_hash_cuckoo.c          |  327 ------
 lib/table/rte_table_hash_cuckoo.h          |   57 -
 lib/table/rte_table_hash_ext.c             | 1011 ----------------
 lib/table/rte_table_hash_func.h            |  263 -----
 lib/table/rte_table_hash_func_arm64.h      |   21 -
 lib/table/rte_table_hash_key16.c           | 1190 -------------------
 lib/table/rte_table_hash_key32.c           | 1223 --------------------
 lib/table/rte_table_hash_key8.c            | 1157 ------------------
 lib/table/rte_table_hash_lru.c             |  959 ---------------
 lib/table/rte_table_lpm.c                  |  369 ------
 lib/table/rte_table_lpm.h                  |   94 --
 lib/table/rte_table_lpm_ipv6.c             |  370 ------
 lib/table/rte_table_lpm_ipv6.h             |   92 --
 lib/table/rte_table_stub.c                 |   95 --
 lib/table/rte_table_stub.h                 |   30 -
 lib/table/table_log.c                      |    7 -
 lib/table/table_log.h                      |   11 -
 31 files changed, 4 insertions(+), 9855 deletions(-)
 delete mode 100644 lib/table/rte_lru.h
 delete mode 100644 lib/table/rte_lru_arm64.h
 delete mode 100644 lib/table/rte_lru_x86.h
 delete mode 100644 lib/table/rte_table.h
 delete mode 100644 lib/table/rte_table_acl.c
 delete mode 100644 lib/table/rte_table_acl.h
 delete mode 100644 lib/table/rte_table_array.c
 delete mode 100644 lib/table/rte_table_array.h
 delete mode 100644 lib/table/rte_table_hash.h
 delete mode 100644 lib/table/rte_table_hash_cuckoo.c
 delete mode 100644 lib/table/rte_table_hash_cuckoo.h
 delete mode 100644 lib/table/rte_table_hash_ext.c
 delete mode 100644 lib/table/rte_table_hash_func.h
 delete mode 100644 lib/table/rte_table_hash_func_arm64.h
 delete mode 100644 lib/table/rte_table_hash_key16.c
 delete mode 100644 lib/table/rte_table_hash_key32.c
 delete mode 100644 lib/table/rte_table_hash_key8.c
 delete mode 100644 lib/table/rte_table_hash_lru.c
 delete mode 100644 lib/table/rte_table_lpm.c
 delete mode 100644 lib/table/rte_table_lpm.h
 delete mode 100644 lib/table/rte_table_lpm_ipv6.c
 delete mode 100644 lib/table/rte_table_lpm_ipv6.h
 delete mode 100644 lib/table/rte_table_stub.c
 delete mode 100644 lib/table/rte_table_stub.h
 delete mode 100644 lib/table/table_log.c
 delete mode 100644 lib/table/table_log.h
doc/api/doxy-api-index.md +0 -7
index 17c15027b8bd3aae13b992b4bfd038ef8b2bb5cd..760b770d6f8ac636e56541b4db609768e6558e11 100644
@@ -189,13 +189,6 @@ The public API headers are grouped by topics:
     [reass](@ref rte_port_ras.h),
     [sched](@ref rte_port_sched.h),
     [src/sink](@ref rte_port_source_sink.h)
-  * [table](@ref rte_table.h):
-    [lpm IPv4](@ref rte_table_lpm.h),
-    [lpm IPv6](@ref rte_table_lpm_ipv6.h),
-    [ACL](@ref rte_table_acl.h),
-    [hash](@ref rte_table_hash.h),
-    [array](@ref rte_table_array.h),
-    [stub](@ref rte_table_stub.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/packet_framework.rst +0 -811

817 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 758652a492e600b267feba131ddcf943106c8c8b..9dcf86098f0d391a44ee1887ba823a1dd04ac295 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* table: The table library legacy API (functions rte_table_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new table library API (functions rte_swx_table_*)
-  will gradually transition from experimental to stable status.
-
 * port: The port library legacy API (functions rte_port_*)
   will be deprecated and subsequently removed in DPDK 24.11 release.
   Before this, the new port library API (functions rte_swx_port_*)
doc/guides/rel_notes/release_26_11.rst +3 -0
index f7d34aa1ee7fd363f456ecf27effdbfb65efbad5..50b0d3ac06e35b8fd5b86baafd85723d7539cb5d 100644
@@ -88,6 +88,9 @@ Removed Items
   ``rte_port_in_action_*`` and ``rte_table_action_*`` functions.
   The SWX pipeline API (``rte_swx_pipeline_*``) remains.
 
+* Removed the legacy table library API (``rte_table_*`` functions).
+  The SWX table API (``rte_swx_table_*``) remains.
+
 
 API Changes
 -----------
lib/table/meson.build +1 -29
index e27957fe8995a2ffb3aca4d2b514f0be6b8d6968..c9d5e873ddb5ee1642f30974b7c360b79e99510c 100644
@@ -9,42 +9,14 @@ sources = files(
         'rte_swx_table_learner.c',
         'rte_swx_table_selector.c',
         'rte_swx_table_wm.c',
-        'rte_table_acl.c',
-        'rte_table_array.c',
-        'rte_table_hash_cuckoo.c',
-        'rte_table_hash_ext.c',
-        'rte_table_hash_key8.c',
-        'rte_table_hash_key16.c',
-        'rte_table_hash_key32.c',
-        'rte_table_hash_lru.c',
-        'rte_table_lpm.c',
-        'rte_table_lpm_ipv6.c',
-        'rte_table_stub.c',
-        'table_log.c',
 )
 
 headers = files(
-        'rte_lru.h',
         'rte_swx_hash_func.h',
         'rte_swx_table.h',
         'rte_swx_table_em.h',
         'rte_swx_table_learner.h',
         'rte_swx_table_selector.h',
         'rte_swx_table_wm.h',
-        'rte_table.h',
-        'rte_table_acl.h',
-        'rte_table_array.h',
-        'rte_table_hash.h',
-        'rte_table_hash_cuckoo.h',
-        'rte_table_hash_func.h',
-        'rte_table_lpm.h',
-        'rte_table_lpm_ipv6.h',
-        'rte_table_stub.h',
-)
-deps += ['mbuf', 'port', 'lpm', 'hash', 'acl']
-
-indirect_headers += files(
-        'rte_lru_arm64.h',
-        'rte_lru_x86.h',
-        'rte_table_hash_func_arm64.h',
 )
+deps += ['hash', 'acl']
lib/table/rte_lru.h deleted +0 -85

85 lines not on this page · raw message

lib/table/rte_lru_arm64.h deleted +0 -61

61 lines not on this page · raw message

lib/table/rte_lru_x86.h deleted +0 -96

96 lines not on this page · raw message

lib/table/rte_table.h deleted +0 -263

263 lines not on this page · raw message

lib/table/rte_table_acl.c deleted +0 -795

795 lines not on this page · raw message

lib/table/rte_table_acl.h deleted +0 -65

65 lines not on this page · raw message

lib/table/rte_table_array.c deleted +0 -210

210 lines not on this page · raw message

lib/table/rte_table_array.h deleted +0 -46

46 lines not on this page · raw message

lib/table/rte_table_hash.h deleted +0 -106

106 lines not on this page · raw message

lib/table/rte_table_hash_cuckoo.c deleted +0 -327

327 lines not on this page · raw message

lib/table/rte_table_hash_cuckoo.h deleted +0 -57

53 lines not on this page · raw message

lib/table/rte_table_hash_ext.c deleted +0 -1011

1,011 lines not on this page · raw message

lib/table/rte_table_hash_func.h deleted +0 -263

263 lines not on this page · raw message

lib/table/rte_table_hash_func_arm64.h deleted +0 -21
deleted file mode 100644
index eb04c1ff54f7e930ef8b6e9028a51d5a4ecce6f6..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

lib/table/rte_table_hash_key16.c deleted +0 -1190

1,190 lines not on this page · raw message

lib/table/rte_table_hash_key32.c deleted +0 -1223

1,223 lines not on this page · raw message

lib/table/rte_table_hash_key8.c deleted +0 -1157

1,157 lines not on this page · raw message

lib/table/rte_table_hash_lru.c deleted +0 -959

959 lines not on this page · raw message

lib/table/rte_table_lpm.c deleted +0 -369

369 lines not on this page · raw message

lib/table/rte_table_lpm.h deleted +0 -94

94 lines not on this page · raw message

lib/table/rte_table_lpm_ipv6.c deleted +0 -370

370 lines not on this page · raw message

lib/table/rte_table_lpm_ipv6.h deleted +0 -92

92 lines not on this page · raw message

lib/table/rte_table_stub.c deleted +0 -95

95 lines not on this page · raw message

lib/table/rte_table_stub.h deleted +0 -30
deleted file mode 100644
index f7e589df16f77f0aca839232b32747b4856936f6..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

lib/table/table_log.c deleted +0 -7
deleted file mode 100644
index b329edd2e69f8035d25c05582aeeb97d210a2f9c..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

lib/table/table_log.h deleted +0 -11
deleted file mode 100644
index b24b8614c227be014cd8f3139da712570957ff7d..0000000000000000000000000000000000000000

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#48 lore raw

PATCH v6 6/6 port: remove legacy API

In reply to Stephen Hemminger

Remove the legacy port library API (rte_port_*) as announced for removal in the 24.11 release. The SWX port API remains.

The sched, ip_frag, cryptodev and eventdev dependencies were only used by the legacy port types, so drop them. The pcap dependency is kept for the SWX source/sink port.

---
 doc/api/doxy-api-index.md                  |   7 -
 doc/guides/prog_guide/packet_framework.rst | 132 +---
 doc/guides/rel_notes/deprecation.rst       |   5 -
 doc/guides/rel_notes/release_26_11.rst     |   3 +
 lib/port/meson.build                       |  22 +-
 lib/port/port_log.c                        |   7 -
 lib/port/port_log.h                        |  11 -
 lib/port/rte_port.h                        | 223 ------
 lib/port/rte_port_ethdev.c                 | 530 --------------
 lib/port/rte_port_ethdev.h                 |  75 --
 lib/port/rte_port_eventdev.c               | 590 ---------------
 lib/port/rte_port_eventdev.h               |  94 ---
 lib/port/rte_port_fd.c                     | 524 --------------
 lib/port/rte_port_fd.h                     |  74 --
 lib/port/rte_port_frag.c                   | 280 --------
 lib/port/rte_port_frag.h                   |  70 --
 lib/port/rte_port_ras.c                    | 336 ---------
 lib/port/rte_port_ras.h                    |  58 --
 lib/port/rte_port_ring.c                   | 796 ---------------------
 lib/port/rte_port_ring.h                   |  91 ---
 lib/port/rte_port_sched.c                  | 298 --------
 lib/port/rte_port_sched.h                  |  52 --
 lib/port/rte_port_source_sink.c            | 616 ----------------
 lib/port/rte_port_source_sink.h            |  57 --
 lib/port/rte_port_sym_crypto.c             | 558 ---------------
 lib/port/rte_port_sym_crypto.h             |  92 ---
 26 files changed, 10 insertions(+), 5591 deletions(-)
 delete mode 100644 lib/port/port_log.c
 delete mode 100644 lib/port/port_log.h
 delete mode 100644 lib/port/rte_port.h
 delete mode 100644 lib/port/rte_port_ethdev.c
 delete mode 100644 lib/port/rte_port_ethdev.h
 delete mode 100644 lib/port/rte_port_eventdev.c
 delete mode 100644 lib/port/rte_port_eventdev.h
 delete mode 100644 lib/port/rte_port_fd.c
 delete mode 100644 lib/port/rte_port_fd.h
 delete mode 100644 lib/port/rte_port_frag.c
 delete mode 100644 lib/port/rte_port_frag.h
 delete mode 100644 lib/port/rte_port_ras.c
 delete mode 100644 lib/port/rte_port_ras.h
 delete mode 100644 lib/port/rte_port_ring.c
 delete mode 100644 lib/port/rte_port_ring.h
 delete mode 100644 lib/port/rte_port_sched.c
 delete mode 100644 lib/port/rte_port_sched.h
 delete mode 100644 lib/port/rte_port_source_sink.c
 delete mode 100644 lib/port/rte_port_source_sink.h
 delete mode 100644 lib/port/rte_port_sym_crypto.c
 delete mode 100644 lib/port/rte_port_sym_crypto.h
doc/api/doxy-api-index.md +0 -7
index 760b770d6f8ac636e56541b4db609768e6558e11..16827a602b501491948e583c08bc49c55de44bf1 100644
@@ -182,13 +182,6 @@ The public API headers are grouped by topics:
   [bitmap](@ref rte_bitmap.h)
 
 - **packet framework**:
-  * [port](@ref rte_port.h):
-    [ethdev](@ref rte_port_ethdev.h),
-    [ring](@ref rte_port_ring.h),
-    [frag](@ref rte_port_frag.h),
-    [reass](@ref rte_port_ras.h),
-    [sched](@ref rte_port_sched.h),
-    [src/sink](@ref rte_port_source_sink.h)
   * SWX pipeline:
     [control](@ref rte_swx_ctl.h),
     [extern](@ref rte_swx_extern.h),
doc/guides/prog_guide/packet_framework.rst +6 -126

138 lines not on this page · raw message

doc/guides/rel_notes/deprecation.rst +0 -5
index 9dcf86098f0d391a44ee1887ba823a1dd04ac295..75b56b0e104d95a0d6a4c049bbcec561272104ea 100644
@@ -148,11 +148,6 @@ Deprecation Notices
   The graph walk functions will process nodes in topological order
   using bitmap scanning instead of the circular buffer.
 
-* port: The port library legacy API (functions rte_port_*)
-  will be deprecated and subsequently removed in DPDK 24.11 release.
-  Before this, the new port library API (functions rte_swx_port_*)
-  will gradually transition from experimental to stable status.
-
 * bus/vmbus: Starting DPDK 25.11, all the vmbus API defined in
   ``drivers/bus/vmbus/rte_bus_vmbus.h`` will become internal to DPDK.
   Those API functions are used internally by DPDK core and netvsc PMD.
doc/guides/rel_notes/release_26_11.rst +3 -0
index 50b0d3ac06e35b8fd5b86baafd85723d7539cb5d..31b075b3ccf203b45706b6cb39d5a38f4c20a05b 100644
@@ -91,6 +91,9 @@ Removed Items
 * Removed the legacy table library API (``rte_table_*`` functions).
   The SWX table API (``rte_swx_table_*``) remains.
 
+* Removed the legacy port library API (``rte_port_*`` functions).
+  The SWX port API (``rte_swx_port_*``) remains.
+
 
 API Changes
 -----------
lib/port/meson.build +1 -21
index b5977728723a9ef9e21a23ae3a1eca7342b93dc5..ef88b917a3293fbdc51ea22ef862a8e9f432cae8 100644
@@ -8,39 +8,19 @@ if is_windows
 endif
 
 sources = files(
-        'port_log.c',
-        'rte_port_ethdev.c',
-        'rte_port_fd.c',
-        'rte_port_frag.c',
-        'rte_port_ras.c',
-        'rte_port_ring.c',
-        'rte_port_sched.c',
-        'rte_port_source_sink.c',
-        'rte_port_sym_crypto.c',
-        'rte_port_eventdev.c',
         'rte_swx_port_ethdev.c',
         'rte_swx_port_fd.c',
         'rte_swx_port_ring.c',
         'rte_swx_port_source_sink.c',
 )
 headers = files(
-        'rte_port_ethdev.h',
-        'rte_port_fd.h',
-        'rte_port_frag.h',
-        'rte_port_ras.h',
-        'rte_port.h',
-        'rte_port_ring.h',
-        'rte_port_sched.h',
-        'rte_port_source_sink.h',
-        'rte_port_sym_crypto.h',
-        'rte_port_eventdev.h',
         'rte_swx_port.h',
         'rte_swx_port_ethdev.h',
         'rte_swx_port_fd.h',
         'rte_swx_port_ring.h',
         'rte_swx_port_source_sink.h',
 )
-deps += ['ethdev', 'sched', 'ip_frag', 'cryptodev', 'eventdev']
+deps += ['ethdev']
 
 if dpdk_conf.has('RTE_HAS_LIBPCAP')
     dpdk_conf.set('RTE_PORT_PCAP', 1)
lib/port/port_log.c deleted +0 -7
deleted file mode 100644
index e7a10d80ef8ca58aec03e4764517cc5d8b8dfe79..0000000000000000000000000000000000000000
@@ -1,7 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2024 Stephen Hemminger <[email protected]>
- */
-
-#include <rte_log.h>
-
-RTE_LOG_REGISTER_DEFAULT(port_logtype, INFO);
lib/port/port_log.h deleted +0 -11
deleted file mode 100644
index 28d75ee48b3be232751ac60f8eefc3d4d03850bb..0000000000000000000000000000000000000000
@@ -1,11 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2023 Red Hat, Inc.
- */
-
-#include <rte_log.h>
-
-extern int port_logtype;
-#define RTE_LOGTYPE_PORT port_logtype
-
-#define PORT_LOG(level, ...) \
-	RTE_LOG_LINE(level, PORT, "" __VA_ARGS__)
lib/port/rte_port.h deleted +0 -223

223 lines not on this page · raw message

lib/port/rte_port_ethdev.c deleted +0 -530

530 lines not on this page · raw message

lib/port/rte_port_ethdev.h deleted +0 -75

75 lines not on this page · raw message

lib/port/rte_port_eventdev.c deleted +0 -590

590 lines not on this page · raw message

lib/port/rte_port_eventdev.h deleted +0 -94

94 lines not on this page · raw message

lib/port/rte_port_fd.c deleted +0 -524

524 lines not on this page · raw message

lib/port/rte_port_fd.h deleted +0 -74

74 lines not on this page · raw message

lib/port/rte_port_frag.c deleted +0 -280

280 lines not on this page · raw message

lib/port/rte_port_frag.h deleted +0 -70

70 lines not on this page · raw message

lib/port/rte_port_ras.c deleted +0 -336

311 lines not on this page · raw message

lib/port/rte_port_ras.h deleted +0 -58

58 lines not on this page · raw message

lib/port/rte_port_ring.c deleted +0 -796

796 lines not on this page · raw message

lib/port/rte_port_ring.h deleted +0 -91

91 lines not on this page · raw message

lib/port/rte_port_sched.c deleted +0 -298

298 lines not on this page · raw message

lib/port/rte_port_sched.h deleted +0 -52

52 lines not on this page · raw message

lib/port/rte_port_source_sink.c deleted +0 -616

616 lines not on this page · raw message

lib/port/rte_port_source_sink.h deleted +0 -57

57 lines not on this page · raw message

lib/port/rte_port_sym_crypto.c deleted +0 -558

558 lines not on this page · raw message

lib/port/rte_port_sym_crypto.h deleted +0 -92

92 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.53.0

Part of the diff is not shown here. View the raw message.

#49 lore raw

Re: [PATCH v6 6/6] port: remove legacy API

Quoted 9 lines · On Thu, 30 Jul 2026 09:22:34 -0700 Stephen Hemminger…

Remove the legacy port library API (rte_port_*) as announced for removal in the 24.11 release. The SWX port API remains.

The sched, ip_frag, cryptodev and eventdev dependencies were only used by the legacy port types, so drop them. The pcap dependency is kept for the SWX source/sink port.

---

The CI build infrastructure reports a failure when building docs but this report is bogus. The docs build, the way it is doing it is all wrong. It is applying single patch without others before it; then complaining.

Wordier AI analysis:

Subject: Intel PER_PATCH_BUILD applies patches in isolation, produces false compilation failures

Report: pw167045, sid 38829, job PER_PATCH_BUILD19605, series "packet framework removal" v6 6/6 ("port: remove legacy API"), baseline dpdk-next-net 9231dc7c.

Reported failure: doc build on UB2604-64 (x86_64-native-linuxapp-doc). Doxygen aborts with doc/api/doxy-api-index.md:185: error: unable to resolve reference to 'rte_port.h'.

The series is correct. Patch 6/6 removes that reference in the same commit that deletes lib/port/rte_port.h, so every commit in the series is self-consistent and the tree bisects clean.

Root cause is in the CI, two defects:

The job applied 6/6 alone on top of the baseline rather than
applying 1/6 through 6/6 in order. The resulting tree exists nowhere in history. Patch 6/6's index hunk has trailing context * SWX pipeline:
immediately after the port list, which only holds once 4/6 and 5/6 have removed the pipeline and table entries, so the hunk cannot apply to the bare baseline. The apply was reject-tolerant and the job continued. The lib/port/* deletions landed while doxy-api-index.md stayed untouched, and the build proceeded on that mixed tree.

Proof: line 185 in the log is * [port](@ref rte_port.h):, which is line 185 of the unmodified file at baseline blob 9296042 (byte-identical to main). Had 1/6 through 6/6 been applied in order, 4/6's hunk alone would have shifted that line. Doxygen aborts on the first unresolved reference, which is why rte_table.h and rte_pipeline.h are not also listed. Reproduced locally:

$ git apply --check <6/6 doxy hunk>    # on baseline
error: patch failed: doc/api/doxy-api-index.md:182
$ patch -p1 --dry-run < <same>
Hunk #1 FAILED at 182.

Requested fixes:

Apply the full series with git am onto the baseline, then build
each commit, e.g. git rebase --exec '<build>' <base>. That tests bisectability, which testing patches in isolation does not. Treat any rejected hunk as a job abort, reported as an apply error, not as a compilation FAILURE attributed to the submitter.

Note for anyone hitting this: a bare Recheck-request: retests the patch as-is without re-applying, so it reproduces the same bad tree. rebase={branch} is needed.