Skip to contentSkip to conversation

x86/hyperv: reserve more vectors

PATCH In review [email protected] 4 participants 4 messages Jul 30 – Aug 10

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 x86/hyperv: reserve more vectors

From: Wei Liu <[email protected]>

Microsoft Hypervisor delivers three vectors to the NT HAL running in the root partition and refuses to map a device interrupt to any of them when interrupt remapping is not available in the system. As of writing, the nested MSHV setup has no interrupt remapping capability.

The three vectors are:

HAL_NT_APC_VECTOR 0x1F
HAL_NT_DPC_VECTOR 0x2F
HAL_NT_CLOCK_IPI_VECTOR 0xD2

0x1F is below FIRST_EXTERNAL_VECTOR so the vector allocator never hands it out, but 0x2F and 0xD2 are both inside the allocatable range and are handed out once enough vectors are in use. Mapping such an interrupt then fails with HV_STATUS_INVALID_PARAMETER, and the interrupt is never delivered.

Reserve all three next to the hypervisor debug vectors that are already kept out of the allocator's hands.

---
 arch/x86/kernel/cpu/mshyperv.c | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)
arch/x86/kernel/cpu/mshyperv.c +18 -3
index 185d4f677ec0..229c7377a980 100644
@@ -502,17 +502,32 @@ static void hv_reserve_irq_vectors(void)
 	#define HYPERV_DBG_ASSERT_VECTOR	0x2C
 	#define HYPERV_DBG_SERVICE_VECTOR	0x2D
 
+	/*
+	 * The hypervisor delivers these three to the NT HAL and refuses to
+	 * map a device interrupt to any of them.
+	 *
+	 * The hypervisor will provide a hint in the future when these
+	 * vectors become available to use.
+	 */
+	#define HAL_NT_APC_VECTOR		0x1F
+	#define HAL_NT_DPC_VECTOR		0x2F
+	#define HAL_NT_CLOCK_IPI_VECTOR		0xD2
+
 	if (cpu_feature_enabled(X86_FEATURE_FRED))
 		return;
 
 	if (test_and_set_bit(HYPERV_DBG_ASSERT_VECTOR, system_vectors) ||
 	    test_and_set_bit(HYPERV_DBG_SERVICE_VECTOR, system_vectors) ||
-	    test_and_set_bit(HYPERV_DBG_FASTFAIL_VECTOR, system_vectors))
+	    test_and_set_bit(HYPERV_DBG_FASTFAIL_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_APC_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_DPC_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_CLOCK_IPI_VECTOR, system_vectors))
 		BUG();
 
-	pr_info("Hyper-V: reserve vectors: 0x%x 0x%x 0x%x\n",
+	pr_info("Hyper-V: reserve vectors: 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x\n",
 		HYPERV_DBG_ASSERT_VECTOR, HYPERV_DBG_SERVICE_VECTOR,
-		HYPERV_DBG_FASTFAIL_VECTOR);
+		HYPERV_DBG_FASTFAIL_VECTOR, HAL_NT_APC_VECTOR,
+		HAL_NT_DPC_VECTOR, HAL_NT_CLOCK_IPI_VECTOR);
 }
 
 static void __init ms_hyperv_init_platform(void)
Signature · 1 line
2.53.0
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The patch fails to resolve the interrupt mapping failure on systems with X86_FEATURE_FRED enabled because an early return bypasses the newly added vector reservations. --

--- Patch [1]: [PATCH] x86/hyperv: reserve more vectors --- commit b0d2bc1fc2c7327b5574f796990f799e59f429b9
Author: Wei Liu <[email protected]>

x86/hyperv: reserve more vectors

This commit reserves three additional vectors used by the Microsoft Hypervisor to prevent the kernel vector allocator from mapping device interrupts to them when interrupt remapping is unavailable.

Quoted 4 lines
arch/x86/kernel/cpu/mshyperv.c +0 -0
@@ -502,17 +502,32 @@ static void hv_reserve_irq_vectors(void)

[ ... ]

arch/x86/kernel/cpu/mshyperv.c static void hv_reserve_irq_vectors(void) · line 525

Quoted 11 lines
arch/x86/kernel/cpu/mshyperv.c +4 -1
 	if (cpu_feature_enabled(X86_FEATURE_FRED))
 		return;
 
 	if (test_and_set_bit(HYPERV_DBG_ASSERT_VECTOR, system_vectors) ||
 	    test_and_set_bit(HYPERV_DBG_SERVICE_VECTOR, system_vectors) ||
-	    test_and_set_bit(HYPERV_DBG_FASTFAIL_VECTOR, system_vectors))
+	    test_and_set_bit(HYPERV_DBG_FASTFAIL_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_APC_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_DPC_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_CLOCK_IPI_VECTOR, system_vectors))
 		BUG();

[Severity: High]
This is a pre-existing issue, but does placing these new vector reservations after the FRED early return cause them to be bypassed on FRED-enabled hardware?

Since the early return skips updating the system_vectors bitmap, vectors 0x2F and 0xD2 won't be reserved when X86_FEATURE_FRED is enabled.

Because the kernel's dynamic vector allocator still relies on the system_vectors bitmap to avoid assigning device interrupts, won't the allocator still hand these vectors out to drivers on FRED-enabled systems and reproduce the mapping failure?

Quoted 7 lines
arch/x86/kernel/cpu/mshyperv.c +3 -2
-	pr_info("Hyper-V: reserve vectors: 0x%x 0x%x 0x%x\n",
+	pr_info("Hyper-V: reserve vectors: 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x\n",
 		HYPERV_DBG_ASSERT_VECTOR, HYPERV_DBG_SERVICE_VECTOR,
-		HYPERV_DBG_FASTFAIL_VECTOR);
+		HYPERV_DBG_FASTFAIL_VECTOR, HAL_NT_APC_VECTOR,
+		HAL_NT_DPC_VECTOR, HAL_NT_CLOCK_IPI_VECTOR);
 }
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Reviewed-by on v1 1/1
#2 lore raw
In reply to [email protected]

From: [email protected] <[email protected]> Sent: Wednesday, July 29, 2026 5:50 PM

Quoted 4 lines

Microsoft Hypervisor delivers three vectors to the NT HAL running in the root partition and refuses to map a device interrupt to any of them when interrupt remapping is not available in the system. As of writing, the

s/of writing/of this writing/

Quoted 41 lines

nested MSHV setup has no interrupt remapping capability.

The three vectors are:

HAL_NT_APC_VECTOR 0x1F
HAL_NT_DPC_VECTOR 0x2F
HAL_NT_CLOCK_IPI_VECTOR 0xD2

0x1F is below FIRST_EXTERNAL_VECTOR so the vector allocator never hands it out, but 0x2F and 0xD2 are both inside the allocatable range and are handed out once enough vectors are in use. Mapping such an interrupt then fails with HV_STATUS_INVALID_PARAMETER, and the interrupt is never delivered.

Reserve all three next to the hypervisor debug vectors that are already kept out of the allocator's hands.

---
 arch/x86/kernel/cpu/mshyperv.c | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)
arch/x86/kernel/cpu/mshyperv.c +11 -0
index 185d4f677ec0..229c7377a980 100644
@@ -502,17 +502,32 @@ static void hv_reserve_irq_vectors(void)
 	#define HYPERV_DBG_ASSERT_VECTOR	0x2C
 	#define HYPERV_DBG_SERVICE_VECTOR	0x2D
 
+	/*
+	 * The hypervisor delivers these three to the NT HAL and refuses to
+	 * map a device interrupt to any of them.
+	 *
+	 * The hypervisor will provide a hint in the future when these
+	 * vectors become available to use.
+	 */
+	#define HAL_NT_APC_VECTOR		0x1F
+	#define HAL_NT_DPC_VECTOR		0x2F
+	#define HAL_NT_CLOCK_IPI_VECTOR		0xD2
+

arch/x86/kernel/cpu/mshyperv.c static void hv_reserve_irq_vectors(void) · line 524

Quoted 10 lines
arch/x86/kernel/cpu/mshyperv.c +4 -1
 	if (cpu_feature_enabled(X86_FEATURE_FRED))
 		return;
 
 	if (test_and_set_bit(HYPERV_DBG_ASSERT_VECTOR, system_vectors) ||
 	    test_and_set_bit(HYPERV_DBG_SERVICE_VECTOR, system_vectors) ||
-	    test_and_set_bit(HYPERV_DBG_FASTFAIL_VECTOR, system_vectors))
+	    test_and_set_bit(HYPERV_DBG_FASTFAIL_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_APC_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_DPC_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_CLOCK_IPI_VECTOR, system_vectors))

Calling test_and_set_bit() explicitly for each of the 6 vectors seems right on the border of where it would be better to declare a static array with the vectors and loop through the array. The loop could also populate the string to be output in the pr_info() statement below. But leaving it explicit as you have done is probably simpler unless the vector list grows again.

Quoted 14 lines
arch/x86/kernel/cpu/mshyperv.c +3 -3
 		BUG();
 
-	pr_info("Hyper-V: reserve vectors: 0x%x 0x%x 0x%x\n",
+	pr_info("Hyper-V: reserve vectors: 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x\n",
 		HYPERV_DBG_ASSERT_VECTOR, HYPERV_DBG_SERVICE_VECTOR,
-		HYPERV_DBG_FASTFAIL_VECTOR);
+		HYPERV_DBG_FASTFAIL_VECTOR, HAL_NT_APC_VECTOR,
+		HAL_NT_DPC_VECTOR, HAL_NT_CLOCK_IPI_VECTOR);
 }
 
 static void __init ms_hyperv_init_platform(void)
--

2.53.0

#3 lore raw
Quoted 52 lines · Michael Kelley

From: [email protected] <[email protected]> Sent: Wednesday, July 29, 2026 5:50 PM

Quoted 4 lines

Microsoft Hypervisor delivers three vectors to the NT HAL running in the root partition and refuses to map a device interrupt to any of them when interrupt remapping is not available in the system. As of writing, the

s/of writing/of this writing/

Quoted 44 lines

nested MSHV setup has no interrupt remapping capability.

The three vectors are:

   HAL_NT_APC_VECTOR		0x1F
   HAL_NT_DPC_VECTOR		0x2F
   HAL_NT_CLOCK_IPI_VECTOR	0xD2

0x1F is below FIRST_EXTERNAL_VECTOR so the vector allocator never hands it out, but 0x2F and 0xD2 are both inside the allocatable range and are handed out once enough vectors are in use. Mapping such an interrupt then fails with HV_STATUS_INVALID_PARAMETER, and the interrupt is never delivered.

Reserve all three next to the hypervisor debug vectors that are already kept out of the allocator's hands.

---
  arch/x86/kernel/cpu/mshyperv.c | 21 ++++++++++++++++++---
  1 file changed, 18 insertions(+), 3 deletions(-)
arch/x86/kernel/cpu/mshyperv.c +11 -0
index 185d4f677ec0..229c7377a980 100644
@@ -502,17 +502,32 @@ static void hv_reserve_irq_vectors(void)
  	#define HYPERV_DBG_ASSERT_VECTOR	0x2C
  	#define HYPERV_DBG_SERVICE_VECTOR	0x2D
 
+	/*
+	 * The hypervisor delivers these three to the NT HAL and refuses to
+	 * map a device interrupt to any of them.
+	 *
+	 * The hypervisor will provide a hint in the future when these
+	 * vectors become available to use.
+	 */
+	#define HAL_NT_APC_VECTOR		0x1F
+	#define HAL_NT_DPC_VECTOR		0x2F
+	#define HAL_NT_CLOCK_IPI_VECTOR		0xD2
+
  	if (cpu_feature_enabled(X86_FEATURE_FRED))
  		return;
 
Quoted 13 lines

arch/x86/kernel/cpu/mshyperv.c static void hv_reserve_irq_vectors(void) · line 524

Quoted 7 lines
arch/x86/kernel/cpu/mshyperv.c +4 -1
  	if (test_and_set_bit(HYPERV_DBG_ASSERT_VECTOR, system_vectors) ||
  	    test_and_set_bit(HYPERV_DBG_SERVICE_VECTOR, system_vectors) ||
-	    test_and_set_bit(HYPERV_DBG_FASTFAIL_VECTOR, system_vectors))
+	    test_and_set_bit(HYPERV_DBG_FASTFAIL_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_APC_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_DPC_VECTOR, system_vectors) ||
+	    test_and_set_bit(HAL_NT_CLOCK_IPI_VECTOR, system_vectors))

Calling test_and_set_bit() explicitly for each of the 6 vectors seems right on the border of where it would be better to declare a static array with the vectors and loop through the array. The loop could also populate the string to be output in the pr_info() statement below. But leaving it explicit as you have done is probably simpler unless the vector list grows again.

Simpler and better imo, but moreover, we want to discourage the list enlarging, if anything, i hope going forward we can shrink it back to absolutely minimum.

Thanks,
-Mukesh

Quoted 17 lines
Quoted 14 lines
arch/x86/kernel/cpu/mshyperv.c +3 -3
  		BUG();
 
-	pr_info("Hyper-V: reserve vectors: 0x%x 0x%x 0x%x\n",
+	pr_info("Hyper-V: reserve vectors: 0x%x 0x%x 0x%x 0x%x 0x%x 0x%x\n",
  		HYPERV_DBG_ASSERT_VECTOR, HYPERV_DBG_SERVICE_VECTOR,
-		HYPERV_DBG_FASTFAIL_VECTOR);
+		HYPERV_DBG_FASTFAIL_VECTOR, HAL_NT_APC_VECTOR,
+		HAL_NT_DPC_VECTOR, HAL_NT_CLOCK_IPI_VECTOR);
  }
 
  static void __init ms_hyperv_init_platform(void)
--

2.53.0