Skip to contentSkip to conversation

dt-bindings: display: ti: Convert ti,tpd12s015 to DT schema

PATCH In review Eduard Bostina 3 participants 5 messages Jul 30 – Sep 30

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover dt-bindings: display: ti: Convert ti,tpd12s015 to DT schema

This series converts the TI TPD12S015 HDMI level shifter and ESD protection chip binding to DT schema, and fixes two device trees that use it.

Patch 1 is the conversion.
Patch 2 drops the unit addresses from the TPD12S015 encoder and endpoint nodes in am57xx-idk-common.dtsi and am5729-beagleboneai.dts.

Eduard Bostina (2):
dt-bindings: display: ti: Convert ti,tpd12s015 to DT schema
ARM: dts: ti: omap: Fix TPD12S015 node and endpoint names

 .../bindings/display/ti/ti,tpd12s015.txt      | 44 -----------
 .../bindings/display/ti/ti,tpd12s015.yaml     | 78 +++++++++++++++++++
 .../boot/dts/ti/omap/am5729-beagleboneai.dts  |  6 +-
 .../boot/dts/ti/omap/am57xx-idk-common.dtsi   |  6 +-
 4 files changed, 84 insertions(+), 50 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.txt
 create mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml
Signature · 1 line
2.54.0
#1 lore raw

PATCH 1/2 dt-bindings: display: ti: Convert ti,tpd12s015 to DT schema

Convert the Texas Instruments TPD12S015 HDMI level shifter and ESD protection chip bindings to DT schema.

During the conversion, the following updates were made:
- Added the 'ti,tpd12s016' compatible string, which is used in am57xx device trees.
- The 'gpios' property now allows up to 5 items, as the omap5-igep0050 device tree routes additional control pins beyond the standard 3 documented in the old text file.

---
 .../bindings/display/ti/ti,tpd12s015.txt      | 44 -----------
 .../bindings/display/ti/ti,tpd12s015.yaml     | 78 +++++++++++++++++++
 2 files changed, 78 insertions(+), 44 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.txt
 create mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml
Documentation/devicetree/bindings/display/ti/ti,tpd12s015.txt deleted +0 -44
deleted file mode 100644
index 26e6d32e3..000000000
@@ -1,44 +0,0 @@
-TPD12S015 HDMI level shifter and ESD protection chip
-====================================================
-
-Required properties:
-- compatible: "ti,tpd12s015"
-
-Optional properties:
-- gpios: CT CP HPD, LS OE and HPD gpios
-
-Required nodes:
-- Video port 0 for HDMI input
-- Video port 1 for HDMI output
-
-Example
--------
-
-tpd12s015: encoder@1 {
-	compatible = "ti,tpd12s015";
-
-	gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>,	/* 60, CT CP HPD */
-		<&gpio2 9 GPIO_ACTIVE_HIGH>,	/* 41, LS OE */
-		<&gpio2 31 GPIO_ACTIVE_HIGH>;	/* 63, HPD */
-
-	ports {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		port@0 {
-			reg = <0>;
-
-			tpd12s015_in: endpoint@0 {
-				remote-endpoint = <&hdmi_out>;
-			};
-		};
-
-		port@1 {
-			reg = <1>;
-
-			tpd12s015_out: endpoint@0 {
-				remote-endpoint = <&hdmi_connector_in>;
-			};
-		};
-	};
-};
Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml new file +78 -0

78 lines not on this page · raw message

Signature · 1 line
2.54.0
maintainer Reviewed-by on v1 1/2
#2 lore raw
Quoted 10 lines · Eduard Bostina

Convert the Texas Instruments TPD12S015 HDMI level shifter and ESD protection chip bindings to DT schema.

During the conversion, the following updates were made:
- Added the 'ti,tpd12s016' compatible string, which is used in am57xx device trees.
- The 'gpios' property now allows up to 5 items, as the omap5-igep0050 device tree routes additional control pins beyond the standard 3 documented in the old text file.

Quoted 8 lines
---
 .../bindings/display/ti/ti,tpd12s015.txt      | 44 -----------
 .../bindings/display/ti/ti,tpd12s015.yaml     | 78 +++++++++++++++++++
 2 files changed, 78 insertions(+), 44 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.txt
 create mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml
#3 lore raw

Re: [PATCH 1/2] dt-bindings: display: ti: Convert ti, tpd12s015 to DT schema

In reply to Eduard Bostina
Quoted 9 lines · Eduard Bostina

Convert the Texas Instruments TPD12S015 HDMI level shifter and ESD protection chip bindings to DT schema.

During the conversion, the following updates were made:
- Added the 'ti,tpd12s016' compatible string, which is used in am57xx device trees.
- The 'gpios' property now allows up to 5 items, as the omap5-igep0050 device tree routes additional control pins beyond the standard 3 documented in the old text file.

Isn't this an issue in the omap5-igep0050 DT sources, rather than in the binding ?

Quoted 143 lines
---
 .../bindings/display/ti/ti,tpd12s015.txt      | 44 -----------
 .../bindings/display/ti/ti,tpd12s015.yaml     | 78 +++++++++++++++++++
 2 files changed, 78 insertions(+), 44 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.txt
 create mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml
Documentation/devicetree/bindings/display/ti/ti,tpd12s015.txt deleted +0 -44
deleted file mode 100644
index 26e6d32e3..000000000
@@ -1,44 +0,0 @@
-TPD12S015 HDMI level shifter and ESD protection chip
-====================================================
-
-Required properties:
-- compatible: "ti,tpd12s015"
-
-Optional properties:
-- gpios: CT CP HPD, LS OE and HPD gpios
-
-Required nodes:
-- Video port 0 for HDMI input
-- Video port 1 for HDMI output
-
-Example
--------
-
-tpd12s015: encoder@1 {
-	compatible = "ti,tpd12s015";
-
-	gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>,	/* 60, CT CP HPD */
-		<&gpio2 9 GPIO_ACTIVE_HIGH>,	/* 41, LS OE */
-		<&gpio2 31 GPIO_ACTIVE_HIGH>;	/* 63, HPD */
-
-	ports {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		port@0 {
-			reg = <0>;
-
-			tpd12s015_in: endpoint@0 {
-				remote-endpoint = <&hdmi_out>;
-			};
-		};
-
-		port@1 {
-			reg = <1>;
-
-			tpd12s015_out: endpoint@0 {
-				remote-endpoint = <&hdmi_connector_in>;
-			};
-		};
-	};
-};
Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml new file +78 -0
new file mode 100644
index 000000000..bda4bbab7
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/ti/ti,tpd12s015.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments TPD12S015 HDMI level shifter and ESD protection
+
+maintainers:
+  - Eduard Bostina <[email protected]>
+
+properties:
+  compatible:
+    oneOf:
+      - const: ti,tpd12s015
+      - items:
+          - const: ti,tpd12s016
+          - const: ti,tpd12s015
+
+  gpios:
+    minItems: 3
+    maxItems: 5
+    description: CT CP HPD, LS OE, HPD, and optional supplementary control gpios
+
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+
+    properties:
+      port@0:
+        $ref: /schemas/graph.yaml#/properties/port
+        description: Video port for HDMI input
+
+      port@1:
+        $ref: /schemas/graph.yaml#/properties/port
+        description: Video port for HDMI output
+
+    required:
+      - port@0
+      - port@1
+
+required:
+  - compatible
+  - ports
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    encoder {
+        compatible = "ti,tpd12s015";
+
+        gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>, /* 60, CT CP HPD */
+                <&gpio2 9 GPIO_ACTIVE_HIGH>,  /* 41, LS OE */
+                <&gpio2 31 GPIO_ACTIVE_HIGH>; /* 63, HPD */
+
+        ports {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            port@0 {
+                reg = <0>;
+
+                tpd12s015_in: endpoint {
+                    remote-endpoint = <&hdmi_out>;
+                };
+            };
+
+            port@1 {
+                reg = <1>;
+
+                tpd12s015_out: endpoint {
+                    remote-endpoint = <&hdmi_connector_in>;
+                };
+            };
+        };
+    };
Signature · 3 lines
Regards,

Laurent Pinchart
#4 lore raw

PATCH 2/2 ARM: dts: ti: omap: Fix TPD12S015 node and endpoint names

In reply to Eduard Bostina

The TPD12S015 node and its internal endpoint nodes are currently named with unit addresses ('encoder@0', 'endpoint@0') but lack corresponding 'reg' properties.

Remove the unit addresses from these nodes to resolve the warnings and align with the core schemas.

---
 arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts | 6 +++---
 arch/arm/boot/dts/ti/omap/am57xx-idk-common.dtsi  | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts +3 -3
index 46270ed87..1ac9c13dc 100644
@@ -152,7 +152,7 @@ hdmi_connector_in: endpoint {
 		};
 	};
 
-	hdmi_enc: encoder@0 {
+	hdmi_enc: encoder {
 		/* "ti,tpd12s016" software compatible with "ti,tpd12s015"
 		 *  no need for individual driver
 		 */
@@ -168,7 +168,7 @@ ports {
 			port@0 {
 				reg = <0x0>;
 
-				hdmi_encoder_in: endpoint@0 {
+				hdmi_encoder_in: endpoint {
 					remote-endpoint = <&hdmi_out>;
 				};
 			};
@@ -176,7 +176,7 @@ hdmi_encoder_in: endpoint@0 {
 			port@1 {
 				reg = <0x1>;
 
-				hdmi_encoder_out: endpoint@0 {
+				hdmi_encoder_out: endpoint {
 					remote-endpoint = <&hdmi_connector_in>;
 				};
 			};
arch/arm/boot/dts/ti/omap/am57xx-idk-common.dtsi +3 -3
index a2a654ef4..ed8d3eebf 100644
@@ -121,7 +121,7 @@ hdmi_connector_in: endpoint {
 		};
 	};
 
-	tpd12s015: encoder@0 {
+	tpd12s015: encoder {
 		compatible = "ti,tpd12s016", "ti,tpd12s015";
 
 		gpios = <0>, /* optional CT_CP_HPD */
@@ -135,7 +135,7 @@ ports {
 			port@0 {
 				reg = <0>;
 
-				tpd12s015_in: endpoint@0 {
+				tpd12s015_in: endpoint {
 					remote-endpoint = <&hdmi_out>;
 				};
 			};
@@ -143,7 +143,7 @@ tpd12s015_in: endpoint@0 {
 			port@1 {
 				reg = <1>;
 
-				tpd12s015_out: endpoint@0 {
+				tpd12s015_out: endpoint {
 					remote-endpoint = <&hdmi_connector_in>;
 				};
 			};
Signature · 1 line
2.54.0