media: staging/ipu7: fix async notifier UAF on probe error path
Subsystems (3)
PATCH 1/1 media: staging/ipu7: fix async notifier UAF on probe error path
isys_register_devices() registers the V4L2 async notifier via isys_notifier_init(). If a subsequent probe step such as isys_fw_log_init() fails, isys_probe() jumps to the out_cleanup label which only calls isys_unregister_devices(). That helper tears down the video devices, subdevices, V4L2 device and media device, but never unregisters or cleans up the async notifier.
As a result the notifier stays chained in the global notifier_list while the enclosing struct ipu7_isys is freed by devres, leading to list corruption and a use-after-free the next time the list is walked.
The remove path already does the right thing by calling isys_notifier_cleanup() before isys_unregister_devices(). Mirror that on the probe error path so the notifier is unregistered and cleaned up before the device is torn down.
--- drivers/staging/media/ipu7/ipu7-isys.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/media/ipu7/ipu7-isys.c +1 -0
@@ -773,6 +773,7 @@ static int isys_probe(struct auxiliary_device *auxdev,return 0 ; out_cleanup: +isys_notifier_cleanup (isys);isys_unregister_devices (isys); out_cleanup_fw:ipu7_fw_isys_release (isys);
Signature · 1 line
2.25.1