Skip to contentSkip to conversation

ASoC: SOF: Intel: hda-stream: clear hstream->running flag in hw_params

PATCH In review Peter Ujfalusi 2 participants 2 messages Jul 30 – Jul 31

Subsystems (3)
lore
Share & tools
lore

Peter Ujfalusi

author maintainer
#0 lore raw

PATCH 1/1 ASoC: SOF: Intel: hda-stream: clear hstream->running flag in hw_params

During hw_params call we make sure that the host DMA is stopped but the hstream->running flag is not explicitly cleared at the same time.

If the host DMA fails to stop during previous use then the flag is left set and on next start the host DMA will be left disabled since the trigger:STOP will skip the DMA enable.

---
 sound/soc/sof/intel/hda-stream.c | 3 +++
 1 file changed, 3 insertions(+)
sound/soc/sof/intel/hda-stream.c +3 -0
index 0778002e2bd6..c95230487a1b 100644
@@ -613,6 +613,9 @@ int hda_dsp_stream_hw_params(struct snd_sof_dev *sdev,
 		return ret;
 	}
 
+	/* Host DMA is not running */
+	hstream->running = false;
+
 	snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR,
 				sd_offset + SOF_HDA_ADSP_REG_SD_STS,
 				SOF_HDA_CL_DMA_SD_INT_MASK,
Signature · 1 line
2.55.0
maintainer
#1 lore raw
Quoted 1 line · Peter Ujfalusi

ASoC: SOF: Intel: hda-stream: clear hstream->running flag in hw_params

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/1] ASoC: SOF: Intel: hda-stream: clear hstream->running flag in hw_params

      https://git.kernel.org/broonie/sound/c/dc15652b92a8

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark