media: rkvdec: fix v4l2-compliance failure
Subsystems (3)
PATCH 1/1 media: rkvdec: fix v4l2-compliance failure
rkvdec fails v4l2-compliance in two tests related to V4L2_CID_STATELESS_HEVC_SPS. The Control ioctls test reads the control with GET_EXT_CTRLS and writes the same value back; TRY_EXT_CTRLS then returns -EINVAL because the VDPU38x rkvdec_hevc_validate_sps() rejects sps->chroma_format_idc == 0, which is the value returned when the control has no default.
v4l2-compliance 1.33.0-5491, 64 bits, 64-bit time_t
v4l2-compliance SHA: b32589c51481 2026-07-16 08:51:38
Control ioctls:
fail: v4l2-test-controls.cpp(942):
try_ext_ctrls returned an error (22)
test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL
Buffer ioctls:
fail: v4l2-test-buffers.cpp(3102): node->streamon(q.g_type())
fail: v4l2-test-buffers.cpp(3157): testBlockingDQBuf(node, m2m_q)
test blocking wait: FAILProvide a control default via p_def with chroma_format_idc = 1 (4:2:0), which is the only value the VDPU38x SPS validation accepts. This fixes both the Control ioctls and the Buffer ioctls failures.
Tested on Radxa Rock 5B (RK3588).
--- drivers/media/platform/rockchip/rkvdec/rkvdec.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/media/platform/rockchip/rkvdec/rkvdec.c +5 -0
@@ -236,6 +236,10 @@ static const struct rkvdec_ctrls rkvdec_hevc_ctrls = { .num_ctrls = ARRAY_SIZE(rkvdec_hevc_ctrl_descs), }; +static struct v4l2_ctrl_hevc_sps vdpu38x_hevc_sps_default = { + .chroma_format_idc =1 , +}; +static const struct rkvdec_ctrl_desc vdpu38x_hevc_ctrl_descs[] = { { .cfg.id =V4L2_CID_STATELESS_HEVC_DECODE_PARAMS ,
@@ -243,6 +247,7 @@ static const struct rkvdec_ctrl_desc vdpu38x_hevc_ctrl_descs[] = { { .cfg.id = V4L2_CID_STATELESS_HEVC_SPS, .cfg.ops = &rkvdec_ctrl_ops, + .cfg.p_def.p_hevc_sps = &vdpu38x_hevc_sps_default, }, { .cfg.id = V4L2_CID_STATELESS_HEVC_PPS,
Signature · 1 line
2.47.3
Hi,
Le jeudi 30 juillet 2026 à 15:36 +0000, Tharit Tangkijwanichakul a écrit :
Quoted 46 lines
rkvdec fails v4l2-compliance in two tests related to
V4L2_CID_STATELESS_HEVC_SPS. The Control ioctls test reads the control withGET_EXT_CTRLSand writes the same value back;TRY_EXT_CTRLSthen returns-EINVALbecause the VDPU38xrkvdec_hevc_validate_sps()rejectssps->chroma_format_idc== 0, which is the value returned when the control has no default.v4l2-compliance 1.33.0-5491, 64 bits, 64-bit
time_tv4l2-compliance SHA:b32589c514812026-07-16 08:51:38 Control ioctls:
fail: v4l2-test-controls.cpp(942):
try_ext_ctrlsreturned an error (22)
test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL
Buffer ioctls:
fail: v4l2-test-buffers.cpp(3102): node->streamon(q.g_type())
fail: v4l2-test-buffers.cpp(3157):testBlockingDQBuf(node, m2m_q)test blocking wait: FAILProvide a control default via
p_defwithchroma_format_idc= 1 (4:2:0), which is the only value the VDPU38x SPS validation accepts. This fixes both the Control ioctls and the Buffer ioctls failures.Tested on Radxa Rock 5B (RK3588).
Fixes c9a59dc2acc7 ("media: rkvdec: Add HEVC support for the VDPU381 variant")Signed-off-by Tharit Tangkijwanichakul <[email protected]>---
drivers/media/platform/rockchip/rkvdec/rkvdec.c | 5 +++++1 file changed, 5 insertions(+)drivers/media/platform/rockchip/rkvdec/rkvdec.c +0
-0@@ -236,6 +236,10 @@ static const struct rkvdec_ctrls rkvdec_hevc_ctrls = { .num_ctrls = ARRAY_SIZE(rkvdec_hevc_ctrl_descs), };drivers/media/platform/rockchip/rkvdec/rkvdec.c +4
-0+static struct v4l2_ctrl_hevc_sps vdpu38x_hevc_sps_default = { + .chroma_format_idc =1 , +}; +static const struct
rkvdec_ctrl_descvdpu38x_hevc_ctrl_descs[] = { {
.cfg.id =V4L2_CID_STATELESS_HEVC_DECODE_PARAMS,
drivers/media/platform/rockchip/rkvdec/rkvdec.c static const struct rkvdec_ctrl_desc vdpu38x_hevc_ctrl_descs[] = { · line 250
Quoted 4 lines
drivers/media/platform/rockchip/rkvdec/rkvdec.c +1
-0@@ -243,6 +247,7 @@ static const struct rkvdec_ctrl_desc vdpu38x_hevc_ctrl_descs[] = { { .cfg.id = V4L2_CID_STATELESS_HEVC_SPS, .cfg.ops = &rkvdec_ctrl_ops, + .cfg.p_def.p_hevc_sps = &vdpu38x_hevc_sps_default,
Thanks for your patch. Have you considered setting this default in v4l2-common instead ? Monochrome is rarely supported of implemented in codecs, so setting the global default to 4:2:0 seems like it would be valid for all drivers.
Nicolas
Quoted 3 lines
drivers/media/platform/rockchip/rkvdec/rkvdec.c +0
-0}, { .cfg.id = V4L2_CID_STATELESS_HEVC_PPS,
Hi Nicolas,
Thanks for the suggestion.
I moved the default out of rkvdec and into the common V4L2 compound control initialization, making V4L2_CTRL_TYPE_HEVC_SPS default chroma_format_idc to 1 (4:2:0).
I'll send this as v2.
Thanks,
Tharit
Quoted 64 lines · Nicolas Dufresne
Hi,
Quoted 46 lines · Tharit Tangkijwanichakul
rkvdec fails v4l2-compliance in two tests related to
V4L2_CID_STATELESS_HEVC_SPS. The Control ioctls test reads the control withGET_EXT_CTRLSand writes the same value back;TRY_EXT_CTRLSthen returns-EINVALbecause the VDPU38xrkvdec_hevc_validate_sps()rejectssps->chroma_format_idc== 0, which is the value returned when the control has no default.v4l2-compliance 1.33.0-5491, 64 bits, 64-bit time_t v4l2-compliance SHA: b32589c51481 2026-07-16 08:51:38 Control ioctls: fail: v4l2-test-controls.cpp(942): try_ext_ctrls returned an error (22) test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL Buffer ioctls: fail: v4l2-test-buffers.cpp(3102): node->streamon(q.g_type()) fail: v4l2-test-buffers.cpp(3157): testBlockingDQBuf(node, m2m_q) test blocking wait: FAILProvide a control default via
p_defwithchroma_format_idc= 1 (4:2:0), which is the only value the VDPU38x SPS validation accepts. This fixes both the Control ioctls and the Buffer ioctls failures.Tested on Radxa Rock 5B (RK3588).
Fixes c9a59dc2acc7 ("media: rkvdec: Add HEVC support for the VDPU381 variant")Signed-off-by Tharit Tangkijwanichakul <[email protected]>--- drivers/media/platform/rockchip/rkvdec/rkvdec.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/media/platform/rockchip/rkvdec/rkvdec.c +4
-0@@ -236,6 +236,10 @@ static const struct rkvdec_ctrls rkvdec_hevc_ctrls = { .num_ctrls = ARRAY_SIZE(rkvdec_hevc_ctrl_descs), }; +static struct v4l2_ctrl_hevc_sps vdpu38x_hevc_sps_default = { + .chroma_format_idc =1 , +}; +static const struct rkvdec_ctrl_desc vdpu38x_hevc_ctrl_descs[] = { { .cfg.id =V4L2_CID_STATELESS_HEVC_DECODE_PARAMS ,drivers/media/platform/rockchip/rkvdec/rkvdec.c static const struct rkvdec_ctrl_desc vdpu38x_hevc_ctrl_descs[] = { · line 250
Quoted 4 lines
drivers/media/platform/rockchip/rkvdec/rkvdec.c +1
-0@@ -243,6 +247,7 @@ static const struct rkvdec_ctrl_desc vdpu38x_hevc_ctrl_descs[] = { { .cfg.id = V4L2_CID_STATELESS_HEVC_SPS, .cfg.ops = &rkvdec_ctrl_ops, + .cfg.p_def.p_hevc_sps = &vdpu38x_hevc_sps_default,Thanks for your patch. Have you considered setting this default in v4l2-common instead ? Monochrome is rarely supported of implemented in codecs, so setting the global default to 4:2:0 seems like it would be valid for all drivers.
Nicolas
Quoted 3 lines
drivers/media/platform/rockchip/rkvdec/rkvdec.c +0
-0}, { .cfg.id = V4L2_CID_STATELESS_HEVC_PPS,
PATCH v2 1/1 media: v4l2-ctrls: default HEVC SPS chroma format to 4:2:0
In reply to Nicolas DufresneThe default value of a compound control is zero initialized when no explicit default is provided. For V4L2_CTRL_TYPE_HEVC_SPS this results in chroma_format_idc being set to 0, which represents monochrome video.
Most stateless HEVC decoders do not support monochrome video. In particular, the VDPU38x variant of rkvdec fails v4l2-compliance in two tests related to V4L2_CID_STATELESS_HEVC_SPS. The Control ioctls test reads the control with GET_EXT_CTRLS and writes the same value back; TRY_EXT_CTRLS then returns -EINVAL because the VDPU38x rkvdec_hevc_validate_sps() rejects sps->chroma_format_idc == 0.
v4l2-compliance 1.33.0-5491, 64 bits, 64-bit time_t
v4l2-compliance SHA: b32589c51481 2026-07-16 08:51:38
Control ioctls:
fail: v4l2-test-controls.cpp(942):
try_ext_ctrls returned an error (22)
test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL
Buffer ioctls:
fail: v4l2-test-buffers.cpp(3102): node->streamon(q.g_type())
fail: v4l2-test-buffers.cpp(3157): testBlockingDQBuf(node, m2m_q)
test blocking wait: FAILSet the common HEVC SPS compound control default to chroma_format_idc = 1, corresponding to 4:2:0.
---
Changes in v2:
- Move the HEVC SPS default from rkvdec to the common V4L2 control core, as suggested by Nicolas Dufresne.
- Default V4L2_CTRL_TYPE_HEVC_SPS chroma_format_idc to 1 (4:2:0).
drivers/media/v4l2-core/v4l2-ctrls-core.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/media/v4l2-core/v4l2-ctrls-core.c +7 -0
@@ -112,6 +112,7 @@ static void std_init_compound(const struct v4l2_ctrl *ctrl, u32 idx,struct v4l2_ctrl_fwht_params *p_fwht_params;struct v4l2_ctrl_h264_scaling_matrix *p_h264_scaling_matrix;struct v4l2_ctrl_av1_sequence *p_av1_sequence; +struct v4l2_ctrl_hevc_sps *p_hevc_sps;void *p = ptr.p + idx * ctrl->elem_size;if (ctrl->p_def.p_const)
@@ -185,6 +186,12 @@ static void std_init_compound(const struct v4l2_ctrl *ctrl, u32 idx,*/ memset (p_h264_scaling_matrix,16 ,sizeof (*p_h264_scaling_matrix));break ; +case V4L2_CTRL_TYPE_HEVC_SPS : + p_hevc_sps = p; + +/* 4:2:0 */ + p_hevc_sps->chroma_format_idc =1 ; +break ; } }
Signature · 1 line
2.47.3
Re: [PATCH v2] media: v4l2-ctrls: default HEVC SPS chroma format to 4:2:0
Hi,
I haven't received feedback on this patch. Is there anything else I should modify ?
Tharit
Re: [PATCH v2] media: v4l2-ctrls: default HEVC SPS chroma format to 4:2:0
Hi,
Le lundi 24 août 2026 à 20:40 +0700, Tharit Tangkijwanichakul a écrit :
Quoted 4 lines
Hi,
I haven't received feedback on this patch. Is there anything else I should modify ?
Sorry for the delay, hopefully nothing, we'll get to it.
Nicolas
Quoted 2 lines
Tharit