Skip to contentSkip to conversation

hw/i386/pc: xen: reinstate the "xenfv" machine alias

PATCH In review Dario Faggioli 4 participants 4 messages Jul 30 – Aug 15

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/i386/pc: xen: reinstate the "xenfv" machine alias

Commit 7d2778dea32a4924a469f1cc5767042c8f5b4eea ("hw/i386/pc:
Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 machines") removed the Xen machine type that was providing the "xenfv" alias. As a consequence, since the tools are apparently relying on such alias, we're getting this, as soon as one tries to start a Xen (HVM) VM:

qemu-system-i386: unsupported machine type: "xenfv" Use -machine help to list supported machines

Reinstate the alias and let it point to the only Xen machine we still have.

Fixes 7d2778dea3 hw/i386/pc: Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 machines
---
 hw/i386/pc_piix.c | 1 +
 1 file changed, 1 insertion(+)
hw/i386/pc_piix.c +1 -0
index 82457bdb16..0a911ce59e 100644
@@ -658,6 +658,7 @@ static void xenfv_machine_4_2_options(MachineClass *m)
 {
     pc_i440fx_machine_4_2_options(m);
     m->desc = "Xen Fully-virtualized PC";
+    m->alias = "xenfv";
     m->max_cpus = HVM_MAX_VCPUS;
     m->default_machine_opts = "accel=xen,suppress-vmdesc=on";
 }
Signature · 1 line
2.55.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Dario Faggioli

Commit 7d2778dea32a4924a469f1cc5767042c8f5b4eea ("hw/i386/pc:
Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 machines") removed the Xen machine type that was providing the "xenfv" alias. As a consequence, since the tools are apparently relying on such alias, we're getting this, as soon as one tries to start a Xen (HVM) VM:

qemu-system-i386: unsupported machine type: "xenfv" Use -machine help to list supported machines

Quoted 8 lines

Reinstate the alias and let it point to the only Xen machine we still have.

Fixes 7d2778dea3 hw/i386/pc: Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 machines
---
 hw/i386/pc_piix.c | 1 +
 1 file changed, 1 insertion(+)

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|
#2 lore raw
Quoted 13 lines · Daniel P. Berrangé
Quoted 12 lines · Dario Faggioli

Commit 7d2778dea32a4924a469f1cc5767042c8f5b4eea ("hw/i386/pc:
Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 machines") removed the Xen machine type that was providing the "xenfv" alias. As a consequence, since the tools are apparently relying on such alias, we're getting this, as soon as one tries to start a Xen (HVM) VM:

qemu-system-i386: unsupported machine type: "xenfv" Use -machine help to list supported machines

Reinstate the alias and let it point to the only Xen machine we still have.

Quoted 7 lines
Quoted 5 lines
Fixes 7d2778dea3 hw/i386/pc: Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 machines
---
 hw/i386/pc_piix.c | 1 +
 1 file changed, 1 insertion(+)
Reviewed-by on v1 1/1
#3 lore raw
In reply to Dario Faggioli
Quoted 23 lines · Dario Faggioli

Commit 7d2778dea32a4924a469f1cc5767042c8f5b4eea ("hw/i386/pc:
Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 machines") removed the Xen machine type that was providing the "xenfv" alias. As a consequence, since the tools are apparently relying on such alias, we're getting this, as soon as one tries to start a Xen (HVM) VM:

qemu-system-i386: unsupported machine type: "xenfv" Use -machine help to list supported machines

Reinstate the alias and let it point to the only Xen machine we still have.

Fixes 7d2778dea3 hw/i386/pc: Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 machines
---
  hw/i386/pc_piix.c | 1 +
  1 file changed, 1 insertion(+)
hw/i386/pc_piix.c +0 -0
index 82457bdb16..0a911ce59e 100644

hw/i386/pc_piix.c static void xenfv_machine_4_2_options(MachineClass *m) · line 664

Quoted 7 lines
hw/i386/pc_piix.c +1 -0
@@ -658,6 +658,7 @@ static void xenfv_machine_4_2_options(MachineClass *m)
  {
      pc_i440fx_machine_4_2_options(m);
      m->desc = "Xen Fully-virtualized PC";
+    m->alias = "xenfv";
      m->max_cpus = HVM_MAX_VCPUS;
      m->default_machine_opts = "accel=xen,suppress-vmdesc=on";
  }

Oops.

Queued adding the @stable tag for backport.