mm: zswap: drop list_lru param from zswap_lru_add() and _del()
Subsystems (2)
PATCH 1/1 mm: zswap: drop list_lru param from zswap_lru_add() and _del()
Since zswap_lru_add() and zswap_lru_del() are only called with the global zswap_list_lru, remove the redundant list_lru argument and use zswap_list_lru directly.
--- mm/zswap.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
mm/zswap.c +6 -6
@@ -665,7 +665,7 @@ static inline int entry_to_nid(struct zswap_entry *entry)return page_to_nid (virt_to_page (entry)); } -static void zswap_lru_add (struct list_lru *list_lru,struct zswap_entry *entry) +static void zswap_lru_add (struct zswap_entry *entry) {int nid =entry_to_nid (entry);struct mem_cgroup *memcg;
@@ -684,11 +684,11 @@ static void zswap_lru_add(struct list_lru *list_lru, struct zswap_entry *entry)rcu_read_lock (); memcg =mem_cgroup_from_entry (entry);/* will always succeed */ -list_lru_add (list_lru, &entry->lru, nid, memcg); +list_lru_add (&zswap_list_lru, &entry->lru, nid, memcg);rcu_read_unlock (); } -static void zswap_lru_del (struct list_lru *list_lru,struct zswap_entry *entry) +static void zswap_lru_del (struct zswap_entry *entry) {int nid =entry_to_nid (entry);struct mem_cgroup *memcg;
@@ -696,7 +696,7 @@ static void zswap_lru_del(struct list_lru *list_lru, struct zswap_entry *entry)rcu_read_lock (); memcg =mem_cgroup_from_entry (entry);/* will always succeed */ -list_lru_del (list_lru, &entry->lru, nid, memcg); +list_lru_del (&zswap_list_lru, &entry->lru, nid, memcg);rcu_read_unlock (); }
@@ -764,7 +764,7 @@ static void zswap_entry_cache_free(struct zswap_entry *entry)*/ static void zswap_entry_free (struct zswap_entry *entry) { -zswap_lru_del (&zswap_list_lru, entry); +zswap_lru_del (entry);zs_free (entry->pool->zs_pool, entry->handle);zswap_pool_put (entry->pool);if (entry->objcg) {
@@ -1461,7 +1461,7 @@ static bool zswap_store_page(struct page *page, entry->referenced = true;if (entry->length) {INIT_LIST_HEAD (&entry->lru); -zswap_lru_add (&zswap_list_lru, entry); +zswap_lru_add (entry); }return true;
Signature · 1 line
2.55.0.508.g3f0d502094-goog
Quoted 5 lines · Wilson Felipe Pereira
Since
zswap_lru_add()andzswap_lru_del()are only called with the globalzswap_list_lru, remove the redundantlist_lruargument and usezswap_list_lrudirectly.Signed-off-by Wilson Felipe Pereira <[email protected]>
Quoted 6 lines · Wilson Felipe Pereira
Since
zswap_lru_add()andzswap_lru_del()are only called with the globalzswap_list_lru, remove the redundantlist_lruargument and usezswap_list_lrudirectly.Signed-off-by Wilson Felipe Pereira <[email protected]>
Quoted 3 lines · On Fri, 31 Jul 2026 05:37:06 +0000 Wilson Felipe Pereira <[email protected]>…
Since
zswap_lru_add()andzswap_lru_del()are only called with the globalzswap_list_lru, remove the redundantlist_lruargument and usezswap_list_lrudirectly.
Looks good and making sense to me.
Quoted 2 lines
Signed-off-by Wilson Felipe Pereira <[email protected]>
Thanks,
SJ
[...]
Quoted 6 lines · Wilson Felipe Pereira
Since
zswap_lru_add()andzswap_lru_del()are only called with the globalzswap_list_lru, remove the redundantlist_lruargument and usezswap_list_lrudirectly.Signed-off-by Wilson Felipe Pereira <[email protected]>
Beats me to it :) Thanks for fixing this!