Skip to contentSkip to conversation

selftests/net: gro: use variable sleep to handle slow environments

PATCH New Brian Grech 1 participant 1 message Jul 31

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/net: gro: use variable sleep to handle slow environments

The server socket initialization sleep was hardcoded at 0.5 seconds. On slow or heavily loaded machines this is insufficient, causing the client to connect before the server is ready and producing spurious test failures.

Respect KSFT_MACHINE_SLOW by extending the sleep to 2 seconds when set, consistent with how other selftests handle slow environments.

---
 tools/testing/selftests/net/gro.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tools/testing/selftests/net/gro.sh +3 -1
index 4c5144c6f652..7c0e4434fa58 100755
@@ -21,12 +21,14 @@ run_test() {
   # Each test is run 6 times to deflake, because given the receive timing,
   # not all packets that should coalesce will be considered in the same flow
   # on every try.
+  local sleep_time=0.5
+  [ "$KSFT_MACHINE_SLOW" = yes ] && sleep_time=2
   for tries in {1..6}; do
     # Actual test starts here
     ip netns exec $server_ns ./gro "${ARGS[@]}" "--rx" "--iface" "server" \
       1>>log.txt &
     server_pid=$!
-    sleep 0.5  # to allow for socket init
+    sleep $sleep_time  # to allow for socket init
     ip netns exec $client_ns ./gro "${ARGS[@]}" "--iface" "client" \
       1>>log.txt
     wait "${server_pid}"
Signature · 1 line
2.55.0