Skip to contentSkip to conversation

arm64: dts: qcom: sm7325-nothing-spacewar: Add ath11k calibration-variant

PATCH Applied Danila Tikhonov 3 participants 5 messages Aug 2 – Aug 31

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sm7325-nothing-spacewar: Add ath11k calibration-variant

The Nothing Phone (1) has its own calibration files for the WCN6750 used with the ath11k driver. Add the calibration variant name to the DTS so that the appropriate calibration files can be loaded from linux-firmware.

Nothing capitalizes its codenames, so the capitalization is intentional.

---
 arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts +2 -0
index 1e78a42062c7..85811b5de4af 100644
@@ -1546,5 +1546,7 @@ &venus {
 };
 
 &wifi {
+	qcom,calibration-variant = "Nothing_Spacewar";
+
 	status = "okay";
 };
Signature · 1 line
2.55.0
#1 lore raw
Quoted 17 lines · Danila Tikhonov

The Nothing Phone (1) has its own calibration files for the WCN6750 used with the ath11k driver. Add the calibration variant name to the DTS so that the appropriate calibration files can be loaded from linux-firmware.

Nothing capitalizes its codenames, so the capitalization is intentional.

---
 arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts +0 -0
index 1e78a42062c7..85811b5de4af 100644

arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts &venus { · line 1549

Quoted 4 lines
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts +1 -0
@@ -1546,5 +1546,7 @@ &venus {
 };
 
 &wifi {
+	qcom,calibration-variant = "Nothing_Spacewar";

Have you submitted that variant to the atheros mailing list?

Konrad

#2 lore raw

Hello Konrad,

Thank you for your message.

Quoted 20 lines · Konrad Dybcio
Quoted 19 lines · Danila Tikhonov

The Nothing Phone (1) has its own calibration files for the WCN6750 used with the ath11k driver. Add the calibration variant name to the DTS so that the appropriate calibration files can be loaded from linux-firmware.

Nothing capitalizes its codenames, so the capitalization is intentional.

---
  arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts | 2 ++
  1 file changed, 2 insertions(+)
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts +0 -0
index 1e78a42062c7..85811b5de4af 100644
@@ -1546,5 +1546,7 @@ &venus {
  };
 
Quoted 3 lines

arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts &venus { · line 1549

Quoted 2 lines
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts +1 -0
  &wifi {
+	qcom,calibration-variant = "Nothing_Spacewar";

Have you submitted that variant to the atheros mailing list?

I just did it and sent you a copy of the letter:
https://lore.kernel.org/all/[email protected]

Quoted 1 line

Konrad

Signature · 2 lines
Best regards,
Danila
Reviewed-by
#3 lore raw
Quoted 29 lines · Danila Tikhonov

Hello Konrad,

Thank you for your message.

Quoted 13 lines · Konrad Dybcio
Quoted 12 lines · Danila Tikhonov

The Nothing Phone (1) has its own calibration files for the WCN6750 used with the ath11k driver. Add the calibration variant name to the DTS so that the appropriate calibration files can be loaded from linux-firmware.

Nothing capitalizes its codenames, so the capitalization is intentional.

---
  arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts | 2 ++

  1 file changed, 2 insertions(+)
Quoted 9 lines

arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts &venus { · line 1548

Quoted 8 lines
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts +1 -0
index 1e78a42062c7..85811b5de4af 100644
@@ -1546,5 +1546,7 @@ &venus {
   };
     &wifi {
+    qcom,calibration-variant = "Nothing_Spacewar";

Have you submitted that variant to the atheros mailing list?

Quoted 2 lines

I just did it and sent you a copy of the letter:
https://lore.kernel.org/all/[email protected]

Thanks

Konrad

maintainer Applied
#4 lore raw
In reply to Danila Tikhonov
Quoted 8 lines · Danila Tikhonov

The Nothing Phone (1) has its own calibration files for the WCN6750 used with the ath11k driver. Add the calibration variant name to the DTS so that the appropriate calibration files can be loaded from linux-firmware.

Nothing capitalizes its codenames, so the capitalization is intentional.

[...]

Applied, thanks!

[1/1] arm64: dts: qcom: sm7325-nothing-spacewar: Add ath11k calibration-variant

      commit: 5be53952fda81a465fbd5fd564b04f38b4a62243

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>