dt-bindings: net: add nvmem-consumer reference to network-class
Subsystems (4)
PATCH 1/1 dt-bindings: net: add nvmem-consumer reference to network-class
The nvmem-cells and nvmem-cell-names properties are used to supply MAC addresses to both wired and wireless network controllers. The wired hierarchy already allows them through ethernet-controller.yaml, but the wireless hierarchy (wireless-controller.yaml -> network-class.yaml) does not. As a result, brcm,bcm4329-fmac nodes using nvmem (e.g. bcm4709-linksys-ea9200.dts) failed dtbs_check with:
Unevaluated properties are not allowed ('nvmem-cell-names', 'nvmem-cells' were unexpected)
Each wireless driver otherwise has to add the nvmem-consumer reference individually (qca,ath9k and mediatek,mt76 already declare their own nvmem-cells/nvmem-cell-names).
Add the nvmem-consumer reference to network-class.yaml so all network nodes inherit the properties at once. Wired controllers keep the tighter single-cell, mac-address-only constraints via ethernet-controller.yaml, which still apply alongside the relaxed class-level properties.
--- Documentation/devicetree/bindings/net/network-class.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/net/network-class.yaml +3 -0
@@ -43,4 +43,7 @@ properties: maximum frame size (there\'s contradiction in the Devicetree Specification). +allOf: + - $ref: /schemas/nvmem/nvmem-consumer.yaml# + additionalProperties: true
Signature · 1 line
2.55.0
Rob Herring
maintainerQuoted 30 lines · Rosen Penev
The nvmem-cells and nvmem-cell-names properties are used to supply MAC addresses to both wired and wireless network controllers. The wired hierarchy already allows them through
ethernet-controller.yaml, but the wireless hierarchy (wireless-controller.yaml->network-class.yaml) does not. As a result, brcm,bcm4329-fmac nodes using nvmem (e.g.bcm4709-linksys-ea9200.dts) faileddtbs_checkwith:Unevaluated properties are not allowed ('nvmem-cell-names', 'nvmem-cells' were unexpected)
Each wireless driver otherwise has to add the nvmem-consumer reference individually (qca,ath9k and mediatek,mt76 already declare their own nvmem-cells/nvmem-cell-names).
Add the nvmem-consumer reference to
network-class.yamlso all network nodes inherit the properties at once. Wired controllers keep the tighter single-cell, mac-address-only constraints viaethernet-controller.yaml, which still apply alongside the relaxed class-level properties.Assisted-by opencode:big-pickleSigned-off-by Rosen Penev <[email protected]>--- Documentation/devicetree/bindings/net/network-class.yaml | 3 +++ 1 file changed, 3 insertions(+)Documentation/devicetree/bindings/net/network-class.yaml +0
-0
Documentation/devicetree/bindings/net/network-class.yaml properties: · line 47
Quoted 5 lines
Documentation/devicetree/bindings/net/network-class.yaml +2
-0@@ -43,4 +43,7 @@ properties: maximum frame size (there\'s contradiction in the Devicetree Specification). +allOf: + - $ref: /schemas/nvmem/nvmem-consumer.yaml#
This is not correct as I explained in the prior patch.
Rob