Skip to contentSkip to conversation

tty: remove the ipwireless driver

PATCH In review Qingfang Deng 4 participants 4 messages Aug 3 – Aug 5

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tty: remove the ipwireless driver

The last mentions of this driver on local Linux and telco support forums date back to 2011. This does not prove that no users remain, but the likelihood is too low to justify continuing to carry the driver in the kernel.

The maintainer agreed that the driver should be removed and noted that it is simple enough to build as an external module if a user resurfaces [1].

Remove the driver along with its Kconfig, defconfig, build and MAINTAINERS entries.

[1] https://lore.kernel.org/linux-serial/[email protected]/

Assisted-by Codex:GPT-5.6
---
 MAINTAINERS                             |    6 -
 arch/powerpc/configs/ppc6xx_defconfig   |    1 -
 drivers/tty/Kconfig                     |    9 -
 drivers/tty/Makefile                    |    2 -
 drivers/tty/ipwireless/Makefile         |    9 -
 drivers/tty/ipwireless/hardware.c       | 1770 -----------------------
 drivers/tty/ipwireless/hardware.h       |   63 -
 drivers/tty/ipwireless/main.c           |  356 -----
 drivers/tty/ipwireless/main.h           |   66 -
 drivers/tty/ipwireless/network.c        |  517 -------
 drivers/tty/ipwireless/network.h        |   54 -
 drivers/tty/ipwireless/setup_protocol.h |  109 --
 drivers/tty/ipwireless/tty.c            |  627 --------
 drivers/tty/ipwireless/tty.h            |   46 -
 14 files changed, 3635 deletions(-)
 delete mode 100644 drivers/tty/ipwireless/Makefile
 delete mode 100644 drivers/tty/ipwireless/hardware.c
 delete mode 100644 drivers/tty/ipwireless/hardware.h
 delete mode 100644 drivers/tty/ipwireless/main.c
 delete mode 100644 drivers/tty/ipwireless/main.h
 delete mode 100644 drivers/tty/ipwireless/network.c
 delete mode 100644 drivers/tty/ipwireless/network.h
 delete mode 100644 drivers/tty/ipwireless/setup_protocol.h
 delete mode 100644 drivers/tty/ipwireless/tty.c
 delete mode 100644 drivers/tty/ipwireless/tty.h
MAINTAINERS +0 -6
index 716acfc3d7c1..ce74c0fe88ff 100644
@@ -13699,12 +13699,6 @@ F:	include/net/ip_vs.h
 F:	include/uapi/linux/ip_vs.h
 F:	net/netfilter/ipvs/
 
-IPWIRELESS DRIVER
-M:	Jiri Kosina <[email protected]>
-M:	David Sterba <[email protected]>
-S:	Odd Fixes
-F:	drivers/tty/ipwireless/
-
 IRON DEVICE AUDIO CODEC DRIVERS
 M:	Kiseok Jo <[email protected]>
 L:	[email protected]
arch/powerpc/configs/ppc6xx_defconfig +0 -1
index 06e3cc55cb0d..eb0e76da151d 100644
@@ -572,7 +572,6 @@ CONFIG_PPDEV=m
 CONFIG_HW_RANDOM=y
 CONFIG_HW_RANDOM_VIRTIO=m
 CONFIG_NVRAM=y
-CONFIG_IPWIRELESS=m
 CONFIG_I2C_CHARDEV=m
 CONFIG_I2C_HYDRA=m
 CONFIG_I2C_MPC=m
drivers/tty/Kconfig +0 -9
index df6832a4c237..5d6b0dd4d423 100644
@@ -291,15 +291,6 @@ config GOLDFISH_TTY_EARLY_CONSOLE
 	default y if GOLDFISH_TTY=y
 	select SERIAL_EARLYCON
 
-config IPWIRELESS
-	tristate "IPWireless 3G UMTS PCMCIA card support"
-	depends on PCMCIA && NETDEVICES && HAS_IOPORT
-	select PPP
-	help
-	  This is a driver for 3G UMTS PCMCIA card from IPWireless company. In
-	  some countries (for example Czech Republic, T-Mobile ISP) this card
-	  is shipped for service called UMTS 4G.
-
 config N_GSM
 	tristate "GSM MUX line discipline support (EXPERIMENTAL)"
 	depends on NET
drivers/tty/Makefile +0 -2
index 8ca1a0a2229f..c6a063a541fd 100644
@@ -26,5 +26,3 @@ obj-$(CONFIG_GOLDFISH_TTY)	+= goldfish.o
 obj-$(CONFIG_MIPS_EJTAG_FDC_TTY) += mips_ejtag_fdc.o
 obj-$(CONFIG_VCC)		+= vcc.o
 obj-$(CONFIG_RPMSG_TTY)		+= rpmsg_tty.o
-
-obj-y += ipwireless/
drivers/tty/ipwireless/Makefile deleted +0 -9
deleted file mode 100644
index a665d021e24d..000000000000
@@ -1,9 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-#
-# Makefile for the IPWireless driver
-#
-
-obj-$(CONFIG_IPWIRELESS) += ipwireless.o
-
-ipwireless-y := hardware.o main.o network.o tty.o
-
drivers/tty/ipwireless/hardware.c deleted +0 -1770

1,770 lines not on this page · raw message

drivers/tty/ipwireless/hardware.h deleted +0 -63

63 lines not on this page · raw message

drivers/tty/ipwireless/main.c deleted +0 -356

356 lines not on this page · raw message

drivers/tty/ipwireless/main.h deleted +0 -66

66 lines not on this page · raw message

drivers/tty/ipwireless/network.c deleted +0 -517

517 lines not on this page · raw message

drivers/tty/ipwireless/network.h deleted +0 -54

54 lines not on this page · raw message

drivers/tty/ipwireless/setup_protocol.h deleted +0 -109

109 lines not on this page · raw message

drivers/tty/ipwireless/tty.c deleted +0 -627

17 lines not on this page · raw message

drivers/tty/ipwireless/tty.h deleted +0 -46

46 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.43.0

Part of the diff is not shown here. View the raw message.

Reviewed-by Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Qingfang Deng

The last mentions of this driver on local Linux and telco support forums date back to 2011. This does not prove that no users remain, but the likelihood is too low to justify continuing to carry the driver in the kernel.

The maintainer agreed that the driver should be removed and noted that it is simple enough to build as an external module if a user resurfaces [1].

Quoted 7 lines

Remove the driver along with its Kconfig, defconfig, build and MAINTAINERS entries.

[1] https://lore.kernel.org/linux-serial/[email protected]/

Assisted-by Codex:GPT-5.6

This is not for stable trees.

Quoted 1 line
maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Qingfang Deng
Quoted 10 lines · Qingfang Deng

The last mentions of this driver on local Linux and telco support forums date back to 2011. This does not prove that no users remain, but the likelihood is too low to justify continuing to carry the driver in the kernel.

The maintainer agreed that the driver should be removed and noted that it is simple enough to build as an external module if a user resurfaces [1].

Remove the driver along with its Kconfig, defconfig, build and MAINTAINERS entries.

<nostalgy>This was the first large tty driver I reviewed.</nostalgy>

thanks,

Signature · 2 lines
js
suse labs