nvmet: fix NULL pointer dereference in nvmet_execute_identify_ns_zns()
Subsystems (2)
PATCH 1/1 nvmet: fix NULL pointer dereference in nvmet_execute_identify_ns_zns()
When a host issues an Identify command with CNS 05h (I/O Command Set specific Identify Namespace) and CSI 02h (ZNS) targeting a file-backed namespace, nvmet_execute_identify_ns_zns() calls bdev_is_zoned() on req->ns->bdev. A file-backed namespace has no block device, so req->ns->bdev is NULL and bdev_is_zoned() dereferences it, oopsing.
The I/O command set is selected by the host-supplied CSI field and the command is routed here whenever CONFIG_BLK_DEV_ZONED is enabled, independent of the namespace backing type, so any file-backed namespace is exposed.
Reject the command with Invalid Field when the namespace is not backed by a block device.
--- drivers/nvme/target/zns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/zns.c +1 -1
@@ -116,7 +116,7 @@ void nvmet_execute_identify_ns_zns(struct nvmet_req *req)mutex_unlock (&req->ns->subsys->lock); } -if (!bdev_is_zoned (req->ns->bdev)) { +if (!req->ns->bdev || !bdev_is_zoned (req->ns->bdev)) { status =NVME_SC_INVALID_FIELD |NVME_STATUS_DNR ; req->error_loc = offsetof(struct nvme_identify , nsid); goto out;
Signature · 1 line
2.43.7
Quoted 11 lines · Guixin Liu
When a host issues an Identify command with CNS 05h (I/O Command Set specific Identify Namespace) and CSI 02h (ZNS) targeting a file-backed namespace,
nvmet_execute_identify_ns_zns()callsbdev_is_zoned()onreq->ns->bdev. A file-backed namespace has no block device, soreq->ns->bdevis NULL andbdev_is_zoned()dereferences it, oopsing.The I/O command set is selected by the host-supplied CSI field and the command is routed here whenever
CONFIG_BLK_DEV_ZONEDis enabled, independent of the namespace backing type, so any file-backed namespace is exposed.
Quoted 5 lines
Reject the command with Invalid Field when the namespace is not backed by a block device.
Fixes aaf2e048af27 ("nvmet: add ZBD over ZNS backend support")Signed-off-by Guixin Liu <[email protected]>
Looks good to me.
Signature · 2 lines
Damien Le Moal Western Digital Research
Looks good:
Quoted 5 lines · Guixin Liu
When a host issues an Identify command with CNS 05h (I/O Command Set specific Identify Namespace) and CSI 02h (ZNS) targeting a file-backed namespace,
nvmet_execute_identify_ns_zns()callsbdev_is_zoned()onreq->ns->bdev. A file-backed namespace has no block device, soreq->ns->bdevis NULL andbdev_is_zoned()dereferences it, oopsing.
Thanks, applied to nvme-7.3.