Skip to contentSkip to conversation

Fix MAPML calculation in ap bus code

PATCH Superseded Finn Callies 3 participants 5 messages Aug 4

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Fix MAPML calculation in ap bus code

Pretty self explanatory...

====== CHANGELOG ======

v1:
initial version

Finn Callies (1):
s390/ap: Fix MAPML computation

 drivers/s390/crypto/ap_card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 2 lines
Finn Callies <[email protected]>
Linux on Z - crypto
#1 lore raw

PATCH 1/1 s390/ap: Fix MAPML computation

When the TAPQ subfunction of PQAP returns a value between 0 and 3 in the ml field the Principles of Operation states that the MAPML size is to be 12k bytes.

---
 drivers/s390/crypto/ap_card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/crypto/ap_card.c +1 -1
index e827fbeb76fb..c86397f4ddcd 100644
@@ -241,7 +241,7 @@ struct ap_card *ap_card_create(int id, struct ap_tapq_hwinfo hwinfo,
 	ac->ap_dev.device_type = comp_type;
 	ac->hwinfo = hwinfo;
 	ac->id = id;
-	ac->maxmsgsize = hwinfo.ml > 0 ?
+	ac->maxmsgsize = hwinfo.ml > 3 ?
 		hwinfo.ml * AP_TAPQ_ML_FIELD_CHUNK_SIZE : AP_DEFAULT_MAX_MSG_SIZE;
 
 	return ac;
Signature · 2 lines
Finn Callies <[email protected]>
Linux on Z - crypto
#2 lore raw

Re: [PATCH v1 1/1] s390/ap: Fix MAPML computation

Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines

When the TAPQ subfunction of PQAP returns a value between 0 and 3 in the ml field the Principles of Operation states that the MAPML size is to be 12k bytes.

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
maintainer
#3 lore raw

Re: [PATCH v1 1/1] s390/ap: Fix MAPML computation

In reply to Finn Callies
Quoted 3 lines · Finn Callies

When the TAPQ subfunction of PQAP returns a value between 0 and 3 in the ml field the Principles of Operation states that the MAPML size is to be 12k bytes.

What is "MAPML"?

Quoted 5 lines
---
 drivers/s390/crypto/ap_card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Why is this fix required? What does this fix? Are there user observable bugs fixed with this? If so, which ones?
Is a Fixes: and/or stable tag required?

maintainer
#4 lore raw
In reply to Finn Callies
Quoted 6 lines · Finn Callies

Pretty self explanatory...

====== CHANGELOG ======

v1:
initial version

You don't need to provide a cover-letter for a single patch, however if you provide a cover-letter, then please provide meaningful text.

"Pretty self explanatory..." is not helpful at all.