staging: greybus: Align wrapped function parameter
Subsystems (3)
PATCH 1/1 staging: greybus: Align wrapped function parameter
Align the wrapped function parameter declaration with the kernel coding style to improve readability.
Signed-off-by Pedro Amorim <[email protected]>
--- drivers/staging/greybus/loopback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/loopback.c +1 -1
@@ -589,7 +589,7 @@ static int gb_loopback_async_sink(struct gb_loopback *gb, u32 len) }static int gb_loopback_async_transfer_complete ( -struct gb_loopback_async_operation *op_async) +struct gb_loopback_async_operation *op_async) {struct gb_loopback *gb;struct gb_operation *operation;
Signature · 1 line
2.55.0
Greg KH
maintainerQuoted 2 lines · Pedro Amorim
Align the wrapped function parameter declaration with the kernel coding style to improve readability.
Ok, but:
Quoted 11 lines
Signed-off-by Pedro Amorim <[email protected]>--- drivers/staging/greybus/loopback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/greybus/loopback.c +0
-0
drivers/staging/greybus/loopback.c static int gb_loopback_async_sink(struct gb_loopback *gb, u32 len) · line 592
Quoted 5 lines
drivers/staging/greybus/loopback.c +1
-1@@ -589,7 +589,7 @@ static int gb_loopback_async_sink(struct gb_loopback *gb, u32 len) }static int gb_loopback_async_transfer_complete ( -struct gb_loopback_async_operation *op_async) +struct gb_loopback_async_operation *op_async)
You didn't align it here :(
PATCH v2 1/1 staging: greybus: fix checkpatch alignment warnings in loopback.c
Fix two alignment warnings reported by checkpatch.pl: the wrapped function declaration for gb_loopback_async_transfer_complete(), and the continuation line in the gb_operation_response_alloc() call.
Signed-off-by Pedro Amorim <[email protected]>
---
v2: Fix remaining checkpatch alignment warnings in the file
drivers/staging/greybus/loopback.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/greybus/loopback.c +2 -3
@@ -588,8 +588,7 @@ static int gb_loopback_async_sink(struct gb_loopback *gb, u32 len)return retval; } -static int gb_loopback_async_transfer_complete ( -struct gb_loopback_async_operation *op_async) +static int gb_loopback_async_transfer_complete (struct gb_loopback_async_operation *op_async) {struct gb_loopback *gb;struct gb_operation *operation;
@@ -679,7 +678,7 @@ static int gb_loopback_request_handler(struct gb_operation *operation) }if (!gb_operation_response_alloc (operation, - len +sizeof (*response),GFP_KERNEL )) { + len +sizeof (*response),GFP_KERNEL )) {dev_err (dev,"error allocating response\n" );return -ENOMEM ; }
Signature · 1 line
2.55.0