Skip to contentSkip to conversation

libgit2: set correct homepage URL

PATCH In review Ross Burton 2 participants 4 messages Aug 4 – Sep 7 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 libgit2: set correct homepage URL

libgit2.github.com no longer resolves, the homepage is now libgit2.org.

---
 meta/recipes-support/libgit2/libgit2_1.9.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/libgit2/libgit2_1.9.4.bb +1 -1
index 999ad6b05c8..6b01ab28c78 100644
@@ -1,5 +1,5 @@
 SUMMARY = "the Git linkable library"
-HOMEPAGE = "http://libgit2.github.com/"
+HOMEPAGE = "https://libgit2.org/"
 LICENSE = "GPL-2.0-only WITH GCC-exception-2.0 AND MIT AND OpenSSL AND BSD-3-Clause AND Zlib AND ISC AND LGPL-2.1-or-later AND CC0-1.0 AND BSD-2-Clause"
 LIC_FILES_CHKSUM = "file://COPYING;md5=8eacfdc17c8f4d219e131a073973b97d"
 
Signature · 1 line
2.43.0
#1 lore raw

PATCH 2/2 libjpeg-turbo: use system zlib instead of bundled copy

The libjpegturbo library bundles a copy of libspng which in turn bundles a copy of zlib. We don't currently have a libspng recipe but we can stop it bundling zlib.

---
 meta/recipes-graphics/jpeg/libjpeg-turbo_3.2.0.bb | 3 +++
 1 file changed, 3 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_3.2.0.bb +3 -0
index 89504419762..7a548d4e9c6 100644
@@ -5,6 +5,7 @@ HOMEPAGE = "http://libjpeg-turbo.org/"
 LICENSE = "BSD-3-Clause AND IJG AND Zlib"
 LIC_FILES_CHKSUM = "file://LICENSE.md;md5=d21daef3b4b318f77062055059c72934"
 
+DEPENDS = "zlib"
 DEPENDS:append:x86-64:class-target = " nasm-native"
 DEPENDS:append:x86:class-target = " nasm-native"
 
@@ -28,6 +29,8 @@ export NASMENV = "--reproducible --debug-prefix-map=${WORKDIR}=${TARGET_DBGSRC_D
 EXTRA_OECMAKE += "-DCMAKE_SKIP_INSTALL_RPATH=ON"
 # Ensure the -fPIC options are used to avoid -native compile failures, e.g. on opensuse160
 EXTRA_OECMAKE += "-DCMAKE_POSITION_INDEPENDENT_CODE=ON"
+# Use system zlib instead of the bundled copy
+EXTRA_OECMAKE += "-DWITH_SYSTEM_ZLIB=ON"
 
 # Add nasm-native dependency consistently for all build arches is hard
 EXTRA_OECMAKE:append:class-native = " -DWITH_SIMD=False"
Signature · 1 line
2.43.0
#2 lore raw

RE: [OE-core] [PATCH 2/2] libjpeg-turbo: use system zlib instead of bundled copy

Quoted 37 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Ross Burton via lists.openembedded.org
Sent: den 4 augusti 2026 17:45
To: [email protected]
Subject: [OE-core] [PATCH 2/2] libjpeg-turbo: use system zlib instead of bundled copy

The libjpegturbo library bundles a copy of libspng which in turn bundles a copy of zlib. We don't currently have a libspng recipe but we can stop it bundling zlib.

---
 meta/recipes-graphics/jpeg/libjpeg-turbo_3.2.0.bb | 3 +++
 1 file changed, 3 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_3.2.0.bb +3 -1
index 89504419762..7a548d4e9c6 100644
@@ -5,6 +5,7 @@ HOMEPAGE = "http://libjpeg-turbo.org/"
 LICENSE = "BSD-3-Clause AND IJG AND Zlib"
 LIC_FILES_CHKSUM = "file://LICENSE.md;md5=d21daef3b4b318f77062055059c72934"
 
+DEPENDS = "zlib"
 DEPENDS:append:x86-64:class-target = " nasm-native"
 DEPENDS:append:x86:class-target = " nasm-native"
 
@@ -28,6 +29,8 @@ export NASMENV = "--reproducible --debug-prefix-map=${WORKDIR}=${TARGET_DBGSRC_D
 EXTRA_OECMAKE += "-DCMAKE_SKIP_INSTALL_RPATH=ON"
 # Ensure the -fPIC options are used to avoid -native compile failures, e.g. on opensuse160
 EXTRA_OECMAKE += "-DCMAKE_POSITION_INDEPENDENT_CODE=ON"
+# Use system zlib instead of the bundled copy
+EXTRA_OECMAKE += "-DWITH_SYSTEM_ZLIB=ON"
 
 # Add nasm-native dependency consistently for all build arches is hard
 EXTRA_OECMAKE:append:class-native = " -DWITH_SIMD=False"
--
Quoted 1 line

2.43.0

After the above change, one of our applications that uses libjpeg-turbo fails to build. It fails with:

| CMake Error at .../recipe-sysroot/usr/lib/cmake/libjpeg-turbo/libjpeg-turboTargets.cmake:77 (set_target_properties):
|   The link interface of target "libjpeg-turbo::turbojpeg" contains:
|
|     ZLIB::ZLIB
|
|   but the target was not found.  Possible reasons include:
|
|     * There is a typo in the target name.
|     * A find_package call is missing for an IMPORTED target.
|     * An ALIAS target is missing.
|
| Call Stack (most recent call first):
|   .../recipe-sysroot/usr/lib/cmake/libjpeg-turbo/libjpeg-turboConfig.cmake:37 (include)
|   code/CMakeLists.txt:20 (find_package)

I can solve it by adding find_package(ZLIB REQUIRED) to the code/CMakeLists.txt file, but is that really expected? I would have assumed that whatever CMake files libjpeg-turbo installs should take care of that automatically.

//Peter

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

RE: [OE-core] [PATCH 2/2] libjpeg-turbo: use system zlib instead of bundled copy

Ross?

Quoted 65 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Peter Kjellerstedt via lists.openembedded.org
Sent: den 20 augusti 2026 17:12
To: [email protected]; [email protected]
Subject: Re: [OE-core] [PATCH 2/2] libjpeg-turbo: use system zlib instead of bundled copy

Quoted 37 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Ross Burton via lists.openembedded.org
Sent: den 4 augusti 2026 17:45
To: [email protected]
Subject: [OE-core] [PATCH 2/2] libjpeg-turbo: use system zlib instead of bundled copy

The libjpegturbo library bundles a copy of libspng which in turn bundles a copy of zlib. We don't currently have a libspng recipe but we can stop it bundling zlib.

---
 meta/recipes-graphics/jpeg/libjpeg-turbo_3.2.0.bb | 3 +++
 1 file changed, 3 insertions(+)
meta/recipes-graphics/jpeg/libjpeg-turbo_3.2.0.bb +3 -1
index 89504419762..7a548d4e9c6 100644
@@ -5,6 +5,7 @@ HOMEPAGE = "http://libjpeg-turbo.org/"
 LICENSE = "BSD-3-Clause AND IJG AND Zlib"
 LIC_FILES_CHKSUM = "file://LICENSE.md;md5=d21daef3b4b318f77062055059c72934"
 
+DEPENDS = "zlib"
 DEPENDS:append:x86-64:class-target = " nasm-native"
 DEPENDS:append:x86:class-target = " nasm-native"
 
@@ -28,6 +29,8 @@ export NASMENV = "--reproducible --debug-prefix-map=${WORKDIR}=${TARGET_DBGSRC_D
 EXTRA_OECMAKE += "-DCMAKE_SKIP_INSTALL_RPATH=ON"
 # Ensure the -fPIC options are used to avoid -native compile failures, e.g. on opensuse160
 EXTRA_OECMAKE += "-DCMAKE_POSITION_INDEPENDENT_CODE=ON"
+# Use system zlib instead of the bundled copy
+EXTRA_OECMAKE += "-DWITH_SYSTEM_ZLIB=ON"
 
 # Add nasm-native dependency consistently for all build arches is hard
 EXTRA_OECMAKE:append:class-native = " -DWITH_SIMD=False"
--
Quoted 1 line

2.43.0

After the above change, one of our applications that uses libjpeg-turbo fails to build. It fails with:

| CMake Error at .../recipe-sysroot/usr/lib/cmake/libjpeg-turbo/libjpeg-turboTargets.cmake:77 (set_target_properties):
|   The link interface of target "libjpeg-turbo::turbojpeg" contains:
|
|     ZLIB::ZLIB
|
|   but the target was not found.  Possible reasons include:
|
|     * There is a typo in the target name.
|     * A find_package call is missing for an IMPORTED target.
|     * An ALIAS target is missing.
|
| Call Stack (most recent call first):
|   .../recipe-sysroot/usr/lib/cmake/libjpeg-turbo/libjpeg-turboConfig.cmake:37 (include)
|   code/CMakeLists.txt:20 (find_package)
Quoted 6 lines

I can solve it by adding find_package(ZLIB REQUIRED) to the code/CMakeLists.txt file, but is that really expected? I would have assumed that whatever CMake files libjpeg-turbo installs should take care of that automatically.

//Peter

//Peter