Skip to contentSkip to conversation

cache: hisi_soc_hha: use named initializers for acpi_device_id

PATCH Applied Pawel Zalewski (The Capable Hub) 4 participants 4 messages Aug 4 – Aug 10

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cache: hisi_soc_hha: use named initializers for acpi_device_id

Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base.

---
 drivers/cache/hisi_soc_hha.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cache/hisi_soc_hha.c +1 -1
index 756c43398515..f0f6c0354108 100644
@@ -170,7 +170,7 @@ static void hisi_soc_hha_remove(struct platform_device *pdev)
 }
 
 static const struct acpi_device_id hisi_soc_hha_ids[] = {
-	{ "HISI0511", },
+	{ .id = "HISI0511" },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, hisi_soc_hha_ids);

---
base-commit: 075b74841bd0065a3bda3440873c747938e69b68
change-id: 20260803-cache-55f8e58f7d94

Best regards,

Signature · 1 line
Pawel Zalewski (The Capable Hub) <[email protected]>
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · On Tue, 04 Aug 2026 12:17:45 +0100 Pawel Zalewski via B4 Relay…

From: "Pawel Zalewski (The Capable Hub)" <[email protected]>

Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base.

Quoted 27 lines
---
 drivers/cache/hisi_soc_hha.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cache/hisi_soc_hha.c +1 -2
index 756c43398515..f0f6c0354108 100644
@@ -170,7 +170,7 @@ static void hisi_soc_hha_remove(struct platform_device *pdev)
 }
 
 static const struct acpi_device_id hisi_soc_hha_ids[] = {
-	{ "HISI0511", },
+	{ .id = "HISI0511" },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, hisi_soc_hha_ids);
 
---

base-commit: 075b74841bd0065a3bda3440873c747938e69b68
change-id: 20260803-cache-55f8e58f7d94

Best regards,

Signature · 1 line
Pawel Zalewski (The Capable Hub) <[email protected]>
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Pawel Zalewski (The Capable Hub)
Quoted 7 lines · On 8/4/2026 7:17 PM, Pawel Zalewski via B4 Relay wrote:

From: "Pawel Zalewski (The Capable Hub)" <[email protected]>

Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base.

Quoted 27 lines
---
 drivers/cache/hisi_soc_hha.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cache/hisi_soc_hha.c +1 -2
index 756c43398515..f0f6c0354108 100644
@@ -170,7 +170,7 @@ static void hisi_soc_hha_remove(struct platform_device *pdev)
 }
 
 static const struct acpi_device_id hisi_soc_hha_ids[] = {
-	{ "HISI0511", },
+	{ .id = "HISI0511" },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, hisi_soc_hha_ids);
 
---

base-commit: 075b74841bd0065a3bda3440873c747938e69b68
change-id: 20260803-cache-55f8e58f7d94

Best regards,

Signature · 1 line
Pawel Zalewski (The Capable Hub) <[email protected]>
maintainer Applied
#3 lore raw
In reply to Pawel Zalewski (The Capable Hub)

From: Conor Dooley <[email protected]>

Quoted 3 lines · Pawel Zalewski (The Capable Hub)

Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base.

Applied to cache-for-next, thanks!

[1/1] cache: hisi_soc_hha: use named initializers for acpi_device_id

      https://git.kernel.org/conor/c/8a5d6c13cc7c

Thanks,
Conor.