Skip to contentSkip to conversation

ASoC: spacemit: advertise only DMA-backed DAI streams

PATCH In review [email protected] 3 participants 3 messages Aug 5 – Aug 13

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: spacemit: advertise only DMA-backed DAI streams

From: bui duc phuc <[email protected]>

The static DAI template initializes both playback and capture stream capabilities before dma-names is examined. As a result, snd_soc_dai_stream_valid() considers both directions valid even when the device only provides a single DMA channel.

Move the playback and capture capability initialization into spacemit_i2s_init_dai(), where it is performed only for the stream directions backed by a corresponding DMA channel. This preserves the existing capabilities for devices with both "tx" and "rx" DMA channels, while preventing unsupported stream directions from being advertised.

Initialize rate_min and rate_max together with the other stream capabilities to preserve the existing rate constraints.

Fixes fce217449075 ("ASoC: spacemit: add i2s support for K1 SoC")

---

Changes in v2:
- Update the commit message to describe the functional fix as suggested by Troy.

Link v1 :
https://lore.kernel.org/all/[email protected]/

 sound/soc/spacemit/k1_i2s.c | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)
sound/soc/spacemit/k1_i2s.c +4 -16
index 2d5ea1fd5d49..28a762769253 100644
@@ -354,22 +354,6 @@ static const struct snd_soc_dai_ops spacemit_i2s_dai_ops = {
 
 static struct snd_soc_dai_driver spacemit_i2s_dai = {
 	.ops = &spacemit_i2s_dai_ops,
-	.playback = {
-		.channels_min = 1,
-		.channels_max = 2,
-		.rates = SPACEMIT_PCM_RATES,
-		.rate_min = SNDRV_PCM_RATE_8000,
-		.rate_max = SNDRV_PCM_RATE_48000,
-		.formats = SPACEMIT_PCM_FORMATS,
-	},
-	.capture = {
-		.channels_min = 1,
-		.channels_max = 2,
-		.rates = SPACEMIT_PCM_RATES,
-		.rate_min = SNDRV_PCM_RATE_8000,
-		.rate_max = SNDRV_PCM_RATE_48000,
-		.formats = SPACEMIT_PCM_FORMATS,
-	},
 	.symmetric_rate = 1,
 };
 
@@ -399,6 +383,8 @@ static int spacemit_i2s_init_dai(struct spacemit_i2s_dev *i2s,
 		dai->playback.channels_min = 1;
 		dai->playback.channels_max = 2;
 		dai->playback.rates = SPACEMIT_PCM_RATES;
+		dai->playback.rate_min = SNDRV_PCM_RATE_8000;
+		dai->playback.rate_max = SNDRV_PCM_RATE_48000;
 		dai->playback.formats = SPACEMIT_PCM_FORMATS;
 
 		i2s->playback_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES;
@@ -411,6 +397,8 @@ static int spacemit_i2s_init_dai(struct spacemit_i2s_dev *i2s,
 		dai->capture.channels_min = 1;
 		dai->capture.channels_max = 2;
 		dai->capture.rates = SPACEMIT_PCM_RATES;
+		dai->capture.rate_min = SNDRV_PCM_RATE_8000;
+		dai->capture.rate_max = SNDRV_PCM_RATE_48000;
 		dai->capture.formats = SPACEMIT_PCM_FORMATS;
 
 		i2s->capture_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES;
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 13 lines · phucduc.bui

From: bui duc phuc <[email protected]>

The static DAI template initializes both playback and capture stream capabilities before dma-names is examined. As a result, snd_soc_dai_stream_valid() considers both directions valid even when the device only provides a single DMA channel.

Move the playback and capture capability initialization into spacemit_i2s_init_dai(), where it is performed only for the stream directions backed by a corresponding DMA channel. This preserves the existing capabilities for devices with both "tx" and "rx" DMA channels, while preventing unsupported stream directions from being advertised.

Quoted 5 lines

Initialize rate_min and rate_max together with the other stream capabilities to preserve the existing rate constraints.

Fixes fce217449075 ("ASoC: spacemit: add i2s support for K1 SoC")

Please don't send out the next version so quickly. Many people may miss it before they even have a chance to see it.

Signature · 1 line
Troy Mitchell
maintainer
#2 lore raw
In reply to [email protected]
Quoted 1 line · On Wed, 05 Aug 2026 13:43:48 +0700, [email protected] wrote:

ASoC: spacemit: advertise only DMA-backed DAI streams

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/1] ASoC: spacemit: advertise only DMA-backed DAI streams

      https://git.kernel.org/broonie/sound/c/0a91bb72980e

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark