FSA: allow rename over files with only POSIX opens
Subsystems (2)
ChenXiaoSong
reviewerPATCH 1/1 FSA: allow rename over files with only POSIX opens
From: ChenXiaoSong <[email protected]>
Update FileRenameInformation processing for an existing destination. Ignore POSIX opens when checking whether the destination is open, so the rename can continue if all destination opens use POSIX semantics.
Keep returning STATUS_ACCESS_DENIED if the destination has one or more non-POSIX opens.
--- fsa_posix_extensions.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
fsa_posix_extensions.md +15 -0
@@ -617,3 +617,18 @@ Open.GrantedAccess does not incluce FILE_WRITE_ATTRIBUTES and not AccessCheck(SecurityContext, File.SecurityDescriptor, FILE_WRITE_ATTRIBUTES): - the operation MUST be failed with STATUS_CANNOT_DELETE. + +##### 2.1.4.8.3 FileRenameInformation + +When processing the following condition from MS-FSA 2.1.5.15.12: + +- If there was not an oplock to be broken and + **TargetLink.File.OpenList** contains an **Open** with a **Stream** + matching the current **Stream**, the operation MUST be failed with + `STATUS_ACCESS_DENIED`. + +For this check, the object store MUST consider only matching opens for which +**Open.IsPosix** is FALSE. If one or more such opens exist, the operation +MUST be failed with `STATUS_ACCESS_DENIED`. If all matching opens have +**Open.IsPosix** set to TRUE, this check MUST NOT fail the operation and +processing MUST continue as specified in MS-FSA 2.1.5.15.12.
Signature · 1 line
2.54.0
Can you please create a MR on gitlab?
Thanks!
Quoted 37 lines · ChenXiaoSong
From: ChenXiaoSong <[email protected]>
Update FileRenameInformation processing for an existing destination. Ignore POSIX opens when checking whether the destination is open, so the rename can continue if all destination opens use POSIX semantics.
Keep returning
STATUS_ACCESS_DENIEDif the destination has one or more non-POSIX opens.Signed-off-by ChenXiaoSong <[email protected]>--- fsa_posix_extensions.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+)fsa_posix_extensions.md +15
-0@@ -617,3 +617,18 @@ Open.GrantedAccess does not incluce FILE_WRITE_ATTRIBUTES and not AccessCheck(SecurityContext, File.SecurityDescriptor, FILE_WRITE_ATTRIBUTES): - the operation MUST be failed with STATUS_CANNOT_DELETE. + +##### 2.1.4.8.3 FileRenameInformation + +When processing the following condition from MS-FSA 2.1.5.15.12: + +- If there was not an oplock to be broken and + **TargetLink.File.OpenList** contains an **Open** with a **Stream** + matching the current **Stream**, the operation MUST be failed with + `STATUS_ACCESS_DENIED`. + +For this check, the object store MUST consider only matching opens for which +**Open.IsPosix** is FALSE. If one or more such opens exist, the operation +MUST be failed with `STATUS_ACCESS_DENIED`. If all matching opens have +**Open.IsPosix** set to TRUE, this check MUST NOT fail the operation and +processing MUST continue as specified in MS-FSA 2.1.5.15.12.
ChenXiaoSong
reviewerI have created the MR:
https://gitlab.com/smb3-posix-extensions/smb3-posix-extensions/-/merge_requests/11/diffs
Quoted 1 line · Ralph Boehme
Can you please create a MR on gitlab?
Signature · 3 lines
ChenXiaoSong <[email protected]> Chinese Homepage: https://chenxiaosong.com English Homepage: https://chenxiaosong.com/en