Skip to contentSkip to conversation

FSA: allow rename over files with only POSIX opens

PATCH In review ChenXiaoSong 2 participants 3 messages Aug 5

Subsystems (2)
lore
Share & tools
lore

ChenXiaoSong

author reviewer
#0 lore raw

PATCH 1/1 FSA: allow rename over files with only POSIX opens

From: ChenXiaoSong <[email protected]>

Update FileRenameInformation processing for an existing destination. Ignore POSIX opens when checking whether the destination is open, so the rename can continue if all destination opens use POSIX semantics.

Keep returning STATUS_ACCESS_DENIED if the destination has one or more non-POSIX opens.

---
 fsa_posix_extensions.md | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
fsa_posix_extensions.md +15 -0
index e03102d..7dbdf77 100644
@@ -617,3 +617,18 @@ Open.GrantedAccess does not incluce FILE_WRITE_ATTRIBUTES and
 not AccessCheck(SecurityContext, File.SecurityDescriptor, FILE_WRITE_ATTRIBUTES):
 
 - the operation MUST be failed with STATUS_CANNOT_DELETE.
+
+##### 2.1.4.8.3 FileRenameInformation
+
+When processing the following condition from MS-FSA 2.1.5.15.12:
+
+- If there was not an oplock to be broken and
+  **TargetLink.File.OpenList** contains an **Open** with a **Stream**
+  matching the current **Stream**, the operation MUST be failed with
+  `STATUS_ACCESS_DENIED`.
+
+For this check, the object store MUST consider only matching opens for which
+**Open.IsPosix** is FALSE. If one or more such opens exist, the operation
+MUST be failed with `STATUS_ACCESS_DENIED`. If all matching opens have
+**Open.IsPosix** set to TRUE, this check MUST NOT fail the operation and
+processing MUST continue as specified in MS-FSA 2.1.5.15.12.
Signature · 1 line
2.54.0
#1 lore raw

Can you please create a MR on gitlab?

Thanks!

Quoted 37 lines · ChenXiaoSong

From: ChenXiaoSong <[email protected]>

Update FileRenameInformation processing for an existing destination. Ignore POSIX opens when checking whether the destination is open, so the rename can continue if all destination opens use POSIX semantics.

Keep returning STATUS_ACCESS_DENIED if the destination has one or more non-POSIX opens.

---
  fsa_posix_extensions.md | 15 +++++++++++++++
  1 file changed, 15 insertions(+)
fsa_posix_extensions.md +15 -0
index e03102d..7dbdf77 100644
@@ -617,3 +617,18 @@ Open.GrantedAccess does not incluce FILE_WRITE_ATTRIBUTES and
  not AccessCheck(SecurityContext, File.SecurityDescriptor, FILE_WRITE_ATTRIBUTES):
 
  - the operation MUST be failed with STATUS_CANNOT_DELETE.
+
+##### 2.1.4.8.3 FileRenameInformation
+
+When processing the following condition from MS-FSA 2.1.5.15.12:
+
+- If there was not an oplock to be broken and
+  **TargetLink.File.OpenList** contains an **Open** with a **Stream**
+  matching the current **Stream**, the operation MUST be failed with
+  `STATUS_ACCESS_DENIED`.
+
+For this check, the object store MUST consider only matching opens for which
+**Open.IsPosix** is FALSE. If one or more such opens exist, the operation
+MUST be failed with `STATUS_ACCESS_DENIED`. If all matching opens have
+**Open.IsPosix** set to TRUE, this check MUST NOT fail the operation and
+processing MUST continue as specified in MS-FSA 2.1.5.15.12.