pinctrl: airoha: fix wrong value for PCIe reset pin
Subsystems (5)
PATCH 1/1 pinctrl: airoha: fix wrong value for PCIe reset pin
The PCIe reset pin actually require the bit to be set as 0 to work as PCIe reset pin. When the bit is set as 1, then the PCIe reset pin act as a GPIO for GPIO44, GPIO45 and GPIO46.
--- drivers/pinctrl/airoha/pinctrl-airoha.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pinctrl/airoha/pinctrl-airoha.c +3 -3
@@ -1412,7 +1412,7 @@ static const struct airoha_pinctrl_func_group pcie_reset_func_group[] = {AIROHA_FUNC_MUX ,REG_GPIO_PON_MODE ,GPIO_PCIE_RESET0_MASK , -GPIO_PCIE_RESET0_MASK +0 }, .regmap_size = 1, }, {
@@ -1421,7 +1421,7 @@ static const struct airoha_pinctrl_func_group pcie_reset_func_group[] = {AIROHA_FUNC_MUX ,REG_GPIO_PON_MODE ,GPIO_PCIE_RESET1_MASK , -GPIO_PCIE_RESET1_MASK +0 }, .regmap_size = 1, }, {
@@ -1430,7 +1430,7 @@ static const struct airoha_pinctrl_func_group pcie_reset_func_group[] = { AIROHA_FUNC_MUX,REG_GPIO_PON_MODE ,GPIO_PCIE_RESET2_MASK , -GPIO_PCIE_RESET2_MASK + 0 }, .regmap_size = 1, },
Signature · 1 line
2.53.0
Quoted 34 lines · Christian Marangi
The PCIe reset pin actually require the bit to be set as 0 to work as PCIe reset pin. When the bit is set as 1, then the PCIe reset pin act as a GPIO for GPIO44, GPIO45 and GPIO46.
Fixes 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC")Signed-off-by Christian Marangi <[email protected]>--- drivers/pinctrl/airoha/pinctrl-airoha.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/pinctrl/airoha/pinctrl-airoha.c +2
-2@@ -1412,7 +1412,7 @@ static const struct airoha_pinctrl_func_group pcie_reset_func_group[] = {AIROHA_FUNC_MUX ,REG_GPIO_PON_MODE ,GPIO_PCIE_RESET0_MASK , -GPIO_PCIE_RESET0_MASK +0 }, .regmap_size = 1, }, {@@ -1421,7 +1421,7 @@ static const struct airoha_pinctrl_func_group pcie_reset_func_group[] = {AIROHA_FUNC_MUX ,REG_GPIO_PON_MODE ,GPIO_PCIE_RESET1_MASK , -GPIO_PCIE_RESET1_MASK +0 }, .regmap_size = 1, }, {
drivers/pinctrl/airoha/pinctrl-airoha.c static const struct airoha_pinctrl_func_group pcie_reset_func_group[] = { · line 1436
Quoted 8 lines
drivers/pinctrl/airoha/pinctrl-airoha.c +1
-1@@ -1430,7 +1430,7 @@ static const struct airoha_pinctrl_func_group pcie_reset_func_group[] = { AIROHA_FUNC_MUX,REG_GPIO_PON_MODE ,GPIO_PCIE_RESET2_MASK , -GPIO_PCIE_RESET2_MASK + 0 }, .regmap_size = 1, },
MvH
Benjamin Larsson
Quoted 7 lines
The PCIe reset pin actually require the bit to be set as 0 to work as PCIe reset pin. When the bit is set as 1, then the PCIe reset pin act as a GPIO for GPIO44, GPIO45 and GPIO46.
Fixes 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC")Signed-off-by Christian Marangi <[email protected]>
Quoted 38 lines
--- drivers/pinctrl/airoha/pinctrl-airoha.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/pinctrl/airoha/pinctrl-airoha.c +3
-3@@ -1412,7 +1412,7 @@ static const struct airoha_pinctrl_func_group pcie_reset_func_group[] = {AIROHA_FUNC_MUX ,REG_GPIO_PON_MODE ,GPIO_PCIE_RESET0_MASK , -GPIO_PCIE_RESET0_MASK +0 }, .regmap_size = 1, }, {@@ -1421,7 +1421,7 @@ static const struct airoha_pinctrl_func_group pcie_reset_func_group[] = {AIROHA_FUNC_MUX ,REG_GPIO_PON_MODE ,GPIO_PCIE_RESET1_MASK , -GPIO_PCIE_RESET1_MASK +0 }, .regmap_size = 1, }, {@@ -1430,7 +1430,7 @@ static const struct airoha_pinctrl_func_group pcie_reset_func_group[] = { AIROHA_FUNC_MUX,REG_GPIO_PON_MODE ,GPIO_PCIE_RESET2_MASK , -GPIO_PCIE_RESET2_MASK + 0 }, .regmap_size = 1, },Signature · 1 line
2.53.0
Linus Walleij
maintainerHi Christian,
Quoted 7 lines · Christian Marangi
The PCIe reset pin actually require the bit to be set as 0 to work as PCIe reset pin. When the bit is set as 1, then the PCIe reset pin act as a GPIO for GPIO44, GPIO45 and GPIO46.
Fixes 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC")Signed-off-by Christian Marangi <[email protected]>
Is this already fixed in the big Airoha patch set from Mikhail that I just applied?
If this is *not* fixed in what is currently in my tree I need a rebased version of this for mainline.
If it *is* fixed in what is currently in my tree, this can be sent separately to the stable tree as a backport once Torvalds has pulled my changes.
Yours,
Linus Walleij