Skip to contentSkip to conversation

mm: debug_page_alloc: fix type mismatch for debug_guardpage_minorder

PATCH Applied Ye Liu 2 participants 2 messages Aug 5

Subsystems (2)
Memory management Page allocator
lore
Share & tools
lore

Ye Liu

author
#0 lore raw

PATCH 1/1 mm: debug_page_alloc: fix type mismatch for debug_guardpage_minorder

From: Ye Liu <[email protected]>

The _debug_guardpage_minorder variable is declared as unsigned int, but the debug_guardpage_minorder_setup() function uses unsigned long and kstrtoul() to parse the value.

Use kstrtouint() with unsigned int local variable to match the actual type of _debug_guardpage_minorder. Also fix the format specifier from %lu to %u accordingly.

Signed-off-by Ye Liu <[email protected]>
---
 mm/debug_page_alloc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
mm/debug_page_alloc.c +3 -3
index 6a26eca546c3..41e3d1f1ad96 100644
@@ -20,14 +20,14 @@ early_param("debug_pagealloc", early_debug_pagealloc);
 
 static int __init debug_guardpage_minorder_setup(char *buf)
 {
-	unsigned long res;
+	unsigned int res;
 
-	if (kstrtoul(buf, 10, &res) < 0 ||  res > MAX_PAGE_ORDER / 2) {
+	if (kstrtouint(buf, 10, &res) < 0 ||  res > MAX_PAGE_ORDER / 2) {
 		pr_err("Bad debug_guardpage_minorder value: %s\n", buf);
 		return 0;
 	}
 	_debug_guardpage_minorder = res;
-	pr_info("Setting debug_guardpage_minorder to %lu\n", res);
+	pr_info("Setting debug_guardpage_minorder to %u\n", res);
 	return 0;
 }
 early_param("debug_guardpage_minorder", debug_guardpage_minorder_setup);
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 8 lines · On Wed, 5 Aug 2026 17:31:07 +0800 Ye Liu <[email protected]> wrote:

The _debug_guardpage_minorder variable is declared as unsigned int, but the debug_guardpage_minorder_setup() function uses unsigned long and kstrtoul() to parse the value.

Use kstrtouint() with unsigned int local variable to match the actual type of _debug_guardpage_minorder. Also fix the format specifier from %lu to %u accordingly.

Fair enough, thanks.

AI review seems to have found a little pre-existing bug in there,

	https://sashiko.dev/#/patchset/[email protected]