media: i2c: imx415: Return test pattern write errors
PATCH v2 1/2 media: i2c: imx415: Return test pattern write errors
imx415_set_testpattern() accumulates failures from cci_write(), but drops the value and always returns success. Return the accumulated error so V4L2 reports failures to userspace.
Fixes d5df1c7f3f83 ("media: i2c: imx415: Convert to new CCI register access helpers")
Reviewed-by Michael Riesch <[email protected]>
Signed-off-by Narasimharao Vadlamudi <[email protected]>
--- drivers/media/i2c/imx415.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/imx415.c +1 -1
@@ -686,7 +686,7 @@ static int imx415_set_testpattern(struct imx415 *sensor, int val)cci_write (sensor->regmap,IMX415_DIG_CLP_MODE ,0x01 , &ret);cci_write (sensor->regmap,IMX415_WRJ_OPEN ,0x01 , &ret); } -return 0 ; +return ret; }static int imx415_s_ctrl (struct v4l2_ctrl *ctrl)
Signature · 1 line
2.43.0
PATCH v2 2/2 media: i2c: imx415: Release runtime PM reference on VBLANK error
The VBLANK path returned immediately when programming VMAX failed after pm_runtime_get_if_in_use() had taken a runtime PM reference. Break out of the switch instead so the common pm_runtime_put() path is used.
Fixes 3bcae55ab96a ("media: i2c: imx415: Add read/write control of VBLANK")
Reviewed-by Michael Riesch <[email protected]>
Signed-off-by Narasimharao Vadlamudi <[email protected]>
--- drivers/media/i2c/imx415.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/imx415.c +1 -1
@@ -720,7 +720,7 @@ static int imx415_s_ctrl(struct v4l2_ctrl *ctrl) ret =cci_write (sensor->regmap,IMX415_VMAX , format->height + ctrl->val,NULL );if (ret) -return ret; +break ;/* * Exposure is set based on VMAX which has just changed, so * program exposure register as well
Signature · 1 line
2.43.0