Skip to contentSkip to conversation

test/iopoll: Fix clang CI build failure

PATCH New Gabriel Krisman Bertazi 1 participant 1 message Aug 5 io_uring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test/iopoll: Fix clang CI build failure

Clang CI builds in liburing repo do -Werror,-Wunused-but-set-global when building with clang. commit c5eead26 ("test/iopoll: fix over-eager no_hybrid check") left a lingering variable that was not used, and clang got smart enough to find for it, causing the build to fail for every commit ever since.

https://github.com/axboe/liburing/actions/runs/30404555586/job/90427017716
https://github.com/axboe/liburing/actions/runs/30404555586/job/90427017742

Fixes c5eead26 ("test/iopoll: fix over-eager no_hybrid check")
---
 test/iopoll.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
test/iopoll.c +1 -4
index 98230657..d68fde10 100644
@@ -23,7 +23,6 @@
 static struct iovec *vecs;
 static int no_buf_select;
 static int no_iopoll;
-static int no_hybrid;
 
 static int provide_buffers(struct io_uring *ring)
 {
@@ -372,10 +371,8 @@ static int test_io(const char *file, int write, int sqthread, int fixed,
 		return 0;
 	}
 	if (ret != T_SETUP_OK) {
-		if (ring_flags & IORING_SETUP_HYBRID_IOPOLL) {
-			no_hybrid = 1;
+		if (ring_flags & IORING_SETUP_HYBRID_IOPOLL)
 			return 0;
-		}
 		fprintf(stderr, "ring create failed: %d\n", ret);
 		return 1;
 	}
Signature · 1 line
2.55.0