Skip to contentSkip to conversation

net: qrtr: ns: Raise lookup limit to 128

PATCH Applied Łukasz Patron 5 participants 7 messages Aug 4 – Aug 7

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: qrtr: ns: Raise lookup limit to 128

Current limit of 64 is not enough for Sony Xperia 10 VII (SM6475).

Fixes 5640227d9a21 ("net: qrtr: ns: Limit the maximum number of lookups")
---
 net/qrtr/ns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/qrtr/ns.c +1 -1
index e5b2adb161d9..c5e7e01db249 100644
@@ -78,7 +78,7 @@ struct qrtr_node {
  */
 #define QRTR_NS_MAX_NODES   512
 #define QRTR_NS_MAX_SERVERS 256
-#define QRTR_NS_MAX_LOOKUPS 64
+#define QRTR_NS_MAX_LOOKUPS 128
 
 static u16 node_count;
 
Signature · 1 line
2.55.0
reviewer
#1 lore raw
Quoted 4 lines · Łukasz Patron

Current limit of 64 is not enough for Sony Xperia 10 VII (SM6475).

Fixes 5640227d9a21 ("net: qrtr: ns: Limit the maximum number of lookups")

Hi Łukasz,

I think that this needs some more explanation.

E.g.:
Why is it insufficient on the cited device?
What is the user experience with the current and new limits? Why is this considered a bug rather than enabling a device that didn't work before?

Signature · 1 line
pw-bot: changes-requested
#2 lore raw

Hi,

After merging v6.6.142 into a downstream AOSP device, it's stuck on boot animation and following log spam can be observed in dmesg:

E qrtr : ctrl_cmd_new_lookup(): QRTR client node exceeds max lookup limit!
E qrtr : qrtr_ns_worker(): failed while handling packet from 1:16600

No idea why it needs more than 64 client lookups, but it appears to work fine with 128 as it did when there were no limits.

Also, I don't really have a good way to investigate what it needs all these lookups for as most of the userspace is closed source. Perhaps someone working at Qualcomm could have some ideas.

Quoted 19 lines · Simon Horman
Quoted 4 lines · Łukasz Patron

Current limit of 64 is not enough for Sony Xperia 10 VII (SM6475).

Fixes 5640227d9a21 ("net: qrtr: ns: Limit the maximum number of lookups")

Hi Łukasz,

I think that this needs some more explanation.

E.g.:
Why is it insufficient on the cited device?
What is the user experience with the current and new limits? Why is this considered a bug rather than enabling a device that didn't work before?

--
pw-bot: changes-requested

maintainer
#3 lore raw
Quoted 8 lines · On Thu, 6 Aug 2026 15:38:22 +0200 Łukasz Patron wrote:

After merging v6.6.142 into a downstream AOSP device, it's stuck on boot animation and following log spam can be observed in dmesg:

E qrtr : ctrl_cmd_new_lookup(): QRTR client node exceeds max lookup limit!
E qrtr : qrtr_ns_worker(): failed while handling packet from 1:16600

No idea why it needs more than 64 client lookups, but it appears to work fine with 128 as it did when there were no limits.

Ack, I'll fold the explanation into the commit msg. pls don't repost.

maintainer Reviewed-by
#4 lore raw
Quoted 11 lines · Jakub Kicinski
Quoted 8 lines · On Thu, 6 Aug 2026 15:38:22 +0200 Łukasz Patron wrote:

After merging v6.6.142 into a downstream AOSP device, it's stuck on boot animation and following log spam can be observed in dmesg:

E qrtr : ctrl_cmd_new_lookup(): QRTR client node exceeds max lookup limit!
E qrtr : qrtr_ns_worker(): failed while handling packet from 1:16600

No idea why it needs more than 64 client lookups, but it appears to work fine with 128 as it did when there were no limits.

Ack, I'll fold the explanation into the commit msg. pls don't repost.

With the added info,

- Mani

Signature · 1 line
மணிவண்ணன் சதாசிவம்
reviewer Reviewed-by
#5 lore raw
Quoted 8 lines · Manivannan Sadhasivam
Quoted 7 lines · Jakub Kicinski
Quoted 6 lines · On Thu, 6 Aug 2026 15:38:22 +0200 Łukasz Patron wrote:

After merging v6.6.142 into a downstream AOSP device, it's stuck on boot animation and following log spam can be observed in dmesg:

E qrtr : ctrl_cmd_new_lookup(): QRTR client node exceeds max lookup limit!
E qrtr : qrtr_ns_worker(): failed while handling packet from 1:16600

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

No idea why it needs more than 64 client lookups, but it appears to work fine with 128 as it did when there were no limits.

Ack, I'll fold the explanation into the commit msg. pls don't repost.

With the added info,

Likewise,

#6 lore raw
In reply to Łukasz Patron
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 7 lines · On Tue, 4 Aug 2026 22:18:30 +0200 you wrote:

Current limit of 64 is not enough for Sony Xperia 10 VII (SM6475).

Fixes 5640227d9a21 ("net: qrtr: ns: Limit the maximum number of lookups")
---
 net/qrtr/ns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- net: qrtr: ns: Raise lookup limit to 128

    https://git.kernel.org/netdev/net/c/7fc1c937b6b3

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html