KVM: arm64: Fix hvhe and broken CNTVOFF_EL2
PATCH 1/1 KVM: arm64: Fix hvhe and broken CNTVOFF_EL2
When running on a setup affected with broken CNTVOFF_EL2 (has_broken_cntvoff())
Booting with VHE or protected mode(nvhe) (id_aa64mmfr1.vh=0 and arm64_sw.hvhe=0) works fine.
However launching a protected VM with protected hvhe mode panics the guest kernel:
[ 0.000000] Internal error: Oops - Undefined instruction: 0000000000000000 [#1] SMP [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 7.2.0-rc3-g05f75bd71e0e-dirty #29 PREEMPT [ 0.000000] Hardware name: linux,dummy-virt (DT) [ 0.000000] pstate: 000003c5 (nzcv DAIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 0.000000] pc : arch_timer_shutdown_virt+0x4/0x1c [ 0.000000] lr : arch_timer_starting_cpu+0x1c4/0x2d4 [ 0.000000] sp : ffffa6bd9a193c00 [ 0.000000] x29: ffffa6bd9a193c20 x28: ffffa6bd9a1bcf88 x27: 0000000000000000 [ 0.000000] x26: ffff00001be70dd8 x25: ffffa6bd99d85000 x24: ffffa6bd99d85ee4 [ 0.000000] x23: ffffa6bd99d85000 x22: ffffa6bd9a1499c0 x21: ffffa6bd9a1ab900 [ 0.000000] x20: 00ffffffffffffff x19: ffff00001be8b600 x18: 000000000000028c [ 0.000000] x17: 00000000510f0010 x16: 00000000510f0010 x15: 00000000500f0000 [ 0.000000] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000018 [ 0.000000] x11: ffffa6bd9a8ac000 x10: 0000000000f0000f x9 : ffffffffffffffff [ 0.000000] x8 : ffffa6bd98822e18 x7 : 0070752d65746174 x6 : 00111ff76e007261 [ 0.000000] x5 : ffffa6bd9ad68078 x4 : 0000000000000000 x3 : ffffa6bd98822a0c [ 0.000000] x2 : 0000000000000073 x1 : 0000000000000001 x0 : ffff00001be8b600 [ 0.000000] Call trace: [ 0.000000] arch_timer_shutdown_virt+0x4/0x1c (P) [ 0.000000] cpuhp_invoke_callback+0x11c/0x280 [ 0.000000] cpuhp_issue_call+0x1e8/0x224 [ 0.000000] __cpuhp_setup_state_cpuslocked+0x1d8/0x2b8 [ 0.000000] __cpuhp_setup_state+0x50/0x74 [ 0.000000] arch_timer_register+0xc0/0x148 [ 0.000000] arch_timer_of_init+0x148/0x170 [ 0.000000] timer_probe+0x74/0x124 [ 0.000000] time_init+0x18/0x58 [ 0.000000] start_kernel+0x1c0/0x3ac [ 0.000000] __primary_switched+0x88/0x90 [ 0.000000] Code: c80b7d2a 35ffffab 17ffffeb d503245f (d53be328)
And for non protected VMs seems to hang or progress really slowly.
The workaround avoids setting non-zero CNTVOFF_EL2 and trapping the virtual counter to emulate the offset.
In the VHE path (timer_set_traps()), traps are only enabled when the guest actually has a non-zero virtual timer offset. However, __timer_enable_traps() in hyp/nvhe/timer-sr.c unconditionally set CNTHCTL_EL1TVT and CNTHCTL_EL1TVCT whenever has_broken_cntvoff() was true.
Which causes 2 issues:
1) Protected VMs: kvm_handle_pvm_sysreg() does not find "cntv_ctl_el0" in pvm_sys_reg_descs and injects undefined instruction exceptions.
2) non-protected guests are trapped all the time even with offset of zero.
Fix this by adding a check in __timer_enable_traps() similar to the one in timer_set_traps()
--- arch/arm64/kvm/hyp/nvhe/timer-sr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/kvm/hyp/nvhe/timer-sr.c +2 -1
@@ -10,6 +10,7 @@#include <asm/kvm_hyp.h> #include <asm/kvm_mmu.h> +#include <hyp/switch.h> void __kvm_timer_set_cntvoff (u64 cntvoff) {
@@ -63,7 +64,7 @@ void __timer_enable_traps(struct kvm_vcpu *vcpu)* Trap the virtual counter/timer if we have a broken cntvoff * implementation. */ -if (has_broken_cntvoff ()) +if (has_broken_cntvoff () &&hyp_timer_get_offset (vcpu_vtimer (vcpu))) set |=CNTHCTL_EL1TVT |CNTHCTL_EL1TVCT ;sysreg_clear_set (cnthctl_el2, clr, set);
Signature · 1 line
2.55.0.654.g21b8a5bc05-goog
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
New issues:
- [High] Virtual timer traps are inadvertently disabled for non-protected guests under pKVM on hardware with broken CNTVOFF_EL2, breaking their configured timer offsets.
Pre-existing issues:
- [High] __timer_enable_traps() uses the global is_protected_kvm_enabled() check and an unsynced poffset, unconditionally disabling physical timer traps for non-protected VMs under pKVM. --
--- Patch [1]: [PATCH] KVM: arm64: Fix hvhe and broken CNTVOFF_EL2 --- commit d5e405a74fba9d73744f97970471012a4473ce3c
Author: Mostafa Saleh <[email protected]>
Subject: KVM: arm64: Fix hvhe and broken CNTVOFF_EL2
The commit fixes a guest kernel panic when launching a protected VM with protected hvhe mode on hardware with a broken CNTVOFF_EL2. It achieves this by conditionally enabling virtual timer traps only when the guest actually has a non-zero virtual timer offset.
arch/arm64/kvm/hyp/nvhe/timer-sr.c
Quoted 4 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c +0
-0
[ ... ]
[Severity: High]
This is a pre-existing issue, but does the physical timer trap logic earlier in __timer_enable_traps() improperly grant all guests under pKVM access to the physical timer?
Looking at the physical timer access check in this function:
if (is_protected_kvm_enabled() || !kern_hyp_va(vcpu->kvm)->arch.timer_data.poffset) set |= CNTHCTL_EL1PCTEN;
The is_protected_kvm_enabled() static key reflects host pKVM support and applies to all guests. Additionally, the fallback poffset check evaluates to true under pKVM because the EL2-private hyp_vm->kvm is never populated with the host's poffset during init_pkvm_hyp_vm().
Can this cause non-protected VMs on older hardware without CNTPOFF_EL2 to bypass physical timer offset emulation and read the raw physical timer directly?
arch/arm64/kvm/hyp/nvhe/timer-sr.c void __timer_enable_traps(struct kvm_vcpu *vcpu) · line 67
Quoted 6 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c +1
-1@@ -63,7 +64,7 @@ void __timer_enable_traps(struct kvm_vcpu *vcpu)* Trap the virtual counter/timer if we have a broken cntvoff * implementation. */ -if (has_broken_cntvoff ()) +if (has_broken_cntvoff () &&hyp_timer_get_offset (vcpu_vtimer (vcpu)))
[Severity: High]
Could this condition inadvertently disable virtual timer traps for non-protected guests under pKVM?
The new check evaluates hyp_timer_get_offset(vcpu_vtimer(vcpu)). However, under pKVM (nVHE), the EL2-private pkvm_hyp_vcpu structure's timer_cpu state is never synchronized from the host vCPU during init_pkvm_hyp_vcpu() or flush_hyp_vcpu().
Since ctxt->offset.vm_offset remains NULL, hyp_timer_get_offset() will unconditionally return 0. Will this allow any non-protected guest with a configured virtual timer offset to bypass the trap and incorrectly observe an offset of 0?
Quoted 3 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c +0
-0set |=CNTHCTL_EL1TVT |CNTHCTL_EL1TVCT ;sysreg_clear_set (cnthctl_el2, clr, set);
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Fuad Tabba
reviewerQuoted 8 lines · On Thu, 6 Aug 2026 at 16:32, <[email protected]> wrote:
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
New issues:
- [High] Virtual timer traps are inadvertently disabled for non-protected guests under pKVM on hardware with brokenCNTVOFF_EL2, breaking their configured timer offsets.Pre-existing issues:
- [High]__timer_enable_traps()uses the globalis_protected_kvm_enabled()check and an unsyncedpoffset, unconditionally disabling physical timer traps for non-protected VMs under pKVM.
This only runs on broken-CNTVOFF hardware, where the workaround pins CNTVOFF_EL2=0 for all guests. Dropping the trap changes nothing observable.
/fuad
Quoted 66 lines
--
--- Patch [1]: [PATCH] KVM: arm64: Fix hvhe and broken
CNTVOFF_EL2--- commitd5e405a74fba9d73744f97970471012a4473ce3c
Author: Mostafa Saleh <[email protected]>
Subject: KVM: arm64: Fix hvhe and brokenCNTVOFF_EL2The commit fixes a guest kernel panic when launching a protected VM with protected hvhe mode on hardware with a broken
CNTVOFF_EL2. It achieves this by conditionally enabling virtual timer traps only when the guest actually has a non-zero virtual timer offset.arch/arm64/kvm/hyp/nvhe/timer-sr.c
Quoted 4 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c +0
-0[ ... ]
[Severity: High]
This is a pre-existing issue, but does the physical timer trap logic earlier in__timer_enable_traps()improperly grant all guests under pKVM access to the physical timer?Looking at the physical timer access check in this function:
if (is_protected_kvm_enabled() || !kern_hyp_va(vcpu->kvm)->arch.timer_data.poffset) set |= CNTHCTL_EL1PCTEN;The
is_protected_kvm_enabled()static key reflects host pKVM support and applies to all guests. Additionally, the fallback poffset check evaluates to true under pKVM because the EL2-privatehyp_vm->kvmis never populated with the host's poffset duringinit_pkvm_hyp_vm().Can this cause non-protected VMs on older hardware without
CNTPOFF_EL2to bypass physical timer offset emulation and read the raw physical timer directly?arch/arm64/kvm/hyp/nvhe/timer-sr.c void __timer_enable_traps(struct kvm_vcpu *vcpu) · line 67
Quoted 6 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c +1
-1@@ -63,7 +64,7 @@ void __timer_enable_traps(struct kvm_vcpu *vcpu)* Trap the virtual counter/timer if we have a broken cntvoff * implementation. */ -if (has_broken_cntvoff ()) +if (has_broken_cntvoff () &&hyp_timer_get_offset (vcpu_vtimer (vcpu)))[Severity: High]
Could this condition inadvertently disable virtual timer traps for non-protected guests under pKVM?The new check evaluates hyp_timer_get_offset(vcpu_vtimer(vcpu)). However, under pKVM (nVHE), the EL2-private
pkvm_hyp_vcpustructure'stimer_cpustate is never synchronized from the host vCPU duringinit_pkvm_hyp_vcpu()orflush_hyp_vcpu().Since
ctxt->offset.vm_offsetremains NULL,hyp_timer_get_offset()will unconditionally return 0. Will this allow any non-protected guest with a configured virtual timer offset to bypass the trap and incorrectly observe an offset of 0?arch/arm64/kvm/hyp/nvhe/timer-sr.c void __timer_enable_traps(struct kvm_vcpu *vcpu) · line 70
Quoted 3 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c +0
-0set |=CNTHCTL_EL1TVT |CNTHCTL_EL1TVCT ;sysreg_clear_set (cnthctl_el2, clr, set);--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Hi Mostafa,
On Thu, 6 Aug 2026 at 16:01, Mostafa Saleh <[email protected]> wrote:
...
arch/arm64/kvm/hyp/nvhe/timer-sr.c void __timer_enable_traps(struct kvm_vcpu *vcpu) · line 68
Quoted 9 lines
void
__kvm_timer_set_cntvoff(u64 cntvoff)
{arch/arm64/kvm/hyp/nvhe/timer-sr.c +1
-1@@ -63,7 +64,7 @@ void __timer_enable_traps(struct kvm_vcpu *vcpu)* Trap the virtual counter/timer if we have a broken cntvoff * implementation. */ -if (has_broken_cntvoff ()) +if (has_broken_cntvoff () &&hyp_timer_get_offset (vcpu_vtimer (vcpu))) set |=CNTHCTL_EL1TVT |CNTHCTL_EL1TVCT ;
nit: the comment above could note the trap is now gated on a non-zero virtual offset, to match timer_set_traps() on the VHE side (well... maybe you don't want to _completely_ match _that_ comment, but you get my drift ;)) .
Tested on QEMU with a forced has_broken_cntvoff(), then booted a protected guest: without the patch it hits the UNDEF, with it the guest boots.
Cheers,
/fuad
Quoted 5 lines
(quoted diff) +0
-1sysreg_clear_set(cnthctl_el2, clr, set); --2.55.0.654.g21b8a5bc05-goog
Quoted 8 lines · Mostafa Saleh
When running on a setup affected with broken
CNTVOFF_EL2(has_broken_cntvoff())Booting with VHE or protected mode(nvhe) (id_aa64mmfr1.vh=0 and arm64_sw.hvhe=0) works fine.
However launching a protected VM with protected hvhe mode panics the guest kernel:
...
Quoted 14 lines
And for non protected VMs seems to hang or progress really slowly.
The workaround avoids setting non-zero
CNTVOFF_EL2and trapping the virtual counter to emulate the offset.
In the VHE path (timer_set_traps()), traps are only enabled when the guest actually has a non-zero virtual timer offset. However,__timer_enable_traps()inhyp/nvhe/timer-sr.cunconditionally setCNTHCTL_EL1TVTandCNTHCTL_EL1TVCTwheneverhas_broken_cntvoff()was true.Which causes 2 issues:
1) Protected VMs:kvm_handle_pvm_sysreg()does not find "cntv_ctl_el0" inpvm_sys_reg_descsand injects undefined instruction exceptions.
Quoted 5 lines
2) non-protected guests are trapped all the time even with offset of zero.
Fix this by adding a check in
__timer_enable_traps()similar to the one intimer_set_traps()
Hi Saleh,
May more fix is needed for case that guest real have virtual offset, due to no cntv_ctl_el0 handler there. For current fix for virtual offset is zero:
Quoted 31 lines
Fixes 0bc9a9e85fcf ("KVM: arm64: Work around x1e's CNTVOFF_EL2 bogosity")Signed-off-by Mostafa Saleh <[email protected]>--- arch/arm64/kvm/hyp/nvhe/timer-sr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/arm64/kvm/hyp/nvhe/timer-sr.c +2
-2@@ -10,6 +10,7 @@#include <asm/kvm_hyp.h> #include <asm/kvm_mmu.h> +#include <hyp/switch.h> void __kvm_timer_set_cntvoff (u64 cntvoff) {@@ -63,7 +64,7 @@ void __timer_enable_traps(struct kvm_vcpu *vcpu)* Trap the virtual counter/timer if we have a broken cntvoff * implementation. */ -if (has_broken_cntvoff ()) +if (has_broken_cntvoff () &&hyp_timer_get_offset (vcpu_vtimer (vcpu))) set |=CNTHCTL_EL1TVT |CNTHCTL_EL1TVCT ;sysreg_clear_set (cnthctl_el2, clr, set); --2.55.0.654.g21b8a5bc05-goog
Marc Zyngier
maintainerQuoted 73 lines · Mostafa Saleh
When running on a setup affected with broken
CNTVOFF_EL2(has_broken_cntvoff())Booting with VHE or protected mode(nvhe) (id_aa64mmfr1.vh=0 and arm64_sw.hvhe=0) works fine.
However launching a protected VM with protected hvhe mode panics the guest kernel:
[ 0.000000] Internal error: Oops - Undefined instruction: 0000000000000000 [#1] SMP [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 7.2.0-rc3-g05f75bd71e0e-dirty #29 PREEMPT [ 0.000000] Hardware name: linux,dummy-virt (DT) [ 0.000000] pstate: 000003c5 (nzcv DAIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 0.000000] pc : arch_timer_shutdown_virt+0x4/0x1c [ 0.000000] lr : arch_timer_starting_cpu+0x1c4/0x2d4 [ 0.000000] sp : ffffa6bd9a193c00 [ 0.000000] x29: ffffa6bd9a193c20 x28: ffffa6bd9a1bcf88 x27: 0000000000000000 [ 0.000000] x26: ffff00001be70dd8 x25: ffffa6bd99d85000 x24: ffffa6bd99d85ee4 [ 0.000000] x23: ffffa6bd99d85000 x22: ffffa6bd9a1499c0 x21: ffffa6bd9a1ab900 [ 0.000000] x20: 00ffffffffffffff x19: ffff00001be8b600 x18: 000000000000028c [ 0.000000] x17: 00000000510f0010 x16: 00000000510f0010 x15: 00000000500f0000 [ 0.000000] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000018 [ 0.000000] x11: ffffa6bd9a8ac000 x10: 0000000000f0000f x9 : ffffffffffffffff [ 0.000000] x8 : ffffa6bd98822e18 x7 : 0070752d65746174 x6 : 00111ff76e007261 [ 0.000000] x5 : ffffa6bd9ad68078 x4 : 0000000000000000 x3 : ffffa6bd98822a0c [ 0.000000] x2 : 0000000000000073 x1 : 0000000000000001 x0 : ffff00001be8b600 [ 0.000000] Call trace: [ 0.000000] arch_timer_shutdown_virt+0x4/0x1c (P) [ 0.000000] cpuhp_invoke_callback+0x11c/0x280 [ 0.000000] cpuhp_issue_call+0x1e8/0x224 [ 0.000000] __cpuhp_setup_state_cpuslocked+0x1d8/0x2b8 [ 0.000000] __cpuhp_setup_state+0x50/0x74 [ 0.000000] arch_timer_register+0xc0/0x148 [ 0.000000] arch_timer_of_init+0x148/0x170 [ 0.000000] timer_probe+0x74/0x124 [ 0.000000] time_init+0x18/0x58 [ 0.000000] start_kernel+0x1c0/0x3ac [ 0.000000] __primary_switched+0x88/0x90 [ 0.000000] Code: c80b7d2a 35ffffab 17ffffeb d503245f (d53be328)And for non protected VMs seems to hang or progress really slowly.
The workaround avoids setting non-zero
CNTVOFF_EL2and trapping the virtual counter to emulate the offset.
In the VHE path (timer_set_traps()), traps are only enabled when the guest actually has a non-zero virtual timer offset. However,__timer_enable_traps()inhyp/nvhe/timer-sr.cunconditionally setCNTHCTL_EL1TVTandCNTHCTL_EL1TVCTwheneverhas_broken_cntvoff()was true.Which causes 2 issues:
1) Protected VMs:kvm_handle_pvm_sysreg()does not find "cntv_ctl_el0" inpvm_sys_reg_descsand injects undefined instruction exceptions.2) non-protected guests are trapped all the time even with offset of zero.
Fix this by adding a check in
__timer_enable_traps()similar to the one intimer_set_traps()Fixes 0bc9a9e85fcf ("KVM: arm64: Work around x1e's CNTVOFF_EL2 bogosity")Signed-off-by Mostafa Saleh <[email protected]>--- arch/arm64/kvm/hyp/nvhe/timer-sr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/arm64/kvm/hyp/nvhe/timer-sr.c +0
-0
arch/arm64/kvm/hyp/nvhe/timer-sr.c line 13
Quoted 4 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c +1
-0@@ -10,6 +10,7 @@#include <asm/kvm_hyp.h> #include <asm/kvm_mmu.h> +#include <hyp/switch.h>
I'd rather not include this. It drags too many things, and is solely expected to be included from switch.c (both implementations).
You could use the hack below as a prefix to this change.
arch/arm64/kvm/hyp/nvhe/timer-sr.c void __timer_enable_traps(struct kvm_vcpu *vcpu) · line 70
Quoted 12 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c +1
-1void __kvm_timer_set_cntvoff (u64 cntvoff) {@@ -63,7 +64,7 @@ void __timer_enable_traps(struct kvm_vcpu *vcpu)* Trap the virtual counter/timer if we have a broken cntvoff * implementation. */ -if (has_broken_cntvoff ()) +if (has_broken_cntvoff () &&hyp_timer_get_offset (vcpu_vtimer (vcpu))) set |=CNTHCTL_EL1TVT |CNTHCTL_EL1TVCT ;sysreg_clear_set (cnthctl_el2, clr, set);
I don't immediately see why a non-protected guest is so slow with hVHE, irrespective of the offset. Even if we go back to the host for the emulation, this should be usable.
Could you describe what actually happens? Do you also see the issue with pure hVHE (without protected)?
Thanks,
M.
From a7ec0d7f23d86b028164328f33a7114fa6aad2c3 Mon Sep 17 00:00:00 2001
From: Marc Zyngier <[email protected]>
Date: Fri, 7 Aug 2026 11:36:48 +0100
Subject: [PATCH] KVM: arm64: Make timer_get_offset() work in all contexts
We currently have two implementations of get_timer offset(), one in arm_arch_timer.h, and another one in switch.h.
These two only differ by a pair of kern_hyp_va(), which seems a pretty weak reason to open-code it.
Turn this function into a macro to avoid the include dependency hell on kern_hyp_va(), and make it work correctly in all contexts.
--- arch/arm64/kvm/hyp/include/hyp/switch.h | 15 +---------- include/kvm/arm_arch_timer.h | 34 +++++++++++++++---------- 2 files changed, 22 insertions(+), 27 deletions(-)
arch/arm64/kvm/hyp/include/hyp/switch.h +1 -14
@@ -706,22 +706,9 @@ static inline bool handle_tx2_tvm(struct kvm_vcpu *vcpu)return true; } -/* Open-coded version of timer_get_offset() to allow for kern_hyp_va() */ -static inline u64 hyp_timer_get_offset (struct arch_timer_context *ctxt) -{ -u64 offset =0 ; - -if (ctxt->offset.vm_offset) - offset += *kern_hyp_va (ctxt->offset.vm_offset); -if (ctxt->offset.vcpu_offset) - offset += *kern_hyp_va (ctxt->offset.vcpu_offset); - -return offset; -} -static inline u64 compute_counter_value (struct arch_timer_context *ctxt) { -return arch_timer_read_cntpct_el0 () -hyp_timer_get_offset (ctxt); +return arch_timer_read_cntpct_el0 () -timer_get_offset (ctxt); }static bool kvm_handle_cntxct (struct kvm_vcpu *vcpu)
include/kvm/arm_arch_timer.h +21 -13
@@ -162,20 +162,28 @@ static inline bool has_cntpoff(void)return (has_vhe () &&cpus_have_final_cap (ARM64_HAS_ECV_CNTPOFF )); } -static inline u64 timer_get_offset (struct arch_timer_context *ctxt) -{ -u64 offset =0 ; +#ifdef __KVM_NVHE_HYPERVISOR__ +#define KERN_HYP_VA (x) kern_hyp_va(x) +#else +#define KERN_HYP_VA (x) x +#endif -if (!ctxt) -return 0 ; - -if (ctxt->offset.vm_offset) - offset += *ctxt->offset.vm_offset; -if (ctxt->offset.vcpu_offset) - offset += *ctxt->offset.vcpu_offset; - -return offset; -} +#define timer_get_offset (ctxt) \ + ({ \ + struct arch_timer_context *__ctxt = (ctxt); \ + u64 off = 0; \ + \ + if (__ctxt) { \ + struct arch_timer_offset *ato = &__ctxt->offset;\ + \ + if (ato->vm_offset) \ + off += *KERN_HYP_VA(ato->vm_offset); \ + if (ato->vcpu_offset) \ + off += *KERN_HYP_VA(ato->vcpu_offset); \ + } \ + \ + off; \ + })static inline void timer_set_offset (struct arch_timer_context *ctxt,u64 offset) {
Signature · 5 lines
2.47.3 -- Without deviation from the norm, progress is not possible.
Quoted 76 lines · Marc Zyngier
Quoted 74 lines · Mostafa Saleh
When running on a setup affected with broken
CNTVOFF_EL2(has_broken_cntvoff())Booting with VHE or protected mode(nvhe) (id_aa64mmfr1.vh=0 and arm64_sw.hvhe=0) works fine.
However launching a protected VM with protected hvhe mode panics the guest kernel:
[ 0.000000] Internal error: Oops - Undefined instruction: 0000000000000000 [#1] SMP [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 7.2.0-rc3-g05f75bd71e0e-dirty #29 PREEMPT [ 0.000000] Hardware name: linux,dummy-virt (DT) [ 0.000000] pstate: 000003c5 (nzcv DAIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 0.000000] pc : arch_timer_shutdown_virt+0x4/0x1c [ 0.000000] lr : arch_timer_starting_cpu+0x1c4/0x2d4 [ 0.000000] sp : ffffa6bd9a193c00 [ 0.000000] x29: ffffa6bd9a193c20 x28: ffffa6bd9a1bcf88 x27: 0000000000000000 [ 0.000000] x26: ffff00001be70dd8 x25: ffffa6bd99d85000 x24: ffffa6bd99d85ee4 [ 0.000000] x23: ffffa6bd99d85000 x22: ffffa6bd9a1499c0 x21: ffffa6bd9a1ab900 [ 0.000000] x20: 00ffffffffffffff x19: ffff00001be8b600 x18: 000000000000028c [ 0.000000] x17: 00000000510f0010 x16: 00000000510f0010 x15: 00000000500f0000 [ 0.000000] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000018 [ 0.000000] x11: ffffa6bd9a8ac000 x10: 0000000000f0000f x9 : ffffffffffffffff [ 0.000000] x8 : ffffa6bd98822e18 x7 : 0070752d65746174 x6 : 00111ff76e007261 [ 0.000000] x5 : ffffa6bd9ad68078 x4 : 0000000000000000 x3 : ffffa6bd98822a0c [ 0.000000] x2 : 0000000000000073 x1 : 0000000000000001 x0 : ffff00001be8b600 [ 0.000000] Call trace: [ 0.000000] arch_timer_shutdown_virt+0x4/0x1c (P) [ 0.000000] cpuhp_invoke_callback+0x11c/0x280 [ 0.000000] cpuhp_issue_call+0x1e8/0x224 [ 0.000000] __cpuhp_setup_state_cpuslocked+0x1d8/0x2b8 [ 0.000000] __cpuhp_setup_state+0x50/0x74 [ 0.000000] arch_timer_register+0xc0/0x148 [ 0.000000] arch_timer_of_init+0x148/0x170 [ 0.000000] timer_probe+0x74/0x124 [ 0.000000] time_init+0x18/0x58 [ 0.000000] start_kernel+0x1c0/0x3ac [ 0.000000] __primary_switched+0x88/0x90 [ 0.000000] Code: c80b7d2a 35ffffab 17ffffeb d503245f (d53be328)And for non protected VMs seems to hang or progress really slowly.
The workaround avoids setting non-zero
CNTVOFF_EL2and trapping the virtual counter to emulate the offset.
In the VHE path (timer_set_traps()), traps are only enabled when the guest actually has a non-zero virtual timer offset. However,__timer_enable_traps()inhyp/nvhe/timer-sr.cunconditionally setCNTHCTL_EL1TVTandCNTHCTL_EL1TVCTwheneverhas_broken_cntvoff()was true.Which causes 2 issues:
1) Protected VMs:kvm_handle_pvm_sysreg()does not find "cntv_ctl_el0" inpvm_sys_reg_descsand injects undefined instruction exceptions.2) non-protected guests are trapped all the time even with offset of zero.
Fix this by adding a check in
__timer_enable_traps()similar to the one intimer_set_traps()Fixes 0bc9a9e85fcf ("KVM: arm64: Work around x1e's CNTVOFF_EL2 bogosity")Signed-off-by Mostafa Saleh <[email protected]>--- arch/arm64/kvm/hyp/nvhe/timer-sr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/arm64/kvm/hyp/nvhe/timer-sr.c +0
-0@@ -10,6 +10,7 @@
Quoted 9 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c line 13
Quoted 3 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c +1
-0#include <asm/kvm_hyp.h> #include <asm/kvm_mmu.h> +#include <hyp/switch.h> I'd rather not include this. It drags too many things, and is solely expected to be included from
switch.c(both implementations).You could use the hack below as a prefix to this change.
I see, I will add your patch as a prefix and respin another version.
Quoted 11 lines
Quoted 11 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c +1
-1void __kvm_timer_set_cntvoff (u64 cntvoff) {@@ -63,7 +64,7 @@ void __timer_enable_traps(struct kvm_vcpu *vcpu)* Trap the virtual counter/timer if we have a broken cntvoff * implementation. */ -if (has_broken_cntvoff ()) +if (has_broken_cntvoff () &&hyp_timer_get_offset (vcpu_vtimer (vcpu))) set |=CNTHCTL_EL1TVT |CNTHCTL_EL1TVCT ;
Quoted 8 lines
arch/arm64/kvm/hyp/nvhe/timer-sr.c void __timer_enable_traps(struct kvm_vcpu *vcpu) · line 70
Quoted 1 line
arch/arm64/kvm/hyp/nvhe/timer-sr.c +0
-0sysreg_clear_set (cnthctl_el2, clr, set);I don't immediately see why a non-protected guest is so slow with hVHE, irrespective of the offset. Even if we go back to the host for the emulation, this should be usable.
Could you describe what actually happens? Do you also see the issue with pure hVHE (without protected)?
I haven't checked with pure hvhe, I do not have access to the HW at the moment, but I can repro both the pVM panic and non-protected hang on Qemu by stubbing “has_broken_cntvoff()” which indicates it’s a software issue.
I looked more into this and I think I get it, which is the same bug Sashiko reported here:
The kernel sets the offset when a non-protected VM is started at kvm_timer_vcpu_init() based on the current timer value.
When hypervisor emulates the timer it reads in kvm_handle_cntxct() => compute_counter_value() which sets offset of zero (that's a bug) and the guest reads the raw counter value.
However, I see the guest using CVAL (likely for tick or events), which is handled by the host and not the hypervisor, and the host will use the true offset in that case which is not zero, which makes the VM events fire way later.
Adding some traces in timer_restore_state() I can confirm the massive CVAL diff from the current virtual timer.
I have a fix already for this that fixes the hang without this patch, I will send it along the respin shortly.
Thanks,
Mostafa
Quoted 105 lines
Thanks,
M.From
a7ec0d7f23d86b028164328f33a7114fa6aad2c3Mon Sep 17 00:00:00 2001
From: Marc Zyngier <[email protected]>
Date: Fri, 7 Aug 2026 11:36:48 +0100
Subject: [PATCH] KVM: arm64: Maketimer_get_offset()work in all contextsWe currently have two implementations of
get_timeroffset(), one inarm_arch_timer.h, and another one inswitch.h.These two only differ by a pair of
kern_hyp_va(), which seems a pretty weak reason to open-code it.Turn this function into a macro to avoid the include dependency hell on
kern_hyp_va(), and make it work correctly in all contexts.Signed-off-by Marc Zyngier <[email protected]>--- arch/arm64/kvm/hyp/include/hyp/switch.h | 15 +---------- include/kvm/arm_arch_timer.h | 34 +++++++++++++++---------- 2 files changed, 22 insertions(+), 27 deletions(-)arch/arm64/kvm/hyp/include/hyp/switch.h +1
-14@@ -706,22 +706,9 @@ static inline bool handle_tx2_tvm(struct kvm_vcpu *vcpu)return true; } -/* Open-coded version of timer_get_offset() to allow for kern_hyp_va() */ -static inline u64 hyp_timer_get_offset (struct arch_timer_context *ctxt) -{ -u64 offset =0 ; - -if (ctxt->offset.vm_offset) - offset += *kern_hyp_va (ctxt->offset.vm_offset); -if (ctxt->offset.vcpu_offset) - offset += *kern_hyp_va (ctxt->offset.vcpu_offset); - -return offset; -} -static inline u64 compute_counter_value (struct arch_timer_context *ctxt) { -return arch_timer_read_cntpct_el0 () -hyp_timer_get_offset (ctxt); +return arch_timer_read_cntpct_el0 () -timer_get_offset (ctxt); }static bool kvm_handle_cntxct (struct kvm_vcpu *vcpu)include/kvm/arm_arch_timer.h +21
-13@@ -162,20 +162,28 @@ static inline bool has_cntpoff(void)return (has_vhe () &&cpus_have_final_cap (ARM64_HAS_ECV_CNTPOFF )); } -static inline u64 timer_get_offset (struct arch_timer_context *ctxt) -{ -u64 offset =0 ; +#ifdef __KVM_NVHE_HYPERVISOR__ +#define KERN_HYP_VA (x) kern_hyp_va(x) +#else +#define KERN_HYP_VA (x) x +#endif -if (!ctxt) -return 0 ; - -if (ctxt->offset.vm_offset) - offset += *ctxt->offset.vm_offset; -if (ctxt->offset.vcpu_offset) - offset += *ctxt->offset.vcpu_offset; - -return offset; -} +#define timer_get_offset (ctxt) \ + ({ \ + struct arch_timer_context *__ctxt = (ctxt); \ + u64 off = 0; \ + \ + if (__ctxt) { \ + struct arch_timer_offset *ato = &__ctxt->offset;\ + \ + if (ato->vm_offset) \ + off += *KERN_HYP_VA(ato->vm_offset); \ + if (ato->vcpu_offset) \ + off += *KERN_HYP_VA(ato->vcpu_offset); \ + } \ + \ + off; \ + })static inline void timer_set_offset (struct arch_timer_context *ctxt,u64 offset) {Signature · 5 lines
2.47.3 -- Without deviation from the norm, progress is not possible.