platform/x86: thinkpad_acpi: Fix fan speed reporting on Edge E330
Subsystems (3)
PATCH 1/1 platform/x86: thinkpad_acpi: Fix fan speed reporting on Edge E330
The ThinkPad Edge E330 with H3 firmware uses the non-standard EC fan register block. Without a matching quirk, thinkpad_acpi reads the legacy tachometer registers and reports 0 RPM.
Add the H3 BIOS family to TPACPI_FAN_NS so the driver reads the fan period from EC register 0x95 using the existing non-standard reporting path.
Tested on a ThinkPad Edge E330 with BIOS H3ET77WW and EC H3EC35WW.
--- drivers/platform/x86/lenovo/thinkpad_acpi.c | 1 + 1 file changed, 1 insertion(+)
drivers/platform/x86/lenovo/thinkpad_acpi.c +1 -0
@@ -8840,6 +8840,7 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = {TPACPI_Q_LNV3 ('R' ,'0' ,'T' ,TPACPI_FAN_NS ),/* 11e Gen5 GL */ TPACPI_Q_LNV3 ('R' ,'1' ,'D' ,TPACPI_FAN_NS ),/* 11e Gen5 GL-R */ TPACPI_Q_LNV3 ('R' ,'0' ,'V' ,TPACPI_FAN_NS ),/* 11e Gen5 KL-Y */ +TPACPI_Q_LNV ('H' ,'3' ,TPACPI_FAN_NS ),/* Edge E330 */ TPACPI_Q_LNV3 ('N' ,'1' ,'O' ,TPACPI_FAN_NOFAN ),/* X1 Tablet (2nd gen) */ TPACPI_Q_LNV3 ('R' ,'0' ,'Q' ,TPACPI_FAN_DECRPM ),/* L480 */ TPACPI_Q_LNV('8', 'F', TPACPI_FAN_TPR), /* ThinkPad x120e */
base-commit: 0d839570765118029aa8bf4a95444c6a11aacf85
Signature · 1 line
2.34.1
Quoted 31 lines · Andrew Onyshchuk
The ThinkPad Edge E330 with H3 firmware uses the non-standard EC fan register block. Without a matching quirk,
thinkpad_acpireads the legacy tachometer registers and reports 0 RPM.Add the H3 BIOS family to
TPACPI_FAN_NSso the driver reads the fan period from EC register0x95using the existing non-standard reporting path.Tested on a ThinkPad Edge E330 with BIOS H3ET77WW and EC H3EC35WW.
Signed-off-by Andrew Onyshchuk <[email protected]>--- drivers/platform/x86/lenovo/thinkpad_acpi.c | 1 + 1 file changed, 1 insertion(+)drivers/platform/x86/lenovo/thinkpad_acpi.c +1
-0@@ -8840,6 +8840,7 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = { TPACPI_Q_LNV3('R', '0', 'T', TPACPI_FAN_NS), /* 11e Gen5 GL */ TPACPI_Q_LNV3('R', '1', 'D', TPACPI_FAN_NS), /* 11e Gen5 GL-R */ TPACPI_Q_LNV3('R', '0', 'V', TPACPI_FAN_NS), /* 11e Gen5 KL-Y */ + TPACPI_Q_LNV('H', '3', TPACPI_FAN_NS), /* Edge E330 */ TPACPI_Q_LNV3('N', '1', 'O', TPACPI_FAN_NOFAN), /* X1 Tablet (2ndgen) */
drivers/platform/x86/lenovo/thinkpad_acpi.c +0
-0TPACPI_Q_LNV3 ('R' ,'0' ,'Q' ,TPACPI_FAN_DECRPM ),/* L480 */ TPACPI_Q_LNV('8', 'F', TPACPI_FAN_TPR), /* ThinkPad x120e */
Quoted 3 lines
base-commit:
0d839570765118029aa8bf4a95444c6a11aacf85Signature · 1 line
2.34.1
Afraid this platform is old enough (~14 years I believe?) that I have no easy way to confirm if it's correct or not - so glad you figured it out!
Mark
Ilpo Järvinen
maintainerQuoted 9 lines · Andrew Onyshchuk
The ThinkPad Edge E330 with H3 firmware uses the non-standard EC fan register block. Without a matching quirk,
thinkpad_acpireads the legacy tachometer registers and reports 0 RPM.Add the H3 BIOS family to
TPACPI_FAN_NSso the driver reads the fan period from EC register0x95using the existing non-standard reporting path.[...]
Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also fixes are mostly routed through for-next unless the fix is for a commit introduced in the most recent cycle or is clearly a regression fix.
The list of commits applied:
[1/1] platform/x86: thinkpad_acpi: Fix fan speed reporting on Edge E330
commit: 051292bf7697e72a760401b6883c55a98beecc5b
--
i.