Skip to contentSkip to conversation

fix license error

PATCH In review Wang Mingyu 2 participants 3 messages Aug 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix license error

From: Wang Mingyu <[email protected]>

---
 .../python/python3-cssselect_1.1.0.bb                 |  2 +-
 .../python/python3-django-appconf_1.0.4.bb            |  2 +-
 .../python/python3-django-babel_0.6.2.bb              |  2 +-
 .../python/python3-django-nose_1.4.7.bb               |  4 ++--
 .../python/python3-dogpile.cache_1.1.2.bb             |  2 +-
 .../recipes-devtools/python/python3-kombu_5.0.2.bb    |  2 +-
 .../recipes-devtools/python/python3-logutils_0.3.5.bb |  2 +-
 .../python/python3-nose-exclude_0.5.0.bb              |  5 -----
 .../recipes-devtools/python/python3-pecan_1.4.0.bb    |  8 ++++++--
 .../recipes-devtools/python/python3-pysnmp_4.4.12.bb  |  4 ++--
 .../python/python3-setuptools-git_1.2.bb              |  2 +-
 ...narios_0.5.0.bb => python3-testscenarios_0.6.2.bb} | 11 ++++++-----
 .../python/python3-unicodecsv_0.14.1.bb               |  2 +-
 .../python/python3-voluptuous_0.12.0.bb               |  2 +-
 14 files changed, 25 insertions(+), 25 deletions(-)
 rename meta-openstack/recipes-devtools/python/{python3-testscenarios_0.5.0.bb => python3-testscenarios_0.6.2.bb} (61%)
meta-openstack/recipes-devtools/python/python3-cssselect_1.1.0.bb +1 -1
index a13a2183..592c640c 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "cssselect parses CSS3 Selectors and translates them to XPath 1.0"
 HOMEPAGE = "http://packages.python.org/cssselect/"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=952026b3fd2f625f2a3c0aa21da2493d"
 
 SRC_URI[md5sum] = "fa57704c1cb66cc8e537b782bd6b227e"
meta-openstack/recipes-devtools/python/python3-django-appconf_1.0.4.bb +1 -1
index cffcb353..7d334e81 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "A helper class for handling configuration defaults of packaged apps gracefully."
 HOMEPAGE = "http://django-appconf.readthedocs.org/"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=3f34b9b2f6413fd5f91869fa7e992457"
 
 SRC_URI[md5sum] = "da4a355140acaa3eeb236987ab174e9d"
meta-openstack/recipes-devtools/python/python3-django-babel_0.6.2.bb +1 -1
index 0c4dd755..0cca5755 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "Tools for using Babel with Django"
 HOMEPAGE = "https://github.com/python-babel/django-babel"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://COPYING;md5=5ae97ab65116b8d7890c59de57577b46"
 
 inherit setuptools3 pypi
meta-openstack/recipes-devtools/python/python3-django-nose_1.4.7.bb +2 -2
index 3fb8b633..fa3e3798 100644
@@ -4,7 +4,7 @@
 DESCRIPTION = "Django test runner using nose"
 HOMEPAGE = "https://github.com/django-nose/django-nose"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=7f88f52f66738ec7259424ce46e855c2"
 
 SRC_URI[md5sum] = "fe386c6e218b0f7b353494329c380a79"
@@ -18,7 +18,7 @@ DEPENDS += " \
 
 RDEPENDS:${PN} += " \
         python3-django \
-        python3-nose \
+        python3-nose-exclude \
         python3-misc \
         "
 
meta-openstack/recipes-devtools/python/python3-dogpile.cache_1.1.2.bb +1 -1
index 41e36333..f0970942 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "Python Dogpile Cache: A caching front-end based on the Dogpile lock"
 HOMEPAGE = "https://pypi.python.org/pypi/dogpile.cache"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=6d830a549d9d8c25362346e0f8fbba53"
 
 SRC_URI[md5sum] = "fb9bea726156560d03890599c4cd92e0"
meta-openstack/recipes-devtools/python/python3-kombu_5.0.2.bb +1 -1
index bd06f3ee..a3c97314 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "A messaging framework for Python"
 HOMEPAGE = "http://kombu.readthedocs.org"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=daea7c168428449fbee05e644df929f4"
 
 SRC_URI[md5sum] = "52192e631ac39a443fb1abeb52299f22"
meta-openstack/recipes-devtools/python/python3-logutils_0.3.5.bb +1 -1
index c0068559..2024ee0d 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "Set of handlers for the Python standard library's logging package"
 HOMEPAGE = "https://pypi.python.org/pypi/logutils"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=44c35f0b8e2a27a2f33a4e4a5c65d014"
 
 SRC_URI[md5sum] = "fcd2f8e9217bfa0b580f253b35a9d954"
meta-openstack/recipes-devtools/python/python3-nose-exclude_0.5.0.bb +0 -5
index 765c9b08..e8356bbe 100644
@@ -15,8 +15,3 @@ inherit setuptools3 pypi
 DEPENDS += " \
         python3-pip \
         "
-
-RDEPENDS:${PN} += " \
-        python3-nose \
-        "
-
meta-openstack/recipes-devtools/python/python3-pecan_1.4.0.bb +6 -2
index b772ca40..b8ed8231 100644
@@ -1,13 +1,13 @@
 DESCRIPTION = "WSGI object-dispatching web framework"
 HOMEPAGE = "https://pypi.python.org/pypi/pecan/"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=d846877d24bbb3d7a00a985c90378e8c"
 
 SRC_URI[md5sum] = "70667908b648043bc8a3fcb7d1e4d53a"
 SRC_URI[sha256sum] = "4b2acd6802a04b59e306d0a6ccf37701d24376f4dc044bbbafba3afdf9d3389a"
 
-inherit setuptools3 pypi
+inherit python_setuptools_build_meta pypi
 
 RDEPENDS:${PN} = "${PYTHON_PN}-mako \
                   ${PYTHON_PN}-webtest \
@@ -17,3 +17,7 @@ RDEPENDS:${PN} = "${PYTHON_PN}-mako \
                   ${PYTHON_PN}-backlash \
                   ${PYTHON_PN}-pprint \
 "
+
+do_configure:prepend() {
+    sed -i "/scripts.*bin\/pecan/d" ${S}/setup.py
+}
meta-openstack/recipes-devtools/python/python3-pysnmp_4.4.12.bb +2 -2
index c7acfaea..4cdd76f1 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "A pure-Python SNMPv1/v2c/v3 library"
 HOMEPAGE = "https://pypi.python.org/pypi/pysnmp"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE.rst;md5=b15d29f500f748d1c2a15709769090a8"
 
 SRC_URI[md5sum] = "2222880259daf6e2cb322e938c818276"
@@ -9,6 +9,6 @@ SRC_URI[sha256sum] = "0c3dbef2f958caca96071fe5c19de43e9c1b0484ab02a0cf08b190bcee
 
 inherit setuptools3 pypi
 
-RDEPENDS:${PN} += "${PYTHON_PN}-pycrypto \
+RDEPENDS:${PN} += "${PYTHON_PN}-pycryptodome \
                    ${PYTHON_PN}-pyasn1 \
 "
meta-openstack/recipes-devtools/python/python3-setuptools-git_1.2.bb +1 -1
index 98fec91f..7554cc33 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "Plugin for setuptools that enables git integration"
 HOMEPAGE = "https://github.com/wichert/setuptools-git"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=3775480a712fc46a69647678acb234cb"
 
 SRC_URI[md5sum] = "40b2ef7687a384ea144503c2e5bc67e2"
meta-openstack/recipes-devtools/python/python3-testscenarios_0.6.2.bb renamed from meta-openstack/recipes-devtools/python/python3-testscenarios_0.5.0.bb +6 -5
similarity index 61%
rename from meta-openstack/recipes-devtools/python/python3-testscenarios_0.5.0.bb
rename to meta-openstack/recipes-devtools/python/python3-testscenarios_0.6.2.bb
index 79b03fb7..2a9dd71c 100644
@@ -1,16 +1,17 @@
 DESCRIPTION = "testscenarios: a pyunit extension for dependency injection"
 HOMEPAGE = "https://pypi.python.org/pypi/testscenarios"
 SECTION = "devel/python"
-LICENSE = "BSD"
-LIC_FILES_CHKSUM = "file://BSD;md5=0805e4f024d089a52dca0671a65b8b66"
+LICENSE = "Apache-2.0 OR BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://BSD;md5=0805e4f024d089a52dca0671a65b8b66 \
+                    file://Apache-2.0;md5=3b83ef96387f14655fc854ddc3c6bd57"
 
-SRC_URI[md5sum] = "859073d9e7b049aee2e6704c51f6001a"
-SRC_URI[sha256sum] = "c257cb6b90ea7e6f8fef3158121d430543412c9a87df30b5dde6ec8b9b57a2b6"
+SRC_URI[sha256sum] = "ab5ae8cd550e11ea978151981e7a8ecac329b7b22e4dec706b1e6fe213f463e7"
 
-inherit setuptools3 pypi
+inherit python_hatchling pypi
 
 DEPENDS += "\
     ${PYTHON_PN}-pbr \
+    ${PYTHON_PN}-hatch-vcs-native \
     "
 
 # Satisfy setup.py 'setup_requires'
meta-openstack/recipes-devtools/python/python3-unicodecsv_0.14.1.bb +1 -1
index b11c3d85..3520a980 100644
@@ -1,7 +1,7 @@
 SUMMARY = "Python2's stdlib csv module replacement with unicode support"
 HOMEPAGE = "https://github.com/jdunck/python-unicodecsv"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 
 LIC_FILES_CHKSUM = "file://PKG-INFO;md5=776dee90d219355b4ffd5c06fda5a39d"
 
meta-openstack/recipes-devtools/python/python3-voluptuous_0.12.0.bb +1 -1
index 3e77e306..7b5e50b3 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "Voluptuous is a Python data validation library"
 HOMEPAGE = "https://pypi.python.org/pypi/voluptuous/"
 SECTION = "devel/python"
-LICENSE = "BSD"
+LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://COPYING;md5=9855ba150f2edb00d8e7a41554896ffb"
 
 SRC_URI[md5sum] = "4b628978d320baeee543ee407aefc0b1"
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/1 open-iscsi-kernel: remove recipe

From: Wang Mingyu <[email protected]>

Upstream SRC_URI is no longer reachable, so the recipe cannot fetch.

---
 .../open-iscsi/open-iscsi-kernel_2.0-873.bb   | 25 -------------------
 1 file changed, 25 deletions(-)
 delete mode 100644 meta-openstack/recipes-connectivity/open-iscsi/open-iscsi-kernel_2.0-873.bb
meta-openstack/recipes-connectivity/open-iscsi/open-iscsi-kernel_2.0-873.bb deleted +0 -25
deleted file mode 100644
index 81b3cd01..00000000
@@ -1,25 +0,0 @@
-DESCRIPTION = "Open-iSCSI project is a high performance, transport independent, multi-platform implementation of RFC3720."
-HOMEPAGE = "http://www.open-iscsi.org/"
-LICENSE = "GPL"
-MACHINE_KERNEL_PR:append = "a"
-PR = "r2"
-
-LIC_FILES_CHKSUM = "file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
-
-SRC_URI = " http://www.open-iscsi.org/bits/open-iscsi-${PV}.tar.gz "
-
-S = "${UNPACKDIR}/open-iscsi-${PV}"
-TARGET_CC_ARCH += "${LDFLAGS}"
-
-inherit module
-
-do_compile () {
-        oe_runmake 'KSRC=${STAGING_KERNEL_DIR}' LDFLAGS="" kernel
-}
-
-do_install() {
-        oe_runmake 'KSRC=${STAGING_KERNEL_DIR}' LDFLAGS="" DESTDIR="${D}" install_kernel
-}
-
-SRC_URI[md5sum] = "8b8316d7c9469149a6cc6234478347f7"
-SRC_URI[sha256sum] = "7dd9f2f97da417560349a8da44ea4fcfe98bfd5ef284240a2cc4ff8e88ac7cd9"
Signature · 1 line
2.43.0
#2 lore raw
In reply to Wang Mingyu

Hi Wang,

Individually each of these changes looks right, but the commit as posted bundles ~5 unrelated fixes under "fix license error" and I'd like a v2 split before I take them. Bisect-hostile if any one turns out to have side effects, and the subject undersells (and mis-names) most of what's in there.

Suggested split, one commit per logical change:

1. python3-*: use SPDX-2 BSD-3-Clause instead of bare BSD

The 11 recipes that just swap LICENSE = "BSD" for LICENSE = "BSD-3-Clause". Pure license syntax cleanup, matches what OE-core is asking for.

2. python3-django-nose, python3-nose-exclude: drop dead python3-nose RDEPENDS

python3-nose is Python-2-era and has been removed upstream. The django-nose swap to python3-nose-exclude belongs here too.

3. python3-pecan: migrate to python_setuptools_build_meta

PEP 517 backend switch + the scripts= sed in setup.py. Not a license fix.

4. python3-pysnmp: replace dead pycrypto with pycryptodome

pycrypto is EOL upstream and gone from oe-core; pycryptodome is the maintained fork.

5. python3-testscenarios: update to 0.6.2

PV bump, dual-license update to "Apache-2.0 OR BSD-3-Clause", backend switch to python_hatchling, dependencies. All belongs together as one version-bump commit.

The 12006 open-iscsi-kernel removal I've taken as-is, thanks.

Bruce