Skip to contentSkip to conversation

syscalls/file_attr01: Fix EOPNOTSUPP expectation on tmpfs

PATCH Applied Wake Liu via ltp 2 participants 5 messages Aug 7 – Aug 10

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 syscalls/file_attr01: Fix EOPNOTSUPP expectation on tmpfs

The test was expecting EOPNOTSUPP when ufattr is NULL on tmpfs without xattr support. However, file_setattr() always copy structure from userspace early (via copy_struct_from_user) and returns EFAULT if the pointer is invalid, before checking filesystem xattr support.

Therefore, the EOPNOTSUPP exception is only valid for file_getattr() which does not read from ufattr early.

Restrict the EOPNOTSUPP expectation to file_getattr() (tst_variant != 0) to avoid false failures on file_setattr().

---
 testcases/kernel/syscalls/file_attr/file_attr01.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/syscalls/file_attr/file_attr01.c +1 -1
index 419d54c36..2e6c07d07 100644
@@ -119,7 +119,7 @@ static void run(unsigned int i)
 	struct tcase *tc = &tcases[i];
 	int exp_errno = tc->exp_errno;
 
-	if (tc->ufattr == (struct file_attr **)(&null_ptr) && missing_tmpfs_xattr)
+	if (tc->ufattr == (struct file_attr **)(&null_ptr) && missing_tmpfs_xattr && tst_variant)
 		exp_errno = EOPNOTSUPP;
 
 	if (tst_variant) {
Signature · 5 lines
2.55.0.654.g21b8a5bc05-goog


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Wake,

Quoted 1 line · Wake Liu

syscalls/file_attr01: Fix EOPNOTSUPP expectation on tmpfs

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp