Skip to contentSkip to conversation

Change in openvpn[master]: t_client.rc-sample: Add missing documentation for FPING_ARGS_x

Openvpn-devel In review flichtenheld (Code Review) via Openvpn-devel 3 participants 7 messages Jul 17 – Aug 8 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1784290573000.Ib6956c3a8b332866a59b41c186cce4e0bc5f078f@gerrit.openvpn.net

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1791?usp=email

to review the following change.

Change subject: t_client.rc-sample: Add missing documentation for FPING_ARGS_x
......................................................................

t_client.rc-sample: Add missing documentation for FPING_ARGS_x

Also include some smaller misc documentation fixes.

Change-Id Ib6956c3a8b332866a59b41c186cce4e0bc5f078f

---
M tests/t_client.rc-sample

1 file changed, 7 insertions(+), 2 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/91/1791/1

tests/t_client.rc-sample +7 -2
index 5534bf8..e92e338 100644
@@ -8,9 +8,13 @@
 # define these - if empty, no tests will run
 #
 top_srcdir="${top_srcdir:-..}"
+
+# PKI args
 CA_CERT="${top_srcdir}/sample/sample-keys/ca.crt"
 CLIENT_KEY="${top_srcdir}/sample/sample-keys/client.key"
 CLIENT_CERT="${top_srcdir}/sample/sample-keys/client.crt"
+
+# Customize ping tests
 #FPING_EXTRA_ARGS="-t 1000"
 
 # Load EXPECT_IFCONFIG* parameters from cache
@@ -63,8 +67,8 @@
 
 #
 #
-# now define the individual tests - all variables suffixed with _1, _2 etc
-# will be used in test run "1", "2", etc.
+# now define the individual tests - all variables suffixed with _1, _2, _2n etc
+# will be used in test run "1", "2", "2n" etc.
 #
 # if something is not defined here, the corresponding test is not run
 #
@@ -86,6 +90,7 @@
 #
 # hook test options:
 #
+# FPING_ARGS_x      = "arguments to append to the fping command line"
 # CHECK_SKIP_x      = "commands to execute before openvpn, skip test on failure"
 # PREPARE_x         = "commands to execute before openvpn"
 # POSTINIT_CMD_x    = "commands to execute after openvpn but before ping"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1791?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib6956c3a8b332866a59b41c186cce4e0bc5f078f
Gerrit-Change-Number: 1791
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1791?usp=email )

Change subject: t_client.rc-sample: Add missing documentation for FPING_ARGS_x
......................................................................

Patch Set 2: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1791?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib6956c3a8b332866a59b41c186cce4e0bc5f078f
Gerrit-Change-Number: 1791
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 07 Aug 2026 11:37:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

#3 lore raw

PATCH v2 1/1 t_client.rc-sample: Add missing documentation for FPING_ARGS_x

In reply to a message not in the archive

Also include some smaller misc documentation fixes.

Change-Id Ib6956c3a8b332866a59b41c186cce4e0bc5f078f

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1791
---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1791
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]>

tests/t_client.rc-sample +7 -2
index d07c376..defa4aa 100644
@@ -8,9 +8,13 @@
 # define these - if empty, no tests will run
 #
 top_srcdir="${top_srcdir:-..}"
+
+# PKI args
 CA_CERT="${top_srcdir}/sample/sample-keys/ca.crt"
 CLIENT_KEY="${top_srcdir}/sample/sample-keys/client.key"
 CLIENT_CERT="${top_srcdir}/sample/sample-keys/client.crt"
+
+# Customize ping tests
 #FPING_EXTRA_ARGS="-t 1000"
 
 # Load EXPECT_IFCONFIG* parameters from cache
@@ -63,8 +67,8 @@
 
 #
 #
-# now define the individual tests - all variables suffixed with _1, _2 etc
-# will be used in test run "1", "2", etc.
+# now define the individual tests - all variables suffixed with _1, _2, _2n etc
+# will be used in test run "1", "2", "2n" etc.
 #
 # if something is not defined here, the corresponding test is not run
 #
@@ -86,6 +90,7 @@
 #
 # hook test options:
 #
+# FPING_ARGS_x      = "arguments to append to the fping command line"
 # CHECK_SKIP_x      = "commands to execute before openvpn, skip test on failure"
 # PREPARE_x         = "commands to execute before openvpn"
 # POSTINIT_CMD_x    = "commands to execute after openvpn but before ping"

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Acked-by Arne Schwabe on v2 1/1
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: t_client.rc-sample: Add missing documentation for FPING_ARGS_x

Thanks. Documentation is always welcome :-) - since it's all commented-out text in a sample file, nothing for me to test, just look at it.

Your patch has been applied to the master and release/2.7 branch (documentation).

commit 944166798f7696d8db2412be59a29f3e3f19270c (master) commit 1728a75745bb069decb1ad229b3780b7f0c799ab (release/2.7)

Author: Frank Lichtenheld
Date:   Fri Aug 7 15:13:27 2026 +0200

t_client.rc-sample: Add missing documentation for FPING_ARGS_x

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1791
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg38207.html

--
kind regards,

Gert Doering

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

#5 lore raw

PATCH v2 1/1 t_client.rc-sample: Add missing documentation for FPING_ARGS_x

In reply to a message not in the archive

From: Frank Lichtenheld <[email protected]>

Also include some smaller misc documentation fixes.

Change-Id Ib6956c3a8b332866a59b41c186cce4e0bc5f078f

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1791
---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1791
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]>

tests/t_client.rc-sample +7 -2
index d07c376..defa4aa 100644
@@ -8,9 +8,13 @@
 # define these - if empty, no tests will run
 #
 top_srcdir="${top_srcdir:-..}"
+
+# PKI args
 CA_CERT="${top_srcdir}/sample/sample-keys/ca.crt"
 CLIENT_KEY="${top_srcdir}/sample/sample-keys/client.key"
 CLIENT_CERT="${top_srcdir}/sample/sample-keys/client.crt"
+
+# Customize ping tests
 #FPING_EXTRA_ARGS="-t 1000"
 
 # Load EXPECT_IFCONFIG* parameters from cache
@@ -63,8 +67,8 @@
 
 #
 #
-# now define the individual tests - all variables suffixed with _1, _2 etc
-# will be used in test run "1", "2", etc.
+# now define the individual tests - all variables suffixed with _1, _2, _2n etc
+# will be used in test run "1", "2", "2n" etc.
 #
 # if something is not defined here, the corresponding test is not run
 #
@@ -86,6 +90,7 @@
 #
 # hook test options:
 #
+# FPING_ARGS_x      = "arguments to append to the fping command line"
 # CHECK_SKIP_x      = "commands to execute before openvpn, skip test on failure"
 # PREPARE_x         = "commands to execute before openvpn"
 # POSTINIT_CMD_x    = "commands to execute after openvpn but before ping"

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

#6 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1791?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by plaisthos

Change subject: t_client.rc-sample: Add missing documentation for FPING_ARGS_x
......................................................................

t_client.rc-sample: Add missing documentation for FPING_ARGS_x

Also include some smaller misc documentation fixes.

Change-Id Ib6956c3a8b332866a59b41c186cce4e0bc5f078f

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1791
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg38207.html

---
M tests/t_client.rc-sample

1 file changed, 7 insertions(+), 2 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/91/1791/3

tests/t_client.rc-sample +7 -2
index d61ecc4..a35d185 100644
@@ -8,9 +8,13 @@
 # define these - if empty, no tests will run
 #
 top_srcdir="${top_srcdir:-..}"
+
+# PKI args
 CA_CERT="${top_srcdir}/sample/sample-keys/ca.crt"
 CLIENT_KEY="${top_srcdir}/sample/sample-keys/client.key"
 CLIENT_CERT="${top_srcdir}/sample/sample-keys/client.crt"
+
+# Customize ping tests
 #FPING_EXTRA_ARGS="-t 1000"
 
 # Load EXPECT_IFCONFIG* parameters from cache
@@ -48,8 +52,8 @@
 
 #
 #
-# now define the individual tests - all variables suffixed with _1, _2 etc
-# will be used in test run "1", "2", etc.
+# now define the individual tests - all variables suffixed with _1, _2, _2n etc
+# will be used in test run "1", "2", "2n" etc.
 #
 # if something is not defined here, the corresponding test is not run
 #
@@ -64,6 +68,7 @@
 #
 # hook test options:
 #
+# FPING_ARGS_x      = "arguments to append to the fping command line"
 # CHECK_SKIP_x      = "commands to execute before openvpn, skip test on failure"
 # PREPARE_x         = "commands to execute before openvpn"
 # POSTINIT_CMD_x    = "commands to execute after openvpn but before ping"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1791?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib6956c3a8b332866a59b41c186cce4e0bc5f078f
Gerrit-Change-Number: 1791
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

#7 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1791?usp=email )

Change subject: t_client.rc-sample: Add missing documentation for FPING_ARGS_x
......................................................................

t_client.rc-sample: Add missing documentation for FPING_ARGS_x

Also include some smaller misc documentation fixes.

Change-Id Ib6956c3a8b332866a59b41c186cce4e0bc5f078f

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1791
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg38207.html

---
M tests/t_client.rc-sample

1 file changed, 7 insertions(+), 2 deletions(-)
tests/t_client.rc-sample +7 -2
index d61ecc4..a35d185 100644
@@ -8,9 +8,13 @@
 # define these - if empty, no tests will run
 #
 top_srcdir="${top_srcdir:-..}"
+
+# PKI args
 CA_CERT="${top_srcdir}/sample/sample-keys/ca.crt"
 CLIENT_KEY="${top_srcdir}/sample/sample-keys/client.key"
 CLIENT_CERT="${top_srcdir}/sample/sample-keys/client.crt"
+
+# Customize ping tests
 #FPING_EXTRA_ARGS="-t 1000"
 
 # Load EXPECT_IFCONFIG* parameters from cache
@@ -48,8 +52,8 @@
 
 #
 #
-# now define the individual tests - all variables suffixed with _1, _2 etc
-# will be used in test run "1", "2", etc.
+# now define the individual tests - all variables suffixed with _1, _2, _2n etc
+# will be used in test run "1", "2", "2n" etc.
 #
 # if something is not defined here, the corresponding test is not run
 #
@@ -64,6 +68,7 @@
 #
 # hook test options:
 #
+# FPING_ARGS_x      = "arguments to append to the fping command line"
 # CHECK_SKIP_x      = "commands to execute before openvpn, skip test on failure"
 # PREPARE_x         = "commands to execute before openvpn"
 # POSTINIT_CMD_x    = "commands to execute after openvpn but before ping"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1791?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib6956c3a8b332866a59b41c186cce4e0bc5f078f
Gerrit-Change-Number: 1791
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel