powerpc/pseries: papr-phy-attest - validate cmd.length, plug mem leak
Subsystems (2)
PATCH 1/1 powerpc/pseries: papr-phy-attest - validate cmd.length, plug mem leak
In papr_phy_attest_create_handle(), the params->cmd.length is not validated before use, which can result in a buffer overlow. Check it and return -EINVAL if it is either 0 or exceeds sizeof(params->cmd).
Also, params is freed on the success path but not error. Free it on errors after memory allocation. And free it on negative fd.
Fixes 86900ab620a4 ("powerpc/pseries: Add a char driver for physical-attestation RTAS")
Acked-by Haren Myneni <[email protected]>
Acked-by Nayna Jain <[email protected]>
Tested-by R Nageswara Sastry <[email protected]>
Cc [email protected] # 6.16
Signed-off-by George Wilson <[email protected]>
--- arch/powerpc/platforms/pseries/papr-phy-attest.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
arch/powerpc/platforms/pseries/papr-phy-attest.c +11 -1
@@ -230,10 +230,17 @@ static long papr_phy_attest_create_handle(struct papr_phy_attest_io_block __userreturn -ENOMEM ;if (copy_from_user (¶ms->cmd, ulc, -sizeof (struct papr_phy_attest_io_block ))) +sizeof (struct papr_phy_attest_io_block ))) { +kfree (params);return -EFAULT ; + } params->cmd_len =be32_to_cpu (params->cmd.length); +if (params->cmd_len ==0 || params->cmd_len >sizeof (params->cmd)) { +kfree (params); +return -EINVAL ; + } + seq = (struct papr_rtas_sequence ) { .begin = phy_attest_sequence_begin, .end = phy_attest_sequence_end,
@@ -246,6 +253,9 @@ static long papr_phy_attest_create_handle(struct papr_phy_attest_io_block __user &papr_phy_attest_handle_ops, "[papr-physical-attestation]"); +if (fd <0 ) +kfree (params); +return fd; }
Signature · 1 line
2.47.3