Skip to contentSkip to conversation

gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM

PATCH In review Yao Qi 5 participants 16 messages Aug 8 – Nov 19

Subsystems (3)
lore
Share & tools
lore

Yao Qi

author
#0 lore raw

PATCH 1/1 gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle (Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these unwanted wakeups. This has been runtime-tested and verified using the gpiolib_acpi.ignore_wake=AMDI0030:00@24 kernel parameter.

---
 drivers/gpio/gpiolib-acpi-quirks.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
drivers/gpio/gpiolib-acpi-quirks.c +13 -0
index a0116f004..8d7d18b62 100644
@@ -392,6 +392,19 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
 			.ignore_wake = "VEN_0488:00@355",
 		},
 	},
+	{
+		/*
+		 * Spurious wakeups from s2idle when suspended with an
+		 * external HDMI display connected.
+		 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TX Air FA401GM"),
+		},
+		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+			.ignore_wake = "AMDI0030:00@24",
+		},
+	},
 	{} /* Terminating entry */
 };
 
Signature · 1 line
2.55.0
maintainer
#1 lore raw
Quoted 10 lines · Yao Qi

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle (Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these unwanted wakeups. This has been runtime-tested and verified using the gpiolib_acpi.ignore_wake=AMDI0030:00@24 kernel parameter.

If AMD people will be quick enough to tag this, I will include in my PR to Linus W. on next week.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 7 lines · Yao Qi

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle (Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Quoted 6 lines
Quoted 3 lines

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these unwanted wakeups. This has been runtime-tested and verified using the gpiolib_acpi.ignore_wake=AMDI0030:00@24 kernel parameter.

If AMD people will be quick enough to tag this, I will include in my PR to Linus W. on next week.

To Bartosz?

It's gpiolib...

Yours,
Linus Walleij

maintainer
#3 lore raw
Quoted 15 lines · Linus Walleij
Quoted 13 lines · Andy Shevchenko
Quoted 10 lines · Yao Qi

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle (Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these unwanted wakeups. This has been runtime-tested and verified using the gpiolib_acpi.ignore_wake=AMDI0030:00@24 kernel parameter.

Quoted 5 lines
Quoted 2 lines

If AMD people will be quick enough to tag this, I will include in my PR to Linus W. on next week.

To Bartosz?
It's gpiolib...

Oh, true, I have also pin control stuff to send!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Reviewed-by
#4 lore raw
Quoted 16 lines · Andy Shevchenko
Quoted 15 lines · Linus Walleij
Quoted 13 lines · Andy Shevchenko
Quoted 10 lines · Yao Qi

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle (Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these unwanted wakeups. This has been runtime-tested and verified using the gpiolib_acpi.ignore_wake=AMDI0030:00@24 kernel parameter.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

If AMD people will be quick enough to tag this, I will include in my PR to Linus W. on next week.

To Bartosz?
It's gpiolib...

Oh, true, I have also pin control stuff to send!

Okay, I have checked if I have anything to Bart and it seems I mixed that with pin control stuff. So, Bart, if you feel confident about this patch, you can take it directly. Here is my formal tag for that

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
Quoted 23 lines · Andy Shevchenko
Quoted 22 lines · Andy Shevchenko
Quoted 20 lines · Linus Walleij
Quoted 9 lines · Andy Shevchenko
Quoted 7 lines · Yao Qi

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle (Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Quoted 6 lines
Quoted 3 lines

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these unwanted wakeups. This has been runtime-tested and verified using the gpiolib_acpi.ignore_wake=AMDI0030:00@24 kernel parameter.

If AMD people will be quick enough to tag this, I will include in my PR to Linus W. on next week.

To Bartosz?
It's gpiolib...

Quoted 8 lines
Quoted 1 line

Oh, true, I have also pin control stuff to send!

Okay, I have checked if I have anything to Bart and it seems I mixed that with pin control stuff. So, Bart, if you feel confident about this patch, you can take it directly. Here is my formal tag for that

Is this a bugfix? I'll be OoO until the end of August starting on Friday with the exception of a single day to catch up on email. I'll be sending my PRs for v7.3 tomorrow. Not sure if I should take it for v7.3 or v7.2?

Bart

maintainer
#6 lore raw
Quoted 7 lines · Bartosz Golaszewski
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Linus Walleij
Quoted 1 line · Andy Shevchenko

On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:

...

Quoted 12 lines
Quoted 12 lines
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

If AMD people will be quick enough to tag this, I will include in my PR to Linus W. on next week.

To Bartosz?
It's gpiolib...

Oh, true, I have also pin control stuff to send!

Okay, I have checked if I have anything to Bart and it seems I mixed that with pin control stuff. So, Bart, if you feel confident about this patch, you can take it directly. Here is my formal tag for that

Quoted 5 lines
Quoted 1 line

Is this a bugfix? I'll be OoO until the end of August starting on Friday with the exception of a single day to catch up on email. I'll be sending my PRs for v7.3 tomorrow. Not sure if I should take it for v7.3 or v7.2?

On one hand there is no rocket science behind this patch (that's why I gave my tag), but if you strictly want AMD to confirm, then postpone, so it's up to you to decide.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#7 lore raw
Quoted 23 lines · Andy Shevchenko
Quoted 7 lines · Bartosz Golaszewski
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Linus Walleij
Quoted 1 line · Andy Shevchenko

On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:

...

Quoted 12 lines
Quoted 12 lines
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

If AMD people will be quick enough to tag this, I will include in my PR to Linus W. on next week.

To Bartosz?
It's gpiolib...

Oh, true, I have also pin control stuff to send!

Okay, I have checked if I have anything to Bart and it seems I mixed that with pin control stuff. So, Bart, if you feel confident about this patch, you can take it directly. Here is my formal tag for that

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

Is this a bugfix? I'll be OoO until the end of August starting on Friday with the exception of a single day to catch up on email. I'll be sending my PRs for v7.3 tomorrow. Not sure if I should take it for v7.3 or v7.2?

On one hand there is no rocket science behind this patch (that's why I gave my tag), but if you strictly want AMD to confirm, then postpone, so it's up to you to decide.

If this is not an important bugfix, then let me postpone it until next cycle.

Bart

maintainer
#8 lore raw
Quoted 10 lines · Bartosz Golaszewski
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Bartosz Golaszewski
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Linus Walleij
Quoted 1 line · Andy Shevchenko

On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:

...

Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 13 lines
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

If AMD people will be quick enough to tag this, I will include in my PR to Linus W. on next week.

To Bartosz?
It's gpiolib...

Oh, true, I have also pin control stuff to send!

Okay, I have checked if I have anything to Bart and it seems I mixed that with pin control stuff. So, Bart, if you feel confident about this patch, you can take it directly. Here is my formal tag for that

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Is this a bugfix? I'll be OoO until the end of August starting on Friday with the exception of a single day to catch up on email. I'll be sending my PRs for v7.3 tomorrow. Not sure if I should take it for v7.3 or v7.2?

On one hand there is no rocket science behind this patch (that's why I gave my tag), but if you strictly want AMD to confirm, then postpone, so it's up to you to decide.

If this is not an important bugfix, then let me postpone it until next cycle.

I believe a user may survive with this bug to be present for a bit longer. But not my call, at Intel I have no such hardware :-)

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#9 lore raw
Quoted 32 lines · Andy Shevchenko
Quoted 10 lines · Bartosz Golaszewski
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Bartosz Golaszewski
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Linus Walleij
Quoted 1 line · Andy Shevchenko

On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:

...

Quoted 18 lines
Quoted 18 lines
Quoted 17 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines

If AMD people will be quick enough to tag this, I will include in my PR to Linus W. on next week.

To Bartosz?
It's gpiolib...

Quoted 7 lines
Quoted 1 line

Oh, true, I have also pin control stuff to send!

Okay, I have checked if I have anything to Bart and it seems I mixed that with pin control stuff. So, Bart, if you feel confident about this patch, you can take it directly. Here is my formal tag for that

Is this a bugfix? I'll be OoO until the end of August starting on Friday with the exception of a single day to catch up on email. I'll be sending my PRs for v7.3 tomorrow. Not sure if I should take it for v7.3 or v7.2?

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

On one hand there is no rocket science behind this patch (that's why I gave my tag), but if you strictly want AMD to confirm, then postpone, so it's up to you to decide.

If this is not an important bugfix, then let me postpone it until next cycle.

I believe a user may survive with this bug to be present for a bit longer. But not my call, at Intel I have no such hardware :-)

No worries, it can go upstream right after I'm back from vacations.

Bart

maintainer
#10 lore raw
Quoted 13 lines · Bartosz Golaszewski
Quoted 11 lines · Andy Shevchenko
Quoted 10 lines · Bartosz Golaszewski
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Bartosz Golaszewski
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Linus Walleij
Quoted 1 line · Andy Shevchenko

On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:

...

Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Quoted 20 lines
Quoted 12 lines
Quoted 12 lines
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

If AMD people will be quick enough to tag this, I will include in my PR to Linus W. on next week.

To Bartosz?
It's gpiolib...

Oh, true, I have also pin control stuff to send!

Okay, I have checked if I have anything to Bart and it seems I mixed that with pin control stuff. So, Bart, if you feel confident about this patch, you can take it directly. Here is my formal tag for that

Quoted 5 lines
Quoted 1 line

Is this a bugfix? I'll be OoO until the end of August starting on Friday with the exception of a single day to catch up on email. I'll be sending my PRs for v7.3 tomorrow. Not sure if I should take it for v7.3 or v7.2?

On one hand there is no rocket science behind this patch (that's why I gave my tag), but if you strictly want AMD to confirm, then postpone, so it's up to you to decide.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

If this is not an important bugfix, then let me postpone it until next cycle.

I believe a user may survive with this bug to be present for a bit longer. But not my call, at Intel I have no such hardware :-)

No worries, it can go upstream right after I'm back from vacations.

Since there is another similar patch pending, I will take them all into my branch and issue a fix PR after -rc1.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#11 lore raw
In reply to Yao Qi
Quoted 10 lines · Yao Qi

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle (Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these unwanted wakeups. This has been runtime-tested and verified using the gpiolib_acpi.ignore_wake=AMDI0030:00@24 kernel parameter.

Mario, can you ack this one?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#12 lore raw
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Yao Qi

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle (Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Quoted 6 lines
Quoted 3 lines

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these unwanted wakeups. This has been runtime-tested and verified using the gpiolib_acpi.ignore_wake=AMDI0030:00@24 kernel parameter.

Mario, can you ack this one?

It's likely very similar to

https://lore.kernel.org/linux-gpio/[email protected]/

As you can see that's also GPIO pin 24.

Can we please see an acpidump to confirm though?

maintainer
#13 lore raw
Quoted 13 lines · Mario Limonciello
Quoted 12 lines · Andy Shevchenko
Quoted 10 lines · Yao Qi

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle (Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these unwanted wakeups. This has been runtime-tested and verified using the gpiolib_acpi.ignore_wake=AMDI0030:00@24 kernel parameter.

Quoted 7 lines
Quoted 1 line

Mario, can you ack this one?

It's likely very similar to

https://lore.kernel.org/linux-gpio/[email protected]/

As you can see that's also GPIO pin 24.

Right, but this will need still its own DMI entry, will it?

Quoted 1 line

Can we please see an acpidump to confirm though?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#14 lore raw
Quoted 16 lines · Andy Shevchenko
Quoted 15 lines · Mario Limonciello
Quoted 13 lines · Andy Shevchenko
Quoted 10 lines · Yao Qi

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle (Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these unwanted wakeups. This has been runtime-tested and verified using the gpiolib_acpi.ignore_wake=AMDI0030:00@24 kernel parameter.

Mario, can you ack this one?

Quoted 8 lines
Quoted 5 lines

It's likely very similar to

https://lore.kernel.org/linux-gpio/[email protected]/

As you can see that's also GPIO pin 24.

Right, but this will need still its own DMI entry, will it?

Right. We just need to look through the acpidump to confirm this.

Quoted 2 lines
Quoted 1 line

Can we please see an acpidump to confirm though?

maintainer
#15 lore raw
Quoted 19 lines · Mario Limonciello
Quoted 18 lines · Andy Shevchenko
Quoted 17 lines · Mario Limonciello
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Yao Qi

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle (Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Quoted 5 lines
Quoted 3 lines

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these unwanted wakeups. This has been runtime-tested and verified using the gpiolib_acpi.ignore_wake=AMDI0030:00@24 kernel parameter.

Mario, can you ack this one?

It's likely very similar to

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

https://lore.kernel.org/linux-gpio/[email protected]/

As you can see that's also GPIO pin 24.

Right, but this will need still its own DMI entry, will it?

Right. We just need to look through the acpidump to confirm this.

Quoted 1 line
Quoted 1 line

Can we please see an acpidump to confirm though?

Yao Qi, do you have a reference to ACPI tables (acpidump) for us?

Signature · 2 lines
With Best Regards,
Andy Shevchenko