Skip to contentSkip to conversation

staging: greybus: light: use sysfs_emit() instead of sprintf()

PATCH New Mohit Mishra 1 participant 1 message Aug 8

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: greybus: light: use sysfs_emit() instead of sprintf()

color_show() and fade_show callbacks use sprintf() to format sysfs output into the page buffer. Convert them to sysfs_emit(), which is the preferred helper for sysfs show() callbacks as it enforces page boundary checks.

Similar conversions have already been made elsewhere in this subsystem (e.g. loopback.c, arche-platform.c).

---
 drivers/staging/greybus/light.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/greybus/light.c +2 -2
index cab02b5da867..2689f9a7524a 100644
@@ -173,7 +173,7 @@ static ssize_t fade_##__dir##_show(struct device *dev,			\
 	struct led_classdev *cdev = dev_get_drvdata(dev);		\
 	struct gb_channel *channel = get_channel_from_cdev(cdev);	\
 									\
-	return sprintf(buf, "%u\n", channel->fade_##__dir);		\
+	return sysfs_emit(buf, "%u\n", channel->fade_##__dir);		\
 }									\
 									\
 static ssize_t fade_##__dir##_store(struct device *dev,			\
@@ -220,7 +220,7 @@ static ssize_t color_show(struct device *dev, struct device_attribute *attr,
 	struct led_classdev *cdev = dev_get_drvdata(dev);
 	struct gb_channel *channel = get_channel_from_cdev(cdev);
 
-	return sprintf(buf, "0x%08x\n", channel->color);
+	return sysfs_emit(buf, "0x%08x\n", channel->color);
 }
 
 static ssize_t color_store(struct device *dev, struct device_attribute *attr,
Signature · 1 line
2.43.0