Skip to contentSkip to conversation

cifs: fix clearing stats for fastest execution of each smb2 command

PATCH In review Frank Sorenson 2 participants 2 messages Aug 8 – Aug 18

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: fix clearing stats for fastest execution of each smb2 command

The code to clear the 'fastest_cmd' statistics has a typo that repeatedly clears the stat for cmd 0, rather than iterating through each cmd. Fix the typo (0->i).

Fixes 433b8dd7672be ("SMB3: Track total time spent on roundtrips for each SMB3 command")
---
 fs/smb/client/cifs_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/smb/client/cifs_debug.c +1 -1
index 4ed4f55a0bb7..3761d3ad6088 100644
@@ -754,7 +754,7 @@ static ssize_t cifs_stats_proc_write(struct file *file,
 				atomic_set(&server->smb2slowcmd[i], 0);
 				server->time_per_cmd[i] = 0;
 				server->slowest_cmd[i] = 0;
-				server->fastest_cmd[0] = 0;
+				server->fastest_cmd[i] = 0;
 			}
 #endif /* CONFIG_CIFS_STATS2 */
 			list_for_each_entry(ses, &server->smb_ses_list, smb_ses_list) {
Signature · 1 line
2.55.0
maintainer
#1 lore raw
Quoted 7 lines · Frank Sorenson

The code to clear the 'fastest_cmd' statistics has a typo that repeatedly clears the stat for cmd 0, rather than iterating through each cmd. Fix the typo (0->i).

Fixes 433b8dd7672be ("SMB3: Track total time spent on roundtrips for each SMB3 command")

Will apply it to #for-next.
Thanks!