Skip to contentSkip to conversation

hw/nvme: add SPDM_SOCKET Kconfig dependency

PATCH In review Stefan Hajnoczi 3 participants 4 messages Aug 10 – Aug 11

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/nvme: add SPDM_SOCKET Kconfig dependency

The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add a Kconfig dependency to avoid build errors when NVME_PCI is enabled without SPDM_SOCKET.

---
 hw/nvme/Kconfig | 1 +
 1 file changed, 1 insertion(+)
hw/nvme/Kconfig +1 -0
index cfa2ab0f9d5..cfeeed64cd7 100644
@@ -2,3 +2,4 @@ config NVME_PCI
     bool
     default y if PCI_DEVICES || PCIE_DEVICES
     depends on PCI
+    select SPDM_SOCKET
Signature · 1 line
2.55.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Stefan Hajnoczi

The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add a Kconfig dependency to avoid build errors when NVME_PCI is enabled without SPDM_SOCKET.

Fixes 4f947b10d52 ("hw/nvme: Add SPDM over DOE support")
Quoted 14 lines
---
  hw/nvme/Kconfig | 1 +
  1 file changed, 1 insertion(+)
hw/nvme/Kconfig +1 -0
index cfa2ab0f9d5..cfeeed64cd7 100644
@@ -2,3 +2,4 @@ config NVME_PCI
      bool
      default y if PCI_DEVICES || PCIE_DEVICES
      depends on PCI
+    select SPDM_SOCKET
Reviewed-by on v1 1/1
#2 lore raw
In reply to Stefan Hajnoczi
Quoted 22 lines · Stefan Hajnoczi

The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add a Kconfig dependency to avoid build errors when NVME_PCI is enabled without SPDM_SOCKET.

---
 hw/nvme/Kconfig | 1 +
 1 file changed, 1 insertion(+)
hw/nvme/Kconfig +1 -0
index cfa2ab0f9d5..cfeeed64cd7 100644
@@ -2,3 +2,4 @@ config NVME_PCI
     bool
     default y if PCI_DEVICES || PCIE_DEVICES
     depends on PCI
+    select SPDM_SOCKET
Signature · 1 line
2.55.0

Stefan, Philippe,

Do you want to grab this through trivial fixes tree or should I send a pull?

#3 lore raw
Quoted 26 lines · Klaus Jensen
Quoted 22 lines · Stefan Hajnoczi

The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add a Kconfig dependency to avoid build errors when NVME_PCI is enabled without SPDM_SOCKET.

---
  hw/nvme/Kconfig | 1 +
  1 file changed, 1 insertion(+)
hw/nvme/Kconfig +1 -0
index cfa2ab0f9d5..cfeeed64cd7 100644
@@ -2,3 +2,4 @@ config NVME_PCI
      bool
      default y if PCI_DEVICES || PCIE_DEVICES
      depends on PCI
+    select SPDM_SOCKET
Signature · 1 line
2.55.0
Quoted 4 lines

Stefan, Philippe,

Do you want to grab this through trivial fixes tree or should I send a pull?

Sure, queued via hw-misc, thanks!