selftests: drv-net: hide the devlink port_split test
Subsystems (3)
Jakub Kicinski
maintainerPATCH v2 1/1 selftests: drv-net: hide the devlink port_split test
The devlink port_split test has limited applicability. NICs (as opposed to switches) require at least a re-probe to apply the split configuration.
On top of that the test is not compatible with our driver env, it just splits all ports on the system, not only what NETIF points at.
Long term we may want to add some indication in devlink whether the port splitting is runtime (cmode of sorts), and fix the test to follow driver env. But since no (known) NIC driver can support runtime anyway let's just hide the test from the selftest framework by moving it to extra files.
Having this test randomly break unrelated NICs within the DUT makes people implement allow-lists for ksft, which then means their setups don't run new tests. It's very useful during test review to see whether the test works across all the runners.
---
v2:
- use TEST_PROGS_EXTENDED instead of TEST_FILES
v1: https://lore.kernel.org/[email protected]
--- tools/testing/selftests/drivers/net/hw/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
tools/testing/selftests/drivers/net/hw/Makefile +4 -1
@@ -19,7 +19,6 @@ TEST_GEN_FILES := \ TEST_PROGS = \ csum.py \ - devlink_port_split.py \ devlink_rate_cross_esw.py \ devlink_rate_tc_bw.py \ devmem.py \
@@ -54,6 +53,10 @@ TEST_PROGS = \ xsk_reconfig.py \ # +TEST_PROGS_EXTENDED := \ + devlink_port_split.py \ +# end of TEST_PROGS_EXTENDED + TEST_FILES := \ devmem_lib.py \ ethtool_lib.sh \
Signature · 1 line
2.55.0
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Mon, 10 Aug 2026 17:46:45 -0700 you wrote:
The devlink
port_splittest has limited applicability. NICs (as opposed to switches) require at least a re-probe to apply the split configuration.On top of that the test is not compatible with our driver env, it just splits all ports on the system, not only what NETIF points at.
[...]
Here is the summary with links:
- [net-next,v2] selftests: drv-net: hide the devlink port_split test
https://git.kernel.org/netdev/net-next/c/878b56de01e2
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html