Skip to contentSkip to conversation

mtd: spi-nor: xmc: add locking to XM25QH128A

PATCH Applied Michael Walle 3 participants 4 messages Aug 11 – Sep 4

Subsystems (2)
lore
Share & tools
lore

Michael Walle

author maintainer
#0 lore raw

PATCH 1/1 mtd: spi-nor: xmc: add locking to XM25QH128A

Add support for locking to the XM25QH128A part.

---
Hi Takino,

please test it and reply with a "Tested-by" tag. With your full name if you like. I didn't get that from the bug report.

---
 drivers/mtd/spi-nor/xmc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi-nor/xmc.c +1 -0
index d5a06054b0dd..d3b52eb93e2c 100644
@@ -19,6 +19,7 @@ static const struct flash_info xmc_nor_parts[] = {
 		.name = "XM25QH128A",
 		.size = SZ_16M,
 		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+		.flags = SPI_NOR_HAS_LOCK | SPI_NOR_4BIT_BP | SPI_NOR_HAS_TB,
 	},
 };
 
Signature · 1 line
2.47.3
Tested-by Wei, Takino on v1 1/1
#1 lore raw
Quoted 8 lines · Michael Walle

Add support for locking to the XM25QH128A part.

Tested to the max of my abilities here; the driver no longer returns “EOPNOTSUPP”. It now returns “unlocked" which is technically correct as the bits are not set. Intel locks it using a different mechanism and could’ve/should’ve also set the bits. This likely needs a BIOS update to properly fix it. Which may never happen.

Regards,
Takino.

Quoted 24 lines

---
Hi Takino,

please test it and reply with a "Tested-by" tag. With your full name if you like. I didn't get that from the bug report.
---
drivers/mtd/spi-nor/xmc.c | 1 +

1 file changed, 1 insertion(+)
drivers/mtd/spi-nor/xmc.c +1 -0
index d5a06054b0dd..d3b52eb93e2c 100644
@@ -19,6 +19,7 @@ static const struct flash_info xmc_nor_parts[] = {
 .name = "XM25QH128A",
 .size = SZ_16M,
 .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ .flags = SPI_NOR_HAS_LOCK | SPI_NOR_4BIT_BP | SPI_NOR_HAS_TB,
 },
 };
 
Signature · 1 line
2.47.3
reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Michael Walle
Quoted 5 lines

Add support for locking to the XM25QH128A part.

Quoted 23 lines

---
Hi Takino,

please test it and reply with a "Tested-by" tag. With your full name if you like. I didn't get that from the bug report.

---
 drivers/mtd/spi-nor/xmc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi-nor/xmc.c +1 -1
index d5a06054b0dd..d3b52eb93e2c 100644
@@ -19,6 +19,7 @@ static const struct flash_info xmc_nor_parts[] = {
                .name = "XM25QH128A",
                .size = SZ_16M,
                .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+               .flags = SPI_NOR_HAS_LOCK | SPI_NOR_4BIT_BP | SPI_NOR_HAS_TB,
        },
 };
 
--

2.47.3

author maintainer Applied
#3 lore raw
In reply to Michael Walle
Quoted 1 line · Michael Walle

Add support for locking to the XM25QH128A part.

Applied, thanks!

[1/1] mtd: spi-nor: xmc: add locking to XM25QH128A

      commit: 3c2464c70284eb5443a18ea7ee2f815a06d91a5b

Best regards,

Signature · 1 line
Michael Walle <[email protected]>