staging: rtl8723bs: small cleanup of RTL8192C leftovers
cover staging: rtl8723bs: small cleanup of RTL8192C leftovers
Hi,
This is my first patch series to the kernel, and I am glad to contribute.
The series is a step toward the TODO item "find and remove any code for other chips that is left over" in drivers/staging/rtl8723bs/TODO:
- Patch 1 corrects two comments whose referenced file names no longer match the files present in the driver.
- Patch 2 removes two RTL8192C function declarations that have no definition or caller anywhere in the kernel tree.
Neither patch introduces a functional change. The driver builds cleanly with W=1 for CONFIG_RTL8723BS=m.
Thanks,
Jonggeun
Jonggeun Park (2):
staging: rtl8723bs: fix stale file name references in comments
staging: rtl8723bs: remove dead RTL8192C function declarations
drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 2 +- drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 --- drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-)
Signature · 1 line
2.43.0
PATCH 1/2 staging: rtl8723bs: fix stale file name references in comments
Correct two comments whose referenced file names do not match the files currently present in the driver:
- include/rtl8723b_hal.h: "rtl8723a_hal_init.c" -> "rtl8723b_hal_init.c"
- hal/rtl8723b_rf6052.c: "rtl8192c_rf6052.c" -> "rtl8723b_rf6052.c"
No functional change.
--- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 2 +- drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c +1 -1
@@ -7,7 +7,7 @@/****************************************************************************** * * -* Module: rtl8192c_rf6052.c (Source C File) +* Module: rtl8723b_rf6052.c (Source C File) * * Note: Provide RF 6052 series relative API. *
drivers/staging/rtl8723bs/include/rtl8723b_hal.h +1 -1
@@ -185,7 +185,7 @@ enum { /* tag_Package_Definition */#define INCLUDE_MULTI_FUNC_GPS (_Adapter) \ (GET_HAL_DATA(_Adapter)->MultiFunc & RT_MULTI_FUNC_GPS) -/* rtl8723a_hal_init.c */ +/* rtl8723b_hal_init.c */ s32 rtl8723b_FirmwareDownload (struct adapter *padapter,bool bUsedWoWLANFw);void rtl8723b_FirmwareSelfReset (struct adapter *padapter);void rtl8723b_InitializeFirmwareVars (struct adapter *padapter);
Signature · 1 line
2.43.0
PATCH 2/2 staging: rtl8723bs: remove dead RTL8192C function declarations
In reply to Jonggeun Parkinclude/rtl8192c_recv.h declares two functions:
rtl8192c_translate_rx_signal_stuff()
rtl8192c_query_rx_desc_status()
Neither has a definition or any caller in the kernel tree.
Remove them as a step toward the TODO item "find and remove any code for other chips that is left over".
No functional change.
--- drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0 -3
@@ -30,7 +30,4 @@ struct phy_stat {/* Rx smooth factor */ #define Rx_Smooth_Factor (20) -void rtl8192c_translate_rx_signal_stuff (union recv_frame *precvframe,struct phy_stat *pphy_status); -void rtl8192c_query_rx_desc_status (union recv_frame *precvframe,struct recv_stat *pdesc); -#endif
Signature · 1 line
2.43.0
Greg Kroah-Hartman
maintainerRe: [PATCH 2/2] staging: rtl8723bs: remove dead RTL8192C function declarations
Quoted 32 lines · Jonggeun Park
include/rtl8192c_recv.hdeclares two functions:
rtl8192c_translate_rx_signal_stuff()
rtl8192c_query_rx_desc_status()Neither has a definition or any caller in the kernel tree.
Remove them as a step toward the TODO item "find and remove any code for other chips that is left over".
No functional change.
Signed-off-by Jonggeun Park <[email protected]>--- drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 --- 1 file changed, 3 deletions(-)drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0
-3@@ -30,7 +30,4 @@ struct phy_stat {/* Rx smooth factor */ #define Rx_Smooth_Factor (20) -void rtl8192c_translate_rx_signal_stuff (union recv_frame *precvframe,struct phy_stat *pphy_status); -void rtl8192c_query_rx_desc_status (union recv_frame *precvframe,struct recv_stat *pdesc); -#endif Signature · 1 line
2.43.0
This patch was already in the latest tree, sorry.
greg k-h