drm/panthor: ignore CS IRQs for uninitialized slots
Subsystems (4)
PATCH 1/1 drm/panthor: ignore CS IRQs for uninitialized slots
CS interrupts are reported through firmware-provided bits in the CSG interface. sched_process_csg_irq_locked() iterates over those bits and passes each CS ID to cs_slot_process_irq_locked().
panthor_fw_get_cs_iface() only bounds the CS ID against MAX_CS_PER_CSG, while the firmware can expose fewer CS slots. If an IRQ bit is reported for a slot beyond sched->cs_slot_count, the driver can fetch a zero-initialized interface entry and dereference cs_iface->input.
Ignore IRQs for slots that were not exposed by the firmware. The CSG IRQ acknowledgment is already updated from cs_irq_req before processing the individual CS IRQs, so ignored bits are still acknowledged.
--- drivers/gpu/drm/panthor/panthor_sched.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/panthor/panthor_sched.c +3 -0
@@ -1705,6 +1705,9 @@ static bool cs_slot_process_irq_locked(struct panthor_device *ptdev,lockdep_assert_held (&ptdev->scheduler->lock); +if (cs_id >= ptdev->scheduler->cs_slot_count) +return false; + cs_iface =panthor_fw_get_cs_iface (ptdev, csg_id, cs_id); req = cs_iface->input->req; ack = cs_iface->output->ack;
Signature · 1 line
2.43.0
Quoted 25 lines · On Tue, 11 Aug 2026 16:33:18 +0200 Osama Abdelkader…
CS interrupts are reported through firmware-provided bits in the CSG interface.
sched_process_csg_irq_locked()iterates over those bits and passes each CS ID tocs_slot_process_irq_locked().
panthor_fw_get_cs_iface()only bounds the CS ID againstMAX_CS_PER_CSG, while the firmware can expose fewer CS slots. If an IRQ bit is reported for a slot beyondsched->cs_slot_count, the driver can fetch a zero-initialized interface entry and dereferencecs_iface->input.Ignore IRQs for slots that were not exposed by the firmware. The CSG IRQ acknowledgment is already updated from
cs_irq_reqbefore processing the individual CS IRQs, so ignored bits are still acknowledged.Fixes de8548813824 ("drm/panthor: Add the scheduler logical block")Signed-off-by Osama Abdelkader <[email protected]>--- drivers/gpu/drm/panthor/panthor_sched.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/panthor/panthor_sched.c +0
-0
drivers/gpu/drm/panthor/panthor_sched.c static bool cs_slot_process_irq_locked(struct panthor_device *ptdev, · line 1708
Quoted 4 lines
drivers/gpu/drm/panthor/panthor_sched.c +1
-0@@ -1705,6 +1705,9 @@ static bool cs_slot_process_irq_locked(struct panthor_device *ptdev,lockdep_assert_held (&ptdev->scheduler->lock); +if (cs_id >= ptdev->scheduler->cs_slot_count)
if (drm_WARN_ON_ONCE(&ptdev->base, cs_id >= ptdev->scheduler->cs_slot_count))
Since this is certainly not supposed to happen. Looks good otherwise.
Quoted 5 lines
drivers/gpu/drm/panthor/panthor_sched.c +2
-0+return false; + cs_iface =panthor_fw_get_cs_iface (ptdev, csg_id, cs_id); req = cs_iface->input->req; ack = cs_iface->output->ack;