Skip to contentSkip to conversation

dt-bindings: iio: accel: adi,adis16201: add adis16203 compatible

PATCH In review Shehryar Ahmad 3 participants 3 messages Aug 5 – Aug 12

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: iio: accel: adi,adis16201: add adis16203 compatible

The ADIS16203 has the same external interface as the already documented ADIS16201/ADIS16209, for the properties covered by this binding (compatible/reg, the DIO-based interrupt pin, and VDD supply), verified by datasheets Table 5, Pin Function Descriptions, in the respective Analog Devices datasheets. Some Auxiliary pins differ (e.g. adis16209 marks a few pins DNC where adis16201/adis16203 use them as AUX COM), but these are not represented in this binding. Add adis16203 to the existing enum rather than creating a separate file.

Tested with checkpatch.pl --strict and dt_binding_check; both pass with no warnings.

Three prior attempts to document this part are visible on the mailing list, all as separate files, each redirected toward this existing binding approach instead: Saalim Quadri, March 2025 [2], and Sheng Kun Chang, April 2026 [3]. See below for Jonathan Cameron's earlier, related attempt [1].

A richer version adding reset-gpios and a second interrupt (interrupt-names: dio0/dio1) was proposed by Jonathan Cameron in 2023 [1]. I tested the same additions locally for all three parts; checkpatch and dt_binding_check both pass. It is not included here, as it hasn't been verified against any real board dts file, and none in-tree currently reference adis16201, adis16203, or adis16209. Can send that as a follow-up if wanted.

---
 .../devicetree/bindings/iio/accel/adi,adis16201.yaml        | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/iio/accel/adi,adis16201.yaml +4 -2
index b6ba7ad1..3ce5fb1b 100644
@@ -4,21 +4,23 @@
 $id: http://devicetree.org/schemas/iio/accel/adi,adis16201.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: ADIS16201 Dual Axis Inclinometer and similar
+title: ADIS16201 Inclinometer and similar
 
 maintainers:
   - Jonathan Cameron <[email protected]>
 
 description: |
-  Two similar parts from external interface point of view.
+  Three similar parts from external interface point of view.
   SPI interface.
     https://www.analog.com/en/products/adis16201.html
+    https://www.analog.com/en/products/adis16203.html
     https://www.analog.com/en/products/adis16209.html
 
 properties:
   compatible:
     enum:
       - adi,adis16201
+      - adi,adis16203
       - adi,adis16209
 
   reg:
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Shehryar Ahmad

The ADIS16203 has the same external interface as the already documented ADIS16201/ADIS16209, for the properties covered by this binding (compatible/reg, the DIO-based interrupt pin, and VDD supply), verified by datasheets Table 5, Pin Function Descriptions, in the respective Analog Devices datasheets. Some Auxiliary pins differ (e.g. adis16209 marks a few pins DNC where adis16201/adis16203 use them as AUX COM), but these are not represented in this binding. Add adis16203 to the existing enum rather than creating a separate file.

Quoted 2 lines

Tested with checkpatch.pl --strict and dt_binding_check; both pass with no warnings.

This is assumed, no need to record it forever in the commit.

Quoted 15 lines

Three prior attempts to document this part are visible on the mailing list, all as separate files, each redirected toward this existing binding approach instead: Saalim Quadri, March 2025 [2], and Sheng Kun Chang, April 2026 [3]. See below for Jonathan Cameron's earlier, related attempt [1].

A richer version adding reset-gpios and a second interrupt (interrupt-names: dio0/dio1) was proposed by Jonathan Cameron in 2023 [1]. I tested the same additions locally for all three parts; checkpatch and dt_binding_check both pass. It is not included here, as it hasn't been verified against any real board dts file, and none in-tree currently reference adis16201, adis16203, or adis16209. Can send that as a follow-up if wanted.

Quoted 3 lines

Thanks for the history. It should be after the '---' so it too is not recorded in the commit.

Quoted 5 lines
---
 .../devicetree/bindings/iio/accel/adi,adis16201.yaml        | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
maintainer
#2 lore raw
Quoted 11 lines · On Tue, 11 Aug 2026 20:54:21 -0500 Rob Herring <[email protected]> wrote:
Quoted 10 lines · Shehryar Ahmad

The ADIS16203 has the same external interface as the already documented ADIS16201/ADIS16209, for the properties covered by this binding (compatible/reg, the DIO-based interrupt pin, and VDD supply), verified by datasheets Table 5, Pin Function Descriptions, in the respective Analog Devices datasheets. Some Auxiliary pins differ (e.g. adis16209 marks a few pins DNC where adis16201/adis16203 use them as AUX COM), but these are not represented in this binding. Add adis16203 to the existing enum rather than creating a separate file.

Quoted 10 lines
Quoted 2 lines

Tested with checkpatch.pl --strict and dt_binding_check; both pass with no warnings.

This is assumed, no need to record it forever in the commit.

Quoted 5 lines

Three prior attempts to document this part are visible on the mailing list, all as separate files, each redirected toward this existing binding approach instead: Saalim Quadri, March 2025 [2], and Sheng Kun Chang, April 2026 [3]. See below for Jonathan Cameron's earlier, related attempt [1].

Key thing here is that we generally don't take bindings for drivers that are in staging and adis16203 remains there.

This patch looks good for when/if the driver is moved out of staging. There have been various series on list for that so perhaps ask those authors what current status is (just reply to that series).

e.g.

https://lore.kernel.org/linux-iio/[email protected]/

Which is the parent of the last link below and I think the last of various attempts to do this.

Jonathan

Quoted 24 lines
Quoted 10 lines

A richer version adding reset-gpios and a second interrupt (interrupt-names: dio0/dio1) was proposed by Jonathan Cameron in 2023 [1]. I tested the same additions locally for all three parts; checkpatch and dt_binding_check both pass. It is not included here, as it hasn't been verified against any real board dts file, and none in-tree currently reference adis16201, adis16203, or adis16209. Can send that as a follow-up if wanted.

Quoted 3 lines

Thanks for the history. It should be after the '---' so it too is not recorded in the commit.

Quoted 5 lines
---
 .../devicetree/bindings/iio/accel/adi,adis16201.yaml        | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)