Skip to contentSkip to conversation

nics: add E2200 to the NIC guide

PATCH In review Hailin Xu 2 participants 3 messages Aug 12 – Sep 18

lore
Share & tools
lore

Hailin Xu

author
#0 lore raw

PATCH 1/1 nics: add E2200 to the NIC guide

nics/cpfl: add E2200 to cpfi
nics/idpf: add E2200 to idpf

---
 doc/guides/nics/cpfl.rst | 1 +
 doc/guides/nics/idpf.rst | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
doc/guides/nics/cpfl.rst +1 -0
index 3e2788ba03..5964a980ee 100644
@@ -8,6 +8,7 @@ CPFL Poll Mode Driver
 
 The cpfl PMD (**librte_net_cpfl**) provides poll mode driver support for
 Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2100.
+Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2200.
 Please refer to
 https://www.intel.com/content/www/us/en/products/network-io/infrastructure-processing-units/asic/e2000-asic.html
 for more information.
doc/guides/nics/idpf.rst +1 -1
index f4cd69ba7d..1f06eed645 100644
@@ -8,7 +8,7 @@ IDPF Poll Mode Driver
 
 The idpf PMD (**librte_net_idpf**) provides poll mode driver support for
 Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2100.
-
+Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2200.
 
 Linux Prerequisites
 -------------------
Signature · 1 line
2.34.1
#1 lore raw
Quoted 3 lines · Hailin Xu

nics/cpfl: add E2200 to cpfi
nics/idpf: add E2200 to idpf

Needs a proper text description. The commit title probably should start with "doc" or "doc/nics" rather than just "doc".

Quoted 11 lines
---
 doc/guides/nics/cpfl.rst | 1 +
 doc/guides/nics/idpf.rst | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
doc/guides/nics/cpfl.rst +0 -0
index 3e2788ba03..5964a980ee 100644

doc/guides/nics/cpfl.rst CPFL Poll Mode Driver · line 11

Quoted 4 lines
doc/guides/nics/cpfl.rst +1 -0
@@ -8,6 +8,7 @@ CPFL Poll Mode Driver
 
 The cpfl PMD (**librte_net_cpfl**) provides poll mode driver support for
 Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2100.
+Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2200.

Since this is not a bulleted list or similar, best to add an "and" in between the two NIC names.

Quoted 8 lines
doc/guides/nics/cpfl.rst +0 -0
 Please refer to
 https://www.intel.com/content/www/us/en/products/network-io/infrastructure-processing-units/asic/e2000-asic.html
 for more information.
doc/guides/nics/idpf.rst +0 -0
index f4cd69ba7d..1f06eed645 100644

doc/guides/nics/idpf.rst IDPF Poll Mode Driver · line 12

Quoted 6 lines
doc/guides/nics/idpf.rst +1 -1
@@ -8,7 +8,7 @@ IDPF Poll Mode Driver
 
 The idpf PMD (**librte_net_idpf**) provides poll mode driver support for
 Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2100.
-
+Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2200.
 

Similarly here. However, I think in this case you probably want to keep the two blank lines at end of the section i.e. just adding a new line rather than replacing a blank line with the new text.

Quoted 5 lines
doc/guides/nics/idpf.rst +0 -0
 Linux Prerequisites
 -------------------
Signature · 1 line
2.34.1

Regards,
/Bruce

#2 lore raw
Quoted 36 lines · Bruce Richardson
Quoted 2 lines · Hailin Xu

nics/cpfl: add E2200 to cpfi nics/idpf: add E2200 to idpf

Needs a proper text description. The commit title probably should start with "doc" or "doc/nics" rather than just "doc".

Quoted 8 lines

doc/guides/nics/cpfl.rst | 1 + doc/guides/nics/idpf.rst | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)

doc/guides/nics/cpfl.rst index renamed from doc/guides/nics/cpfl.rst +0 -0

3e2788ba03..5964a980ee 100644 --- a/doc/guides/nics/cpfl.rst +++ b/doc/guides/nics/cpfl.rst @@ -8,6 +8,7 @@ CPFL Poll Mode Driver

Quoted 4 lines

The cpfl PMD (**librte_net_cpfl**) provides poll mode driver support for Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2100. +Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2200.

Since this is not a bulleted list or similar, best to add an "and" in between the two NIC names.

Quoted 7 lines

Please refer to
https://www.intel.com/content/www/us/en/products/network-io/infrastructure-processing-units/asic/e2000-asic.html
for more information. diff --git a/doc/guides/nics/idpf.rst b/doc/guides/nics/idpf.rst index f4cd69ba7d..1f06eed645 100644 --- a/doc/guides/nics/idpf.rst +++ b/doc/guides/nics/idpf.rst @@ -8,7 +8,7 @@ IDPF Poll Mode Driver

Quoted 5 lines

The idpf PMD (**librte_net_idpf**) provides poll mode driver support for Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2100. - +Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU) E2200.

Quoted 6 lines

Similarly here. However, I think in this case you probably want to keep the two blank lines at end of the section i.e. just adding a new line rather than replacing a blank line with the new text.

Quoted 2 lines

Linux Prerequisites ------------------- -- 2.34.1

Rather than waiting further for a v2, I've made the necessary changes on apply and added my own signoff (in addition to original author) to this patch too.

Patch now applied to dpdk-next-net-intel.

Thanks,
/Bruce