f2fs: fix to propagate error from f2fs_sync_fs()
Chao Yu
maintainerPATCH 1/1 f2fs: fix to propagate error from f2fs_sync_fs()
So that caller can detect any failure from f2fs_sync_fs().
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/namei.c | 51 ++++++++++++++++++++++++++++++++++--------------- fs/f2fs/super.c | 4 +++- 2 files changed, 39 insertions(+), 16 deletions(-)
fs/f2fs/namei.c +36 -15
@@ -402,8 +402,11 @@ static int f2fs_create(struct mnt_idmap *idmap, struct inode *dir,d_instantiate_new (dentry, inode); -if (IS_DIRSYNC (dir)) -f2fs_sync_fs (sbi->sb,1 ); +if (IS_DIRSYNC (dir)) { + err =f2fs_sync_fs (sbi->sb,1 ); +if (err) +return err; + }f2fs_balance_fs (sbi, true);return 0 ;
@@ -455,8 +458,11 @@ static int f2fs_link(struct dentry *old_dentry, struct inode *dir,d_instantiate (dentry, inode); -if (IS_DIRSYNC (dir)) -f2fs_sync_fs (sbi->sb,1 ); +if (IS_DIRSYNC (dir)) { + err =f2fs_sync_fs (sbi->sb,1 ); +if (err) +return err; + }return 0 ; out:clear_inode_flag (inode,FI_INC_LINK );
@@ -624,8 +630,11 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)if (IS_ENABLED (CONFIG_UNICODE ) &&IS_CASEFOLDED (dir))d_invalidate (dentry); -if (IS_DIRSYNC (dir)) -f2fs_sync_fs (sbi->sb,1 ); +if (IS_DIRSYNC (dir)) { + err =f2fs_sync_fs (sbi->sb,1 ); +if (err) + goto out; + } goto out; corrupted:
@@ -717,7 +726,7 @@ static int f2fs_symlink(struct mnt_idmap *idmap, struct inode *dir, disk_link.len - 1);if (!err &&IS_DIRSYNC (dir)) -f2fs_sync_fs (sbi->sb,1 ); + err =f2fs_sync_fs (sbi->sb,1 ); }if (err)
@@ -769,8 +778,11 @@ static struct dentry *f2fs_mkdir(struct mnt_idmap *idmap, struct inode *dir,d_instantiate_new (dentry, inode); -if (IS_DIRSYNC (dir)) -f2fs_sync_fs (sbi->sb,1 ); +if (IS_DIRSYNC (dir)) { + err =f2fs_sync_fs (sbi->sb,1 ); +if (err) +return ERR_PTR (err); + }f2fs_balance_fs (sbi, true);return NULL ;
@@ -824,8 +836,11 @@ static int f2fs_mknod(struct mnt_idmap *idmap, struct inode *dir,d_instantiate_new (dentry, inode); -if (IS_DIRSYNC (dir)) -f2fs_sync_fs (sbi->sb,1 ); +if (IS_DIRSYNC (dir)) { + err =f2fs_sync_fs (sbi->sb,1 ); +if (err) +return err; + }f2fs_balance_fs (sbi, true);return 0 ;
@@ -1122,8 +1137,11 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir,f2fs_unlock_op (sbi, &lc); -if (IS_DIRSYNC (old_dir) ||IS_DIRSYNC (new_dir)) -f2fs_sync_fs (sbi->sb,1 ); +if (IS_DIRSYNC (old_dir) ||IS_DIRSYNC (new_dir)) { + err =f2fs_sync_fs (sbi->sb,1 ); +if (err) +return err; + }f2fs_update_time (sbi,REQ_TIME );return 0 ;
@@ -1289,8 +1307,11 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,f2fs_unlock_op (sbi, &lc); -if (IS_DIRSYNC (old_dir) ||IS_DIRSYNC (new_dir)) -f2fs_sync_fs (sbi->sb,1 ); +if (IS_DIRSYNC (old_dir) ||IS_DIRSYNC (new_dir)) { + err =f2fs_sync_fs (sbi->sb,1 ); +if (err) +return err; + }f2fs_update_time (sbi,REQ_TIME );return 0 ;
fs/f2fs/super.c +3 -1
@@ -2960,7 +2960,9 @@ static int __f2fs_remount(struct fs_context *fc, struct super_block *sb)set_sbi_flag (sbi,SBI_IS_DIRTY );set_sbi_flag (sbi,SBI_IS_CLOSE ); -f2fs_sync_fs (sb,1 ); + err =f2fs_sync_fs (sb,1 ); +if (err) + goto restore_gc;clear_sbi_flag (sbi,SBI_IS_CLOSE ); }
Signature · 1 line
2.49.0
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 7 lines · On Wed, 12 Aug 2026 12:20:43 +0000 you wrote:
So that caller can detect any failure from
f2fs_sync_fs().Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/namei.c | 51 ++++++++++++++++++++++++++++++++++--------------- fs/f2fs/super.c | 4 +++- 2 files changed, 39 insertions(+), 16 deletions(-)
Here is the summary with links:
- [f2fs-dev] f2fs: fix to propagate error from f2fs_sync_fs()
https://git.kernel.org/jaegeuk/f2fs/c/c7d026012a46
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html