Skip to contentSkip to conversation

dt-bindings: hwmon: tmp102: Document TMP110

PATCH Applied Marek Vasut 4 participants 7 messages Aug 12 – Aug 18

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: hwmon: tmp102: Document TMP110

The TMP110 is register compatible with TMP102, document it using a fallback compatible.

---
Cc: Conor Dooley <[email protected]>
Cc: Flaviu Nistor <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 .../devicetree/bindings/hwmon/ti,tmp102.yaml         | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +8 -4
index 96b2e4969f78a..f0dbe9f07b939 100644
@@ -4,15 +4,19 @@
 $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: TMP102 temperature sensor
+title: TMP102 and TMP110 temperature sensor
 
 maintainers:
   - Krzysztof Kozlowski <[email protected]>
 
 properties:
   compatible:
-    enum:
-      - ti,tmp102
+    oneOf:
+      - items:
+          - const: ti,tmp110
+          - const: ti,tmp102
+      - enum:
+          - ti,tmp102
 
   interrupts:
     maxItems: 1
@@ -28,7 +32,7 @@ properties:
     const: 1
 
   vcc-supply:
-    description: Power supply for tmp102
+    description: Power supply for the sensor
 
 required:
   - compatible
Signature · 1 line
2.53.0
#1 lore raw

PATCH 2/2 hwmon: (tmp102) Add TMP110 device ID

The TMP110 is register compatible with TMP102, add non-DT I2C device ID.

---
Cc: Conor Dooley <[email protected]>
Cc: Flaviu Nistor <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 drivers/hwmon/tmp102.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/tmp102.c +1 -0
index 95fb912a1f7ed..26c461e95175b 100644
@@ -396,6 +396,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(tmp102_dev_pm_ops, tmp102_suspend, tmp102_resume
 
 static const struct i2c_device_id tmp102_id[] = {
 	{ .name = "tmp102" },
+	{ .name = "tmp110" },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, tmp102_id);
Signature · 1 line
2.53.0
#2 lore raw

Re: [PATCH 2/2] hwmon: (tmp102) Add TMP110 device ID

Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 3 lines

The TMP110 is register compatible with TMP102, add non-DT I2C device ID.

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
Reviewed-by on v1 1/2
#5 lore raw
In reply to Marek Vasut
Quoted 13 lines · Marek Vasut

The TMP110 is register compatible with TMP102, document it using a fallback compatible.

---
Cc: Conor Dooley <[email protected]>
Cc: Flaviu Nistor <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

Quoted 3 lines
---
 .../devicetree/bindings/hwmon/ti,tmp102.yaml         | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Best regards,
Krzysztof