target/i386: Set aliased x87 exponent bits to all 1s for MMX register writes
PATCH v2 1/1 target/i386: Set aliased x87 exponent bits to all 1s for MMX register writes
Per the Intel SDM (Vol 3, 15.2), writing an MMX register also sets bits 64-79 of the aliased x87 register to all 1s. gen_writeback() never does this for X86_OP_MMX destinations, so those bits keep whatever the x87 side left there (e.g. 0 after finit/fldz). A later x87 instruction such as fucomi/fucomip can then read a stale finite value where real hardware guarantees a NaN encoding, changing comparison results and flags.
Set the high 16 bits to 0xffff when writing back to a MMX register (not memory).
Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4105
---
v2: use offsetof(CPUX86State, fpregs[op->n].d.high) directly instead of
reusing MMX_OFFSET() + offsetof(floatx80, high), per Richard's review.
target/i386/tcg/emit.c.inc | 4 ++++ 1 file changed, 4 insertions(+)
target/i386/tcg/emit.c.inc +4 -0
@@ -352,6 +352,10 @@ static void gen_writeback(DisasContext *s, X86DecodedInsn *decode, int opn, TCGv } break; case X86_OP_MMX: + if (!op->has_ea) { + tcg_gen_st16_i32(tcg_constant_i32(0xffff), tcg_env, + offsetof(CPUX86State, fpregs[op->n].d.high)); + } break; case X86_OP_SSE: if (!op->has_ea && (s->prefix & PREFIX_VEX) && op->ot <= MO_128) {
Signature · 1 line
2.53.0
Ping. Maybe the patch has been missed.
Quoted 40 lines · Simon Scherer
Per the Intel SDM (Vol 3, 15.2), writing an MMX register also sets bits 64-79 of the aliased x87 register to all 1s.
gen_writeback()never does this forX86_OP_MMXdestinations, so those bits keep whatever the x87 side left there (e.g. 0 after finit/fldz). A later x87 instruction such as fucomi/fucomip can then read a stale finite value where real hardware guarantees a NaN encoding, changing comparison results and flags.Set the high 16 bits to
0xffffwhen writing back to a MMX register (not memory).Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4105
Signed-off-by Simon Scherer <[email protected]>Reviewed-by Richard Henderson <[email protected]>---
v2: useoffsetof(CPUX86State, fpregs[op->n].d.high)directly instead of
reusingMMX_OFFSET()+offsetof(floatx80, high), per Richard's review.target/i386/tcg/emit.c.inc | 4 ++++ 1 file changed, 4 insertions(+)target/i386/tcg/emit.c.inc +4
-1@@ -352,6 +352,10 @@ static void gen_writeback(DisasContext *s, X86DecodedInsn *decode, int opn, TCGv } break; case X86_OP_MMX: + if (!op->has_ea) { + tcg_gen_st16_i32(tcg_constant_i32(0xffff), tcg_env, + offsetof(CPUX86State, fpregs[op->n].d.high)); + } break; case X86_OP_SSE: if (!op->has_ea && (s->prefix & PREFIX_VEX) && op->ot <= MO_128) { --2.53.0
Ping. Maybe the patch has been missed.
Quoted 40 lines · Simon Scherer
Per the Intel SDM (Vol 3, 15.2), writing an MMX register also sets bits 64-79 of the aliased x87 register to all 1s.
gen_writeback()never does this forX86_OP_MMXdestinations, so those bits keep whatever the x87 side left there (e.g. 0 after finit/fldz). A later x87 instruction such as fucomi/fucomip can then read a stale finite value where real hardware guarantees a NaN encoding, changing comparison results and flags.Set the high 16 bits to
0xffffwhen writing back to a MMX register (not memory).Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4105
Signed-off-by Simon Scherer <[email protected]>Reviewed-by Richard Henderson <[email protected]>---
v2: useoffsetof(CPUX86State, fpregs[op->n].d.high)directly instead of
reusingMMX_OFFSET()+offsetof(floatx80, high), per Richard's review.target/i386/tcg/emit.c.inc | 4 ++++ 1 file changed, 4 insertions(+)target/i386/tcg/emit.c.inc +4
-1@@ -352,6 +352,10 @@ static void gen_writeback(DisasContext *s, X86DecodedInsn *decode, int opn, TCGv } break; case X86_OP_MMX: + if (!op->has_ea) { + tcg_gen_st16_i32(tcg_constant_i32(0xffff), tcg_env, + offsetof(CPUX86State, fpregs[op->n].d.high)); + } break; case X86_OP_SSE: if (!op->has_ea && (s->prefix & PREFIX_VEX) && op->ot <= MO_128) { --2.53.0