Skip to contentSkip to conversation

bus: arm-cci: fix device_node refcount leak in cci_probe_ports()

PATCH New Manush Prajwal 1 participant 1 message Aug 13

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus: arm-cci: fix device_node refcount leak in cci_probe_ports()

When the number of matching child nodes reaches nb_cci_ports, cci_probe_ports() breaks out of the for_each_available_child_of_node() loop without releasing the reference held on the current node. Every other exit from this loop iteration either continues (handled by the iterator) or stores the node into ports[i].dn; this early break is the only path that drops the last handle to the node without a matching of_node_put(). Add it before the break.

---
 drivers/bus/arm-cci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/bus/arm-cci.c +3 -1
index 7f2baf0571..5ab3d74c9a 100644
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)
 
 		i = nb_ace + nb_ace_lite;
 
-		if (i >= nb_cci_ports)
+		if (i >= nb_cci_ports) {
+			of_node_put(cp);
 			break;
+		}
 
 		if (of_property_read_string(cp, "interface-type",
 					&match_str)) {
Signature · 1 line
2.46.2.windows.1