ice driver compiler warning
Subsystems (2)
ice driver maintainers,
Is the ice base driver still defining structure fields with [0], or has it been updated to use []? Maybe the workaround in meson.build is not required anymore:
# Bugzilla ID: 678
if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
error_cflags += ['-Wno-array-bounds']
endif
Ref:
https://github.com/DPDK/dpdk/blob/main/drivers/net/intel/ice/base/meson.build#L49
Venlig hilsen / Kind regards,
-Morten Brørup
Quoted 8 lines · On Sat, 1 Aug 2026 11:00:38 +0200 Morten Brørup <[email protected]>…
ice driver maintainers,
Is the ice base driver still defining structure fields with [0], or has it been updated to use []? Maybe the workaround in meson.build is not required anymore:
# Bugzilla ID: 678
if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))error_cflags += ['-Wno-array-bounds']
Quoted 10 lines
endif
Ref:
https://github.com/DPDK/dpdk/blob/main/drivers/net/intel/ice/base/meson.build#L49Venlig hilsen / Kind regards,
-Morten Brørup
Looks like it could be dropped. I see no errors with Gcc 18
PATCH 1/1 net/ice/base: allow array bounds warnings
In reply to Morten BrørupSince there are no zero-length arrays in the base code any more, remove the -Wno-array-bounds build flag.
--- drivers/net/intel/ice/base/meson.build | 5 ----- 1 file changed, 5 deletions(-)
drivers/net/intel/ice/base/meson.build +0 -5
@@ -44,11 +44,6 @@ else ] endif -# Bugzilla ID: 678 -if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0')) - error_cflags += ['-Wno-array-bounds'] -endif - foreach flag: error_cflags if cc.has_argument(flag) base_cflags += flag
Signature · 1 line
2.53.0
RE: [PATCH] net/ice/base: allow array bounds warnings
Quoted 17 lines
From: Bruce Richardson [mailto:[email protected]]
Sent: Thursday, 13 August 2026 13.15Since there are no zero-length arrays in the base code any more, remove the -Wno-array-bounds build flag.
Signed-off-by Bruce Richardson <[email protected]>--- drivers/net/intel/ice/base/meson.build | 5 ----- 1 file changed, 5 deletions(-)drivers/net/intel/ice/base/meson.build +0
-0
drivers/net/intel/ice/base/meson.build else · line 51
Quoted 8 lines
drivers/net/intel/ice/base/meson.build +0
-5@@ -44,11 +44,6 @@ else ] endif -# Bugzilla ID: 678 -if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0')) - error_cflags += ['-Wno-array-bounds'] -endif -
Good catch!
Consequential workarounds like this are often overlooked when the workaround is not necessary anymore.
Patchwork should have a "fixed/workaround" state for tracking workarounds, so they can be properly cleaned up like this. The root cause has been fixed, so by removing this last detail of the workaround the bug is truly "fixed/resolved".
Bruce Richardson
AppliedRe: [PATCH] net/ice/base: allow array bounds warnings
Quoted 29 lines · Morten Brørup
Quoted 17 lines
From: Bruce Richardson [mailto:[email protected]]
Sent: Thursday, 13 August 2026 13.15Since there are no zero-length arrays in the base code any more, remove the -Wno-array-bounds build flag.
Signed-off-by Bruce Richardson <[email protected]>--- drivers/net/intel/ice/base/meson.build | 5 ----- 1 file changed, 5 deletions(-)drivers/net/intel/ice/base/meson.build +0
-0drivers/net/intel/ice/base/meson.build else · line 51
Quoted 8 lines
drivers/net/intel/ice/base/meson.build +0
-5@@ -44,11 +44,6 @@ else ] endif -# Bugzilla ID: 678 -if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0')) - error_cflags += ['-Wno-array-bounds'] -endif -Good catch!
Consequential workarounds like this are often overlooked when the workaround is not necessary anymore.
Quoted 5 lines
Patchwork should have a "fixed/workaround" state for tracking workarounds, so they can be properly cleaned up like this. The root cause has been fixed, so by removing this last detail of the workaround the bug is truly "fixed/resolved".
Acked-by Morten Brørup <[email protected]>
Applied to dpdk-next-net-intel.
/Bruce