Skip to contentSkip to conversation

staging: greybus: loopback: remove unused includes

PATCH In review Batu Ada Tutkun 2 participants 2 messages Aug 12

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: greybus: loopback: remove unused includes

linux/random.h, linux/sizes.h, linux/cdev.h, linux/fs.h, and linux/workqueue.h are not used anywhere in this file; none of their symbols appear in the source, and none are needed transitively either (debugfs helpers come from linux/debugfs.h, the async worker uses kthread_run()/kthread_stop() rather than the workqueue API).

Verified by removing the five includes and rebuilding drivers/staging/greybus out-of-tree with W=1: no new warnings or errors, and checkpatch.pl reports the same warning/check count before and after.

Assisted-by Claude:claude-sonnet-4-6
---
 drivers/staging/greybus/loopback.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/staging/greybus/loopback.c +0 -5
index ea57b1f5d156..1169cfcd28c6 100644
@@ -14,15 +14,10 @@
 #include <linux/slab.h>
 #include <linux/kthread.h>
 #include <linux/delay.h>
-#include <linux/random.h>
-#include <linux/sizes.h>
-#include <linux/cdev.h>
-#include <linux/fs.h>
 #include <linux/kfifo.h>
 #include <linux/debugfs.h>
 #include <linux/list_sort.h>
 #include <linux/spinlock.h>
-#include <linux/workqueue.h>
 #include <linux/atomic.h>
 #include <linux/pm_runtime.h>
 #include <linux/greybus.h>
Signature · 1 line
2.53.0
#1 lore raw
Quoted 11 lines · Batu Ada Tutkun

linux/random.h, linux/sizes.h, linux/cdev.h, linux/fs.h, and linux/workqueue.h are not used anywhere in this file; none of their symbols appear in the source, and none are needed transitively either (debugfs helpers come from linux/debugfs.h, the async worker uses kthread_run()/kthread_stop() rather than the workqueue API).

Verified by removing the five includes and rebuilding drivers/staging/greybus out-of-tree with W=1: no new warnings or errors, and checkpatch.pl reports the same warning/check count before and after.

Quoted 5 lines
Assisted-by Claude:claude-sonnet-4-6
---
 drivers/staging/greybus/loopback.c | 5 -----
 1 file changed, 5 deletions(-)

Please read:

	https://lore.kernel.org/all/2026080354-skater-urgent-31b2@gregkh