Skip to contentSkip to conversation

i3c: dw: rename "pclk" to "apb" to match dt-binding

PATCH Applied Jisheng Zhang 4 participants 4 messages Aug 14 – Aug 18

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 i3c: dw: rename "pclk" to "apb" to match dt-binding

Change clock name "pclk" to "apb" to match dt-binding doc. No upstream device tree sources currently use the "pclk" clock name, so no any backward compatibility issues.

Fixes a0d48ebf39ce ("i3c: dw: Add optional apb clock")

---

since v1:
- update commit msg

 drivers/i3c/master/dw-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i3c/master/dw-i3c-master.c +1 -1
index d6f84f0f4c2d..1053cfb05c05 100644
@@ -1582,7 +1582,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
 	if (IS_ERR(master->core_clk))
 		return PTR_ERR(master->core_clk);
 
-	master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "pclk");
+	master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "apb");
 	if (IS_ERR(master->pclk))
 		return PTR_ERR(master->pclk);
 
Signature · 1 line
2.51.0
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Missing error check for platform_get_irq() breaks probe deferral. --

--- Patch [1]: [PATCH v2] i3c: dw: rename "pclk" to "apb" to match dt-binding --- commit 342a3504d5ec0fb05c08b9de5076fc569bcdc43b
Author: Jisheng Zhang <[email protected]>

i3c: dw: rename "pclk" to "apb" to match dt-binding

Change clock name "pclk" to "apb" to match dt-binding doc. No upstream device tree sources currently use the "pclk" clock name, so no any backward compatibility issues.

Quoted 12 lines
drivers/i3c/master/dw-i3c-master.c +1 -1
index 2f8c0c4683e06..0625587f15274 100644
@@ -1579,7 +1579,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
 	if (IS_ERR(master->core_clk))
 		return PTR_ERR(master->core_clk);
 
-	master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "pclk");
+	master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "apb");
 	if (IS_ERR(master->pclk))
 		return PTR_ERR(master->pclk);

[ ... ]

drivers/i3c/master/dw-i3c-master.c

Quoted 5 lines
drivers/i3c/master/dw-i3c-master.c +0 -0
 	writel(INTR_ALL, master->regs + INTR_STATUS);
 	irq = platform_get_irq(pdev, 0);
 	ret = devm_request_irq(&pdev->dev, irq,
 			       dw_i3c_master_irq_handler, 0,
 			       dev_name(&pdev->dev), master);

[Severity: High]
This isn't a bug introduced by this patch, but is it possible for platform_get_irq() to return a negative error code like -EPROBE_DEFER here?

If irq is negative, passing it to devm_request_irq() without validation causes it to fail with -EINVAL, overriding the original -EPROBE_DEFER error code. Could this break the probe deferral mechanism for dw_i3c_common_probe() in drivers/i3c/master/dw-i3c-master.c by preventing it from retrying when the IRQ controller is ready?

Signature · 6 lines
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1

-- 
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c
Reviewed-by on v2 1/1
#2 lore raw
In reply to Jisheng Zhang
Quoted 7 lines · Jisheng Zhang

Change clock name "pclk" to "apb" to match dt-binding doc. No upstream device tree sources currently use the "pclk" clock name, so no any backward compatibility issues.

Fixes a0d48ebf39ce ("i3c: dw: Add optional apb clock")

---

Quoted 23 lines

since v1:
- update commit msg

 drivers/i3c/master/dw-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i3c/master/dw-i3c-master.c +1 -2
index d6f84f0f4c2d..1053cfb05c05 100644
@@ -1582,7 +1582,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
 	if (IS_ERR(master->core_clk))
 		return PTR_ERR(master->core_clk);
 
-	master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "pclk");
+	master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "apb");
 	if (IS_ERR(master->pclk))
 		return PTR_ERR(master->pclk);
 
--

2.51.0

maintainer Applied
#3 lore raw
In reply to Jisheng Zhang
Quoted 3 lines · Jisheng Zhang

Change clock name "pclk" to "apb" to match dt-binding doc. No upstream device tree sources currently use the "pclk" clock name, so no any backward compatibility issues.

Applied, thanks!

[1/1] i3c: dw: rename "pclk" to "apb" to match dt-binding

      https://git.kernel.org/i3c/c/ff2eee2b8686

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com